Commit Graph

2009 Commits

Author SHA1 Message Date
Eric Davis 488879d9cf Refactor: pull #query_statement_invalid up to ApplicationController.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3696 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-29 15:19:19 +00:00
Eric Davis e65c3cfc7d Refactor: Move gantts to a separate controller.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3695 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-28 15:54:46 +00:00
Jean-Philippe Lang a925435b29 Add "Check/Unckeck all" buttons to rows and columns on workflow edit screen (#3201).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3694 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-27 17:54:27 +00:00
Jean-Philippe Lang c18cb9451d Fixed: private subprojects names may be revealed on issue summary report (#5360).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3692 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-27 16:43:52 +00:00
Eric Davis df7edb843b Refactor: move method to helper.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3691 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-27 15:28:52 +00:00
Eric Davis dfc448030d Refactor: extract error to new method with before_filter.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3690 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-26 15:08:06 +00:00
Eric Davis 23f097e344 Refactor: Extract duplicated code to a new method.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3689 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-23 15:05:13 +00:00
Eric Davis 2c898d8a81 Refactor: Split IssuesController#new to #new and #create to match REST pattern.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3688 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-22 15:43:57 +00:00
Eric Davis 657aa624a4 Adding missing setter for Query#available_columns
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-20 15:42:52 +00:00
Eric Davis bf33b57aa4 Refactor: Move method to Query model
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3684 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-19 15:08:28 +00:00
Jean-Philippe Lang 0004b52646 Fixes behaviour of move_issues permission for non member role (#5309).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3683 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-18 12:47:41 +00:00
Jean-Philippe Lang de51e16d2b Removes hard-coded size on user search fields (#5319).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3682 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-18 10:17:27 +00:00
Jean-Philippe Lang 3bf6790826 Add "Repository" menu item after repository creation (#5328).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3680 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-17 12:51:46 +00:00
Jean-Philippe Lang aa4d1fe816 Fixed: API 401 response does not include WWW-Authenticate header (#5322).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3679 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-17 12:45:23 +00:00
Jean-Philippe Lang 2c0ce104e7 Fixed: Error on db:migrate with table prefix set (#5335).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3678 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-17 12:14:52 +00:00
Jean-Philippe Lang e4e4b0f4b8 Fixes error on subtask XML format (#5336).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3677 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-17 11:49:56 +00:00
Eric Davis 538642c5c4 Let custom field formats control how they are edited.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3675 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-16 15:34:05 +00:00
Eric Davis d22723ed04 Refactor: Move method
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3673 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-16 15:33:55 +00:00
Eric Davis 88db9d0bdc Replace the hardcoded CustomField::FIELD_FORMATS with a class.
Custom Field Formats are now full objects and can be registered with
Redmine::CustomFieldFormat to add new formats.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3672 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-16 15:33:49 +00:00
Jean-Philippe Lang 0e1595ad56 Adds parent issue id in issue REST API (#5304).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3671 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-13 17:51:06 +00:00
Jean-Philippe Lang 9ccccb9984 Do not raise an error when destroying a Version with assigned issues.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3668 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-11 17:47:29 +00:00
Jean-Philippe Lang 734f8324ea Fixed: empty ul tag for issue updates with notes only (#5281).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3666 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-11 17:10:26 +00:00
Jean-Philippe Lang f77e5d093a Merge issue and time entry validation error messages.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3665 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-11 17:00:13 +00:00
Jean-Philippe Lang f35921d308 Fixes Issue#save_issue_with_child_records so that time entry do not get saved if issue save fails.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3664 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-11 16:48:46 +00:00
Jean-Philippe Lang 43e5bb75d2 Fixed: issue optimistic locking broken by r3308 (#5280).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3663 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-11 16:27:37 +00:00
Jean-Philippe Lang 2674c6116c Linkify folder names on revision view (#5164).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3659 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-11 15:18:49 +00:00
Jean-Philippe Lang 5163904a3a Fixed: Update of Subversion changesets broken by r3466 under Solaris (#5255).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3635 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-11 13:55:30 +00:00
Jean-Philippe Lang 71a4158fd0 Fixes calculation of version estimated hours with subtasks (#5265).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3633 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-11 13:20:02 +00:00
Jean-Philippe Lang 5879273739 Makes the wiki sidebar editable (#5208).
The content of the wiki page named 'Sidebar' is rendered in the sidebar if it exists. Permission to edit protected pages is required to create this page.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3632 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-11 12:56:18 +00:00
Eric Davis 3979224693 Removed count from issues.xml. It causes a typecast error in ActiveResource. (#4745)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3631 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-10 07:30:06 +00:00
Azamat Hackimov eb80b79c26 New strings to localization (#5225)
* error_can_not_delete_custom_field: Unable to delete custom field
* error_unable_to_connect: Unable to connect ({{value}})
* error_can_not_remove_role: This role is in use and can not be deleted.
* error_can_not_delete_tracker: This tracker contains issues and can't be deleted.


git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3627 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-03 11:54:24 +00:00
Jean-Philippe Lang 8df189ff86 Adds a css class to issue id tds (#5204).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3625 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-29 19:50:00 +00:00
Jean-Philippe Lang 2bbc948e06 Preview description if it was edited while updating an issue (#741).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3623 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-28 15:17:46 +00:00
Jean-Philippe Lang ce549933c8 Applies the same style to the admin project tree than issues.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3621 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-28 13:30:44 +00:00
Jean-Philippe Lang e8729feba7 Slight optimization in issue tree rendering.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3620 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-28 12:57:39 +00:00
Jean-Philippe Lang 4524bc04e9 Issue list improvements for subtasking (#5196):
* makes the parent task column available
* display the issue hierarchy when list is sorted by parent

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3618 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-27 16:55:20 +00:00
Jean-Philippe Lang 06d2c3fd4e Adds parent issue id to the issues CSV export.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3617 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-27 13:38:29 +00:00
Jean-Philippe Lang b93cf03483 Fixes backslashes escaping when quoting issue description/note (#5129).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3616 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-27 13:33:19 +00:00
Jean-Philippe Lang 43a5febf61 Fixed: Links to missing wiki pages not red on project overview page (#5177).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3614 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-27 12:54:13 +00:00
Jean-Philippe Lang 89aa60cbbd Escape revision on repository view (#5153).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3613 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-27 12:46:45 +00:00
Jean-Philippe Lang 84dfff5957 Fixes permission check in QueriesController (#5181).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3611 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-24 20:25:09 +00:00
Jean-Philippe Lang 79b4f68176 Adds an option to enable/disable email notifications during a project copy (#4672).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3608 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-21 11:17:29 +00:00
Jean-Philippe Lang 5225fb70f5 Optimize retrieval of user's projects members.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3607 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-21 09:28:24 +00:00
Jean-Philippe Lang e584ae220d Cleans up status assignment in IssuesController#new handled by Issue#safe_attributes= now.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3606 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-20 17:37:04 +00:00
Eric Davis 6e6e260cea Refactor: Extract Query#sortable_columns from the controller.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3604 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-19 15:42:03 +00:00
Jean-Philippe Lang 5e4eef1a4e Fixed: code syntax highlighting not working in Document page (#3740).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3603 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-18 20:06:16 +00:00
Jean-Philippe Lang 4dd4300147 Adds text formatting to documents index (#202).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3602 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-18 20:02:17 +00:00
Eric Davis b5d9a1dfbd Refactor: Extract method to the Member model
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3601 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-18 15:49:11 +00:00
Jean-Philippe Lang f741ca7269 Adds an helper for displaying the 'checked' image.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3600 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-17 20:46:22 +00:00
Jean-Philippe Lang 388805ad58 Do not query the database for project level on projects list.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3599 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-17 20:06:52 +00:00
Jean-Philippe Lang 0e0b8e0799 Accept issue links inside brackets (#4418).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3598 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-17 19:57:32 +00:00
Eric Davis 194dab8e96 Refactor: Change the different find_object filters to share a common method.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3597 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-17 15:41:58 +00:00
Eric Davis 0f999ef0e0 Fixes undefined method 'notes' error from r3594
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3596 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-17 04:13:05 +00:00
Jean-Philippe Lang f4be4d101b Inlines some code to speed up large ticket history rendering.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3594 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-16 21:37:05 +00:00
Jean-Philippe Lang 2f0fbef858 Fixed: Wrong label in issue-journal for subtask-changes (#5090).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3593 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-16 20:37:29 +00:00
Eric Davis e6c8760ad7 Refactor: Split the find_object methods to prep for a larger refactoring.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3591 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-16 15:17:47 +00:00
Jean-Philippe Lang 6b88de1234 Close unclosed pre/code tags (#4265).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3590 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-15 19:57:35 +00:00
Jean-Philippe Lang 7203196212 Do not parse redmine links inside pre/code tags (#1288).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3589 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-15 19:54:50 +00:00
Jean-Philippe Lang a179f261cd Extract parsing of inline attachments, wiki links and redmine links.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3588 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-15 19:37:01 +00:00
Jean-Philippe Lang ad487bf7cc Replace the hardcoded "CodeRay" css class name for highlighted elements.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3585 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-14 13:22:50 +00:00
Jean-Philippe Lang c03b4c2e1e Extract CodeRay calls to Redmine::SyntaxHighlighting (#2985).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3584 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-14 12:57:08 +00:00
Jean-Philippe Lang 2f5c17a0f6 Optimization: load attachments when needed.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3581 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-14 08:33:53 +00:00
Jean-Philippe Lang e605973ec4 Move issue watchers to the sidebar.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3579 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-13 17:45:41 +00:00
Jean-Philippe Lang 508df4a33a Slight UI changes to the subtasks tree.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3577 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-13 15:47:06 +00:00
Jean-Philippe Lang d550c46160 Makes subtasks rescheduled when a 'precedes' relation is set on a parent task.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3574 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-13 15:29:34 +00:00
Jean-Philippe Lang 8e3d1b694a Adds subtasking (#443) including:
* priority, start/due dates, progress, estimate, spent time roll-up to parent issues
* descendant issues tree displayed on the issue view with context menu support
* issue tree display on the gantt chart
* issue tree copy on project copy
* unlimited nesting

Defining subtasks requires the new permission 'Manage subtasks'.
Subtasks can not belong to a different project than the parent task.

Implementation is based on scoped nested sets for fast reads and updates.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3573 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-13 14:56:49 +00:00
Jean-Philippe Lang e109c9b6b6 Do not reset session when a non logged in user request the login form (#4958).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3572 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-12 19:22:11 +00:00
Jean-Philippe Lang 3dc4dbe302 Fixed: error while moving an issue to a project with disabled tracker with SQLite3 (#5049).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3566 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-12 14:51:33 +00:00
Jean-Philippe Lang 63ed494f21 Adds missing flash messages on project settings (#5043).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3565 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-12 13:51:00 +00:00
Eric Davis c7c3c0cc7c Refactor: Extract method for setting the flash on bulk issue saves.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3560 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-11 16:34:08 +00:00
Jean-Philippe Lang 3e2e5a0a0c Removes broken javascript on wiki history.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3559 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-10 19:16:03 +00:00
Eric Davis 22c1e2b8cf Adds named scopes to replace custom finders.
* Adds watched_by class method in ActsAsWatchable
* Adds Issue#recently_updated, Issue#with_limit and Issue#on_active_project

  #2482

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3557 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-10 05:10:43 +00:00
Jean-Philippe Lang b99d4189b7 Fixed: NoMethodError error on roadmap if no trackers are selected and a shared version is available (#5006).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3555 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-08 20:17:09 +00:00
Eric Davis c07696b578 Refactor: Remove duplicated case statements.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3554 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-08 16:47:57 +00:00
Eric Davis 43e3c43cbd Refactor: Extract similar logic in IssuesHelper#show_detail to a new method.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-08 16:47:52 +00:00
Jean-Philippe Lang 6511e94233 Moves ProjectsController#add_issue_category to IssueCategoriesController#new.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3549 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-06 18:43:00 +00:00
Jean-Philippe Lang 729bea1cf3 Moves ProjectsController#add_version to VersionsController#new.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3548 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-06 18:25:01 +00:00
Jean-Philippe Lang 2af97616f7 Adds context menu to the roadmap issue lists.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3547 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-06 18:03:25 +00:00
Eric Davis d65922afde Remove double negative condition
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3546 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-05 17:25:51 +00:00
Eric Davis 3f3e30c2aa Refactor: Moved the contents of #issue_update into Issue.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3545 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-05 17:11:50 +00:00
Jean-Philippe Lang bd5fe10c13 Adds an helper for creating the context menu.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3542 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 19:02:57 +00:00
Jean-Philippe Lang 12759fd416 Fixed: hard coded English string at the selection of issue watchers (#4982).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3541 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 18:49:03 +00:00
Eric Davis c58dc83e74 Refactor: Replace @journal with @issue.current_journal
This removes an instance variable in #issue_update which will let it be moved
to the Issue model.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3540 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 16:18:51 +00:00
Eric Davis 7514e12d33 Hide the main menu div if there isn't any items for it. #3259
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3539 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 06:01:05 +00:00
Eric Davis afdcd770dc Refactor: Extract method
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3538 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 05:33:54 +00:00
Eric Davis bc79caaf69 Refactor: Extract method
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3537 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 05:33:49 +00:00
Eric Davis be20d98040 Refactor: Extract methods to before_filters
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3536 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 05:33:45 +00:00
Eric Davis 3a99f18913 Refactor: Split method
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3535 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 05:33:40 +00:00
Eric Davis ca6df3d78d Refactor: Extract method
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3534 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 05:33:35 +00:00
Eric Davis 976cba0c5d Refactor: use the existing Issue#new_statuses_allowed_to method.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3533 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 00:58:52 +00:00
Jean-Philippe Lang cdb86d5ef7 Fixed: no email notification on new project/version file added (#4966).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3532 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 21:32:41 +00:00
Jean-Philippe Lang 6817a45e7f Adds hooks on login view (#4978).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3530 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 20:21:05 +00:00
Jean-Philippe Lang f2b227547e Filters collapsed by default for saved queries (#4623).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3529 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 20:09:39 +00:00
Eric Davis fe1e3ccd18 Refactor: Decouple failed attachments and the flash messages
Attachment#attach_files will no longer need to return a flash message,
instead it will put unsaved attachments into object#unsaved_attachments
where the calling object can access them.

A utility method #render_attachment_warning_if_needed is included for setting
the standard flash warning.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3528 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 17:05:00 +00:00
Eric Davis f6d8752e44 Fixes destroying attachments if the update fails. (r2875 r3523)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3526 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 17:04:50 +00:00
Eric Davis 3c0c0a7677 Allow multiple selected projects in #project_tree_options_for_select
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3525 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 03:37:40 +00:00
Jean-Philippe Lang b09a483aa9 Fixed: error while deleting an in-use enumeration (#4970).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3524 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-02 20:03:09 +00:00
Eric Davis 0fd7e2d696 Refactor: Moved ApplicationController#attach_files to the Attachment model
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3523 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-02 19:26:03 +00:00
Jean-Philippe Lang b52e75aad9 Fixes some context menu links broken by r3478.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3521 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-01 20:54:55 +00:00
Eric Davis f5f5a5f64f Verify issues are updated by HTTP PUT only. Regression from r3486.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3520 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-01 18:29:18 +00:00
Eric Davis 8699e5bbcd Refactor: Decouple building Issue and TimeEntry objects in #issue_update.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3519 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-01 17:40:54 +00:00
Jean-Philippe Lang c9197769fb Fixes bottom links placement in issue with associated changesets (#4883).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3516 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-28 16:42:31 +00:00
Jean-Philippe Lang d6c299f57d Adds 'Blocked by' (#1755) and 'Duplicated by' relation types to the dropdown menu for new relations.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3512 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-28 11:28:32 +00:00
Jean-Philippe Lang 241f79ac06 Fixed: attachments with the same name at the same time overwrite (#3691).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3511 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-28 11:12:40 +00:00
Jean-Philippe Lang 82310d3162 Allow project custom fields to be searchable (#4945).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3510 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-28 10:55:24 +00:00
Jean-Philippe Lang c174540a0e Adds attachments upload on wiki edit form (#1223).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3500 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-28 09:43:13 +00:00
Jean-Philippe Lang 02cc0efdd7 Fixed: journal details duplicated when an issue is saved twice (#3690).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3499 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-28 09:21:12 +00:00
Jean-Philippe Lang 26e9a0d919 Fixed: Wrong link when "http" not included in project "Homepage" link (#4944).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3498 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-28 09:10:33 +00:00
Eric Davis ddec53b9a2 Refactor: Extracted saving logic out of #update and into a utility method
Now #issue_update can be refactored and push to the Model(s) while keeping
the public interface (#update) clean.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3497 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 16:16:18 +00:00
Jean-Philippe Lang 113049412b Link to the user from the wiki history view.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3496 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 16:03:05 +00:00
Jean-Philippe Lang bda2aa474c Adds a link to the user profile from the administration user edit screen (#4480).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3495 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 16:01:04 +00:00
Jean-Philippe Lang bfed36ac84 Let administrators see locked user profiles.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3493 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 15:50:16 +00:00
Jean-Philippe Lang d6f9e576e8 Makes AuthSource.authenticate return a hash instead of an array.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3492 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 09:13:12 +00:00
Jean-Philippe Lang aa521c5a5a User model should not have to clean up LDAP attributes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 08:29:20 +00:00
Eric Davis 3de1f2e157 Refactor: Extracted the duplication from the last commit into a new method
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 17:01:10 +00:00
Eric Davis c68d853bf4 Refactor: Move the updating of an Issue to the #update method.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3486 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 17:01:05 +00:00
Eric Davis 19d4ddf2f2 Fix LDAP on the fly creation. The User object doesn't have a :dn attribute.
Fixes #4918 and adds a test for the behavior.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3485 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 16:19:55 +00:00
Eric Davis 39c97279ca Optimize: Only select the name when getting the module names.
This has speed up TimelogController#details by 100% with larger databases
(demo.redmine went from 4077ms down to 2085ms).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3484 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 04:55:33 +00:00
Jean-Philippe Lang f7bd0801f6 Fixed: changing user/roles of project member not possible without javascript (#4852)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3483 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-24 21:23:20 +00:00
Jean-Philippe Lang 46ecc488a9 Fixed: projects are referenced by id in search results.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-24 21:08:08 +00:00
Jean-Philippe Lang b2dee55e72 Makes project identifiers searchable (#4897).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3481 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-24 21:05:14 +00:00
Eric Davis d581510af6 Refactor: Start to extract IssuesController#edit into #update (REST).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3480 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-24 17:21:41 +00:00
Jean-Philippe Lang 6ed9734cb9 Reduces spacing on the bulk edit form.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3479 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 21:44:28 +00:00
Jean-Philippe Lang e24d6cc223 Bulk edit refactoring.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3478 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 21:26:29 +00:00
Jean-Philippe Lang 01dbba72ab Move hardcoded calendar images to css classes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3477 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 21:10:15 +00:00
Jean-Philippe Lang a2537b3969 Fixed view_issues_move_bottom hook arguments (#4893).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3476 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 21:04:12 +00:00
Eric Davis f838904a7e Refactor: Extract Issue#bulk_edit from the IssuesController
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3475 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 17:06:08 +00:00
Jean-Philippe Lang 0341ac80eb Avoid unnecessary SQL queries when loading changesets.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3473 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-21 14:43:45 +00:00
Jean-Philippe Lang 3d393a5711 Memorize commit authors to speed up changesets loading.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3472 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-21 14:42:45 +00:00
Jean-Philippe Lang 46aa855572 Remove invalid utf8 sequences from commit comments and author name (#4773).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3466 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-20 11:24:41 +00:00
Jean-Philippe Lang dab0c07fba Fixed: Links in Forum mails should redirect to message, not topic (#4884).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3458 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-20 10:07:53 +00:00
Jean-Philippe Lang 08d7c5bfb4 Adds a controller hook before issue move (#4850).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3457 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-19 19:10:50 +00:00
Jean-Philippe Lang 77459f9ae4 Adds a hook on issue move form (#4850).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3456 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-19 19:10:21 +00:00
Eric Davis c6b2f1d606 Refactor: Extract #get_user_dn from AuthSourceLdap.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3454 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-19 17:00:49 +00:00
Eric Davis d828122009 Refactor: extract AuthSourceLdap#search_attributes
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3453 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-19 16:33:01 +00:00
Jean-Philippe Lang 026fbb99a6 Escaping in html email templates (#4874).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3452 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-18 19:13:38 +00:00
Jean-Philippe Lang d18fba4ffe Fixed: Pound (#) followed by number with leading zero (0) removes leading zero when rendered in wiki (#4872).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3451 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-18 18:53:30 +00:00
Eric Davis 6f930e9be6 Refactor: Rewrite authenticate_dn to use an implicit return.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3450 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-18 16:55:10 +00:00
Eric Davis 82dd1b2bf2 Refactor: Moved the check for an empty DN to authenticate_dn
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3449 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-18 16:55:05 +00:00
Jean-Philippe Lang 74e85953f0 Move SQL LIKE tokens to acts_as_searchable.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3445 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-17 20:20:51 +00:00
Jean-Philippe Lang c11d30ebc9 Makes search providers extensible (#3936).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3444 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-17 20:05:51 +00:00
Eric Davis 4f268c5606 Refactor: extract an #authenticate_dn method in AuthSourceLdap
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3441 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-17 16:35:35 +00:00
Eric Davis 9e22faa640 Converted the REDMINE_SUPPORTED_SCM constant to a class
Now SCMs can be added or removed using a simple API, instead of being
hardcoded:

  Redmine::Scm::Base.add('ScmName')
  Redmine::Scm::Base.delete('ScmName')

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3440 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-16 22:41:59 +00:00
Eric Davis b3330d3995 Refactor: Extract method from AuthSourceLdap#authenticate
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3439 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-16 17:03:54 +00:00
Eric Davis 49bfee0535 Refactor: Merged TrackersController#list and #index
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3437 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-15 16:41:27 +00:00
Eric Davis c5f30fde28 Refactor: Merged AuthSourcesController#list and #index
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3436 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-15 16:41:21 +00:00
Eric Davis 038a88e970 Refactor: Merged RolesController#list and #index
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3435 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-15 16:41:16 +00:00
Jean-Philippe Lang d16c2d4cd3 Adds a few divs to the base layout (#871).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3429 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-14 13:07:51 +00:00
Jean-Philippe Lang 2f8cf7f762 Removes duplicated LOC.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3428 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-14 12:45:48 +00:00
Jean-Philippe Lang a811f67748 Fixed: SystemStackError (stack level too deep) on Issue#attributes= after model reload (#4838).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3427 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-14 12:43:48 +00:00