Commit Graph

2872 Commits

Author SHA1 Message Date
Eric Davis ddec53b9a2 Refactor: Extracted saving logic out of #update and into a utility method
Now #issue_update can be refactored and push to the Model(s) while keeping
the public interface (#update) clean.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3497 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 16:16:18 +00:00
Jean-Philippe Lang 113049412b Link to the user from the wiki history view.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3496 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 16:03:05 +00:00
Jean-Philippe Lang bda2aa474c Adds a link to the user profile from the administration user edit screen (#4480).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3495 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 16:01:04 +00:00
Jean-Philippe Lang c7c43d38ce Removes a useless assignment in Trac importer (#4931).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3494 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 15:55:02 +00:00
Jean-Philippe Lang bfed36ac84 Let administrators see locked user profiles.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3493 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 15:50:16 +00:00
Jean-Philippe Lang d6f9e576e8 Makes AuthSource.authenticate return a hash instead of an array.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3492 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 09:13:12 +00:00
Jean-Philippe Lang f1d16bc007 Test that AuthSourceLdap#authenticate returns valid User attributes only.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3491 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 08:50:37 +00:00
Jean-Philippe Lang 899f06612a Moves the LDAP test server to a fixture.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3490 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 08:42:40 +00:00
Jean-Philippe Lang 7ae53845ac Adds a sample test LDAP configuration file.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3489 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 08:31:36 +00:00
Jean-Philippe Lang aa521c5a5a User model should not have to clean up LDAP attributes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 08:29:20 +00:00
Eric Davis 3de1f2e157 Refactor: Extracted the duplication from the last commit into a new method
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 17:01:10 +00:00
Eric Davis c68d853bf4 Refactor: Move the updating of an Issue to the #update method.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3486 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 17:01:05 +00:00
Eric Davis 19d4ddf2f2 Fix LDAP on the fly creation. The User object doesn't have a :dn attribute.
Fixes #4918 and adds a test for the behavior.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3485 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 16:19:55 +00:00
Eric Davis 39c97279ca Optimize: Only select the name when getting the module names.
This has speed up TimelogController#details by 100% with larger databases
(demo.redmine went from 4077ms down to 2085ms).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3484 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 04:55:33 +00:00
Jean-Philippe Lang f7bd0801f6 Fixed: changing user/roles of project member not possible without javascript (#4852)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3483 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-24 21:23:20 +00:00
Jean-Philippe Lang 46ecc488a9 Fixed: projects are referenced by id in search results.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-24 21:08:08 +00:00
Jean-Philippe Lang b2dee55e72 Makes project identifiers searchable (#4897).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3481 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-24 21:05:14 +00:00
Eric Davis d581510af6 Refactor: Start to extract IssuesController#edit into #update (REST).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3480 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-24 17:21:41 +00:00
Jean-Philippe Lang 6ed9734cb9 Reduces spacing on the bulk edit form.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3479 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 21:44:28 +00:00
Jean-Philippe Lang e24d6cc223 Bulk edit refactoring.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3478 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 21:26:29 +00:00
Jean-Philippe Lang 01dbba72ab Move hardcoded calendar images to css classes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3477 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 21:10:15 +00:00
Jean-Philippe Lang a2537b3969 Fixed view_issues_move_bottom hook arguments (#4893).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3476 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 21:04:12 +00:00
Eric Davis f838904a7e Refactor: Extract Issue#bulk_edit from the IssuesController
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3475 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 17:06:08 +00:00
Eric Davis 89cf2d256d Moved the IssuesController routing tests to an integration test.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3474 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-22 18:15:07 +00:00
Jean-Philippe Lang 0341ac80eb Avoid unnecessary SQL queries when loading changesets.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3473 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-21 14:43:45 +00:00
Jean-Philippe Lang 3d393a5711 Memorize commit authors to speed up changesets loading.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3472 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-21 14:42:45 +00:00
Jean-Philippe Lang 93bcc68017 Adds a missing index (speeds up changesets loading).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3471 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-21 14:40:00 +00:00
Azamat Hackimov 24ec3bb7a9 Translation updates
* sv (#4846)
* ru (#4861)
* de (#4870)



git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3470 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-21 14:38:38 +00:00
Jean-Philippe Lang 103698b371 Wraps changeset creation inside a single transation.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3469 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-21 14:38:34 +00:00
Jean-Philippe Lang 87bc092d7c Removes --find-copies-harder git option to retrieve commits which was way to slow (#4547).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3468 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-21 14:37:09 +00:00
Jean-Philippe Lang 4878d749f4 Do not query git for tags and branches multiple times per request.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3467 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-20 13:35:22 +00:00
Jean-Philippe Lang 46aa855572 Remove invalid utf8 sequences from commit comments and author name (#4773).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3466 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-20 11:24:41 +00:00
Jean-Philippe Lang 6e68921590 Cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3459 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-20 10:11:19 +00:00
Jean-Philippe Lang dab0c07fba Fixed: Links in Forum mails should redirect to message, not topic (#4884).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3458 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-20 10:07:53 +00:00
Jean-Philippe Lang 08d7c5bfb4 Adds a controller hook before issue move (#4850).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3457 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-19 19:10:50 +00:00
Jean-Philippe Lang 77459f9ae4 Adds a hook on issue move form (#4850).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3456 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-19 19:10:21 +00:00
Jean-Philippe Lang d46609f4bb Fixes INSTALL and UPGRADING steps order (#4848).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3455 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-19 18:52:34 +00:00
Eric Davis c6b2f1d606 Refactor: Extract #get_user_dn from AuthSourceLdap.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3454 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-19 17:00:49 +00:00
Eric Davis d828122009 Refactor: extract AuthSourceLdap#search_attributes
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3453 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-19 16:33:01 +00:00
Jean-Philippe Lang 026fbb99a6 Escaping in html email templates (#4874).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3452 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-18 19:13:38 +00:00
Jean-Philippe Lang d18fba4ffe Fixed: Pound (#) followed by number with leading zero (0) removes leading zero when rendered in wiki (#4872).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3451 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-18 18:53:30 +00:00
Eric Davis 6f930e9be6 Refactor: Rewrite authenticate_dn to use an implicit return.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3450 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-18 16:55:10 +00:00
Eric Davis 82dd1b2bf2 Refactor: Moved the check for an empty DN to authenticate_dn
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3449 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-18 16:55:05 +00:00
Eric Davis 899fb1079f Added some common example email configs to email.yml.example (#3120)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3448 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-18 05:20:52 +00:00
Eric Davis 28e9bc5d82 Fix an IndexError if all the :last menu items are deleted from a menu. #4718
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3447 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-18 05:01:39 +00:00
Jean-Philippe Lang 0fcc436f22 Fixed: Deselecting textile text formatting causes interning empty string errors (#4867).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3446 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-17 20:47:50 +00:00
Jean-Philippe Lang 74e85953f0 Move SQL LIKE tokens to acts_as_searchable.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3445 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-17 20:20:51 +00:00
Jean-Philippe Lang c11d30ebc9 Makes search providers extensible (#3936).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3444 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-17 20:05:51 +00:00
Jean-Philippe Lang b733accfe3 Adds a test for emission address with phrase (#4855).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3443 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-17 19:08:04 +00:00
Jean-Philippe Lang 3dd9687d41 Fixed: unit tests broken by r3438 (#4860).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3442 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-17 18:08:15 +00:00