kolan
/
Redmine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
4,042 Commits 2 Branches 91 Tags 22 MiB
Commit Graph

844 Commits

Author SHA1 Message Date
Eric Davis 73f12765a9 Don't duplicate users in Issue#assignable_users. From r4240 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4241 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-10-07 17:46:37 +00:00
Eric Davis 7798e1b1f7 Allow assigning issues back to the author. #4199 
This allows an issue to be reassigned to the author even if they are not
a project member.  Useful when passing back an issue to get more
information from the author.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4240 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-10-07 17:28:29 +00:00
Jean-Baptiste Barth c43ef6e769 Code cleanup: renamed variables in User#allowed_to? with explicit names 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4234 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-10-06 05:08:38 +00:00
Jean-Baptiste Barth e59c927ee5 Fixed: User#allowed_to? returning true in any case if array of projects had only one item (#5332) 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4233 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-10-06 05:08:31 +00:00
Jean-Baptiste Barth e8f3dd07dd Added ability to specify multiple projects in User#allowed_to? (#5332) 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4227 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-29 05:22:45 +00:00
Eric Davis 747b9ec568 Refactor: move method to model 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4224 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-28 22:13:11 +00:00
Eric Davis 437690119b Allow admins to edit user's email notifications and preferences. #3503 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4223 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-28 22:13:06 +00:00
Eric Davis 4c9f261a24 Added three new notifiable events based on issue attributes 
* issue_note_added
* issue_status_updated
* issue_priority_updated

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4221 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-28 20:20:00 +00:00
Eric Davis 582ed86d82 Add a default mail notification setting for new users 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4219 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-28 18:36:50 +00:00
Eric Davis c059300d99 Added User#notify_about? to check when a user should be notified about an event 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4218 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-28 18:22:10 +00:00
Eric Davis 0316af7f6b Converted User#mail_notification from a boolean to a string. 
The string will now store which type of notification option to use.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4216 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-28 18:22:00 +00:00
Eric Davis 83e0be5d07 Fixes reverting an issue to a status with a done_ratio of 0%. #5170 
Contributed by Felix Schäfer

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4186 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-26 18:13:31 +00:00
Eric Davis 83bfb8cd2b Revert "Fixed: gantt broken when no due date on project issues and versions." 
It broke the tests for overdue projects and isn't a good way to fix #6350
because it makes an assumption that a project is due Today and will still
error if issue tracking is disabled.

This reverts commit a7fd592db4. (r4178)

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4184 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-26 17:35:18 +00:00
Jean-Philippe Lang a7fd592db4 Fixed: gantt broken when no due date on project issues and versions. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4178 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-26 08:16:05 +00:00
Eric Davis 51359704a0 Added a users options to the reminders email 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4167 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-20 23:17:51 +00:00
Eric Davis 6a76aef375 Add User#allowed_to_globally? which wraps User#allowed_to? 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4164 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-20 16:38:00 +00:00
Eric Davis f62a1827f3 Updated issue delete confirmation when it has child issues. #6191 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4105 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-20 02:55:26 +00:00
Jean-Baptiste Barth c4d44af54c Fixed non standard SQL syntax. #6413 
Contributed by Juan G

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4091 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-16 19:28:04 +00:00
Eric Davis cdfc57d544 Change the TimelogController's to/from dates based on the project time entries 
Instead of looking for the earliest and latest time entry system wide for the
dates in the form, now TimelogController will only look at the time entries
for the current project (and parent/sub projects).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4087 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-14 19:02:25 +00:00
Eric Davis 8900797ada Refactor: move method to Model. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4086 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-14 19:02:20 +00:00
Eric Davis 878bb55522 Refactor: move method to Project#css_classes 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4080 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-10 23:07:10 +00:00
Eric Davis d36700eeee Refactor: replace chained finders with an inject. Should handle edge cases better. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4079 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-10 19:53:57 +00:00
Eric Davis 41f8d043eb Added a "Member of Role" to the issues filters. #5869 
This filter will check an issue's assigned to field for users who have
(or don't have) a specific Role(s).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4078 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-10 19:44:45 +00:00
Eric Davis 109b42f482 Added a "Member of Group" to the issues filter. #5869 
This filter will check an issue's assigned to field for users in (or not in)
specific groups.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4077 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-10 18:46:29 +00:00
Eric Davis 4c656fcffc Define Principal#name so all subclasses will have some sort of name when printed. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4076 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-10 18:46:23 +00:00
Eric Davis abf3ee4999 Add project names to the Versions in the Gantt export. #5904 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4073 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-10 03:09:11 +00:00
Eric Davis bdb3937e0f Rewrite the Gantt chart. #6276 
This version of the Gantt chart supports nested charts. So Projects,
Versions, and Issues will be nested underneath their parents correctly.

Additional features:

* Move all Gantt code to Redmine::Helpers::Gantt class instead of having it in
  the Gantt class, controller, and view
* Recursive and nest sub-projects
* Recursive and nest versions
* Recursive and nest issues
* Draw a line showing when a Project is active and it's progress
* Draw a line showing when a Version is active and it's progress
* Show a version's % complete
* Change the color of Projects, Versions, and Issues if they are late or
  behind schedule
* Added Project#start_date and #due_date
* Added Project#completed_percent
* Use a mini-gravatar on the Gantt chart
* Added tests for the Gantt rendering

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4072 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-10 03:09:02 +00:00
Eric Davis db11030410 Refactor: move method to model. (references r4057) 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4062 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-09-05 22:57:20 +00:00
Jean-Baptiste Barth e00884bcca Removed hard-coded english error message on failed Member creation 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3929 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-09 05:10:00 +00:00
Jean-Baptiste Barth 56e3953a71 Removed useless debug code. #5978 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3928 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-08 20:26:33 +00:00
Jean-Baptiste Barth 56a6d86af5 Added project filter when viewing all issues. #5084 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3927 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-08 09:01:25 +00:00
Jean-Baptiste Barth 0bcde4ab28 Fixed: assigned_to and author filters in cross project issues view should be based on user's project visibility. #5760 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3916 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-04 21:01:56 +00:00
Eric Davis 16969fdbbb Show the number of days in the subject line of Reminder emails. 
i18n check needed.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3907 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-03 16:01:53 +00:00
Eric Davis 13234f8552 Refactor: Add methods to User to edit the encapsulate the status field. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3906 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-03 15:26:50 +00:00
Jean-Philippe Lang c47d23a87b Fixed: Deleting statuses doesn't delete all workflow entries (#5811). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3881 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-07-25 10:48:27 +00:00
Jean-Philippe Lang 66820dbed3 Strips user email (#5834). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3873 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-07-25 09:50:41 +00:00
Eric Davis a628b0f186 Force-clear the default value for migration from :string to :text. #5846 #5771 
This is a special case for MySQL in Win32.

Contributed by Holger Just.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3860 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-07-24 00:19:32 +00:00
Eric Davis 0d5fca9ba5 Force the default value of path to be set on the Change model class. #5771 
This is needed because MySQL does not support default values on text columns
(Error introduced in r3828)

Contributed by Holger Just

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3830 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-07-06 21:06:09 +00:00
Eric Davis c6201ae15b Recalculate inherited attributes on parents when a child is moved under a new parent. #5524 
Contributed by Jean-Baptiste Barth.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3821 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-30 02:45:34 +00:00
Eric Davis 672852baaf Force string comparison for login search to be case sensitive on MySQL. #2473 
Contributed by Holger Just.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3813 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-24 03:08:20 +00:00
Eric Davis 6cb4ff7d89 Refactor and documentation for User#find_by_login. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3808 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 21:40:55 +00:00
Eric Davis de17640489 Change User#login to be case-insensitive. #2473 
This change also overrides User#find_by_login to give priority to exact
matches in the login.

Contributed by Greg Mefford

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3807 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 21:40:50 +00:00
Eric Davis 4083e7e622 Truncate incoming email subject lines to 255 characters. #5698 
Contributed by Jan

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3801 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 16:22:36 +00:00
Eric Davis d48eb2de47 Accept email from anonymous users with an empty from address. #5604 
Contributed by Andrew Fenn

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3783 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 19:24:17 +00:00
Eric Davis f08b2a394d Unused variable 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3774 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 03:54:28 +00:00
Eric Davis c56c0f411c Fix a nil error when a Project cannot save attachments. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3772 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 03:54:17 +00:00
Eric Davis e94c45d548 Add an "Assigned To" keyword to receiving email. #5594 
Will take a user's email address, login, or full name.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3764 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-29 00:05:24 +00:00
Eric Davis 080dc2212e Add 'Start date' and 'End date' keywords for incoming email. #5595 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3763 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-28 23:45:45 +00:00
Eric Davis 1a4b23731f Include the Project name when sorting versions. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3761 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-27 17:16:15 +00:00
Eric Davis f3cc84b343 Show subproject versions on the Roadmap. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3760 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-27 17:16:10 +00:00
Eric Davis 908d44519c Allow AuthSources to control if they allow password changes. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3745 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-23 03:16:37 +00:00
Eric Davis a1f73c8b20 Remove hard coded LDAP log message. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3743 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-23 03:16:25 +00:00
Jean-Philippe Lang cbd4af236c Adds issue relations to individual issue XML (#5305). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3729 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-01 14:07:36 +00:00
Jean-Philippe Lang da7c89bfd0 Fixes workflow edit with JRuby (#5404). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3709 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-30 12:19:51 +00:00
Eric Davis 7ccdaee110 Only copy visible issues. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3698 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-29 23:26:52 +00:00
Eric Davis 657aa624a4 Adding missing setter for Query#available_columns 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3685 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-20 15:42:52 +00:00
Eric Davis bf33b57aa4 Refactor: Move method to Query model 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3684 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-19 15:08:28 +00:00
Jean-Philippe Lang 0004b52646 Fixes behaviour of move_issues permission for non member role (#5309). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3683 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-18 12:47:41 +00:00
Jean-Philippe Lang 2c0ce104e7 Fixed: Error on db:migrate with table prefix set (#5335). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3678 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-17 12:14:52 +00:00
Eric Davis 88db9d0bdc Replace the hardcoded CustomField::FIELD_FORMATS with a class. 
Custom Field Formats are now full objects and can be registered with
Redmine::CustomFieldFormat to add new formats.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3672 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-16 15:33:49 +00:00
Jean-Philippe Lang 9ccccb9984 Do not raise an error when destroying a Version with assigned issues. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3668 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-11 17:47:29 +00:00
Jean-Philippe Lang f35921d308 Fixes Issue#save_issue_with_child_records so that time entry do not get saved if issue save fails. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3664 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-11 16:48:46 +00:00
Jean-Philippe Lang 43e5bb75d2 Fixed: issue optimistic locking broken by r3308 (#5280). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3663 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-11 16:27:37 +00:00
Jean-Philippe Lang 5163904a3a Fixed: Update of Subversion changesets broken by r3466 under Solaris (#5255). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3635 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-11 13:55:30 +00:00
Jean-Philippe Lang 71a4158fd0 Fixes calculation of version estimated hours with subtasks (#5265). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3633 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-11 13:20:02 +00:00
Jean-Philippe Lang 5879273739 Makes the wiki sidebar editable (#5208). 
The content of the wiki page named 'Sidebar' is rendered in the sidebar if it exists. Permission to edit protected pages is required to create this page.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3632 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-11 12:56:18 +00:00
Jean-Philippe Lang 4524bc04e9 Issue list improvements for subtasking (#5196): 
* makes the parent task column available
* display the issue hierarchy when list is sorted by parent

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3618 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-27 16:55:20 +00:00
Jean-Philippe Lang 79b4f68176 Adds an option to enable/disable email notifications during a project copy (#4672). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3608 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-21 11:17:29 +00:00
Jean-Philippe Lang 5225fb70f5 Optimize retrieval of user's projects members. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3607 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-21 09:28:24 +00:00
Jean-Philippe Lang e584ae220d Cleans up status assignment in IssuesController#new handled by Issue#safe_attributes= now. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3606 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-20 17:37:04 +00:00
Eric Davis 6e6e260cea Refactor: Extract Query#sortable_columns from the controller. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3604 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-19 15:42:03 +00:00
Eric Davis b5d9a1dfbd Refactor: Extract method to the Member model 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3601 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-18 15:49:11 +00:00
Jean-Philippe Lang d550c46160 Makes subtasks rescheduled when a 'precedes' relation is set on a parent task. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3574 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-13 15:29:34 +00:00
Jean-Philippe Lang 8e3d1b694a Adds subtasking (#443) including: 
* priority, start/due dates, progress, estimate, spent time roll-up to parent issues
* descendant issues tree displayed on the issue view with context menu support
* issue tree display on the gantt chart
* issue tree copy on project copy
* unlimited nesting

Defining subtasks requires the new permission 'Manage subtasks'.
Subtasks can not belong to a different project than the parent task.

Implementation is based on scoped nested sets for fast reads and updates.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3573 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-13 14:56:49 +00:00
Jean-Philippe Lang 3dc4dbe302 Fixed: error while moving an issue to a project with disabled tracker with SQLite3 (#5049). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3566 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-12 14:51:33 +00:00
Eric Davis 22c1e2b8cf Adds named scopes to replace custom finders. 
* Adds watched_by class method in ActsAsWatchable
* Adds Issue#recently_updated, Issue#with_limit and Issue#on_active_project

  #2482

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3557 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-10 05:10:43 +00:00
Eric Davis 3f3e30c2aa Refactor: Moved the contents of #issue_update into Issue. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3545 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-05 17:11:50 +00:00
Eric Davis c58dc83e74 Refactor: Replace @journal with @issue.current_journal 
This removes an instance variable in #issue_update which will let it be moved
to the Issue model.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3540 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 16:18:51 +00:00
Eric Davis 976cba0c5d Refactor: use the existing Issue#new_statuses_allowed_to method. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3533 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 00:58:52 +00:00
Jean-Philippe Lang cdb86d5ef7 Fixed: no email notification on new project/version file added (#4966). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3532 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-03 21:32:41 +00:00
Eric Davis fe1e3ccd18 Refactor: Decouple failed attachments and the flash messages 
Attachment#attach_files will no longer need to return a flash message,
instead it will put unsaved attachments into object#unsaved_attachments
where the calling object can access them.

A utility method #render_attachment_warning_if_needed is included for setting
the standard flash warning.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3528 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-03 17:05:00 +00:00
Eric Davis 0fd7e2d696 Refactor: Moved ApplicationController#attach_files to the Attachment model 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3523 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-02 19:26:03 +00:00
Jean-Philippe Lang d6c299f57d Adds 'Blocked by' (#1755) and 'Duplicated by' relation types to the dropdown menu for new relations. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3512 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-28 11:28:32 +00:00
Jean-Philippe Lang 241f79ac06 Fixed: attachments with the same name at the same time overwrite (#3691). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3511 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-28 11:12:40 +00:00
Jean-Philippe Lang 02cc0efdd7 Fixed: journal details duplicated when an issue is saved twice (#3690). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3499 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-28 09:21:12 +00:00
Jean-Philippe Lang d6f9e576e8 Makes AuthSource.authenticate return a hash instead of an array. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3492 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-26 09:13:12 +00:00
Jean-Philippe Lang aa521c5a5a User model should not have to clean up LDAP attributes. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3488 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-26 08:29:20 +00:00
Eric Davis 19d4ddf2f2 Fix LDAP on the fly creation. The User object doesn't have a :dn attribute. 
Fixes #4918 and adds a test for the behavior.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3485 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-25 16:19:55 +00:00
Eric Davis 39c97279ca Optimize: Only select the name when getting the module names. 
This has speed up TimelogController#details by 100% with larger databases
(demo.redmine went from 4077ms down to 2085ms).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3484 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-25 04:55:33 +00:00
Jean-Philippe Lang 46ecc488a9 Fixed: projects are referenced by id in search results. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3482 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-24 21:08:08 +00:00
Jean-Philippe Lang b2dee55e72 Makes project identifiers searchable (#4897). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3481 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-24 21:05:14 +00:00
Jean-Philippe Lang e24d6cc223 Bulk edit refactoring. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3478 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-23 21:26:29 +00:00
Eric Davis f838904a7e Refactor: Extract Issue#bulk_edit from the IssuesController 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3475 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-23 17:06:08 +00:00
Jean-Philippe Lang 0341ac80eb Avoid unnecessary SQL queries when loading changesets. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3473 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-21 14:43:45 +00:00
Jean-Philippe Lang 3d393a5711 Memorize commit authors to speed up changesets loading. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3472 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-21 14:42:45 +00:00
Jean-Philippe Lang 46aa855572 Remove invalid utf8 sequences from commit comments and author name (#4773). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3466 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-20 11:24:41 +00:00
Jean-Philippe Lang dab0c07fba Fixed: Links in Forum mails should redirect to message, not topic (#4884). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3458 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-20 10:07:53 +00:00
Eric Davis c6b2f1d606 Refactor: Extract #get_user_dn from AuthSourceLdap. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3454 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-19 17:00:49 +00:00
Eric Davis d828122009 Refactor: extract AuthSourceLdap#search_attributes 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3453 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-19 16:33:01 +00:00
Eric Davis 6f930e9be6 Refactor: Rewrite authenticate_dn to use an implicit return. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3450 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-18 16:55:10 +00:00
Eric Davis 82dd1b2bf2 Refactor: Moved the check for an empty DN to authenticate_dn 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3449 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-18 16:55:05 +00:00
Eric Davis 4f268c5606 Refactor: extract an #authenticate_dn method in AuthSourceLdap 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3441 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-17 16:35:35 +00:00
Eric Davis b3330d3995 Refactor: Extract method from AuthSourceLdap#authenticate 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3439 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-16 17:03:54 +00:00
Jean-Philippe Lang 2f8cf7f762 Removes duplicated LOC. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3428 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-14 12:45:48 +00:00
Jean-Philippe Lang a811f67748 Fixed: SystemStackError (stack level too deep) on Issue#attributes= after model reload (#4838). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3427 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-14 12:43:48 +00:00
Eric Davis 4a67c211ca Fixed a nil method error in Setting#value= 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3417 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-12 22:08:02 +00:00
Jean-Philippe Lang 541d830d2a Fixed: Project copy loses wiki pages hierarchy (#4797). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3412 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-11 19:30:53 +00:00
Jean-Philippe Lang 2c8a24092b Adds filter for system shared versions on the cross project issue list (#4792). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3409 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-10 21:42:32 +00:00
Jean-Philippe Lang d02ddefff4 Fixed: parent project field doesn't include blank value when a member with 'add subproject' permission edits a child project (#4790). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3405 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-10 20:38:23 +00:00
Jean-Philippe Lang d04d3f181a Fixed: Repository.fetch_changesets tries to fetch changesets for archived projects (#4782). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3402 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-09 18:42:42 +00:00
Jean-Philippe Lang 3c20a9b0ac Do not parse the entire git log to fetch new commits (takes several minutes for a few thousands commits), but only 1 week before the last known commit (#4547, #4716). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3394 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-07 15:17:21 +00:00
Jean-Philippe Lang 8fb29d4d21 Adds pagination to forum messages (#4664). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3373 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-06 12:54:13 +00:00
Eric Davis 5bd912e9a2 Refactor: Extracted the select_all calls to a new private method. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3365 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-04 17:24:33 +00:00
Eric Davis 155083ec97 Change Role#anonymous and #non_member so they generate the record as needed. 
While creating tests, it was a common occurrence to lost the builtin roles
because they are only created in the migrations.  This makes them behave like
User#anonymous.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3363 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-03 17:47:47 +00:00
Eric Davis b86b9b898e Refactor: Moved the raw SQL finders from ReportsController to Issue. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3362 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-03 16:49:21 +00:00
Eric Davis 39c585740d Refactor: Extract method to create a Change from a Changeset. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3360 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-02 17:02:32 +00:00
Eric Davis 358e3194d7 Refactor: Move recipients method into acts_as_event 
acts_as_event should be the standard interface to Redmine events, like mail
notifications, so having a standard recipients implementation there makes sense.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3358 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-01 18:57:12 +00:00
Jean-Philippe Lang d43c860448 Allow commits to reference issues of parent projects and subprojects (#4674). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3357 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-31 16:25:06 +00:00
Jean-Philippe Lang df46d704e8 Log email delivery errors. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3356 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-31 11:41:58 +00:00
Jean-Philippe Lang a0364deb6a Log info when sending an email notification. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3355 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-31 11:00:40 +00:00
Jean-Philippe Lang a1a24483b5 Fixed: deleting a project with subprojects breaks the project tree (#4701). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3354 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-31 10:39:42 +00:00
Jean-Philippe Lang 12ea682b66 Fixed: NOT NULL constraint error when adding a group (#4632). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3343 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-30 10:24:23 +00:00
Jean-Philippe Lang 0a05cc2a37 Set a white list of issue attributes that can be mass-assigned from controllers. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3308 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-12 20:17:20 +00:00
Jean-Philippe Lang ff77fb6aa9 Fixed: email notifications may affect language of notices on the UI (#4086). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3307 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-10 14:54:02 +00:00
Jean-Philippe Lang f6ac12ad9d Fixed: undefined method `stringify_keys!' error in Issue#attributes_with_tracker_first= with ruby1.9 (#4540). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3289 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-09 10:27:05 +00:00
Jean-Philippe Lang 518779d96d Fixed: issue summary counts should link to the issue list without subprojects (#4525). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3283 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-07 21:12:16 +00:00
Eric Davis 4b3d4553e4 Create and assign the api token so the current instance can access it. (#4497) 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3265 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-30 00:25:53 +00:00
Jean-Philippe Lang ff7eb7b23a Auto-detect attachment content type when blank (#3782). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3258 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-29 13:28:30 +00:00
Jean-Philippe Lang 04455783a7 Fixed: project copy doesn't copy group memberships (#3975). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3250 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-26 16:14:55 +00:00
Jean-Philippe Lang c36c924714 Ask for confirmation when a non-admin users tries to remove himself from a project (#4402). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3249 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-26 15:46:12 +00:00
Jean-Philippe Lang a4c64ff84b Fixed: subject of incoming emails gets mangled (#3717). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3247 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-26 12:15:12 +00:00
Jean-Philippe Lang 8db9ecef08 Removes column opt in enumerations table. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3240 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-25 17:13:58 +00:00
Eric Davis 9fb40b1a2f Project#activities should check all overridden activities, not just active ones. 
Fixes #4084

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3239 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-24 18:25:49 +00:00
Jean-Philippe Lang 62c83bdd2e Adds a 'Add subprojects' permission. 
* 'Add project' permission will let user create a root project
* 'Add subprojects' permission will let project members create subprojects

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3238 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-24 16:18:15 +00:00
Jean-Philippe Lang d63784569f Force TimeEntry#hours default to nil (#3075, #4449). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3232 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-23 20:05:46 +00:00
Jean-Philippe Lang 5e1dc78d75 Fixed: wiki pages in search results are referenced by project number, not by project identifier (#4456). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3231 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-23 20:01:28 +00:00
Jean-Philippe Lang 0704ac9444 Fixes delimiters regexp. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3229 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-23 19:52:48 +00:00
Jean-Philippe Lang a54fa93b2e Adds a setting to remove incoming emails body after a delimiter (#4409). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3226 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-23 18:35:19 +00:00
Eric Davis aa9951b38b Added an API token for each User to use when making API requests. (#3920) 
The API key will be displayed on My Account page with a link to reset or
generate a new one.  All existing users will have a token generated by the
migration.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3217 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-23 06:27:28 +00:00
Eric Davis 6be0e335fb Added an optimization note for later. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3207 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-20 19:13:27 +00:00
Jean-Philippe Lang 06ca18b042 Adds a 'no_permission_check' option to the MailHandler. 
Used with the 'project' option, it allows anyone to submit emails to a private inbox project (#4407).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3195 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-19 14:08:48 +00:00
Jean-Philippe Lang 03b57415d6 Avoid a ruby warning. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3192 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-19 12:16:45 +00:00
Jean-Philippe Lang 77aeca5d55 Fixes 'follows' relation validation. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3191 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-18 20:59:30 +00:00
Jean-Philippe Lang beb20e7c6e Adds 'follows' relation (#1432). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3190 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-18 20:35:16 +00:00
Jean-Philippe Lang 6bf0723d06 By default, only show statuses that are used by the tracker on the workflow edit view. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3188 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-18 15:41:32 +00:00
Jean-Philippe Lang bb477a3a0f Make sure users don't get notified for thing they can not view (#3589). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3169 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-13 14:26:54 +00:00
Jean-Philippe Lang 6610bb6b6c Moves watchers filtering logic to ActsAsWatchable. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3168 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-13 13:06:57 +00:00
Jean-Philippe Lang f33231181f Makes user unwatch what he can no longer view after its permissions have changed (#3589). 
A rake task (redmine:watchers:prune) is also added to prune existing watchers.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3167 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-13 12:39:22 +00:00
Eric Davis 17512e7efd Copy issue relations when copying a project. (#3367) 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3164 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-13 03:37:21 +00:00
Jean-Philippe Lang 21b52d2fd9 Display users then groups on project memberships view (#4389). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3161 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-12 11:20:26 +00:00