Commit Graph

4703 Commits

Author SHA1 Message Date
Jean-Philippe Lang a8083fb9a8 Pass the order option as an array to satisfy sqlserver adapter (#12713).
Unlike other adapters, the sqlserver adapter processes the order option and wipes it when using functions.
Here we can see a "ASC" inserted in the COALESCE call:

irb(main):001:0> Issue.order("coalesce(estimated_hours, 0), id").to_sql
=> "SELECT [issues].* FROM [issues] ORDER BY coalesce(estimated_hours ASC, 0) ASC, id ASC"

This does not happen when passing the order SQL fragments separately.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11115 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 10:04:25 +00:00
Jean-Philippe Lang 9613a13b10 Deprecates Version#*_pourcent in favour of #*_percent (#12724).
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11113 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 08:30:25 +00:00
Toshi MARUYAMA 3bf6f8d7ff remove trailing white-space from app/controllers/wiki_controller.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11110 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 01:11:33 +00:00
Jean-Philippe Lang 24ec41f7d4 A column has been specified more than once in the order by list (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11106 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 13:40:50 +00:00
Jean-Philippe Lang 503933c585 Don't do any query if id is not present.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11105 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 13:39:04 +00:00
Jean-Philippe Lang 77f6b404fa Make sure we don't cast an empty string to numeric (#12713).
SQLServer evaluates the CAST condition even if the <> '' condition is false.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11103 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 13:33:16 +00:00
Jean-Philippe Lang d82159bcf5 Use joins instead of sub-queries in group by/sort by when using custom fields (#12713).
Sub-queries in group by are not supported by SQLServer.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11102 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 12:28:50 +00:00
Jean-Philippe Lang 049eaeb776 Repository changesets are already sorted by committed_on DESC (#12713).
SQLServer raises an error because committed_on is specified twice in the order by list.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11101 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:40:39 +00:00
Jean-Philippe Lang 8b08c1a534 Prevents position to be specified more than once in the order by list which is not supported by SQLServer (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11100 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:37:07 +00:00
Jean-Philippe Lang dd7d54b3a1 SQLServer: rule is a reserved keyword (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11099 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:21:45 +00:00
Jean-Philippe Lang 0135dc504a SQLServer: The size (60) given to the type 'decimal' exceeds the maximum allowed (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11098 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:21:03 +00:00
Jean-Philippe Lang 64b98928c9 Typo in app/models/tracker.rb (#12707).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11090 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-02 13:02:20 +00:00
Toshi MARUYAMA 758e07cd96 replace tabs to spaces at app/views/timelog/_form.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11086 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-27 03:09:56 +00:00
Jean-Philippe Lang c87f36d20b Log an error when trying to send an attachment that cannot be read.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11084 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-26 14:00:10 +00:00
Jean-Philippe Lang 6be315c1ff Update the issue subject when choosing an issue from the drop down menu.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11083 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-26 13:12:38 +00:00
Jean-Philippe Lang 7606353ff9 Upgraded JQuery to 1.8.3 and JQuery UI to 1.9.2.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11081 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-26 11:47:51 +00:00
Jean-Philippe Lang 7b8ebb7e3f Auto-populate fields while creating a new user with LDAP (#10286).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11080 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-26 11:23:53 +00:00
Jean-Philippe Lang eba4efc9d0 Missing labels on auth_source edit form.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11079 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-24 10:42:37 +00:00
Jean-Philippe Lang b7d8913459 Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11078 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-23 16:10:07 +00:00
Jean-Philippe Lang 4ac43ab876 Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11077 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-23 15:55:57 +00:00
Jean-Philippe Lang 3ef7f5855e Renamed #_issues_path to #_project_issues_path.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11076 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-23 15:19:57 +00:00
Jean-Philippe Lang e921d70e53 Moved routes helper methods to an helper.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11075 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-23 15:18:39 +00:00
Jean-Philippe Lang 1528c719a4 Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11074 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-23 15:12:57 +00:00
Jean-Philippe Lang 8eea999ca6 Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11072 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 15:57:07 +00:00
Jean-Philippe Lang ad246e81ad Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11071 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 12:24:43 +00:00
Jean-Philippe Lang a4f989a5e0 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11070 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 10:57:01 +00:00
Jean-Philippe Lang 6c15812d96 Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11069 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 10:40:32 +00:00
Jean-Philippe Lang bda9b98a56 Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11068 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 10:30:42 +00:00
Jean-Philippe Lang cd437b7e1d Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11067 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 10:00:00 +00:00
Jean-Philippe Lang 3976d5e740 Use #assert_select instead of #assert_tag.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11066 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 09:35:35 +00:00
Jean-Philippe Lang 94d9172634 Changed revision regexp to make source: links accept a branch.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11063 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-21 20:59:35 +00:00
Toshi MARUYAMA b4aab7b375 remove trailing white-spaces from app/models/issue_relation.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11061 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-21 04:52:58 +00:00
Jean-Philippe Lang 42d3ec3a59 Display 25 items.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11028 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-17 18:24:06 +00:00
Jean-Philippe Lang 85fb937a4e Use scoped models for pagination.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11027 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-17 18:23:30 +00:00
Jean-Philippe Lang 1cf379f370 Replaces the classic_pagination plugin with a simple pagination module.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11026 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-17 18:21:24 +00:00
Toshi MARUYAMA dd26ac3038 code cleanup gantt_helper.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11021 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-17 07:14:26 +00:00
Jean-Philippe Lang 39e7bab2b9 Save the selected file just in case uploading stuff fails/is not supported.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11010 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-15 10:03:34 +00:00
Jean-Philippe Lang 7775f86a69 Code cleanup in AuthSource controller and views.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10996 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-13 15:04:11 +00:00
Jean-Philippe Lang c31f498ba6 Code cleanup: implement Plugin#to_param for generating routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10995 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-13 13:52:56 +00:00
Jean-Philippe Lang c93fccc84a Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10994 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-13 13:43:01 +00:00
Jean-Philippe Lang 0a773bcbb3 Fixed that validation fails when receiving an email with list custom fields (#12400).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10992 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-13 13:14:46 +00:00
Jean-Philippe Lang b99a6f11f3 Fixed: clicking journal edit multiple times shows multiple forms (#12568).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10991 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-13 12:42:10 +00:00
Jean-Philippe Lang c99b638d61 Store attachments in subdirectories (#5298).
Existing files can be moved to their target subdirectories using rake redmine:attachments:move_to_subdirectories.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10990 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-13 12:07:19 +00:00
Jean-Philippe Lang cabfece11b Use browser language as default when registering.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10988 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-12 06:05:35 +00:00
Jean-Philippe Lang 24be0551cc Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10987 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-11 20:38:26 +00:00
Jean-Philippe Lang 8c7b6012f5 Removed unused code.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10985 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-11 20:09:16 +00:00
Jean-Philippe Lang ec7c512693 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10984 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-11 19:42:12 +00:00
Jean-Philippe Lang 8ab9215ea8 Use named routes in controllers.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10983 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-11 19:39:47 +00:00
Jean-Philippe Lang 0b96094680 Use named routes in controllers.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10981 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-11 17:51:30 +00:00
Jean-Philippe Lang 228414f777 Moved IssueRelations to IssueRelation::Relations.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10979 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-10 21:59:01 +00:00