Commit Graph

9288 Commits

Author SHA1 Message Date
Jean-Philippe Lang a8083fb9a8 Pass the order option as an array to satisfy sqlserver adapter (#12713).
Unlike other adapters, the sqlserver adapter processes the order option and wipes it when using functions.
Here we can see a "ASC" inserted in the COALESCE call:

irb(main):001:0> Issue.order("coalesce(estimated_hours, 0), id").to_sql
=> "SELECT [issues].* FROM [issues] ORDER BY coalesce(estimated_hours ASC, 0) ASC, id ASC"

This does not happen when passing the order SQL fragments separately.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11115 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 10:04:25 +00:00
Jean-Philippe Lang 0337d9abc3 Use activerecord-jdbc-adapter 1.2.5.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11114 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 09:00:55 +00:00
Jean-Philippe Lang 9613a13b10 Deprecates Version#*_pourcent in favour of #*_percent (#12724).
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11113 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 08:30:25 +00:00
Jean-Philippe Lang 9c698157f4 Check permissions before the extra condition for displaying a menu item (#12721).
Patch by Daniel Ritz.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11112 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 08:21:33 +00:00
Toshi MARUYAMA 3bf6f8d7ff remove trailing white-space from app/controllers/wiki_controller.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11110 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 01:11:33 +00:00
Jean-Philippe Lang d264911f14 Upgrade to Rails 3.2.10.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11109 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 22:54:33 +00:00
Jean-Philippe Lang 902d4bcf1c Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11108 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 13:59:15 +00:00
Jean-Philippe Lang 03329b5d4d Use joins instead of sub-queries (#12713).
Sub-queries in group by are not supported by SQLServer.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11107 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 13:57:27 +00:00
Jean-Philippe Lang 24ec41f7d4 A column has been specified more than once in the order by list (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11106 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 13:40:50 +00:00
Jean-Philippe Lang 503933c585 Don't do any query if id is not present.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11105 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 13:39:04 +00:00
Jean-Philippe Lang e4f0b9a9f9 Fixed fixtures.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11104 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 13:38:22 +00:00
Jean-Philippe Lang 77f6b404fa Make sure we don't cast an empty string to numeric (#12713).
SQLServer evaluates the CAST condition even if the <> '' condition is false.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11103 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 13:33:16 +00:00
Jean-Philippe Lang d82159bcf5 Use joins instead of sub-queries in group by/sort by when using custom fields (#12713).
Sub-queries in group by are not supported by SQLServer.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11102 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 12:28:50 +00:00
Jean-Philippe Lang 049eaeb776 Repository changesets are already sorted by committed_on DESC (#12713).
SQLServer raises an error because committed_on is specified twice in the order by list.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11101 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:40:39 +00:00
Jean-Philippe Lang 8b08c1a534 Prevents position to be specified more than once in the order by list which is not supported by SQLServer (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11100 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:37:07 +00:00
Jean-Philippe Lang dd7d54b3a1 SQLServer: rule is a reserved keyword (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11099 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:21:45 +00:00
Jean-Philippe Lang 0135dc504a SQLServer: The size (60) given to the type 'decimal' exceeds the maximum allowed (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11098 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:21:03 +00:00
Jean-Philippe Lang 9c561f9124 SQLServer does not support changing the type of an indexed column (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11097 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:19:08 +00:00
Jean-Philippe Lang 3218b8204c Check that locale is well formed.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11096 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:12:41 +00:00
Jean-Philippe Lang 6f614c034f YAML.load_file returns a Hash with 3 keys with ruby 1.9.3p194 (2012-04-20) [i386-mingw32].
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11095 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:02:11 +00:00
Jean-Philippe Lang 5715f40b21 YAML.load_file fails with ruby 1.9.3p194 (2012-04-20) [i386-mingw32].
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11094 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:01:42 +00:00
Toshi MARUYAMA 524baaa9ca German translation restructured by Daniel Felix (#12708)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11092 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-02 16:30:58 +00:00
Toshi MARUYAMA 2ba7228b06 fix incorrect min_x_value of lib/SVG/Graph/TimeSeries.rb by r10439 (#12711, #11290)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11091 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-02 15:53:52 +00:00
Jean-Philippe Lang 64b98928c9 Typo in app/models/tracker.rb (#12707).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11090 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-02 13:02:20 +00:00
Jean-Philippe Lang 3644571d8a cannot load Java class com.mysql.jdbc.Driver error with jdbc-mysql 5.1.22.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11089 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-02 11:59:25 +00:00
Jean-Philippe Lang 01cbac3b74 Link to Wikipedia (#12691).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11088 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-02 07:50:38 +00:00
Jean-Philippe Lang a18f6ffb37 Icon for the textile help link.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11087 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-02 07:47:12 +00:00
Toshi MARUYAMA 758e07cd96 replace tabs to spaces at app/views/timelog/_form.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11086 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-27 03:09:56 +00:00
Jean-Philippe Lang 11977f08a7 Tests broken with activerecord-jdbc-adapter 1.2.3.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11085 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-26 14:16:42 +00:00
Jean-Philippe Lang c87f36d20b Log an error when trying to send an attachment that cannot be read.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11084 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-26 14:00:10 +00:00
Jean-Philippe Lang 6be315c1ff Update the issue subject when choosing an issue from the drop down menu.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11083 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-26 13:12:38 +00:00
Jean-Philippe Lang 48a51e60bc Adds an indicator to all autocomplete/search fields.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11082 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-26 12:01:11 +00:00
Jean-Philippe Lang 7606353ff9 Upgraded JQuery to 1.8.3 and JQuery UI to 1.9.2.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11081 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-26 11:47:51 +00:00
Jean-Philippe Lang 7b8ebb7e3f Auto-populate fields while creating a new user with LDAP (#10286).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11080 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-26 11:23:53 +00:00
Jean-Philippe Lang eba4efc9d0 Missing labels on auth_source edit form.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11079 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-24 10:42:37 +00:00
Jean-Philippe Lang b7d8913459 Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11078 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-23 16:10:07 +00:00
Jean-Philippe Lang 4ac43ab876 Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11077 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-23 15:55:57 +00:00
Jean-Philippe Lang 3ef7f5855e Renamed #_issues_path to #_project_issues_path.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11076 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-23 15:19:57 +00:00
Jean-Philippe Lang e921d70e53 Moved routes helper methods to an helper.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11075 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-23 15:18:39 +00:00
Jean-Philippe Lang 1528c719a4 Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11074 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-23 15:12:57 +00:00
Jean-Philippe Lang 0927230a18 Adds route names for r11072.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11073 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 15:57:27 +00:00
Jean-Philippe Lang 8eea999ca6 Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11072 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 15:57:07 +00:00
Jean-Philippe Lang ad246e81ad Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11071 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 12:24:43 +00:00
Jean-Philippe Lang a4f989a5e0 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11070 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 10:57:01 +00:00
Jean-Philippe Lang 6c15812d96 Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11069 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 10:40:32 +00:00
Jean-Philippe Lang bda9b98a56 Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11068 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 10:30:42 +00:00
Jean-Philippe Lang cd437b7e1d Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11067 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 10:00:00 +00:00
Jean-Philippe Lang 3976d5e740 Use #assert_select instead of #assert_tag.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11066 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 09:35:35 +00:00
Jean-Philippe Lang eecabc5bb0 Use #assert_select instead of #assert_tag.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11065 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 08:17:59 +00:00
Jean-Philippe Lang 7f74044854 "New issue" menu item should not link to copy form (#12652).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11064 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-21 21:17:21 +00:00