Commit Graph

55 Commits

Author SHA1 Message Date
Daniel Pfeifer 5d3b5bef11 QCMakeCacheView: simplify boolean expression 2016-09-08 23:35:59 +02:00
Daniel Pfeifer ad42eb33b6 QCMakeCacheView: no else after return 2016-09-08 23:33:08 +02:00
Daniel Pfeifer 62c5f9afc3 QtDialog: fix clang-tidy warnings 2016-09-06 08:42:54 -04:00
Kitware Robot d9fd2f5402 Revise C++ coding style using clang-format
Run the `Utilities/Scripts/clang-format.bash` script to update
all our C++ code to a new style defined by `.clang-format`.
Use `clang-format` version 3.8.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.
2016-05-16 16:05:19 -04:00
Brad King e1c7747253 Format include directive blocks and ordering with clang-format
Sort include directives within each block (separated by a blank line) in
lexicographic order (except to prioritize `sys/types.h` first).  First
run `clang-format` with the config file:

    ---
    SortIncludes: false
    ...

Commit the result temporarily.  Then run `clang-format` again with:

    ---
    SortIncludes: true
    IncludeCategories:
      - Regex:    'sys/types.h'
        Priority: -1
    ...

Commit the result temporarily.  Start a new branch and cherry-pick the
second commit.  Manually resolve conflicts to preserve indentation of
re-ordered includes.  This cleans up the include ordering without
changing any other style.

Use the following command to run `clang-format`:

    $ git ls-files -z -- \
        '*.c' '*.cc' '*.cpp' '*.cxx' '*.h' '*.hh' '*.hpp' '*.hxx' |
      egrep -z -v '(Lexer|Parser|ParserHelper)\.' |
      egrep -z -v '^Source/cm_sha2' |
      egrep -z -v '^Source/(kwsys|CursesDialog/form)/' |
      egrep -z -v '^Utilities/(KW|cm).*/' |
      egrep -z -v '^Tests/Module/GenerateExportHeader' |
      egrep -z -v '^Tests/RunCMake/CommandLine/cmake_depends/test_UTF-16LE.h' |
      xargs -0 clang-format -i

This selects source files that do not come from a third-party.

Inspired-by: Daniel Pfeifer <daniel@pfeifer-mail.de>
2016-04-29 13:58:54 -04:00
Andreas Mohr f57800d6f5 Fix spelling and typos (product names)
API, Borland, MinGW, UNIX, Mac OS X.
2013-05-07 08:42:20 -04:00
Stephen Kelly 6387f6d85c cmake-gui: Use the QStandardItemModel workaround until 5.1.0.
If there is a Qt 5.0.3 release, it may or may not contain the patch
that fixes this issue.

 http://thread.gmane.org/gmane.comp.lib.qt.releasing/882

Just use the workaround until 5.1.0 which certainly will contain the
fix. Don't use the workaround before Qt 5.0.0.
2013-03-19 15:14:46 -04:00
Stephen Kelly 404e1d675a cmake-gui: Workaround bug in Qt 5.0.0 to 5.0.3 QStandardItemModel
The commit in qtbase 9dfba89c (Add implementations of QAIM::sibling in
public APIs., 2012-09-26) added a buggy implementation of sibling(), and
the commit f136701b (Use the base implementation of
QAbstractItemModel::sibling in QSIM., 2013-02-21) resolves it.
Workaround the bug for Qt releases that have it.
2013-03-12 18:41:26 -04:00
Kitware Robot 7bbaa4283d Remove trailing whitespace from most CMake and C/C++ code
Our Git commit hooks disallow modification or addition of lines with
trailing whitespace.  Wipe out all remnants of trailing whitespace
everywhere except third-party code.

Run the following shell code:

git ls-files -z -- \
 bootstrap doxygen.config '*.readme' \
 '*.c' '*.cmake' '*.cpp' '*.cxx' \
 '*.el' '*.f' '*.f90' '*.h' '*.in' '*.in.l' '*.java' \
 '*.mm' '*.pike' '*.py' '*.txt' '*.vim' |
egrep -z -v '^(Utilities/cm|Source/(kwsys|CursesDialog/form)/)' |
egrep -z -v '^(Modules/CPack\..*\.in)' |
xargs -0 sed -i 's/ \+$//'
2012-08-13 14:18:39 -04:00
Clinton Stimpson b1f52b1fd8 Fix grouping bug where "Ungrouped Entries" showed up as a child. 2011-01-28 08:50:56 -07:00
Clinton Stimpson 3f158c6dfa cmake-gui: always enable generate button. 2010-12-17 19:04:57 -07:00
Brad King 96afb12087 Convert CMake to OSI-approved BSD License
This converts the CMake license to a pure 3-clause OSI-approved BSD
License.  We drop the previous license clause requiring modified
versions to be plainly marked.  We also update the CMake copyright to
cover the full development time range.
2009-09-28 11:43:28 -04:00
Clinton Stimpson 551fcc23c2 fix compile warnings 2009-09-23 13:09:56 -04:00
Clinton Stimpson 37805ff81c ENH: Allow edit on single click. Fixes #9393. Also fix row heights to be consistent. 2009-08-10 13:25:22 -04:00
Clinton Stimpson 17acf0a310 ENH: Add a "Show my changes" to the Tools menu.
Changes by the user are recorded and when requested, it shows
      -D arguments for commandline or contents for a cache file.
2009-07-17 14:38:36 -04:00
Clinton Stimpson ff09eacf5c BUG: Don't return checkable flag for item when in the middle of configure/generate. 2009-03-26 11:42:37 -04:00
Clinton Stimpson c54f47635c ENH: Add support for showing combo box for choosing from a list of strings that a cache property can have. 2009-03-12 11:19:27 -04:00
Clinton Stimpson 667d5f9446 BUG: Fix column widths on some systems. 2008-06-30 14:29:08 -04:00
Clinton Stimpson 88a9a3254e BUG: Don't create empty property. Fixes bug #7193. 2008-06-24 00:00:42 -04:00
Clinton Stimpson b428350d1e ENH: remove red blending. It didn't look good on some systems. 2008-06-13 16:57:07 -04:00
Clinton Stimpson 82a5b8000e ENH: instead of solid red for new entries, blend it with the alternating
white/gray (depending on style).
2008-06-13 15:29:07 -04:00
Clinton Stimpson b1c31be668 ENH: Make original flat view the default.
Add option to switch to grouped view (and remember it).
2008-06-13 11:19:53 -04:00
Clinton Stimpson db016a096e ENH: better name for ungrouped entries. 2008-06-11 15:08:52 -04:00
Clinton Stimpson b31b420b65 BUG: need to invalidate filtering when using Qt 4.3+. 2008-06-11 14:47:56 -04:00
Clinton Stimpson 36576a4e7a ENH: Give a label for the group of properties that didn't get put into another
group.
2008-06-10 20:17:23 -04:00
Clinton Stimpson 2d37d2a48d ENH: group together items with no prefix and items that won't be
grouped with others.
2008-06-10 18:53:22 -04:00
Clinton Stimpson 13d55b6ae4 ENH: Use a tree view of the properties instead of a flat list view.
Properties are grouped by a prefix (up to first "_") and can be expanded
      or collapsed.

      Fixes #6359.
2008-06-10 00:17:00 -04:00
Clinton Stimpson f8f4140b6c ENH: Add cross compiling support in the GUI in the same dialog that prompts for
the generator on the first configure.  It either ask for a toolchain file
      or asks for all the information a toolchain file might contain.

      Also added option for setting non-default compilers if not cross compiling.
      Fixes #6849.

      Also a bit of code cleanup and re-organizing.
2008-05-15 19:21:01 -04:00
Clinton Stimpson 1e61bb1f4c BUG: Keep editor alive when file dialog comes up to pick another file or path.
The editor going away prematurely Seems to only happen on Mac OS X.
2008-04-02 15:28:17 -04:00
Clinton Stimpson d0d67d0015 ENH: Convert native paths from QFileDialog and QDirModel/QCompleter.
BUG:  Block possible completion loop.
2008-02-14 19:58:31 -05:00
Clinton Stimpson df3169273a ENH: Add shortcut to start search/filter.
A bit of cleanup.
      Disable tab navigation in cache variable list.
      Enable home/end keys.

BUG:  Ensure currently edited values are saved before doing configure.
2008-02-14 18:18:10 -05:00
Clinton Stimpson c327b569f0 ENH: Remove CurrentChanged from the table view's edit triggers.
It results in editor issues when modifying the view.
     Remove workarounds for some of those issues.
2008-02-13 13:58:35 -05:00
Clinton Stimpson 45cf2ade08 COMP: Fix build with Qt 4.2.
BUG:  Fix new editors stealing focus while typing search text.
ENH:  Look for translation in data dir, not bin dir.
2008-02-08 10:42:14 -05:00
Clinton Stimpson dcd29a14b0 ENH: Show cache variable name in title of file dialogs. 2008-02-07 17:58:57 -05:00
Clinton Stimpson 5cd4f2a661 ENH: more robust search filter. 2007-11-16 10:40:23 -05:00
Clinton Stimpson 195e1035ab COMP: Fix warning. 2007-11-14 23:30:05 -05:00
Clinton Stimpson 1d2b5ed440 ENH: single click can start editing cache values. 2007-11-13 12:53:10 -05:00
Clinton Stimpson b31d4f9d17 BUG: The search is set to apply to all columns, but in Qt 4.2, that breaks
the search entirely.  Search on the first column only when using Qt 4.2.
2007-11-13 11:18:40 -05:00
Clinton Stimpson 073b109508 ENH: Allow clicking anywhere in field to toggle check boxes. 2007-11-13 00:17:10 -05:00
Clinton Stimpson a81896eaed ENH: Add ability to add cache entries (even before first configure). 2007-11-12 23:54:49 -05:00
Clinton Stimpson 5a539b731b ENH: Re-arrange UI a bit.
BUG:  Properly update when values that changed since the last configure.
2007-11-10 11:36:09 -05:00
Clinton Stimpson 57e46c74d4 BUG: Don't prompt for unsaved changes if no changes were made.
ENH:  Error messages go to output window instead of message boxes.
2007-11-09 15:18:49 -05:00
Clinton Stimpson c5b01a7daf ENH: Add completion to editor for files and file paths. 2007-11-09 01:14:37 -05:00
Clinton Stimpson e615e1416c COMP: Fix warnings. 2007-11-08 10:22:20 -05:00
Clinton Stimpson 9f676df3c6 ENH: add context menu for deleting, ignoring, and getting help for cache entries.
ENH:  add delete cache button
ENH:  add information string above configure/generate buttons
ENH:  change search to search both columns, and from regex to plain string search
ENH:  add buddy info in cache entry view, so double clicking in the left column
      starts editing the associated value.
BUG:  fix file path editor so it goes away when focus is lost
2007-11-08 10:17:37 -05:00
Clinton Stimpson 31d4280bf3 BUG: Fix behavior of CMakeSetupDialog::set{Binary|Source}Directory
so they work right when called externally.
      Disable the generate button when one hits configure again.
ENH:  Some UI tweaks for spacing.
      Allow viewing cache values while configure/generate (but not edit).
2007-11-07 10:09:02 -05:00
Clinton Stimpson 1e91100599 ENH: Disable menu/buttons when doing configure.
Also disable generate until configure is done.
      Save more settings (last 10 binary directories, exit after generate,
                          last generator)
      Some UI tweaks for better layout.
      Support drag & drop of CMakeLists.txt/CMakeCache.txt files.
2007-11-06 19:25:43 -05:00
Clinton Stimpson b61e5ff0f2 ENH: search is case insensitive
ENH:  put back prompt for generator, and change combo to label
      showing current generator.
2007-11-06 00:02:08 -05:00
Clinton Stimpson a7746624e8 ENH: Replace prompt for generator with combobox in UI.
ENH:  Make "Show Advanced" toggle work.
ENH:  Add regex search capabilities.
ENH:  Read existing registry entries from MFC CMakeSetup.exe (will save later).
2007-11-05 19:26:18 -05:00
Clinton Stimpson cfa723d457 ENH: Prompt user for generator when there is none.
Many minor improvements, bug fixes, and style fixes.
2007-11-05 13:20:54 -05:00