15065 Commits

Author SHA1 Message Date
Ben Boeckel
33c63b19ab Add a method to put a watch for variables 2010-09-22 12:46:16 -04:00
Ben Boeckel
535253f385 Initialize the warning variables earlier 2010-09-22 12:46:15 -04:00
Ben Boeckel
cbb286c0b2 Fix the path detection to work for top-level 2010-09-22 12:46:15 -04:00
Ben Boeckel
62be1f78ae Initialize the usage stack earlier 2010-09-22 12:46:15 -04:00
Ben Boeckel
c6e7fabc0f Factor out the checks for unused variables 2010-09-22 12:46:15 -04:00
Ben Boeckel
5e41ba8e4a When using the API, check for Add vs. Remove 2010-09-17 10:13:19 -04:00
Ben Boeckel
dee19760a7 Fix typo in VariableUnusedViaUnset test 2010-09-17 10:04:18 -04:00
Ben Boeckel
f231ce5ce3 Remove old false positive avoidance code
From email explaining existence in the first place:

    This is from before when the used checks throwing false
    positives about unused due to changing the definition without
    checking whether it *had* a value to begin with and me not
    realizing they were false positives. I was thinking that it was
    warning from ARGC et. al. not being used since the previous
    macro or function call and the new value warning about
    overwriting the old value.
2010-09-17 10:02:15 -04:00
Ben Boeckel
a117e02cc8 Revert "Add test for unused warnings at the end of scope"
This reverts commit 91c4c9921c40361df860c1384a46ed77c6118c23.

The test doesn't work yet and should not have been put on this branch
yet.
2010-09-17 09:47:17 -04:00
Ben Boeckel
2c82f2b759 Exempt CMAKE(CURRENT|PARENT)_LIST_FILE from usage 2010-09-16 17:50:07 -04:00
Ben Boeckel
6d7d449cb1 Ignore CLI warnings for ABI determination 2010-09-16 17:49:37 -04:00
Ben Boeckel
7740a738e0 Only return local keys that are defined 2010-09-16 16:07:34 -04:00
Ben Boeckel
bef3aeebab Use the API so that warnings can be tracked 2010-09-16 16:06:16 -04:00
Ben Boeckel
05cb0f4daf Check for unused variables in the dtor 2010-09-16 16:05:59 -04:00
Ben Boeckel
91c4c9921c Add test for unused warnings at the end of scope 2010-09-16 13:54:16 -04:00
Ben Boeckel
ca90f673a0 Fix detection of unused variables when setting 2010-09-16 13:53:41 -04:00
Ben Boeckel
f7438ca7ac Add test for unused detection via setting it 2010-09-16 13:52:54 -04:00
Ben Boeckel
995cfb0e2a Don't warn if the variable wasn't defined 2010-09-16 13:52:17 -04:00
Ben Boeckel
aefc91dd37 Add test for usage checks via unset 2010-09-16 13:51:51 -04:00
Ben Boeckel
a8e97f8a08 Remove VarRemoved code since it's been superceded 2010-09-16 13:50:39 -04:00
Ben Boeckel
59463ef1a3 Rework CheckVariableForUnused usage 2010-09-16 11:50:57 -04:00
Ben Boeckel
f117423336 Fix line lengths to be no more than 78 2010-09-16 11:49:58 -04:00
Ben Boeckel
e49a935c20 Improve unused warning logic
Only warn when changing the definition of an initialized variable.
2010-09-15 11:41:27 -04:00
Ben Boeckel
e01e40cb87 Mark ARGC, ARGV*, and ARGN as used 2010-09-15 11:35:50 -04:00
Ben Boeckel
a17aff74c7 Ignore CMAKE_MATCH_* variables for usage 2010-09-15 11:35:05 -04:00
Ben Boeckel
02a114dfe8 Add method to allow variables to be marked as used 2010-09-15 11:34:35 -04:00
Ben Boeckel
a0b0d23f0c CMAKE_DO_TRY_COMPILE is no longer used 2010-09-14 17:51:43 -04:00
Ben Boeckel
ae3eff35b4 Fix the path used for ignoring system warnings 2010-09-14 17:14:25 -04:00
Ben Boeckel
056b44113f Fix missing case for usage of a variable 2010-09-14 17:10:22 -04:00
Ben Boeckel
980e048a7d Factor out checks for unused variables 2010-09-14 17:10:04 -04:00
Ben Boeckel
83acb0a4b2 Remove now unused variables 2010-09-08 13:29:57 -04:00
Ben Boeckel
3801463c9f Use built-ins for readability and maintainability 2010-09-08 12:03:42 -04:00
Ben Boeckel
8b520158c3 Push the initialize and unused states when copying 2010-09-07 15:12:15 -04:00
Ben Boeckel
439877f620 Be consistent with single and double quotes 2010-09-02 12:14:06 -04:00
Ben Boeckel
4cf17062d3 Add documentation for check-system-vars 2010-09-02 11:39:22 -04:00
Ben Boeckel
b74777fdb2 Fix the spelling of the flag for warn-unused-vars 2010-09-02 11:39:01 -04:00
Ben Boeckel
b94812072a Change logic of flag to turn off cli unused checks
Since we default to checking unused cli variables, make the flag turn
off the checks.
2010-09-02 11:38:00 -04:00
Ben Boeckel
f047a17c59 Add test for uninitialized variables 2010-09-02 11:34:13 -04:00
Ben Boeckel
75bda3864e Add tests for unused command line variables 2010-09-02 11:33:57 -04:00
Ben Boeckel
300fc15779 Fix detection of system files
Instead of looking to see if the file is under CMAKE_ROOT, check to see
if it is instead under the source or binary directories in use.
2010-09-02 11:33:34 -04:00
Ben Boeckel
d784e6af4d Run the unused variables check on the final pass 2010-09-02 11:29:05 -04:00
Ben Boeckel
9efc05722e VariableWatch is not available when bootstrapping 2010-09-02 09:10:52 -04:00
Ben Boeckel
2e78224509 Add a missing comma to the warning message 2010-09-01 13:09:08 -04:00
Ben Boeckel
74997000c8 Add a flag to warn about system files 2010-09-01 13:09:08 -04:00
Ben Boeckel
fff9f6d6f7 Rename flags again and use variablewatch for cli 2010-09-01 13:09:08 -04:00
Ben Boeckel
786e2695cb Add warn-unused to the Qt interface 2010-09-01 13:08:15 -04:00
Ben Boeckel
636e6c4ef7 Default to marking things as used
If we don't then:

    cmake --warn-unused --warn-unused-all

acts differently than:

    cmake --warn-unused-all --warn-unused
2010-09-01 13:08:15 -04:00
Ben Boeckel
4ff03402fc Rename find-unused to warn-unused 2010-09-01 13:08:14 -04:00
Ben Boeckel
d7999e9b29 Rename strict-mode to warn-uninitialized 2010-09-01 13:08:14 -04:00
Ben Boeckel
e141bc950a Detect unused variables 2010-09-01 13:08:14 -04:00