Eric Davis
afdcd770dc
Refactor: Extract method
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3538 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 05:33:54 +00:00
Eric Davis
bc79caaf69
Refactor: Extract method
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3537 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 05:33:49 +00:00
Eric Davis
be20d98040
Refactor: Extract methods to before_filters
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3536 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 05:33:45 +00:00
Eric Davis
3a99f18913
Refactor: Split method
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3535 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 05:33:40 +00:00
Eric Davis
ca6df3d78d
Refactor: Extract method
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3534 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 05:33:35 +00:00
Eric Davis
976cba0c5d
Refactor: use the existing Issue#new_statuses_allowed_to method.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3533 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 00:58:52 +00:00
Eric Davis
fe1e3ccd18
Refactor: Decouple failed attachments and the flash messages
...
Attachment#attach_files will no longer need to return a flash message,
instead it will put unsaved attachments into object#unsaved_attachments
where the calling object can access them.
A utility method #render_attachment_warning_if_needed is included for setting
the standard flash warning.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3528 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 17:05:00 +00:00
Eric Davis
f6d8752e44
Fixes destroying attachments if the update fails. (r2875 r3523)
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3526 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 17:04:50 +00:00
Jean-Philippe Lang
b09a483aa9
Fixed: error while deleting an in-use enumeration ( #4970 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3524 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-02 20:03:09 +00:00
Eric Davis
0fd7e2d696
Refactor: Moved ApplicationController#attach_files to the Attachment model
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3523 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-02 19:26:03 +00:00
Eric Davis
f5f5a5f64f
Verify issues are updated by HTTP PUT only. Regression from r3486.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3520 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-01 18:29:18 +00:00
Eric Davis
8699e5bbcd
Refactor: Decouple building Issue and TimeEntry objects in #issue_update.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3519 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-01 17:40:54 +00:00
Jean-Philippe Lang
c174540a0e
Adds attachments upload on wiki edit form ( #1223 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3500 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-28 09:43:13 +00:00
Eric Davis
ddec53b9a2
Refactor: Extracted saving logic out of #update and into a utility method
...
Now #issue_update can be refactored and push to the Model(s) while keeping
the public interface (#update) clean.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3497 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 16:16:18 +00:00
Jean-Philippe Lang
bfed36ac84
Let administrators see locked user profiles.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3493 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 15:50:16 +00:00
Eric Davis
3de1f2e157
Refactor: Extracted the duplication from the last commit into a new method
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 17:01:10 +00:00
Eric Davis
c68d853bf4
Refactor: Move the updating of an Issue to the #update method.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3486 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 17:01:05 +00:00
Eric Davis
d581510af6
Refactor: Start to extract IssuesController#edit into #update (REST).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3480 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-24 17:21:41 +00:00
Jean-Philippe Lang
e24d6cc223
Bulk edit refactoring.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3478 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 21:26:29 +00:00
Eric Davis
f838904a7e
Refactor: Extract Issue#bulk_edit from the IssuesController
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3475 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 17:06:08 +00:00
Jean-Philippe Lang
08d7c5bfb4
Adds a controller hook before issue move ( #4850 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3457 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-19 19:10:50 +00:00
Jean-Philippe Lang
74e85953f0
Move SQL LIKE tokens to acts_as_searchable.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3445 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-17 20:20:51 +00:00
Jean-Philippe Lang
c11d30ebc9
Makes search providers extensible ( #3936 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3444 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-17 20:05:51 +00:00
Eric Davis
9e22faa640
Converted the REDMINE_SUPPORTED_SCM constant to a class
...
Now SCMs can be added or removed using a simple API, instead of being
hardcoded:
Redmine::Scm::Base.add('ScmName')
Redmine::Scm::Base.delete('ScmName')
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3440 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-16 22:41:59 +00:00
Eric Davis
49bfee0535
Refactor: Merged TrackersController#list and #index
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3437 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-15 16:41:27 +00:00
Eric Davis
c5f30fde28
Refactor: Merged AuthSourcesController#list and #index
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3436 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-15 16:41:21 +00:00
Eric Davis
038a88e970
Refactor: Merged RolesController#list and #index
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3435 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-15 16:41:16 +00:00
Eric Davis
8d086cb7d4
Removed hard coded English string.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3416 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-12 19:15:39 +00:00
Eric Davis
c18f8d34fb
Refactor: Merged IssueStatusesController#list and #index.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3415 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-12 19:15:33 +00:00
Jean-Philippe Lang
55a3ac764f
Issue relation: fixes error with postgres when entering a non-numeric id ( #4820 ) + accept hash (#) before id.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3413 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-12 18:35:31 +00:00
Eric Davis
d2baf5f2a7
Log failed user logins to the Rails logger
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3411 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-11 18:25:38 +00:00
Eric Davis
937d0c70f7
Refactored IssueStatus finder to a before_filter
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3410 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-11 16:42:52 +00:00
Jean-Philippe Lang
1fec53cc25
Fixed: roadmap show subprojects issues even if subprojects is unchecked ( #4761 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3408 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-10 21:29:31 +00:00
Eric Davis
a8a49a26a1
Refactor: inline the utility methods in ReportsController.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3404 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-10 16:59:58 +00:00
Eric Davis
f50feca730
Extracted the rendering from each case statement in issue_reports_details
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3401 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-09 16:47:27 +00:00
Eric Davis
597725d77c
Separated ReportsController#issue_report into two separate actions.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3396 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-08 17:53:58 +00:00
Jean-Philippe Lang
eac7fcff6e
Fixed: error raised when trying to view the gantt or calendar with a grouped query ( #4751 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3379 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-06 18:07:25 +00:00
Jean-Philippe Lang
8fb29d4d21
Adds pagination to forum messages ( #4664 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3373 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-06 12:54:13 +00:00
Jean-Philippe Lang
6c8b87fbc8
Adds a permission for exporting wiki pages.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3371 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-06 09:30:53 +00:00
Eric Davis
e5d300af0a
Refactor: Pull up several #find_project methods to ApplicationController
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3370 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-05 16:57:02 +00:00
Jean-Philippe Lang
626b71622d
Fixed: invalid format parameter returns a DoubleRenderError on issues index ( #4737 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3368 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-04 19:58:42 +00:00
Jean-Philippe Lang
ea51dcf911
Reverts r3366.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3367 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-04 19:57:45 +00:00
Jean-Philippe Lang
cfe4d0e7db
Fixed: invalid format parameter returns a DoubleRenderError on issues index ( #4737 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3366 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-04 19:52:51 +00:00
Eric Davis
b86b9b898e
Refactor: Moved the raw SQL finders from ReportsController to Issue.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3362 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-03 16:49:21 +00:00
Jean-Philippe Lang
d43c860448
Allow commits to reference issues of parent projects and subprojects ( #4674 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3357 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-31 16:25:06 +00:00
Jean-Philippe Lang
1bc00ac022
Accept filters from API calls without set_filter parameter.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3335 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-18 19:53:06 +00:00
Jean-Philippe Lang
320c191f04
Fixed: PDF export of a issue list grouped by a custom field raises an error ( #4600 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3333 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-18 18:00:27 +00:00
Jean-Philippe Lang
0ef9bc039d
Adds a log message when an API call raises an InvalidAuthenticityToken error.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3332 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-17 20:23:06 +00:00
Jean-Philippe Lang
f8b52b13a0
Fixed: Issue Summary tables that list by user are not sorted ( #4552 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3323 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-17 11:07:53 +00:00
Eric Davis
1827d609a1
Cleaned up the IssueController redirects to use the back_url like the other actions.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3315 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-14 23:24:55 +00:00