Eric Davis
be20d98040
Refactor: Extract methods to before_filters
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3536 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 05:33:45 +00:00
Eric Davis
3a99f18913
Refactor: Split method
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3535 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 05:33:40 +00:00
Eric Davis
ca6df3d78d
Refactor: Extract method
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3534 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 05:33:35 +00:00
Eric Davis
976cba0c5d
Refactor: use the existing Issue#new_statuses_allowed_to method.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3533 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 00:58:52 +00:00
Jean-Philippe Lang
cdb86d5ef7
Fixed: no email notification on new project/version file added ( #4966 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3532 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 21:32:41 +00:00
Jean-Philippe Lang
6817a45e7f
Adds hooks on login view ( #4978 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3530 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 20:21:05 +00:00
Jean-Philippe Lang
f2b227547e
Filters collapsed by default for saved queries ( #4623 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3529 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 20:09:39 +00:00
Eric Davis
fe1e3ccd18
Refactor: Decouple failed attachments and the flash messages
...
Attachment#attach_files will no longer need to return a flash message,
instead it will put unsaved attachments into object#unsaved_attachments
where the calling object can access them.
A utility method #render_attachment_warning_if_needed is included for setting
the standard flash warning.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3528 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 17:05:00 +00:00
Eric Davis
f6d8752e44
Fixes destroying attachments if the update fails. (r2875 r3523)
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3526 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 17:04:50 +00:00
Eric Davis
3c0c0a7677
Allow multiple selected projects in #project_tree_options_for_select
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3525 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 03:37:40 +00:00
Jean-Philippe Lang
b09a483aa9
Fixed: error while deleting an in-use enumeration ( #4970 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3524 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-02 20:03:09 +00:00
Eric Davis
0fd7e2d696
Refactor: Moved ApplicationController#attach_files to the Attachment model
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3523 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-02 19:26:03 +00:00
Jean-Philippe Lang
b52e75aad9
Fixes some context menu links broken by r3478.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3521 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-01 20:54:55 +00:00
Eric Davis
f5f5a5f64f
Verify issues are updated by HTTP PUT only. Regression from r3486.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3520 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-01 18:29:18 +00:00
Eric Davis
8699e5bbcd
Refactor: Decouple building Issue and TimeEntry objects in #issue_update.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3519 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-01 17:40:54 +00:00
Jean-Philippe Lang
c9197769fb
Fixes bottom links placement in issue with associated changesets ( #4883 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3516 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-28 16:42:31 +00:00
Jean-Philippe Lang
d6c299f57d
Adds 'Blocked by' ( #1755 ) and 'Duplicated by' relation types to the dropdown menu for new relations.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3512 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-28 11:28:32 +00:00
Jean-Philippe Lang
241f79ac06
Fixed: attachments with the same name at the same time overwrite ( #3691 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3511 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-28 11:12:40 +00:00
Jean-Philippe Lang
82310d3162
Allow project custom fields to be searchable ( #4945 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3510 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-28 10:55:24 +00:00
Jean-Philippe Lang
c174540a0e
Adds attachments upload on wiki edit form ( #1223 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3500 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-28 09:43:13 +00:00
Jean-Philippe Lang
02cc0efdd7
Fixed: journal details duplicated when an issue is saved twice ( #3690 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3499 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-28 09:21:12 +00:00
Jean-Philippe Lang
26e9a0d919
Fixed: Wrong link when "http" not included in project "Homepage" link ( #4944 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3498 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-28 09:10:33 +00:00
Eric Davis
ddec53b9a2
Refactor: Extracted saving logic out of #update and into a utility method
...
Now #issue_update can be refactored and push to the Model(s) while keeping
the public interface (#update) clean.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3497 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 16:16:18 +00:00
Jean-Philippe Lang
113049412b
Link to the user from the wiki history view.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3496 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 16:03:05 +00:00
Jean-Philippe Lang
bda2aa474c
Adds a link to the user profile from the administration user edit screen ( #4480 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3495 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 16:01:04 +00:00
Jean-Philippe Lang
bfed36ac84
Let administrators see locked user profiles.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3493 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 15:50:16 +00:00
Jean-Philippe Lang
d6f9e576e8
Makes AuthSource.authenticate return a hash instead of an array.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3492 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 09:13:12 +00:00
Jean-Philippe Lang
aa521c5a5a
User model should not have to clean up LDAP attributes.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 08:29:20 +00:00
Eric Davis
3de1f2e157
Refactor: Extracted the duplication from the last commit into a new method
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 17:01:10 +00:00
Eric Davis
c68d853bf4
Refactor: Move the updating of an Issue to the #update method.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3486 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 17:01:05 +00:00
Eric Davis
19d4ddf2f2
Fix LDAP on the fly creation. The User object doesn't have a :dn attribute.
...
Fixes #4918 and adds a test for the behavior.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3485 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 16:19:55 +00:00
Eric Davis
39c97279ca
Optimize: Only select the name when getting the module names.
...
This has speed up TimelogController#details by 100% with larger databases
(demo.redmine went from 4077ms down to 2085ms).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3484 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 04:55:33 +00:00
Jean-Philippe Lang
f7bd0801f6
Fixed: changing user/roles of project member not possible without javascript ( #4852 )
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3483 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-24 21:23:20 +00:00
Jean-Philippe Lang
46ecc488a9
Fixed: projects are referenced by id in search results.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-24 21:08:08 +00:00
Jean-Philippe Lang
b2dee55e72
Makes project identifiers searchable ( #4897 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3481 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-24 21:05:14 +00:00
Eric Davis
d581510af6
Refactor: Start to extract IssuesController#edit into #update (REST).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3480 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-24 17:21:41 +00:00
Jean-Philippe Lang
6ed9734cb9
Reduces spacing on the bulk edit form.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3479 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 21:44:28 +00:00
Jean-Philippe Lang
e24d6cc223
Bulk edit refactoring.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3478 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 21:26:29 +00:00
Jean-Philippe Lang
01dbba72ab
Move hardcoded calendar images to css classes.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3477 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 21:10:15 +00:00
Jean-Philippe Lang
a2537b3969
Fixed view_issues_move_bottom hook arguments ( #4893 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3476 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 21:04:12 +00:00
Eric Davis
f838904a7e
Refactor: Extract Issue#bulk_edit from the IssuesController
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3475 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 17:06:08 +00:00
Jean-Philippe Lang
0341ac80eb
Avoid unnecessary SQL queries when loading changesets.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3473 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-21 14:43:45 +00:00
Jean-Philippe Lang
3d393a5711
Memorize commit authors to speed up changesets loading.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3472 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-21 14:42:45 +00:00
Jean-Philippe Lang
46aa855572
Remove invalid utf8 sequences from commit comments and author name ( #4773 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3466 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-20 11:24:41 +00:00
Jean-Philippe Lang
dab0c07fba
Fixed: Links in Forum mails should redirect to message, not topic ( #4884 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3458 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-20 10:07:53 +00:00
Jean-Philippe Lang
08d7c5bfb4
Adds a controller hook before issue move ( #4850 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3457 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-19 19:10:50 +00:00
Jean-Philippe Lang
77459f9ae4
Adds a hook on issue move form ( #4850 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3456 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-19 19:10:21 +00:00
Eric Davis
c6b2f1d606
Refactor: Extract #get_user_dn from AuthSourceLdap.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3454 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-19 17:00:49 +00:00
Eric Davis
d828122009
Refactor: extract AuthSourceLdap#search_attributes
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3453 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-19 16:33:01 +00:00
Jean-Philippe Lang
026fbb99a6
Escaping in html email templates ( #4874 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3452 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-18 19:13:38 +00:00
Jean-Philippe Lang
d18fba4ffe
Fixed: Pound (#) followed by number with leading zero (0) removes leading zero when rendered in wiki ( #4872 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3451 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-18 18:53:30 +00:00
Eric Davis
6f930e9be6
Refactor: Rewrite authenticate_dn to use an implicit return.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3450 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-18 16:55:10 +00:00
Eric Davis
82dd1b2bf2
Refactor: Moved the check for an empty DN to authenticate_dn
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3449 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-18 16:55:05 +00:00
Jean-Philippe Lang
74e85953f0
Move SQL LIKE tokens to acts_as_searchable.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3445 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-17 20:20:51 +00:00
Jean-Philippe Lang
c11d30ebc9
Makes search providers extensible ( #3936 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3444 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-17 20:05:51 +00:00
Eric Davis
4f268c5606
Refactor: extract an #authenticate_dn method in AuthSourceLdap
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3441 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-17 16:35:35 +00:00
Eric Davis
9e22faa640
Converted the REDMINE_SUPPORTED_SCM constant to a class
...
Now SCMs can be added or removed using a simple API, instead of being
hardcoded:
Redmine::Scm::Base.add('ScmName')
Redmine::Scm::Base.delete('ScmName')
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3440 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-16 22:41:59 +00:00
Eric Davis
b3330d3995
Refactor: Extract method from AuthSourceLdap#authenticate
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3439 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-16 17:03:54 +00:00
Eric Davis
49bfee0535
Refactor: Merged TrackersController#list and #index
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3437 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-15 16:41:27 +00:00
Eric Davis
c5f30fde28
Refactor: Merged AuthSourcesController#list and #index
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3436 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-15 16:41:21 +00:00
Eric Davis
038a88e970
Refactor: Merged RolesController#list and #index
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3435 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-15 16:41:16 +00:00
Jean-Philippe Lang
d16c2d4cd3
Adds a few divs to the base layout ( #871 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3429 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-14 13:07:51 +00:00
Jean-Philippe Lang
2f8cf7f762
Removes duplicated LOC.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3428 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-14 12:45:48 +00:00
Jean-Philippe Lang
a811f67748
Fixed: SystemStackError (stack level too deep) on Issue#attributes= after model reload ( #4838 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3427 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-14 12:43:48 +00:00
Jean-Philippe Lang
0ee17b132c
Slight forum styles changes.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3426 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-14 11:52:12 +00:00
Jean-Philippe Lang
00cec500c6
Do not include news author in emphasis tag.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3425 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-14 11:49:29 +00:00
Jean-Philippe Lang
3168ee3d47
Adds projects links ( #4812 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3422 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-13 10:32:06 +00:00
Eric Davis
4a67c211ca
Fixed a nil method error in Setting#value=
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3417 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-12 22:08:02 +00:00
Eric Davis
8d086cb7d4
Removed hard coded English string.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3416 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-12 19:15:39 +00:00
Eric Davis
c18f8d34fb
Refactor: Merged IssueStatusesController#list and #index.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3415 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-12 19:15:33 +00:00
Jean-Philippe Lang
55a3ac764f
Issue relation: fixes error with postgres when entering a non-numeric id ( #4820 ) + accept hash (#) before id.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3413 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-12 18:35:31 +00:00
Jean-Philippe Lang
541d830d2a
Fixed: Project copy loses wiki pages hierarchy ( #4797 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3412 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-11 19:30:53 +00:00
Eric Davis
d2baf5f2a7
Log failed user logins to the Rails logger
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3411 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-11 18:25:38 +00:00
Eric Davis
937d0c70f7
Refactored IssueStatus finder to a before_filter
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3410 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-11 16:42:52 +00:00
Jean-Philippe Lang
2c8a24092b
Adds filter for system shared versions on the cross project issue list ( #4792 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3409 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-10 21:42:32 +00:00
Jean-Philippe Lang
1fec53cc25
Fixed: roadmap show subprojects issues even if subprojects is unchecked ( #4761 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3408 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-10 21:29:31 +00:00
Jean-Philippe Lang
00d7bc3766
Makes use of format_version_name.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3407 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-10 21:21:53 +00:00
Jean-Philippe Lang
0b17e735ea
Fixed: Duplicated project name for subproject version on gantt chart ( #4775 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3406 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-10 21:13:34 +00:00
Jean-Philippe Lang
d02ddefff4
Fixed: parent project field doesn't include blank value when a member with 'add subproject' permission edits a child project ( #4790 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3405 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-10 20:38:23 +00:00
Eric Davis
a8a49a26a1
Refactor: inline the utility methods in ReportsController.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3404 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-10 16:59:58 +00:00
Jean-Philippe Lang
d04d3f181a
Fixed: Repository.fetch_changesets tries to fetch changesets for archived projects ( #4782 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3402 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-09 18:42:42 +00:00
Eric Davis
f50feca730
Extracted the rendering from each case statement in issue_reports_details
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3401 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-09 16:47:27 +00:00
Eric Davis
57a4cefd97
Fixed the link to the Issue Details report, broken in r3396
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3400 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-09 16:47:22 +00:00
Eric Davis
597725d77c
Separated ReportsController#issue_report into two separate actions.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3396 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-08 17:53:58 +00:00
Jean-Philippe Lang
3c20a9b0ac
Do not parse the entire git log to fetch new commits (takes several minutes for a few thousands commits), but only 1 week before the last known commit ( #4547 , #4716 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3394 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-07 15:17:21 +00:00
Jean-Philippe Lang
eac7fcff6e
Fixed: error raised when trying to view the gantt or calendar with a grouped query ( #4751 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3379 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-06 18:07:25 +00:00
Jean-Philippe Lang
88339fd98b
Do not show 'Quote' links on locked topics ( #4749 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3377 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-06 14:15:52 +00:00
Jean-Philippe Lang
5a5d02dfb5
Removes overflow:auto on #content which broke the fix in r2118 ( #4724 ).
...
Autoscroll divs are added around large tables.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3376 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-06 14:05:13 +00:00
Jean-Philippe Lang
695bffe684
Fixed: error messages displayed twice when creating a group ( #4715 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3375 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-06 13:26:29 +00:00
Jean-Philippe Lang
8fb29d4d21
Adds pagination to forum messages ( #4664 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3373 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-06 12:54:13 +00:00
Jean-Philippe Lang
2ad8242ae7
Adds a setting to cache textile rendering (off by default).
...
* it uses ActionController cache store which is MemoryStore by default and can be configured with config.action_controller.cache_store
* macro processing was moved out of textile rendering so that it doesn't get cached
* no noticeable improvement is expected for small portions of text, so only texts larger than 2KB are cached
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3372 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-06 10:40:21 +00:00
Jean-Philippe Lang
6c8b87fbc8
Adds a permission for exporting wiki pages.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3371 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-06 09:30:53 +00:00
Eric Davis
e5d300af0a
Refactor: Pull up several #find_project methods to ApplicationController
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3370 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-05 16:57:02 +00:00
Jean-Philippe Lang
626b71622d
Fixed: invalid format parameter returns a DoubleRenderError on issues index ( #4737 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3368 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-04 19:58:42 +00:00
Jean-Philippe Lang
ea51dcf911
Reverts r3366.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3367 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-04 19:57:45 +00:00
Jean-Philippe Lang
cfe4d0e7db
Fixed: invalid format parameter returns a DoubleRenderError on issues index ( #4737 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3366 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-04 19:52:51 +00:00
Eric Davis
5bd912e9a2
Refactor: Extracted the select_all calls to a new private method.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3365 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-04 17:24:33 +00:00
Eric Davis
155083ec97
Change Role#anonymous and #non_member so they generate the record as needed.
...
While creating tests, it was a common occurrence to lost the builtin roles
because they are only created in the migrations. This makes them behave like
User#anonymous.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3363 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-03 17:47:47 +00:00
Eric Davis
b86b9b898e
Refactor: Moved the raw SQL finders from ReportsController to Issue.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3362 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-03 16:49:21 +00:00
Eric Davis
39c585740d
Refactor: Extract method to create a Change from a Changeset.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3360 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-02 17:02:32 +00:00
Eric Davis
358e3194d7
Refactor: Move recipients method into acts_as_event
...
acts_as_event should be the standard interface to Redmine events, like mail
notifications, so having a standard recipients implementation there makes sense.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3358 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-01 18:57:12 +00:00
Jean-Philippe Lang
d43c860448
Allow commits to reference issues of parent projects and subprojects ( #4674 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3357 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-31 16:25:06 +00:00
Jean-Philippe Lang
df46d704e8
Log email delivery errors.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3356 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-31 11:41:58 +00:00
Jean-Philippe Lang
a0364deb6a
Log info when sending an email notification.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3355 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-31 11:00:40 +00:00
Jean-Philippe Lang
a1a24483b5
Fixed: deleting a project with subprojects breaks the project tree ( #4701 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3354 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-31 10:39:42 +00:00
Jean-Philippe Lang
7ef20cc169
Fixed: potential security leak on my page calendar ( #4691 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3351 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-30 11:23:17 +00:00
Jean-Philippe Lang
12ea682b66
Fixed: NOT NULL constraint error when adding a group ( #4632 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3343 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-30 10:24:23 +00:00
Eric Davis
675f28f895
Use the minimum password length setting when reseting a password. ( #4683 )
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3341 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-28 18:54:51 +00:00
Azamat Hackimov
d1c90d9abf
New strings to translate ( #4647 ):
...
* label_board_sticky: Sticky
* label_board_locked: Locked
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3339 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-25 17:26:02 +00:00
Eric Davis
d4525828b9
Fixed some labels to be more accessible.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3336 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-21 18:21:56 +00:00
Jean-Philippe Lang
1bc00ac022
Accept filters from API calls without set_filter parameter.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3335 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-18 19:53:06 +00:00
Jean-Philippe Lang
320c191f04
Fixed: PDF export of a issue list grouped by a custom field raises an error ( #4600 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3333 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-18 18:00:27 +00:00
Jean-Philippe Lang
0ef9bc039d
Adds a log message when an API call raises an InvalidAuthenticityToken error.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3332 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-17 20:23:06 +00:00
Jean-Philippe Lang
002f440bcd
Move ids in XML views.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3331 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-17 19:45:18 +00:00
Jean-Philippe Lang
f8b52b13a0
Fixed: Issue Summary tables that list by user are not sorted ( #4552 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3323 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-17 11:07:53 +00:00
Eric Davis
1827d609a1
Cleaned up the IssueController redirects to use the back_url like the other actions.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3315 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-14 23:24:55 +00:00
Jean-Philippe Lang
68a4cd38f5
XML REST API for Projects ( #296 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3313 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-14 20:00:17 +00:00
Jean-Philippe Lang
da55be4e9a
Fixed: error when exporting an issue with target version to PDF ( #4556 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3311 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-13 20:17:56 +00:00
Jean-Philippe Lang
3873388f9b
XML REST API for issues that provides CRUD operations for Issues ( #1214 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3310 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-13 19:29:19 +00:00
Eric Davis
667a7256a7
Escape the parent id parameter.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3309 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-13 17:27:37 +00:00
Jean-Philippe Lang
0a05cc2a37
Set a white list of issue attributes that can be mass-assigned from controllers.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3308 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-12 20:17:20 +00:00
Jean-Philippe Lang
ff77fb6aa9
Fixed: email notifications may affect language of notices on the UI ( #4086 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3307 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-10 14:54:02 +00:00
Jean-Philippe Lang
fe7d65922b
Fixed: can not search for 2 letters word ( #4381 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3306 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-10 14:15:12 +00:00
Jean-Philippe Lang
d7c9886b8c
Fixed: attachments get saved on issue update even if validation fails ( #4401 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3305 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-10 14:05:42 +00:00
Jean-Philippe Lang
23508f4f98
Copyright updated ( #4542 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3299 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-09 15:01:39 +00:00
Jean-Philippe Lang
f6ac12ad9d
Fixed: undefined method `stringify_keys!' error in Issue#attributes_with_tracker_first= with ruby1.9 ( #4540 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3289 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-09 10:27:05 +00:00
Jean-Philippe Lang
99956ec248
Avatars added in news ( #3941 ) and forums ( #4468 ) + cleanup.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3284 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-07 21:28:45 +00:00
Jean-Philippe Lang
518779d96d
Fixed: issue summary counts should link to the issue list without subprojects ( #4525 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3283 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-07 21:12:16 +00:00
Jean-Philippe Lang
eecc6864a9
Fixed: 'Delete' link on LDAP list has no effect ( #4530 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3282 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-07 20:56:41 +00:00
Jean-Philippe Lang
eb3b7d055a
Fixed: error when downloading a file with no matching mime type ( #3782 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3281 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-05 18:16:03 +00:00
Jean-Philippe Lang
f05b778065
Bulk edit view cleanup.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3279 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-03 11:37:04 +00:00
Jean-Philippe Lang
cab99aa5ad
Allow bulk edit custom fields of any type ( #461 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3278 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-03 11:18:09 +00:00
Jean-Philippe Lang
e9810b5de6
Fixed: bulk edit doesn't include global custom fields ( #4505 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3277 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-03 10:50:40 +00:00
Azamat Hackimov
f69a4107f8
Fixed untranslated string (:label_close_versions => Close completed versions)
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3273 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-01 16:49:43 +00:00
Eric Davis
4b3d4553e4
Create and assign the api token so the current instance can access it. ( #4497 )
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3265 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-30 00:25:53 +00:00
Eric Davis
c67cc7c285
Added :controller_issues_new_before_save hook. ( #4465 )
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3263 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-29 23:31:24 +00:00
Jean-Philippe Lang
ff7eb7b23a
Auto-detect attachment content type when blank ( #3782 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3258 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-29 13:28:30 +00:00
Eric Davis
b7b4e27833
Added :view_settings_general_form plugin hook
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3256 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-29 00:43:06 +00:00
Jean-Philippe Lang
b718d5dec2
Moves attachments parsing after textile parsing so that:
...
* attachments parsing does not rely on textile syntax
* textile output can be cached (#4482 )
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3253 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-27 10:52:02 +00:00
Jean-Philippe Lang
04455783a7
Fixed: project copy doesn't copy group memberships ( #3975 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3250 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-26 16:14:55 +00:00
Jean-Philippe Lang
c36c924714
Ask for confirmation when a non-admin users tries to remove himself from a project ( #4402 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3249 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-26 15:46:12 +00:00
Jean-Philippe Lang
a4c64ff84b
Fixed: subject of incoming emails gets mangled ( #3717 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3247 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-26 12:15:12 +00:00
Jean-Philippe Lang
9c1efcfa48
Do not display the copy form when project copy is created.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3242 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-26 10:18:28 +00:00
Jean-Philippe Lang
45f3199aa9
View cleanup.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3241 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-25 17:39:06 +00:00
Jean-Philippe Lang
8db9ecef08
Removes column opt in enumerations table.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3240 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-25 17:13:58 +00:00
Eric Davis
9fb40b1a2f
Project#activities should check all overridden activities, not just active ones.
...
Fixes #4084
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3239 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-24 18:25:49 +00:00
Jean-Philippe Lang
62c83bdd2e
Adds a 'Add subprojects' permission.
...
* 'Add project' permission will let user create a root project
* 'Add subprojects' permission will let project members create subprojects
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-24 16:18:15 +00:00
Jean-Philippe Lang
24fde6f109
Hide "Groups" tab on user form if no group exist.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3237 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-24 16:14:15 +00:00
Jean-Philippe Lang
d63784569f
Force TimeEntry#hours default to nil ( #3075 , #4449 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3232 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-23 20:05:46 +00:00
Jean-Philippe Lang
5e1dc78d75
Fixed: wiki pages in search results are referenced by project number, not by project identifier ( #4456 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3231 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-23 20:01:28 +00:00