Commit Graph

1305 Commits

Author SHA1 Message Date
Eric Davis 4baf32b166 Fixing Plugin and Mailer default_url_options.
Both the plugin hooks and Mailer were setting default_url_options incorrectly
and causing ActionContoller::UrlWritter to cache the settings on the module
(mattr_accessor) causing several url generators to fail in either the plugin
hooks or the Mailer.

* Replaced Mailer's use of the default_url_options accessor with the proper class method
* Replaced Hook's use of the default_url_options accessor with the proper class method on the ViewListener class
* Added a test to reproduce the bugs in the Mailer when a hook is registered (thanks Chaoqun Zou)

  #2542

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2522 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-25 07:25:01 +00:00
Jean-Philippe Lang 0f68334f0b Fixed that MailHandler#plain_text_body was returning nil if there was nothing to strip (#2814).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2520 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-23 17:35:16 +00:00
Jean-Philippe Lang 0101e609f7 Sort changesets in the same order as comments on the issue details view (#1546).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2519 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-22 15:16:18 +00:00
Jean-Philippe Lang 7342a00e0a Slight changes to the files list (#2658, #2806).
* Adds a link to the version
* Moves styles to the stylesheet
* Indent the files

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2515 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-22 11:04:17 +00:00
Jean-Philippe Lang 84de5fa3b0 Makes the default issue list columns selection look like other multi-checkbox fieldsets.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2507 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-21 16:15:44 +00:00
Jean-Philippe Lang 1c5a2ddfb0 Limit the size of repository files displayed inline too.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2505 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-21 16:04:51 +00:00
Jean-Philippe Lang 79c074dbe5 Fixes new setting name.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2504 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-21 15:44:00 +00:00
Jean-Philippe Lang 66afc8c054 Adds a setting to limit the size of text attachments that can be displayed by the file viewer (default set to 512KB). Larger files are sent for download.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2503 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-21 15:34:11 +00:00
Jean-Philippe Lang 79fd564b61 Do not show the changed files list on the revision page if the user is not allowed to browse the repository (#2762).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2499 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-21 12:58:18 +00:00
Jean-Philippe Lang 6b770fa70c Deprecated truncate call.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2495 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-21 11:10:34 +00:00
Jean-Philippe Lang fe28193e4e Merged Rails 2.2 branch. Redmine now requires Rails 2.2.2.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2493 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-21 11:04:50 +00:00
Eric Davis 3fa9535670 List the Default Columns displayed on the issue list vertically
instead of horizontally so it's easier to read.

  #2745

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-20 22:59:59 +00:00
Eric Davis befe278fa9 Allow the other format links to appear on the issue list (ATOM, PDF, CSV).
#2779

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-20 22:45:16 +00:00
Jean-Philippe Lang b9e95e7a70 Fixes "too few arguments" error on activerecord error translation (#2626).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2486 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-20 18:55:56 +00:00
Jean-Philippe Lang 33e7ae96ad Adds (a maximum of 3) links to project ancestors in the page title (#2788).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2485 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-20 18:34:57 +00:00
Jean-Philippe Lang 04c428e059 Send an email to the user when an administrator activates a registered user (#2656).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2484 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-20 17:04:47 +00:00
Eric Davis 24ee6b9a1b Fixed the bug in the OpenID registration where the form wouldn't take a login
AccountController#open_id_authenticate was adding an auth_source_registration
to the session which caused AccountController#register to use the wrong codepath.

  #2757

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2483 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-20 00:31:50 +00:00
Eric Davis aed1787d51 Fixed a bug in the OpenID login when a user signed up with OpenID but hasn't
been activated yet.

When logging in the user would come back to the login page with the back_url
of My Page.  This was caused by open_id_authenticate sending the user to My Page
and My Page redirecting the user back to the login page because they haven't
been activated.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-20 00:16:45 +00:00
Jean-Philippe Lang 9525e5f147 Fixes Setting.openid? (#2764).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2481 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-19 21:03:08 +00:00
Jean-Philippe Lang d643d9a94c Fixed: User#identity_url raises an error when invalid url is supplied (#2742).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2476 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-15 18:46:50 +00:00
Jean-Philippe Lang 3183445aea Makes the "type" field disabled when updating a custom field (#2744).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2475 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-15 16:55:48 +00:00
Jean-Philippe Lang 9e4a118528 Create a wiki with a default start page named 'Wiki' when enabling wiki module (#2657).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2474 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-15 16:43:06 +00:00
Jean-Philippe Lang b05ed594a0 Do not DELETE/INSERT enabled_modules when updating project modules.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2473 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-15 16:26:48 +00:00
Jean-Philippe Lang 4601ed2f3a Replaces Enumeration.get_values and Enumeration.default with named scopes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2472 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-15 13:33:09 +00:00
Jean-Philippe Lang d77be4e908 Removes invalid css class on issue details (#2753).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2467 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-15 08:33:48 +00:00
Jean-Philippe Lang 1c2cdedf19 Fixes headings style in html emails (#2739).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2465 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-14 18:32:11 +00:00
Jean-Philippe Lang f9c9b054ba Timelog is ignored when updating an issue if user is admin but not a project member (#2717).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2463 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-13 17:59:45 +00:00
Jean-Philippe Lang bbc8d3d768 Removes invalid css class on issue details (#2733).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2461 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-13 17:29:49 +00:00
Jean-Philippe Lang b8eddf2014 Adds watch/unwatch link on the issue context menu (#2730).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2460 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-12 22:14:22 +00:00
Jean-Philippe Lang 9586269a06 Issues pagination loses project param after applying or clearing filter (#2726).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2459 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-12 22:01:20 +00:00
Jean-Philippe Lang ff9da0bab0 Removes the fat ruby-openid gem. Simply use 'gem install ruby-openid' to enable openid support.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2458 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-12 21:25:50 +00:00
Jean-Philippe Lang 5bdd429162 Link to watched issues list on my page.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2457 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-12 17:38:36 +00:00
Jean-Philippe Lang e1b828de95 Adds ability to filter watched issues (#846).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2456 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-12 17:35:57 +00:00
Jean-Philippe Lang 2807b9c927 Hide openid stuff on my account if disabled (#699).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2454 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-12 17:19:32 +00:00
Eric Davis 60dc357271 Normalize the identity_url when it's set.
OpenId uses a specific format for the url it uses which requires the protocol
and trailing slash.  This change will normalize the value to when a user sets it.

  #699

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2453 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-12 04:31:28 +00:00
Jean-Philippe Lang 4500b606ce Slight changes to the issue lists displayed on My page.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2451 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 20:25:05 +00:00
Eric Davis f1b8bf22a2 Added a space so words don't runtogeatherlikethis. #699
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2450 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:45:53 +00:00
Eric Davis 8d53e433c5 Added a system setting for allowing OpenID logins and registrations
* Defaults to off
* Is set in the Administration panel under Authentication

  #699

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2449 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:24:28 +00:00
Eric Davis 85ad791d81 Prevent registration via OpenID if self registration is off. #699
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2448 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:41 +00:00
Eric Davis 720f928cd2 Refactored common methods out of register and open_id_authenticate
* Extracted register_by_email_activation
* Extracted register_automatically
* Extracted register_manually_by_administrator

  #699

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2447 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:34 +00:00
Eric Davis 8194cfaf86 Added user setup needed based on the system's registration settings
* Copied the register action's chunk of code used to setup the account
  based on Setting.self_registration
* Extracted method for when onthefly_creation_failed
* Added tests to confirm the behavior

  #699

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2446 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:28 +00:00
Eric Davis 876fb69271 Added tests for the other OpenID authentication cases. #699
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2445 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:23 +00:00
Eric Davis 0310f43126 Hooked up on the fly OpenID user creation.
* Use OpenID registration fields for the user.
* Generate a random password when a user is created.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2443 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:12 +00:00
Eric Davis 896e64b759 Added the ability to login via OpenID.
* Refactored AccountController#login to use either
  password or openid based authentication
* Extracted AccountController#successful_authentication
  to setup a user's session cookies and redirect
* Implemented the start of AccountController#open_id_authentication
  which will check with the OpenID server and perform authentication.
* Added text field for the OpenID url to /login
* Added identity_url for OpenID to the user forms.
* Added option to login with OpenID to the register form.
* Added a root url route, which is used by the OpenID plugin

  #699

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2442 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:07 +00:00
Jean-Philippe Lang 70efee1bc5 Leave wiki links untouched if target project doesn't exist or have no wiki.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2436 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-10 22:54:22 +00:00
Jean-Philippe Lang 8cf3d7a492 Replaces the repositories management SOAP API with a simple REST API.
reposman usage is unchanged but the script now requires activeresource.
actionwebservice is now longer used and thus removed from plugins.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2435 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-10 22:03:25 +00:00
Jean-Philippe Lang cf5658d7fe Fixes broken action url on time edit form (#2707).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2434 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-10 17:18:19 +00:00
Eric Davis a3fa56d988 Added two new plugin hooks:
* :view_layouts_base_sidebar
* :view_layouts_base_content

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2428 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-10 01:24:32 +00:00
Eric Davis 0d01e07430 Added plugin hook :view_projects_roadmap_version_bottom. #2543
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2427 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-10 01:18:49 +00:00
Jean-Philippe Lang 2d3b3cee15 Strip keywords from received email body (#2436).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2426 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-09 20:17:58 +00:00