Commit Graph

212 Commits

Author SHA1 Message Date
Eric Davis aed1787d51 Fixed a bug in the OpenID login when a user signed up with OpenID but hasn't
been activated yet.

When logging in the user would come back to the login page with the back_url
of My Page.  This was caused by open_id_authenticate sending the user to My Page
and My Page redirecting the user back to the login page because they haven't
been activated.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-20 00:16:45 +00:00
Jean-Philippe Lang 9525e5f147 Fixes Setting.openid? (#2764).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2481 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-19 21:03:08 +00:00
Jean-Philippe Lang 4601ed2f3a Replaces Enumeration.get_values and Enumeration.default with named scopes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2472 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-15 13:33:09 +00:00
Jean-Philippe Lang ff9da0bab0 Removes the fat ruby-openid gem. Simply use 'gem install ruby-openid' to enable openid support.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2458 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-12 21:25:50 +00:00
Eric Davis 8d53e433c5 Added a system setting for allowing OpenID logins and registrations
* Defaults to off
* Is set in the Administration panel under Authentication

  #699

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2449 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:24:28 +00:00
Eric Davis 85ad791d81 Prevent registration via OpenID if self registration is off. #699
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2448 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:41 +00:00
Eric Davis 720f928cd2 Refactored common methods out of register and open_id_authenticate
* Extracted register_by_email_activation
* Extracted register_automatically
* Extracted register_manually_by_administrator

  #699

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2447 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:34 +00:00
Eric Davis 8194cfaf86 Added user setup needed based on the system's registration settings
* Copied the register action's chunk of code used to setup the account
  based on Setting.self_registration
* Extracted method for when onthefly_creation_failed
* Added tests to confirm the behavior

  #699

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2446 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:28 +00:00
Eric Davis 876fb69271 Added tests for the other OpenID authentication cases. #699
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2445 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:23 +00:00
Eric Davis 48e26aa75b Adding OpenID mock and test. #699
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2444 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:18 +00:00
Jean-Philippe Lang 8cf3d7a492 Replaces the repositories management SOAP API with a simple REST API.
reposman usage is unchanged but the script now requires activeresource.
actionwebservice is now longer used and thus removed from plugins.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2435 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-10 22:03:25 +00:00
Jean-Philippe Lang cf5658d7fe Fixes broken action url on time edit form (#2707).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2434 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-10 17:18:19 +00:00
Jean-Philippe Lang f021c856c1 Fixed: issue details view discloses relations to issues that the user is not allowed to view (#2589).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2343 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-31 13:22:29 +00:00
Jean-Philippe Lang 945ec8942a Adds projects association on tracker form (#2578).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2335 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-29 14:22:56 +00:00
Jean-Philippe Lang 10994e9027 Fixed: users should not be able to add relations with issues they're not allowed to view (#2589).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2323 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-27 19:33:03 +00:00
Jean-Philippe Lang e1f96ca4db Replaces the obsolete robots.txt with a cached action (#2491).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2319 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-27 17:27:50 +00:00
Eric Davis 765f7abc60 Converted routing and urls to follow the Rails REST convention.
Patch supplied by commits from Gerrit Kaiser on Github.  Existing routes will
still work (backwards compatible) but any new urls will be generated using the
new routing rules.

Changes listed below:

* made the URLs for some project tabs and project settings follow the new rails RESTful conventions of /collection/:id/subcollection/:sub_id
* prettier URL for project roadmap
* more nice project URLs
* use GET for filtering form
* prettified URLs used on issues tab
* custom route for activity atom feeds
* prettier repository urls
* fixed broken route definition
* fixed failing tests for issuecontroller that were hardcoding the url string
* more RESTful routes for boards and messages
* RESTful routes for wiki pages
* RESTful routes for documents
* moved old routes that are retained for compatibility to the bottom and grouped them together
* added RESTful URIs for issues
* RESTfulness for the news section
* fixed route order
* changed hardcoded URLs in tests
* fixed badly written tests
* fixed forgotten parameter in routes
* changed hardcoded URLS to new scheme
* changed project add url to the standard POST to collection
* create new issue by POSTing to collection
* changed hardcoded URLs in integrations tests
* made project add form work again
* restful routes for project deletion
* prettier routes for project (un)archival
* made routes table more readable
* fixed note quoting
* user routing
* fixed bug
* always sort by GET
* Fixed: cross-project issue list should not show issues of projects for which the issue tracking module was disabled.
* prettified URLs used on issues tab
* urls for time log
* fixed reply routing
* eliminate revision query paremeter for diff and entry actions
* fixed test failures with hard-coded urls
* ensure ajax links always use get
* refactored ajax link generation into separate method

  #1901


git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2317 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-26 01:47:51 +00:00
Jean-Philippe Lang bcc9007196 Ability to bulk edit custom fields of type 'list' (#461).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2316 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-25 16:04:28 +00:00
Jean-Philippe Lang 1ad2551559 Adds ability to bulk copy issues (#1847).
This can be done by checking the 'Copy' checkbox on the 'Move' form.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2313 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-25 13:12:56 +00:00
Jean-Philippe Lang c9906480d3 Merged nested projects branch. Removes limit on subproject nesting (#594).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2304 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-24 11:31:15 +00:00
Jean-Philippe Lang 51b745470c Fixes a test that was broken by r2294.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2303 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-24 09:02:55 +00:00
Jean-Philippe Lang 12792d8068 User custom fields can now be set as editable so that users can edit them on 'My account'.
For existing user custom fields, this new attribute is set to false by default to preserve the prior behaviour (it can turned on by editing the custom field in admin area).

Note: on the registration form, *required* custom fields will be displayed even if they are not defined as editable so that the account can be created.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2276 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-17 11:18:04 +00:00
Jean-Philippe Lang ee1bb54ab6 CustomFieldsController#list moved to #index.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2274 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-17 08:46:23 +00:00
Jean-Philippe Lang 48295a6c4b CustomFieldsController refactoring.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2273 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-17 08:41:30 +00:00
Jean-Philippe Lang 5ed2e78ae2 Make use of tracker_ids association in issue custom field form.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2272 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-17 08:25:55 +00:00
Jean-Philippe Lang b4640a0904 Adds custom fields functional tests.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2268 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-16 21:02:56 +00:00
Jean-Philippe Lang ffa6c5fe3e Adds a 'Create and continue' button on the new issue form, that will create the issue and display the form again (#2523).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2265 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-16 17:20:41 +00:00
Jean-Philippe Lang 31b3ebf071 Fixes r2226: exporting an issue with attachments to PDF raises an error (#2492).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2262 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-12 17:45:23 +00:00
Jean-Philippe Lang 1ca69f2af1 Different icon for closed issues in search result (#992).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2256 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-11 11:01:35 +00:00
Jean-Philippe Lang 6768bec456 Fixed: no error is raised when entering invalid hours on the issue update form (#2465).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2251 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-09 17:32:46 +00:00
Jean-Philippe Lang 15996c348d Fixes a test failure with svn < 1.5 (#2455).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2249 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-07 20:22:06 +00:00
Jean-Philippe Lang a64928fa6b Fixes functional test broken by r2246.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2248 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-07 20:21:27 +00:00
Jean-Philippe Lang cd83f72da4 Slight changes in functional tests.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2235 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-04 18:14:51 +00:00
Jean-Philippe Lang ceb2320ef0 Move PDF stuff to a single helper.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2226 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-04 12:03:39 +00:00
Jean-Philippe Lang 2355324d73 Jump to the current tab when using the project quick-jump combo (#2364).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2210 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-30 14:24:51 +00:00
Jean-Philippe Lang bde72a5f40 Fixes functional tests fixtures (#2398).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2190 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-28 09:46:16 +00:00
Jean-Philippe Lang caf6b4b3f1 Fixes functional test failures.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2187 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-27 18:07:46 +00:00
Jean-Philippe Lang 5c97a83a70 Validates sort_key and sort_order params (#2378).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2171 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-24 10:03:13 +00:00
Jean-Philippe Lang 1f89dad23a Adds watchers selection on new issue form (#398). Permission 'add issue watchers' required.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2164 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-22 19:21:02 +00:00
Jean-Philippe Lang ede011243b Check that wiki page exists before processing (#2360).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2145 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-19 10:43:06 +00:00
Jean-Philippe Lang 7cea286c23 Fixes repository user mapping submission when a repository username is blank (#2339, Conflicting types for parameter containers).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2137 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-15 18:02:25 +00:00
Jean-Philippe Lang b21b6c365c Fixed: default category ignored when adding a document (#2328).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2124 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-12 13:49:14 +00:00
Jean-Philippe Lang 66ff4cb7de Files module: makes version field non required (#1053).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2117 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-09 18:00:27 +00:00
Jean-Philippe Lang 5d2899ee1b AttachmentsController now handles attachments deletion.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2116 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-09 16:54:46 +00:00
Jean-Philippe Lang 50794b08a9 Cross-project gantt and calendar (#1157).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2088 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-05 15:41:32 +00:00
Jean-Philippe Lang 6e777b7453 Makes activity view accept a user_id param to show user's activity (#1002).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2067 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-30 12:12:06 +00:00
Jean-Philippe Lang 546b98a118 Adds a css class on menu items in order to apply item specific styles (eg. icons).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2059 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-27 18:04:48 +00:00
Jean-Philippe Lang db37e578f2 Slight tests fixes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2055 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-25 17:37:41 +00:00
Jean-Philippe Lang 5362a85f2b Adds url and author_url plugin attributes (#2162).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2041 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-16 17:12:02 +00:00
Jean-Philippe Lang f9ce4ff559 Adds a few Plugin tests.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2040 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-16 16:08:25 +00:00