From f9ce4ff559a1f41dea6981c8cc37cd7e9f71e521 Mon Sep 17 00:00:00 2001
From: Jean-Philippe Lang <jp_lang@yahoo.fr>
Date: Sun, 16 Nov 2008 16:08:25 +0000
Subject: [PATCH] Adds a few Plugin tests.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2040 e93f8b46-1217-0410-a6f0-8f06a7374b81
---
 lib/redmine/plugin.rb                    |  9 +++++
 test/functional/admin_controller_test.rb | 24 ++++++++++-
 test/unit/lib/redmine/plugin_test.rb     | 51 ++++++++++++++++++++++++
 3 files changed, 83 insertions(+), 1 deletion(-)
 create mode 100644 test/unit/lib/redmine/plugin_test.rb

diff --git a/lib/redmine/plugin.rb b/lib/redmine/plugin.rb
index 80c638b2..ad8ed7bb 100644
--- a/lib/redmine/plugin.rb
+++ b/lib/redmine/plugin.rb
@@ -64,6 +64,8 @@ module Redmine #:nodoc:
     def self.register(id, &block)
       p = new(id)
       p.instance_eval(&block)
+      # Set a default name if it was not provided during registration
+      p.name(id.to_s.humanize) if p.name.nil?
       registered_plugins[id] = p
     end
     
@@ -73,10 +75,17 @@ module Redmine #:nodoc:
     end
     
     # Finds a plugin by its id
+    # Returns a PluginNotFound exception if the plugin doesn't exist
     def self.find(id)
       registered_plugins[id.to_sym] || raise(PluginNotFound)
     end
     
+    # Clears the registered plugins hash
+    # It doesn't unload installed plugins
+    def self.clear
+      @registered_plugins = {}
+    end
+    
     def initialize(id)
       @id = id.to_sym
     end
diff --git a/test/functional/admin_controller_test.rb b/test/functional/admin_controller_test.rb
index 9cb2d07f..2bbd8fe9 100644
--- a/test/functional/admin_controller_test.rb
+++ b/test/functional/admin_controller_test.rb
@@ -79,11 +79,33 @@ class AdminControllerTest < Test::Unit::TestCase
     assert_equal [user.mail], mail.bcc
   end
   
-  def test_plugins
+  def test_no_plugins
+    Redmine::Plugin.clear
+    
     get :plugins
     assert_response :success
     assert_template 'plugins'
   end
+  
+  def test_plugins
+    # Register a few plugins
+    Redmine::Plugin.register :foo do
+      name 'Foo plugin'
+      author 'John Smith'
+      description 'This is a test plugin'
+      version '0.0.1'
+      settings :default => {'sample_setting' => 'value', 'foo'=>'bar'}, :partial => 'foo/settings'
+    end
+    Redmine::Plugin.register :bar do
+    end
+  
+    get :plugins
+    assert_response :success
+    assert_template 'plugins'
+    
+    assert_tag :td, :content => 'Foo plugin'
+    assert_tag :td, :content => 'Bar'
+  end
 
   def test_info
     get :info
diff --git a/test/unit/lib/redmine/plugin_test.rb b/test/unit/lib/redmine/plugin_test.rb
new file mode 100644
index 00000000..432fe0bf
--- /dev/null
+++ b/test/unit/lib/redmine/plugin_test.rb
@@ -0,0 +1,51 @@
+# Redmine - project management software
+# Copyright (C) 2006-2008  Jean-Philippe Lang
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+# 
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+# 
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+
+require File.dirname(__FILE__) + '/../../../test_helper'
+
+class Redmine::PluginTest < Test::Unit::TestCase
+
+  def setup
+    @klass = Redmine::Plugin
+    # In case some real plugins are installed
+    @klass.clear
+  end
+  
+  def teardown
+    @klass.clear
+  end
+  
+  def test_register
+    @klass.register :foo do
+      name 'Foo plugin'
+      author 'John Smith'
+      description 'This is a test plugin'
+      version '0.0.1'
+      settings :default => {'sample_setting' => 'value', 'foo'=>'bar'}, :partial => 'foo/settings'
+    end
+    
+    assert_equal 1, @klass.all.size
+    
+    plugin = @klass.find('foo')
+    assert plugin.is_a?(Redmine::Plugin)
+    assert_equal :foo, plugin.id
+    assert_equal 'Foo plugin', plugin.name
+    assert_equal 'John Smith', plugin.author
+    assert_equal 'This is a test plugin', plugin.description
+    assert_equal '0.0.1', plugin.version
+  end
+end