From d2cc2861de766d1c0f1e38f9d1b48c16e46b2e1c Mon Sep 17 00:00:00 2001 From: Jean-Philippe Lang Date: Wed, 29 Dec 2010 19:55:52 +0000 Subject: [PATCH] Find visible issues only in ContextMenusController#issues. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4580 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/controllers/context_menus_controller.rb | 3 ++- test/functional/context_menus_controller_test.rb | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/app/controllers/context_menus_controller.rb b/app/controllers/context_menus_controller.rb index 3e143830..373938ab 100644 --- a/app/controllers/context_menus_controller.rb +++ b/app/controllers/context_menus_controller.rb @@ -2,7 +2,8 @@ class ContextMenusController < ApplicationController helper :watchers def issues - @issues = Issue.find_all_by_id(params[:ids], :include => :project) + @issues = Issue.visible.all(:conditions => {:id => params[:ids]}, :include => :project) + if (@issues.size == 1) @issue = @issues.first @allowed_statuses = @issue.new_statuses_allowed_to(User.current) diff --git a/test/functional/context_menus_controller_test.rb b/test/functional/context_menus_controller_test.rb index 9eacdbba..7f160881 100644 --- a/test/functional/context_menus_controller_test.rb +++ b/test/functional/context_menus_controller_test.rb @@ -102,4 +102,10 @@ class ContextMenusControllerTest < ActionController::TestCase :class => 'icon-del' } end + def test_context_menu_issue_visibility + get :issues, :ids => [1, 4] + assert_response :success + assert_template 'context_menu' + assert_equal [1], assigns(:issues).collect(&:id) + end end