From 7c4abeb8d31d1a5502707eee9bfaa8e0287db3ce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20Sch=C3=A4fer?= Date: Fri, 8 Jul 2011 21:39:36 +0200 Subject: [PATCH] Correct filters for int,float custom fields. #498 --- app/models/query.rb | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/app/models/query.rb b/app/models/query.rb index e2ffd95d..e73411d8 100644 --- a/app/models/query.rb +++ b/app/models/query.rb @@ -587,9 +587,17 @@ class Query < ActiveRecord::Base sql = "#{db_table}.#{db_field} IS NOT NULL" sql << " AND #{db_table}.#{db_field} <> ''" if is_custom_filter when ">=" - sql = "#{db_table}.#{db_field} >= #{value.first.to_i}" + if is_custom_filter + sql = "#{db_table}.#{db_field} != '' AND CAST(#{db_table}.#{db_field} AS decimal(60,4)) >= #{value.first.to_f}" + else + sql = "#{db_table}.#{db_field} >= #{value.first.to_f}" + end when "<=" - sql = "#{db_table}.#{db_field} <= #{value.first.to_i}" + if is_custom_filter + sql = "#{db_table}.#{db_field} != '' AND CAST(#{db_table}.#{db_field} AS decimal(60,4)) <= #{value.first.to_f}" + else + sql = "#{db_table}.#{db_field} <= #{value.first.to_f}" + end when "o" sql = "#{IssueStatus.table_name}.is_closed=#{connection.quoted_false}" if field == "status_id" when "c" @@ -629,6 +637,8 @@ class Query < ActiveRecord::Base custom_fields.select(&:is_filter?).each do |field| case field.field_format + when "int", "float" + options = { :type => :integer, :order => 20 } when "text" options = { :type => :text, :order => 20 } when "list"