diff --git a/app/controllers/watchers_controller.rb b/app/controllers/watchers_controller.rb index 11699c35..a7a9abfd 100644 --- a/app/controllers/watchers_controller.rb +++ b/app/controllers/watchers_controller.rb @@ -78,23 +78,43 @@ private @watched.set_watcher(user, watching) if params[:replace].present? if params[:replace].is_a? Array - replace_ids = params[:replace] + replace_selectors = params[:replace] else - replace_ids = [params[:replace]] + replace_selectors = params[:replace].split(',').map(&:strip) end else - replace_ids = ['watcher'] + replace_selectors = ['#watcher'] end + + watcher_partial = lambda do + render_to_string(:partial => 'watchers/watchers', :locals => {:watched => @watched}) + end + respond_to do |format| format.html { redirect_to :back } format.js do render(:update) do |page| - replace_ids.each do |replace_id| - case replace_id - when 'watchers' - page.replace_html 'watchers', :partial => 'watchers/watchers', :locals => {:watched => @watched} + replace_selectors.each do |selector| + next if selector.blank? + + case selector + when '#watchers' + page.select('#watchers').each do |node| + node.update watcher_partial.call + end else - page.replace_html replace_id, watcher_link(@watched, user, :replace => replace_ids) + page.select(selector).each do |node| + options = {:replace => replace_selectors} + + last_selector = selector.split(' ').last + if last_selector.starts_with? '.' + options[:class] = last_selector[1..-1] + elsif last_selector.starts_with? '#' + options[:id] = last_selector[1..-1] + end + + node.replace watcher_link(@watched, user, options) + end end end end diff --git a/app/helpers/watchers_helper.rb b/app/helpers/watchers_helper.rb index 2695ce9f..b336233d 100644 --- a/app/helpers/watchers_helper.rb +++ b/app/helpers/watchers_helper.rb @@ -17,32 +17,28 @@ module WatchersHelper - # Valid options - # * :id - the element id - # * :replace - a string or array of element ids that will be - # replaced - def watcher_tag(object, user, options={:replace => 'watcher'}) - id = options[:id] - id ||= options[:replace] if options[:replace].is_a? String - content_tag("span", watcher_link(object, user, options), :id => id) - end - - # Valid options - # * :replace - a string or array of element ids that will be - # replaced - def watcher_link(object, user, options={:replace => 'watcher'}) + # Create a link to watch/unwatch object + # + # * :replace - a string or array of strings with css selectors that will be updated, whenever the watcher status is changed + def watcher_link(object, user, options = {:replace => '.watcher_link', :class => 'watcher_link'}) + options = options.with_indifferent_access + raise ArgumentError, 'Missing :replace option in options hash' if options['replace'].blank? + return '' unless user && user.logged? && object.respond_to?('watched_by?') + watched = object.watched_by?(user) url = {:controller => 'watchers', :action => (watched ? 'unwatch' : 'watch'), :object_type => object.class.to_s.underscore, :object_id => object.id, - :replace => options[:replace]} - link_to_remote((watched ? l(:button_unwatch) : l(:button_watch)), - {:url => url}, - :href => url_for(url), - :class => (watched ? 'icon icon-fav' : 'icon icon-fav-off')) - + :replace => options.delete('replace')} + + url_options = {:url => url} + + html_options = options.merge(:href => url_for(url)) + html_options[:class] += watched ? ' icon icon-fav' : ' icon icon-fav-off' + + link_to_remote((watched ? l(:button_unwatch) : l(:button_watch)), url_options, html_options) end # Returns a comma separated list of users watching the given object diff --git a/app/views/boards/show.rhtml b/app/views/boards/show.rhtml index c4a08b29..595038e8 100644 --- a/app/views/boards/show.rhtml +++ b/app/views/boards/show.rhtml @@ -5,7 +5,7 @@ {:controller => 'messages', :action => 'new', :board_id => @board}, :class => 'icon icon-add', :onclick => 'Element.show("add-message"); Form.Element.focus("message_subject"); return false;' %> -<%= watcher_tag(@board, User.current) %> + <%= watcher_link(@board, User.current) %>