diff --git a/app/controllers/news_controller.rb b/app/controllers/news_controller.rb index 6f26d5c9..d97b0e0a 100644 --- a/app/controllers/news_controller.rb +++ b/app/controllers/news_controller.rb @@ -59,14 +59,12 @@ class NewsController < ApplicationController def create @news = News.new(:project => @project, :author => User.current) - if request.post? - @news.attributes = params[:news] - if @news.save - flash[:notice] = l(:notice_successful_create) - redirect_to :controller => 'news', :action => 'index', :project_id => @project - else - render :action => 'new' - end + @news.safe_attributes = params[:news] + if @news.save + flash[:notice] = l(:notice_successful_create) + redirect_to :controller => 'news', :action => 'index', :project_id => @project + else + render :action => 'new' end end @@ -74,7 +72,8 @@ class NewsController < ApplicationController end def update - if request.put? and @news.update_attributes(params[:news]) + @news.safe_attributes = params[:news] + if @news.save flash[:notice] = l(:notice_successful_update) redirect_to :action => 'show', :id => @news else diff --git a/app/models/news.rb b/app/models/news.rb index 8104002e..2ceb3bfd 100644 --- a/app/models/news.rb +++ b/app/models/news.rb @@ -13,6 +13,7 @@ #++ class News < ActiveRecord::Base + include Redmine::SafeAttributes belongs_to :project belongs_to :author, :class_name => 'User', :foreign_key => 'author_id' has_many :comments, :as => :commented, :dependent => :delete_all, :order => "created_on" @@ -33,6 +34,8 @@ class News < ActiveRecord::Base :conditions => Project.allowed_to_condition(args.first || User.current, :view_news) }} + safe_attributes 'title', 'summary', 'description' + def visible?(user=User.current) !user.nil? && user.allowed_to?(:view_news, project) end