765f7abc60
Patch supplied by commits from Gerrit Kaiser on Github. Existing routes will still work (backwards compatible) but any new urls will be generated using the new routing rules. Changes listed below: * made the URLs for some project tabs and project settings follow the new rails RESTful conventions of /collection/:id/subcollection/:sub_id * prettier URL for project roadmap * more nice project URLs * use GET for filtering form * prettified URLs used on issues tab * custom route for activity atom feeds * prettier repository urls * fixed broken route definition * fixed failing tests for issuecontroller that were hardcoding the url string * more RESTful routes for boards and messages * RESTful routes for wiki pages * RESTful routes for documents * moved old routes that are retained for compatibility to the bottom and grouped them together * added RESTful URIs for issues * RESTfulness for the news section * fixed route order * changed hardcoded URLs in tests * fixed badly written tests * fixed forgotten parameter in routes * changed hardcoded URLS to new scheme * changed project add url to the standard POST to collection * create new issue by POSTing to collection * changed hardcoded URLs in integrations tests * made project add form work again * restful routes for project deletion * prettier routes for project (un)archival * made routes table more readable * fixed note quoting * user routing * fixed bug * always sort by GET * Fixed: cross-project issue list should not show issues of projects for which the issue tracking module was disabled. * prettified URLs used on issues tab * urls for time log * fixed reply routing * eliminate revision query paremeter for diff and entry actions * fixed test failures with hard-coded urls * ensure ajax links always use get * refactored ajax link generation into separate method #1901 git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2317 e93f8b46-1217-0410-a6f0-8f06a7374b81
518 lines
17 KiB
Ruby
518 lines
17 KiB
Ruby
# Redmine - project management software
|
|
# Copyright (C) 2006-2008 Jean-Philippe Lang
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License
|
|
# as published by the Free Software Foundation; either version 2
|
|
# of the License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
|
|
require File.dirname(__FILE__) + '/../test_helper'
|
|
require 'projects_controller'
|
|
|
|
# Re-raise errors caught by the controller.
|
|
class ProjectsController; def rescue_action(e) raise e end; end
|
|
|
|
class ProjectsControllerTest < Test::Unit::TestCase
|
|
fixtures :projects, :versions, :users, :roles, :members, :issues, :journals, :journal_details,
|
|
:trackers, :projects_trackers, :issue_statuses, :enabled_modules, :enumerations, :boards, :messages,
|
|
:attachments
|
|
|
|
def setup
|
|
@controller = ProjectsController.new
|
|
@request = ActionController::TestRequest.new
|
|
@response = ActionController::TestResponse.new
|
|
@request.session[:user_id] = nil
|
|
Setting.default_language = 'en'
|
|
end
|
|
|
|
def test_index_routing
|
|
assert_routing(
|
|
{:method => :get, :path => '/projects'},
|
|
:controller => 'projects', :action => 'index'
|
|
)
|
|
end
|
|
|
|
def test_index
|
|
get :index
|
|
assert_response :success
|
|
assert_template 'index'
|
|
assert_not_nil assigns(:projects)
|
|
|
|
assert_tag :ul, :child => {:tag => 'li',
|
|
:descendant => {:tag => 'a', :content => 'eCookbook'},
|
|
:child => { :tag => 'ul',
|
|
:descendant => { :tag => 'a',
|
|
:content => 'Child of private child'
|
|
}
|
|
}
|
|
}
|
|
|
|
assert_no_tag :a, :content => /Private child of eCookbook/
|
|
end
|
|
|
|
def test_index_atom_routing
|
|
assert_routing(
|
|
{:method => :get, :path => '/projects.atom'},
|
|
:controller => 'projects', :action => 'index', :format => 'atom'
|
|
)
|
|
end
|
|
|
|
def test_index_atom
|
|
get :index, :format => 'atom'
|
|
assert_response :success
|
|
assert_template 'common/feed.atom.rxml'
|
|
assert_select 'feed>title', :text => 'Redmine: Latest projects'
|
|
assert_select 'feed>entry', :count => Project.count(:conditions => Project.visible_by(User.current))
|
|
end
|
|
|
|
def test_add_routing
|
|
assert_routing(
|
|
{:method => :get, :path => '/projects/new'},
|
|
:controller => 'projects', :action => 'add'
|
|
)
|
|
assert_recognizes(
|
|
{:controller => 'projects', :action => 'add'},
|
|
{:method => :post, :path => '/projects/new'}
|
|
)
|
|
assert_recognizes(
|
|
{:controller => 'projects', :action => 'add'},
|
|
{:method => :post, :path => '/projects'}
|
|
)
|
|
end
|
|
|
|
def test_show_routing
|
|
assert_routing(
|
|
{:method => :get, :path => '/projects/test'},
|
|
:controller => 'projects', :action => 'show', :id => 'test'
|
|
)
|
|
end
|
|
|
|
def test_show_by_id
|
|
get :show, :id => 1
|
|
assert_response :success
|
|
assert_template 'show'
|
|
assert_not_nil assigns(:project)
|
|
end
|
|
|
|
def test_show_by_identifier
|
|
get :show, :id => 'ecookbook'
|
|
assert_response :success
|
|
assert_template 'show'
|
|
assert_not_nil assigns(:project)
|
|
assert_equal Project.find_by_identifier('ecookbook'), assigns(:project)
|
|
end
|
|
|
|
def test_private_subprojects_hidden
|
|
get :show, :id => 'ecookbook'
|
|
assert_response :success
|
|
assert_template 'show'
|
|
assert_no_tag :tag => 'a', :content => /Private child/
|
|
end
|
|
|
|
def test_private_subprojects_visible
|
|
@request.session[:user_id] = 2 # manager who is a member of the private subproject
|
|
get :show, :id => 'ecookbook'
|
|
assert_response :success
|
|
assert_template 'show'
|
|
assert_tag :tag => 'a', :content => /Private child/
|
|
end
|
|
|
|
def test_settings_routing
|
|
assert_routing(
|
|
{:method => :get, :path => '/projects/4223/settings'},
|
|
:controller => 'projects', :action => 'settings', :id => '4223'
|
|
)
|
|
assert_routing(
|
|
{:method => :get, :path => '/projects/4223/settings/members'},
|
|
:controller => 'projects', :action => 'settings', :id => '4223', :tab => 'members'
|
|
)
|
|
end
|
|
|
|
def test_settings
|
|
@request.session[:user_id] = 2 # manager
|
|
get :settings, :id => 1
|
|
assert_response :success
|
|
assert_template 'settings'
|
|
end
|
|
|
|
def test_edit
|
|
@request.session[:user_id] = 2 # manager
|
|
post :edit, :id => 1, :project => {:name => 'Test changed name',
|
|
:issue_custom_field_ids => ['']}
|
|
assert_redirected_to 'projects/settings/ecookbook'
|
|
project = Project.find(1)
|
|
assert_equal 'Test changed name', project.name
|
|
end
|
|
|
|
def test_add_version_routing
|
|
assert_routing(
|
|
{:method => :get, :path => 'projects/64/versions/new'},
|
|
:controller => 'projects', :action => 'add_version', :id => '64'
|
|
)
|
|
assert_routing(
|
|
#TODO: use PUT
|
|
{:method => :post, :path => 'projects/64/versions/new'},
|
|
:controller => 'projects', :action => 'add_version', :id => '64'
|
|
)
|
|
end
|
|
|
|
def test_add_issue_category_routing
|
|
assert_routing(
|
|
{:method => :get, :path => 'projects/test/categories/new'},
|
|
:controller => 'projects', :action => 'add_issue_category', :id => 'test'
|
|
)
|
|
assert_routing(
|
|
#TODO: use PUT and update form
|
|
{:method => :post, :path => 'projects/64/categories/new'},
|
|
:controller => 'projects', :action => 'add_issue_category', :id => '64'
|
|
)
|
|
end
|
|
|
|
def test_destroy_routing
|
|
assert_routing(
|
|
{:method => :get, :path => '/projects/567/destroy'},
|
|
:controller => 'projects', :action => 'destroy', :id => '567'
|
|
)
|
|
assert_routing(
|
|
#TODO: use DELETE and update form
|
|
{:method => :post, :path => 'projects/64/destroy'},
|
|
:controller => 'projects', :action => 'destroy', :id => '64'
|
|
)
|
|
end
|
|
|
|
def test_get_destroy
|
|
@request.session[:user_id] = 1 # admin
|
|
get :destroy, :id => 1
|
|
assert_response :success
|
|
assert_template 'destroy'
|
|
assert_not_nil Project.find_by_id(1)
|
|
end
|
|
|
|
def test_post_destroy
|
|
@request.session[:user_id] = 1 # admin
|
|
post :destroy, :id => 1, :confirm => 1
|
|
assert_redirected_to 'admin/projects'
|
|
assert_nil Project.find_by_id(1)
|
|
end
|
|
|
|
def test_add_file
|
|
set_tmp_attachments_directory
|
|
@request.session[:user_id] = 2
|
|
Setting.notified_events = ['file_added']
|
|
ActionMailer::Base.deliveries.clear
|
|
|
|
assert_difference 'Attachment.count' do
|
|
post :add_file, :id => 1, :version_id => '',
|
|
:attachments => {'1' => {'file' => test_uploaded_file('testfile.txt', 'text/plain')}}
|
|
end
|
|
assert_redirected_to 'projects/list_files/ecookbook'
|
|
a = Attachment.find(:first, :order => 'created_on DESC')
|
|
assert_equal 'testfile.txt', a.filename
|
|
assert_equal Project.find(1), a.container
|
|
|
|
mail = ActionMailer::Base.deliveries.last
|
|
assert_kind_of TMail::Mail, mail
|
|
assert_equal "[eCookbook] New file", mail.subject
|
|
assert mail.body.include?('testfile.txt')
|
|
end
|
|
|
|
def test_add_file_routing
|
|
assert_routing(
|
|
{:method => :get, :path => '/projects/33/files/new'},
|
|
:controller => 'projects', :action => 'add_file', :id => '33'
|
|
)
|
|
assert_routing(
|
|
{:method => :post, :path => '/projects/33/files/new'},
|
|
:controller => 'projects', :action => 'add_file', :id => '33'
|
|
)
|
|
end
|
|
|
|
def test_add_version_file
|
|
set_tmp_attachments_directory
|
|
@request.session[:user_id] = 2
|
|
Setting.notified_events = ['file_added']
|
|
|
|
assert_difference 'Attachment.count' do
|
|
post :add_file, :id => 1, :version_id => '2',
|
|
:attachments => {'1' => {'file' => test_uploaded_file('testfile.txt', 'text/plain')}}
|
|
end
|
|
assert_redirected_to 'projects/list_files/ecookbook'
|
|
a = Attachment.find(:first, :order => 'created_on DESC')
|
|
assert_equal 'testfile.txt', a.filename
|
|
assert_equal Version.find(2), a.container
|
|
end
|
|
|
|
def test_list_files
|
|
get :list_files, :id => 1
|
|
assert_response :success
|
|
assert_template 'list_files'
|
|
assert_not_nil assigns(:containers)
|
|
|
|
# file attached to the project
|
|
assert_tag :a, :content => 'project_file.zip',
|
|
:attributes => { :href => '/attachments/download/8/project_file.zip' }
|
|
|
|
# file attached to a project's version
|
|
assert_tag :a, :content => 'version_file.zip',
|
|
:attributes => { :href => '/attachments/download/9/version_file.zip' }
|
|
end
|
|
|
|
def test_list_files_routing
|
|
assert_routing(
|
|
{:method => :get, :path => '/projects/33/files'},
|
|
:controller => 'projects', :action => 'list_files', :id => '33'
|
|
)
|
|
end
|
|
|
|
def test_changelog_routing
|
|
assert_routing(
|
|
{:method => :get, :path => '/projects/44/changelog'},
|
|
:controller => 'projects', :action => 'changelog', :id => '44'
|
|
)
|
|
end
|
|
|
|
def test_changelog
|
|
get :changelog, :id => 1
|
|
assert_response :success
|
|
assert_template 'changelog'
|
|
assert_not_nil assigns(:versions)
|
|
end
|
|
|
|
def test_roadmap_routing
|
|
assert_routing(
|
|
{:method => :get, :path => 'projects/33/roadmap'},
|
|
:controller => 'projects', :action => 'roadmap', :id => '33'
|
|
)
|
|
end
|
|
|
|
def test_roadmap
|
|
get :roadmap, :id => 1
|
|
assert_response :success
|
|
assert_template 'roadmap'
|
|
assert_not_nil assigns(:versions)
|
|
# Version with no date set appears
|
|
assert assigns(:versions).include?(Version.find(3))
|
|
# Completed version doesn't appear
|
|
assert !assigns(:versions).include?(Version.find(1))
|
|
end
|
|
|
|
def test_roadmap_with_completed_versions
|
|
get :roadmap, :id => 1, :completed => 1
|
|
assert_response :success
|
|
assert_template 'roadmap'
|
|
assert_not_nil assigns(:versions)
|
|
# Version with no date set appears
|
|
assert assigns(:versions).include?(Version.find(3))
|
|
# Completed version appears
|
|
assert assigns(:versions).include?(Version.find(1))
|
|
end
|
|
|
|
def test_project_activity_routing
|
|
assert_routing(
|
|
{:method => :get, :path => '/projects/1/activity'},
|
|
:controller => 'projects', :action => 'activity', :id => '1'
|
|
)
|
|
end
|
|
|
|
def test_project_activity_atom_routing
|
|
assert_routing(
|
|
{:method => :get, :path => '/projects/1/activity.atom'},
|
|
:controller => 'projects', :action => 'activity', :id => '1', :format => 'atom'
|
|
)
|
|
end
|
|
|
|
def test_project_activity
|
|
get :activity, :id => 1, :with_subprojects => 0
|
|
assert_response :success
|
|
assert_template 'activity'
|
|
assert_not_nil assigns(:events_by_day)
|
|
|
|
assert_tag :tag => "h3",
|
|
:content => /#{2.days.ago.to_date.day}/,
|
|
:sibling => { :tag => "dl",
|
|
:child => { :tag => "dt",
|
|
:attributes => { :class => /issue-edit/ },
|
|
:child => { :tag => "a",
|
|
:content => /(#{IssueStatus.find(2).name})/,
|
|
}
|
|
}
|
|
}
|
|
end
|
|
|
|
def test_previous_project_activity
|
|
get :activity, :id => 1, :from => 3.days.ago.to_date
|
|
assert_response :success
|
|
assert_template 'activity'
|
|
assert_not_nil assigns(:events_by_day)
|
|
|
|
assert_tag :tag => "h3",
|
|
:content => /#{3.day.ago.to_date.day}/,
|
|
:sibling => { :tag => "dl",
|
|
:child => { :tag => "dt",
|
|
:attributes => { :class => /issue/ },
|
|
:child => { :tag => "a",
|
|
:content => /#{Issue.find(1).subject}/,
|
|
}
|
|
}
|
|
}
|
|
end
|
|
|
|
def test_global_activity_routing
|
|
assert_routing({:method => :get, :path => '/activity'}, :controller => 'projects', :action => 'activity')
|
|
end
|
|
|
|
def test_global_activity
|
|
get :activity
|
|
assert_response :success
|
|
assert_template 'activity'
|
|
assert_not_nil assigns(:events_by_day)
|
|
|
|
assert_tag :tag => "h3",
|
|
:content => /#{5.day.ago.to_date.day}/,
|
|
:sibling => { :tag => "dl",
|
|
:child => { :tag => "dt",
|
|
:attributes => { :class => /issue/ },
|
|
:child => { :tag => "a",
|
|
:content => /#{Issue.find(5).subject}/,
|
|
}
|
|
}
|
|
}
|
|
end
|
|
|
|
def test_user_activity
|
|
get :activity, :user_id => 2
|
|
assert_response :success
|
|
assert_template 'activity'
|
|
assert_not_nil assigns(:events_by_day)
|
|
|
|
assert_tag :tag => "h3",
|
|
:content => /#{3.day.ago.to_date.day}/,
|
|
:sibling => { :tag => "dl",
|
|
:child => { :tag => "dt",
|
|
:attributes => { :class => /issue/ },
|
|
:child => { :tag => "a",
|
|
:content => /#{Issue.find(1).subject}/,
|
|
}
|
|
}
|
|
}
|
|
end
|
|
|
|
def test_global_activity_atom_routing
|
|
assert_routing({:method => :get, :path => '/activity.atom'}, :controller => 'projects', :action => 'activity', :format => 'atom')
|
|
end
|
|
|
|
def test_activity_atom_feed
|
|
get :activity, :format => 'atom'
|
|
assert_response :success
|
|
assert_template 'common/feed.atom.rxml'
|
|
end
|
|
|
|
def test_archive_routing
|
|
assert_routing(
|
|
#TODO: use PUT to project path and modify form
|
|
{:method => :post, :path => 'projects/64/archive'},
|
|
:controller => 'projects', :action => 'archive', :id => '64'
|
|
)
|
|
end
|
|
|
|
def test_archive
|
|
@request.session[:user_id] = 1 # admin
|
|
post :archive, :id => 1
|
|
assert_redirected_to 'admin/projects'
|
|
assert !Project.find(1).active?
|
|
end
|
|
|
|
def test_unarchive_routing
|
|
assert_routing(
|
|
#TODO: use PUT to project path and modify form
|
|
{:method => :post, :path => '/projects/567/unarchive'},
|
|
:controller => 'projects', :action => 'unarchive', :id => '567'
|
|
)
|
|
end
|
|
|
|
def test_unarchive
|
|
@request.session[:user_id] = 1 # admin
|
|
Project.find(1).archive
|
|
post :unarchive, :id => 1
|
|
assert_redirected_to 'admin/projects'
|
|
assert Project.find(1).active?
|
|
end
|
|
|
|
def test_jump_should_redirect_to_active_tab
|
|
get :show, :id => 1, :jump => 'issues'
|
|
assert_redirected_to 'projects/ecookbook/issues'
|
|
end
|
|
|
|
def test_jump_should_not_redirect_to_inactive_tab
|
|
get :show, :id => 3, :jump => 'documents'
|
|
assert_response :success
|
|
assert_template 'show'
|
|
end
|
|
|
|
def test_jump_should_not_redirect_to_unknown_tab
|
|
get :show, :id => 3, :jump => 'foobar'
|
|
assert_response :success
|
|
assert_template 'show'
|
|
end
|
|
|
|
def test_project_menu
|
|
assert_no_difference 'Redmine::MenuManager.items(:project_menu).size' do
|
|
Redmine::MenuManager.map :project_menu do |menu|
|
|
menu.push :foo, { :controller => 'projects', :action => 'show' }, :cation => 'Foo'
|
|
menu.push :bar, { :controller => 'projects', :action => 'show' }, :before => :activity
|
|
menu.push :hello, { :controller => 'projects', :action => 'show' }, :caption => Proc.new {|p| p.name.upcase }, :after => :bar
|
|
end
|
|
|
|
get :show, :id => 1
|
|
assert_tag :div, :attributes => { :id => 'main-menu' },
|
|
:descendant => { :tag => 'li', :child => { :tag => 'a', :content => 'Foo',
|
|
:attributes => { :class => 'foo' } } }
|
|
|
|
assert_tag :div, :attributes => { :id => 'main-menu' },
|
|
:descendant => { :tag => 'li', :child => { :tag => 'a', :content => 'Bar',
|
|
:attributes => { :class => 'bar' } },
|
|
:before => { :tag => 'li', :child => { :tag => 'a', :content => 'ECOOKBOOK' } } }
|
|
|
|
assert_tag :div, :attributes => { :id => 'main-menu' },
|
|
:descendant => { :tag => 'li', :child => { :tag => 'a', :content => 'ECOOKBOOK',
|
|
:attributes => { :class => 'hello' } },
|
|
:before => { :tag => 'li', :child => { :tag => 'a', :content => 'Activity' } } }
|
|
|
|
# Remove the menu items
|
|
Redmine::MenuManager.map :project_menu do |menu|
|
|
menu.delete :foo
|
|
menu.delete :bar
|
|
menu.delete :hello
|
|
end
|
|
end
|
|
end
|
|
|
|
# A hook that is manually registered later
|
|
class ProjectBasedTemplate < Redmine::Hook::ViewListener
|
|
def view_layouts_base_html_head(context)
|
|
# Adds a project stylesheet
|
|
stylesheet_link_tag(context[:project].identifier) if context[:project]
|
|
end
|
|
end
|
|
# Don't use this hook now
|
|
Redmine::Hook.clear_listeners
|
|
|
|
def test_hook_response
|
|
Redmine::Hook.add_listener(ProjectBasedTemplate)
|
|
get :show, :id => 1
|
|
assert_tag :tag => 'link', :attributes => {:href => '/stylesheets/ecookbook.css'},
|
|
:parent => {:tag => 'head'}
|
|
|
|
Redmine::Hook.clear_listeners
|
|
end
|
|
end
|