976a31e941
The 'Change status' specific form removed and now accessible from issue/show view with no additional request (click on 'Update' to show the form). The 'Change issue status' permission is removed. To change the status, the user just needs to have either 'Edit' or 'Add note' permissions and some workflow transitions allowed. git-svn-id: http://redmine.rubyforge.org/svn/trunk@1043 e93f8b46-1217-0410-a6f0-8f06a7374b81
238 lines
10 KiB
Ruby
238 lines
10 KiB
Ruby
# redMine - project management software
|
|
# Copyright (C) 2006-2007 Jean-Philippe Lang
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License
|
|
# as published by the Free Software Foundation; either version 2
|
|
# of the License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
|
|
class IssuesController < ApplicationController
|
|
layout 'base'
|
|
before_filter :find_project, :authorize, :except => [:index, :changes, :preview]
|
|
before_filter :find_optional_project, :only => [:index, :changes]
|
|
accept_key_auth :index, :changes
|
|
|
|
cache_sweeper :issue_sweeper, :only => [ :edit, :update, :destroy ]
|
|
|
|
helper :projects
|
|
include ProjectsHelper
|
|
helper :custom_fields
|
|
include CustomFieldsHelper
|
|
helper :ifpdf
|
|
include IfpdfHelper
|
|
helper :issue_relations
|
|
include IssueRelationsHelper
|
|
helper :watchers
|
|
include WatchersHelper
|
|
helper :attachments
|
|
include AttachmentsHelper
|
|
helper :queries
|
|
helper :sort
|
|
include SortHelper
|
|
include IssuesHelper
|
|
|
|
def index
|
|
sort_init "#{Issue.table_name}.id", "desc"
|
|
sort_update
|
|
retrieve_query
|
|
if @query.valid?
|
|
limit = %w(pdf csv).include?(params[:format]) ? Setting.issues_export_limit.to_i : per_page_option
|
|
@issue_count = Issue.count(:include => [:status, :project], :conditions => @query.statement)
|
|
@issue_pages = Paginator.new self, @issue_count, limit, params['page']
|
|
@issues = Issue.find :all, :order => sort_clause,
|
|
:include => [ :assigned_to, :status, :tracker, :project, :priority, :category, :fixed_version ],
|
|
:conditions => @query.statement,
|
|
:limit => limit,
|
|
:offset => @issue_pages.current.offset
|
|
respond_to do |format|
|
|
format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }
|
|
format.atom { render_feed(@issues, :title => l(:label_issue_plural)) }
|
|
format.csv { send_data(issues_to_csv(@issues, @project).read, :type => 'text/csv; header=present', :filename => 'export.csv') }
|
|
format.pdf { send_data(render(:template => 'issues/index.rfpdf', :layout => false), :type => 'application/pdf', :filename => 'export.pdf') }
|
|
end
|
|
else
|
|
# Send html if the query is not valid
|
|
render(:template => 'issues/index.rhtml', :layout => !request.xhr?)
|
|
end
|
|
end
|
|
|
|
def changes
|
|
sort_init "#{Issue.table_name}.id", "desc"
|
|
sort_update
|
|
retrieve_query
|
|
if @query.valid?
|
|
@changes = Journal.find :all, :include => [ :details, :user, {:issue => [:project, :author, :tracker, :status]} ],
|
|
:conditions => @query.statement,
|
|
:limit => 25,
|
|
:order => "#{Journal.table_name}.created_on DESC"
|
|
end
|
|
@title = (@project ? @project.name : Setting.app_title) + ": " + (@query.new_record? ? l(:label_changes_details) : @query.name)
|
|
render :layout => false, :content_type => 'application/atom+xml'
|
|
end
|
|
|
|
def show
|
|
@custom_values = @issue.custom_values.find(:all, :include => :custom_field, :order => "#{CustomField.table_name}.position")
|
|
@journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
|
|
@status_options = @issue.new_statuses_allowed_to(User.current)
|
|
@activities = Enumeration::get_values('ACTI')
|
|
respond_to do |format|
|
|
format.html { render :template => 'issues/show.rhtml' }
|
|
format.pdf { send_data(render(:template => 'issues/show.rfpdf', :layout => false), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
|
|
end
|
|
end
|
|
|
|
def edit
|
|
@priorities = Enumeration::get_values('IPRI')
|
|
@custom_values = []
|
|
if request.get?
|
|
@custom_values = @project.custom_fields_for_issues(@issue.tracker).collect { |x| @issue.custom_values.find_by_custom_field_id(x.id) || CustomValue.new(:custom_field => x, :customized => @issue) }
|
|
else
|
|
begin
|
|
journal = @issue.init_journal(User.current)
|
|
# Retrieve custom fields and values
|
|
if params["custom_fields"]
|
|
@custom_values = @project.custom_fields_for_issues(@issue.tracker).collect { |x| CustomValue.new(:custom_field => x, :customized => @issue, :value => params["custom_fields"][x.id.to_s]) }
|
|
@issue.custom_values = @custom_values
|
|
end
|
|
@issue.attributes = params[:issue]
|
|
if @issue.save
|
|
flash[:notice] = l(:notice_successful_update)
|
|
Mailer.deliver_issue_edit(journal) if Setting.notified_events.include?('issue_updated')
|
|
redirect_to(params[:back_to] || {:action => 'show', :id => @issue})
|
|
end
|
|
rescue ActiveRecord::StaleObjectError
|
|
# Optimistic locking exception
|
|
flash[:error] = l(:notice_locking_conflict)
|
|
end
|
|
end
|
|
end
|
|
|
|
# Attributes that can be updated on workflow transition
|
|
# TODO: make it configurable (at least per role)
|
|
UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION)
|
|
|
|
def update
|
|
@status_options = @issue.new_statuses_allowed_to(User.current)
|
|
@activities = Enumeration::get_values('ACTI')
|
|
journal = @issue.init_journal(User.current, params[:notes])
|
|
# User can change issue attributes only if a workflow transition is allowed
|
|
if !@status_options.empty? && params[:issue]
|
|
attrs = params[:issue].dup
|
|
attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) }
|
|
attrs.delete(:status_id) unless @status_options.detect {|s| s.id.to_s == attrs[:status_id].to_s}
|
|
@issue.attributes = attrs
|
|
end
|
|
if request.post?
|
|
attachments = attach_files(@issue, params[:attachments])
|
|
attachments.each {|a| journal.details << JournalDetail.new(:property => 'attachment', :prop_key => a.id, :value => a.filename)}
|
|
if @issue.save
|
|
# Log spend time
|
|
if current_role.allowed_to?(:log_time)
|
|
@time_entry = TimeEntry.new(:project => @project, :issue => @issue, :user => User.current, :spent_on => Date.today)
|
|
@time_entry.attributes = params[:time_entry]
|
|
@time_entry.save
|
|
end
|
|
if !journal.new_record?
|
|
# Only send notification if something was actually changed
|
|
flash[:notice] = l(:notice_successful_update)
|
|
Mailer.deliver_issue_edit(journal) if Setting.notified_events.include?('issue_updated')
|
|
end
|
|
redirect_to(params[:back_to] || {:action => 'show', :id => @issue})
|
|
end
|
|
end
|
|
rescue ActiveRecord::StaleObjectError
|
|
# Optimistic locking exception
|
|
flash.now[:error] = l(:notice_locking_conflict)
|
|
end
|
|
|
|
def destroy
|
|
@issue.destroy
|
|
redirect_to :action => 'index', :project_id => @project
|
|
end
|
|
|
|
def destroy_attachment
|
|
a = @issue.attachments.find(params[:attachment_id])
|
|
a.destroy
|
|
journal = @issue.init_journal(User.current)
|
|
journal.details << JournalDetail.new(:property => 'attachment',
|
|
:prop_key => a.id,
|
|
:old_value => a.filename)
|
|
journal.save
|
|
redirect_to :action => 'show', :id => @issue
|
|
end
|
|
|
|
def context_menu
|
|
@priorities = Enumeration.get_values('IPRI').reverse
|
|
@statuses = IssueStatus.find(:all, :order => 'position')
|
|
@allowed_statuses = @issue.new_statuses_allowed_to(User.current)
|
|
@assignables = @issue.assignable_users
|
|
@assignables << @issue.assigned_to if @issue.assigned_to && !@assignables.include?(@issue.assigned_to)
|
|
@can = {:edit => User.current.allowed_to?(:edit_issues, @project),
|
|
:assign => (@allowed_statuses.any? || User.current.allowed_to?(:edit_issues, @project)),
|
|
:add => User.current.allowed_to?(:add_issues, @project),
|
|
:move => User.current.allowed_to?(:move_issues, @project),
|
|
:copy => (@project.trackers.include?(@issue.tracker) && User.current.allowed_to?(:add_issues, @project)),
|
|
:delete => User.current.allowed_to?(:delete_issues, @project)}
|
|
render :layout => false
|
|
end
|
|
|
|
def preview
|
|
issue = Issue.find_by_id(params[:id])
|
|
@attachements = issue.attachments if issue
|
|
@text = params[:issue][:description]
|
|
render :partial => 'common/preview'
|
|
end
|
|
|
|
private
|
|
def find_project
|
|
@issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
|
|
@project = @issue.project
|
|
rescue ActiveRecord::RecordNotFound
|
|
render_404
|
|
end
|
|
|
|
def find_optional_project
|
|
return true unless params[:project_id]
|
|
@project = Project.find(params[:project_id])
|
|
authorize
|
|
rescue ActiveRecord::RecordNotFound
|
|
render_404
|
|
end
|
|
|
|
# Retrieve query from session or build a new query
|
|
def retrieve_query
|
|
if params[:query_id]
|
|
@query = Query.find(params[:query_id], :conditions => {:project_id => (@project ? @project.id : nil)})
|
|
session[:query] = {:id => @query.id, :project_id => @query.project_id}
|
|
else
|
|
if params[:set_filter] || session[:query].nil? || session[:query][:project_id] != (@project ? @project.id : nil)
|
|
# Give it a name, required to be valid
|
|
@query = Query.new(:name => "_")
|
|
@query.project = @project
|
|
if params[:fields] and params[:fields].is_a? Array
|
|
params[:fields].each do |field|
|
|
@query.add_filter(field, params[:operators][field], params[:values][field])
|
|
end
|
|
else
|
|
@query.available_filters.keys.each do |field|
|
|
@query.add_short_filter(field, params[field]) if params[field]
|
|
end
|
|
end
|
|
session[:query] = {:project_id => @query.project_id, :filters => @query.filters}
|
|
else
|
|
@query = Query.find_by_id(session[:query][:id]) if session[:query][:id]
|
|
@query ||= Query.new(:name => "_", :project => @project, :filters => session[:query][:filters])
|
|
end
|
|
end
|
|
end
|
|
end
|