fe1e3ccd18
Refactor: Decouple failed attachments and the flash messages
...
Attachment#attach_files will no longer need to return a flash message,
instead it will put unsaved attachments into object#unsaved_attachments
where the calling object can access them.
A utility method #render_attachment_warning_if_needed is included for setting
the standard flash warning.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3528 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 17:05:00 +00:00
f6d8752e44
Fixes destroying attachments if the update fails. (r2875 r3523)
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3526 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-03 17:04:50 +00:00
0fd7e2d696
Refactor: Moved ApplicationController#attach_files to the Attachment model
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3523 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-02 19:26:03 +00:00
f5f5a5f64f
Verify issues are updated by HTTP PUT only. Regression from r3486.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3520 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-01 18:29:18 +00:00
8699e5bbcd
Refactor: Decouple building Issue and TimeEntry objects in #issue_update.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3519 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-01 17:40:54 +00:00
ddec53b9a2
Refactor: Extracted saving logic out of #update and into a utility method
...
Now #issue_update can be refactored and push to the Model(s) while keeping
the public interface (#update) clean.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3497 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-26 16:16:18 +00:00
3de1f2e157
Refactor: Extracted the duplication from the last commit into a new method
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 17:01:10 +00:00
c68d853bf4
Refactor: Move the updating of an Issue to the #update method.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3486 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-25 17:01:05 +00:00
d581510af6
Refactor: Start to extract IssuesController#edit into #update (REST).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3480 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-24 17:21:41 +00:00
e24d6cc223
Bulk edit refactoring.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3478 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 21:26:29 +00:00
f838904a7e
Refactor: Extract Issue#bulk_edit from the IssuesController
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3475 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-23 17:06:08 +00:00
08d7c5bfb4
Adds a controller hook before issue move ( #4850 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3457 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-19 19:10:50 +00:00
eac7fcff6e
Fixed: error raised when trying to view the gantt or calendar with a grouped query ( #4751 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3379 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-06 18:07:25 +00:00
626b71622d
Fixed: invalid format parameter returns a DoubleRenderError on issues index ( #4737 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3368 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-04 19:58:42 +00:00
ea51dcf911
Reverts r3366.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3367 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-04 19:57:45 +00:00
cfe4d0e7db
Fixed: invalid format parameter returns a DoubleRenderError on issues index ( #4737 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3366 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-04 19:52:51 +00:00
d43c860448
Allow commits to reference issues of parent projects and subprojects ( #4674 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3357 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-31 16:25:06 +00:00
1bc00ac022
Accept filters from API calls without set_filter parameter.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3335 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-18 19:53:06 +00:00
320c191f04
Fixed: PDF export of a issue list grouped by a custom field raises an error ( #4600 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3333 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-18 18:00:27 +00:00
1827d609a1
Cleaned up the IssueController redirects to use the back_url like the other actions.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3315 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-14 23:24:55 +00:00
3873388f9b
XML REST API for issues that provides CRUD operations for Issues ( #1214 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3310 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-13 19:29:19 +00:00
0a05cc2a37
Set a white list of issue attributes that can be mass-assigned from controllers.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3308 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-12 20:17:20 +00:00
d7c9886b8c
Fixed: attachments get saved on issue update even if validation fails ( #4401 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3305 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-10 14:05:42 +00:00
cab99aa5ad
Allow bulk edit custom fields of any type ( #461 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3278 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-03 11:18:09 +00:00
e9810b5de6
Fixed: bulk edit doesn't include global custom fields ( #4505 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3277 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-01-03 10:50:40 +00:00
c67cc7c285
Added :controller_issues_new_before_save hook. ( #4465 )
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3263 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-29 23:31:24 +00:00
488c192286
Removes "xxx and return" calls ( #4446 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3185 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-18 14:22:18 +00:00
7537e86fd2
Fixes that issue copy/move throws an error when status is not changed ( #4369 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3148 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-09 16:04:45 +00:00
8f33c6589d
Fixed: error when changing tracker on the new issue form ( #4345 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3125 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-06 10:37:08 +00:00
5f8e9d7118
Version sharing ( #465 ) + optional inclusion of subprojects in the roadmap view ( #2666 ).
...
Each version of a project can be shared with:
* subprojects
* projects in the project hierarchy: ancestors + descendants (needs versions management permission on the root project)
* projects in the project tree: root project + all its descendants (same as above)
* all projects (can be set by admin users only)
Notes:
* when sharing a version of a private project with others projects, its name will be visible within the other projects
* a project with versions used by non descendant projects can not be archived
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3123 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-06 10:28:20 +00:00
e178123569
Enhanced the Issue Bulk Copy feature:
...
* Add a Copy option to the Context menu for multiple issues.
* Added assigned to, status, start and due date options to the move/copy form.
* Allow Issue#move_to to change attributes on the moved/copied issue.
#4117
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3122 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-04 22:46:12 +00:00
8b8c24e61f
Fixes context menu broken by r3109 ( #2405 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3111 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-30 19:18:09 +00:00
f134e72fec
Adds tracker update to context menu and bulk edit form ( #2405 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3109 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-29 20:00:21 +00:00
88fcf484d4
Enable tracker update on issue edit form ( #2405 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3108 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-29 19:46:40 +00:00
66540afc08
Adds dynamic columns selection on the issue list ( #4272 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3105 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-28 11:34:12 +00:00
99b52c8796
Rescue invalid query statement error with an error message.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3104 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-28 10:29:48 +00:00
915bbcfaff
Move issues, journals, versions queries from IssuesController to Query model.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3103 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-28 10:08:29 +00:00
4af8765f15
Reverts r3072 ( #4302 : error raised when sorting on an association not included as column).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3097 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-27 19:59:10 +00:00
d84bd8edd8
Optimize associations loading on the issue list.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3072 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-16 18:28:44 +00:00
71bc44a89d
Allow issue grouping by custom field ( #2679 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3071 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-16 18:07:30 +00:00
7d57833740
Adds a 'Move and follow' button on Move/Copy view to be redirected to the created issue(s) rather than the source project issue list ( #1847 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3063 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-15 14:31:19 +00:00
58103680bd
Redirect to the current page when using context menu on the issue list ( #4184 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3027 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-11 11:35:27 +00:00
27e3fa2bed
Use FasterCSV or ruby1.9 CSV instead of ruby1.8 builtin CSV.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3007 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-04 13:22:26 +00:00
6994a81209
Fixed: Feed content limit ignored on issues list.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3005 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-04 12:31:37 +00:00
9aa2b6b9a4
IssuesController#destroy accepts POST only ( #4107 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2980 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-10-25 13:38:48 +00:00
07aa3c55bd
Contextual quick search ( #3263 ).
...
Eg. when viewing issues, the quick search will search issues only.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2943 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-10-21 17:07:18 +00:00
aca6ed13fc
Fixed: issue attachments are saved even if the issue has been updated by another user ( #3846 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2875 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-09-12 09:59:38 +00:00
f1f65794e4
New strings for translation ( fixes #2872 ), thanks for Enderson Maia for pointing and translation
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2847 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-08-21 19:43:33 +00:00
62e58f26b0
Changed Enumerations to use a Single Table Inheritance
...
* Added migrations to change Enumerations to an STI relationship
* Added TimeEntryActivity model (STI)
* Added DocumentCategory model (STI)
* Added IssuePriority model (STI)
* Added Enumeration#get_subclasses to get a list of the subclasses of Enumeration
* Changed Enumeration to use the STI type field instead of the opt field
* Changed Enumeration#opt to return the old opt values but with a deprecation warning.
* Removed Enumeration::OPTIONS
* Removed the dynamic named_scopes in favor of specific named_scopes. Kept for
compatibility reasons.
* Added Enumeration#default so each subclass can easily find it's default record.
* Fixed Enumeration#default to use the STI scoping with a fake default scope for finding Enumeration's default.
* Added a 'all' named scope for getting all records in order by position.
* Added Deprecation warnings to the old named_scopes in Enumerations.
* Moved various methods off of Enumeration and onto the concrete classes
* Changed the EnumerationsController to use types
* Updated the Enumeration list template
* Added has_many relationships to the Enumeration STI classes.
* Fixes for tests.
#3007
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2777 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-05-30 23:30:36 +00:00
6e0a818caf
Makes issues/show accept rss key ( #3362 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2745 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-05-17 08:35:57 +00:00
Eric Davis
Jean-Philippe Lang
Azamat Hackimov