Commit Graph

1607 Commits

Author SHA1 Message Date
Jean-Philippe Lang 9536d04c1e Typo that triggers an error when editing a subproject (#5605).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11301 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-02 13:18:04 +00:00
Jean-Philippe Lang 5fea79504c Don't remove watchers on permission change.
This can be far too slow (especially with membership inheritance) and notifications are not sent to watchers that are not allowed to view the item. If we still want to remove watchers that are no longer able to view the watched items, the redmine:watchers:prune task can be called periodically.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11300 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-02 13:03:22 +00:00
Jean-Philippe Lang 0f29e265fc Optionaly inherit members from parent project (#5605).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11298 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-02 12:50:45 +00:00
Jean-Philippe Lang 137aa1cf66 Test broken by r11296.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11297 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-02 09:49:26 +00:00
Jean-Philippe Lang 9e0723c11b Refactors methods for searching a user by token.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11296 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-02 08:46:58 +00:00
Jean-Philippe Lang 9bf98bce26 Skip callbacks when updating last_login_on.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11294 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-01 18:32:12 +00:00
Jean-Philippe Lang bf2613a02b Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11291 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-30 21:31:13 +00:00
Jean-Philippe Lang 1e0a94de84 Fixe that filter "Assignee's group" doesn't work with group assignments (#13006).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11285 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-29 17:59:20 +00:00
Jean-Philippe Lang 10a38010fb Test failure with JRuby 1.7.2 (#12228).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11280 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-27 12:23:02 +00:00
Jean-Philippe Lang 134b66cb29 Always notify project members about news unless they turned off all notifications (#4700).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11271 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-26 18:07:57 +00:00
Toshi MARUYAMA 3d7819ed82 remove trailing white-space from app/models/attachment.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11267 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-26 00:47:29 +00:00
Jean-Philippe Lang e53a5de918 Adds "sorted" scope to Principal and User and sort users/groups properly.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11259 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-23 17:44:28 +00:00
Jean-Philippe Lang f99535bba2 "Parent task is invalid" while editing child issues with restricted Issues Visibility (#12851).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11228 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-20 16:41:31 +00:00
Jean-Philippe Lang 5741d007f6 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11222 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-20 13:57:29 +00:00
Jean-Philippe Lang 48fb02e383 Split "Manage documents" permission into create, edit and delete permissions (#12401).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11206 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-20 11:38:20 +00:00
Jean-Philippe Lang e224d50408 Removed useless require 'iconv' (#12787).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11176 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 20:36:22 +00:00
Jean-Philippe Lang e18d0e268d Makes issue custom fields available as timelog columns (#1766).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11174 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 13:09:06 +00:00
Jean-Philippe Lang 14b09361e4 Adds issue custom fields to time entries filters (#10191).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11171 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 12:38:45 +00:00
Jean-Philippe Lang e396a0eebe Copyright for 2013 (#12788).
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11169 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 09:29:31 +00:00
Jean-Philippe Lang 5c1039a69e Ability to uncheck "Multiple values" for existing custom fields (#12251).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11167 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 09:12:09 +00:00
Jean-Philippe Lang 8ee0b52d59 Gantt perf: fixed that Project#start_date and #due_date run way too much queries.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11135 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-06 14:03:49 +00:00
Toshi MARUYAMA 4bc2805c4a remove trailing white-spaces from app/models/mail_handler.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11127 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-06 09:32:42 +00:00
Jean-Philippe Lang 45c93340b7 Negative estimated hours should not be valid (#12735).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11125 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-05 16:34:41 +00:00
Jean-Philippe Lang 3e14c3017c Adds a custom validator for dates (#12736).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11124 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-05 16:09:15 +00:00
Jean-Philippe Lang 9adb0c61a9 Make sure that dates are stored as YYYY-MM-DD in journal details (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11117 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 15:38:52 +00:00
Jean-Philippe Lang 9a66463ff8 Prevent sqlserver adapter from breaking the sub-query (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11116 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 10:08:29 +00:00
Jean-Philippe Lang a8083fb9a8 Pass the order option as an array to satisfy sqlserver adapter (#12713).
Unlike other adapters, the sqlserver adapter processes the order option and wipes it when using functions.
Here we can see a "ASC" inserted in the COALESCE call:

irb(main):001:0> Issue.order("coalesce(estimated_hours, 0), id").to_sql
=> "SELECT [issues].* FROM [issues] ORDER BY coalesce(estimated_hours ASC, 0) ASC, id ASC"

This does not happen when passing the order SQL fragments separately.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11115 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 10:04:25 +00:00
Jean-Philippe Lang 9613a13b10 Deprecates Version#*_pourcent in favour of #*_percent (#12724).
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11113 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 08:30:25 +00:00
Jean-Philippe Lang 77f6b404fa Make sure we don't cast an empty string to numeric (#12713).
SQLServer evaluates the CAST condition even if the <> '' condition is false.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11103 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 13:33:16 +00:00
Jean-Philippe Lang d82159bcf5 Use joins instead of sub-queries in group by/sort by when using custom fields (#12713).
Sub-queries in group by are not supported by SQLServer.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11102 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 12:28:50 +00:00
Jean-Philippe Lang 049eaeb776 Repository changesets are already sorted by committed_on DESC (#12713).
SQLServer raises an error because committed_on is specified twice in the order by list.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11101 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:40:39 +00:00
Jean-Philippe Lang 8b08c1a534 Prevents position to be specified more than once in the order by list which is not supported by SQLServer (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11100 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:37:07 +00:00
Jean-Philippe Lang dd7d54b3a1 SQLServer: rule is a reserved keyword (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11099 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:21:45 +00:00
Jean-Philippe Lang 0135dc504a SQLServer: The size (60) given to the type 'decimal' exceeds the maximum allowed (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11098 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:21:03 +00:00
Jean-Philippe Lang 64b98928c9 Typo in app/models/tracker.rb (#12707).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11090 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-02 13:02:20 +00:00
Jean-Philippe Lang 7b8ebb7e3f Auto-populate fields while creating a new user with LDAP (#10286).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11080 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-26 11:23:53 +00:00
Jean-Philippe Lang bda9b98a56 Code cleanup, use named routes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11068 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-22 10:30:42 +00:00
Toshi MARUYAMA b4aab7b375 remove trailing white-spaces from app/models/issue_relation.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11061 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-21 04:52:58 +00:00
Jean-Philippe Lang c93fccc84a Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10994 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-13 13:43:01 +00:00
Jean-Philippe Lang 0a773bcbb3 Fixed that validation fails when receiving an email with list custom fields (#12400).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10992 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-13 13:14:46 +00:00
Jean-Philippe Lang c99b638d61 Store attachments in subdirectories (#5298).
Existing files can be moved to their target subdirectories using rake redmine:attachments:move_to_subdirectories.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10990 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-13 12:07:19 +00:00
Jean-Philippe Lang 228414f777 Moved IssueRelations to IssueRelation::Relations.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10979 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-10 21:59:01 +00:00
Jean-Philippe Lang ef25210aca Merged ajax_upload branch (#3957).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-10 20:09:41 +00:00
Jean-Philippe Lang 0ce6eb9285 Makes time entry custom fields available for display on the time entries list (#1766).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10972 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-09 21:03:30 +00:00
Jean-Philippe Lang 60088ed5a3 Adds filters for custom fields related to the project and user of time entries (#10191).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10971 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-09 19:25:03 +00:00
Jean-Philippe Lang 9dc07d4790 Adds filters for regular/custom fields to the time entries list/report (#10191).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10970 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-09 19:18:57 +00:00
Jean-Philippe Lang 093ecdfc73 Fixed syntax for ruby1.8.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10969 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-09 18:46:02 +00:00
Jean-Philippe Lang f8895a7cdd Adds TimeEntryQuery for listing time entries.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10967 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-09 17:57:18 +00:00
Jean-Philippe Lang 10998c9bae Moved build_query_from_params helper to Query#build_from_params.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10966 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-09 15:11:00 +00:00
Jean-Philippe Lang eb1829e739 Moves issue specific code to IssueQuery.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10965 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-09 14:44:28 +00:00