Commit Graph

1389 Commits

Author SHA1 Message Date
Jean-Philippe Lang f04c7a7680 Fixed Version#issues_progress for Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8986 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 00:07:09 +00:00
Jean-Philippe Lang d04b4aafb6 Use :joins instead of :include.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8982 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 18:55:09 +00:00
Jean-Philippe Lang 430477d4d6 Round hours when reading TimeEntry attribute.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8980 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 18:40:22 +00:00
Jean-Philippe Lang 492cce7975 Cleanup instance variables when reloading a project.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8979 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 18:38:05 +00:00
Jean-Philippe Lang 67d816705d Removed useless option.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8978 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 18:27:38 +00:00
Jean-Philippe Lang 528735b955 Use subclasses method instead of class variable.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 18:23:58 +00:00
Toshi MARUYAMA 55a8087f67 Rails3: scm: mercurial: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8976 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:59:54 +00:00
Toshi MARUYAMA ebb109b67e Rails3: scm: git: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8975 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:59:31 +00:00
Toshi MARUYAMA e6916cf72f Rails3: scm: filesystem: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8974 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:59:06 +00:00
Toshi MARUYAMA 7100ca61ba Rails3: scm: darcs: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8973 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:58:43 +00:00
Toshi MARUYAMA e5bcac1572 Rails3: scm: cvs: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8972 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:58:18 +00:00
Toshi MARUYAMA 565ac00b70 Rails3: scm: bazaar: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8971 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:57:52 +00:00
Toshi MARUYAMA cd9b62d734 Rails3: scm: use .to_s for overriding human_attribute_name parameter at repository model
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8970 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:57:26 +00:00
Toshi MARUYAMA a4ee104bd7 Rails3: use .to_s for overriding human_attribute_name parameter at group model
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8969 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:56:54 +00:00
Toshi MARUYAMA 6bdc2c36f1 scm: mercurial: use to_s for revision in find_changeset_by_name method
On Rails 3.0.11, functional test fails.

<pre>
Error: test_diff_two_revs(RepositoriesMercurialControllerTest)
NoMethodError: undefined method `empty?' for 4:Fixnum
app/models/repository/mercurial.rb:76:in `find_changeset_by_name'
</pre>

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8938 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 12:18:30 +00:00
Jean-Philippe Lang 7e347069d5 Better message for file size validation error.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8937 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 12:18:10 +00:00
Toshi MARUYAMA a261006666 scm: use to_s for revision in find_changeset_by_name method
On Rails 3.0.11, Subversion functional test fails.

<pre>
Error: test_directory_diff(RepositoriesSubversionControllerTest)
NoMethodError: undefined method `match' for 2:Fixnum
app/models/repository.rb:234:in `find_changeset_by_name'
</pre>

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8931 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 10:11:19 +00:00
Jean-Philippe Lang 77626ef6fb Adds support for adding attachments to issues through the REST API (#8171).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8928 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 10:01:16 +00:00
Jean-Philippe Lang 77287d1f0b Fixed magic link in the note added when closing an issue by a commit from a subproject (#10284).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8917 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-20 21:58:57 +00:00
Jean-Philippe Lang 3e3d7c8d4f Friendly response when the LDAP connection fails.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8911 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-19 18:13:46 +00:00
Jean-Philippe Lang 59c2530001 Fixed random failures in RepositoriesControllerTest with ruby-1.8.7-p358.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8909 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-19 15:34:06 +00:00
Jean-Philippe Lang 97075c85e8 Require net/ldap.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8907 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-19 15:04:10 +00:00
Jean-Philippe Lang b455ac2a27 Adds a rake test that removes old unattached uploads (#10253).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8893 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-16 21:18:01 +00:00
Jean-Philippe Lang d4e6355eb3 Better handling of attachments when issue validation fails (#10253).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8891 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-16 21:00:11 +00:00
Jean-Philippe Lang 008557581d Makes user autocompleters work with firstname and lastname.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8875 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-14 16:29:48 +00:00
Jean-Philippe Lang cccfed7006 Fixed: error when creating a project with a version format custom field (#10218).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8865 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-13 18:57:12 +00:00
Jean-Philippe Lang 7fa18cad57 Prevent ActiveRecord::StaleObjectError in Issue#reschedule_after (#7920).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8864 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-12 19:41:42 +00:00
Jean-Philippe Lang d289619c75 Fixed potential error when sorting members without role (#10053).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8863 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-12 14:54:30 +00:00
Jean-Philippe Lang 8ddcc4caf5 Adds a News#commentable? method to easily specific additional rules.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8854 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 17:14:56 +00:00
Jean-Philippe Lang 8f92121606 Fixed that changesets parents associations are not deleted when deleting a repository.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8847 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 14:17:47 +00:00
Toshi MARUYAMA 165327a074 scm: git: reduce saving heads times in fetching revisions (#8857, #9472)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8840 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 05:42:43 +00:00
Toshi MARUYAMA 1e5f16722f scm: git: call "git log" only once instead of per branch in fetching revisions (#8857)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8839 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 05:42:06 +00:00
Toshi MARUYAMA d90cdb1b10 scm: git: raise exception if "git log" is error and block is given in lib revision method (#8857)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-10 22:56:54 +00:00
Jean-Philippe Lang 8c38510ee5 Use #reduce instead of #inject for getting the intersection of arrays.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8827 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-09 20:06:36 +00:00
Jean-Philippe Lang 8b3ed4175d Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8826 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-09 19:51:38 +00:00
Jean-Philippe Lang 5e0c1cc5ce Bulk-edit custom fields through context menu (#6296).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8824 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-09 18:22:11 +00:00
Toshi MARUYAMA 693191e8bf scm: git: add model method to get heads from extra_info branches hash (#8857)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8816 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-09 00:11:03 +00:00
Toshi MARUYAMA adb81b1ff6 scm: git: split fetch_changesets method
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8814 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-08 11:10:46 +00:00
Jean-Philippe Lang dfbab5d61e Fixed "can't convert Fixnum into String" error on projects with numerical identifier (#10135).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8804 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-06 14:44:40 +00:00
Jean-Philippe Lang 001b255b08 Ability to edit a wiki page's parent on the edit page (#6449).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8787 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-05 14:35:27 +00:00
Jean-Philippe Lang 967f42aa98 Adds a X-Redmine-Sender header to email notifications (#5643).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8785 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-05 12:57:19 +00:00
Jean-Philippe Lang a00f04886f Increase username length limit from 30 to 60 (#2719).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8778 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-05 11:50:53 +00:00
Jean-Philippe Lang 1d4ef8964d Adds a "Manage related isses" permission to add/remove commits/issues relations manually from the changeset view (#2009).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8777 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-05 10:56:27 +00:00
Jean-Philippe Lang fb3b904b8f Better handling of issue update conflicts (#8691).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8774 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-04 17:36:15 +00:00
Jean-Philippe Lang 73f9b825f0 Replaced ruby-net-ldap with net-ldap 0.2.2 gem.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8751 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-02 19:30:01 +00:00
Jean-Philippe Lang d02f6a8e32 Adds a setting that allows to reference/fix issues of all projects (#3087).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8750 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-02 18:09:37 +00:00
Jean-Philippe Lang 2808adf99f Adds members of subprojects in assignee and author filters (#10126).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8747 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-01 20:07:01 +00:00
Jean-Philippe Lang 0154d7477b Simplifies Principal.active scope (status defaults to 1 for groups).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-01 19:35:49 +00:00
Toshi MARUYAMA 5dd08133ef code layout cleanup app/models/mail_handler.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8745 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-31 12:49:06 +00:00
Toshi MARUYAMA 7b600cdb91 code layout cleanup app/models/mail_handler.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8744 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-31 10:19:04 +00:00
Jean-Philippe Lang 24138187eb Allows attachments on news (#1972).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8728 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-29 22:39:06 +00:00
Jean-Philippe Lang 8d5f932660 Do not validate blank default custom field value.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8722 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-29 21:09:44 +00:00
Jean-Philippe Lang cd6db6a3cb Adds support for multiselect custom fields (#1189).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8721 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-29 20:51:48 +00:00
Jean-Philippe Lang 83e7ee6729 Extracts custom field values validation from CustomValue so that they can be validated globally from the customized object (#1189).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8717 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-28 11:16:58 +00:00
Jean-Philippe Lang 9d372ce6f5 Allow underscores in project identifiers (#1363).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8708 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-27 17:34:58 +00:00
Jean-Philippe Lang ffbd3c0522 Makes all workflow transitions defined for all roles available to administrators (#2323).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8707 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-26 20:30:47 +00:00
Jean-Philippe Lang 22317105f9 Notify previous assignee when assignee changes (#2694).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8695 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-23 17:55:29 +00:00
Jean-Philippe Lang 41eab6615b Enable global time logging at /time_entries/new (#10020).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8691 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-21 14:26:51 +00:00
Jean-Philippe Lang 94b621a99f Fixed that reminders are sent for closed issues (#10006).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8690 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-21 12:28:39 +00:00
Jean-Philippe Lang 11725be278 Makes Version REST API accept due_date attribute (#10013).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8686 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-21 09:39:29 +00:00
Jean-Philippe Lang fbf30eec7c Adds an option of the copy form to enable/disable attachments copy (#3055).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8677 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-20 18:22:43 +00:00
Jean-Philippe Lang 8a3623733f Copy attachments on issue and project copy (#3055).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8676 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-20 17:56:28 +00:00
Jean-Philippe Lang 34d1683087 Skip a bunch of useless "UPDATE repositories SET extra_info = ..." queries when navigating in repositories.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8658 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-16 17:52:54 +00:00
Jean-Philippe Lang 83bb41d3a3 Display identifier for the default repository too (#779).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8654 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-15 22:25:20 +00:00
Jean-Philippe Lang 5f7995f977 Adds repository_id param for activity and search results (#779).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8651 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-15 18:30:52 +00:00
Jean-Philippe Lang 1bd5e58c84 Adds support for multiple repositories per project (#779).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8650 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-15 18:19:19 +00:00
Jean-Philippe Lang fb1a2fd7cd Resourcified repositories for CRUD operations to prepare for multiple SCM per project (#779).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8648 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-15 14:23:06 +00:00
Jean-Philippe Lang 980b6db5c0 Adds "me" to user custom fields filters (#9923).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8638 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-13 19:38:06 +00:00
Jean-Philippe Lang 919d0a68c3 Adds "my projects" filter on the cross-project issue list.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8637 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-13 18:16:15 +00:00
Jean-Philippe Lang 906fcd290c Initialize watcher_user_ids for new records to prevent useless queries on each #watched_by?.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8554 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-08 12:26:57 +00:00
Jean-Philippe Lang 2a55d37619 Check project assignment on issue copy/move.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-08 11:48:36 +00:00
Jean-Philippe Lang 121bc44cc5 Use the regular issue form to copy a single issue.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8552 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-08 11:16:54 +00:00
Jean-Philippe Lang 1653735758 Deprecated Issue#move_to_project.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8539 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-07 18:02:02 +00:00
Jean-Philippe Lang 6539d04622 Check permission before retrieving projects.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8532 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-07 12:39:26 +00:00
Jean-Philippe Lang 81cf6b2343 Allows project to be changed from the regular issue update action (#4769, #9803).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8531 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-07 12:34:52 +00:00
Jean-Philippe Lang 6d974eb018 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8527 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-06 20:46:45 +00:00
Jean-Philippe Lang f3a2c8d7f7 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8526 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-06 20:34:42 +00:00
Jean-Philippe Lang ca1958972e Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8525 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-06 20:06:25 +00:00
Jean-Philippe Lang b3c678da87 Extracted some code from #move_to_project to a callback.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8524 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-06 19:50:02 +00:00
Toshi MARUYAMA 206c7eca78 remove duplicate "private" from MailHandler model
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8522 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-06 07:48:03 +00:00
Toshi MARUYAMA 16cb0ce1c9 remove redundant "email" parameter from MailHandler#create_user_from_email
"email" is defined as attr_reader.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8521 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-06 07:47:38 +00:00
Toshi MARUYAMA f01dc24877 Rails3: replace deprecated Errors#on to Errors#[] at app/models/mail_handler.rb
On Rails2, Errors#[] returns single error if one error raises.
But, on Rails3, Errors#[] always returns the array.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8520 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-05 14:47:35 +00:00
Toshi MARUYAMA 0bd651330b code layout clean up app/models/news.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8513 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-05 03:46:19 +00:00
Jean-Philippe Lang bbe1ff3ec9 Faster query.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-03 18:10:03 +00:00
Toshi MARUYAMA 2ab7dba964 Rails3: model: mailer: use .to_s at redmine_headers method
On Rails 3.0:
<pre>
DEPRECATION WARNING: Using a non-String object for a header's value is deprecated.
You specified 15 (a Fixnum) for X-Redmine-Issue-Id.
</pre>

On Rails 3.1.3:
<pre>
Error:
test_message_posted_message_id(MailerTest):
NoMethodError: undefined method `index' for 1:Fixnum
    test/unit/mailer_test.rb:226:in `test_message_posted_message_id'
</pre>

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8468 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-02 09:35:50 +00:00
Jean-Philippe Lang 1f6764e2af Rails3 compat.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8459 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-01 17:58:14 +00:00
Jean-Philippe Lang cd256fe89f Order is already defined on attachments association.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8458 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-01 17:35:34 +00:00
Jean-Philippe Lang 852dee37ec Do not add errors on attributes on fake attributes.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8388 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-26 13:34:50 +00:00
Jean-Philippe Lang a03432cbe6 Rails3 compatibility.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8383 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-26 12:22:03 +00:00
Jean-Philippe Lang b20598d755 Use :joins instead of :include in calculations.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8382 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-26 12:07:07 +00:00
Jean-Philippe Lang 20ead6d8f7 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8345 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-24 09:53:10 +00:00
Jean-Philippe Lang 8f23043851 Dup attributes instead of issue object.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8344 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-24 09:51:26 +00:00
Toshi MARUYAMA 16e8818d9e remove trailing white-spaces from app/models/user.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8296 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-19 04:41:13 +00:00
Jean-Philippe Lang f5987a5ca0 Use validation callback.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8293 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 15:48:06 +00:00
Jean-Philippe Lang 14ea087edc Removed unused scope.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8292 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 15:04:34 +00:00
Jean-Philippe Lang b7ceb3c333 Removed unused scope.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8291 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 15:04:08 +00:00
Jean-Philippe Lang b8ce888d98 Use scoped method instead of merge_conditions.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8290 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 15:02:46 +00:00
Jean-Philippe Lang 9e83ee2ddf Removed after_initialize methods.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8288 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 14:57:58 +00:00
Jean-Philippe Lang 062fbeae80 Makes models #initialize accept additional arguments.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8287 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 13:26:20 +00:00
Jean-Philippe Lang 5eed64b848 human_attribute_name accepts optional argument.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8286 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 13:20:19 +00:00
Jean-Philippe Lang 2a0257e8af Use open scope in version issues count methods.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8285 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 13:05:46 +00:00
Jean-Philippe Lang 3717ff34af Rails3.1 compatibility
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8275 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 08:21:29 +00:00
Toshi MARUYAMA a36904c9ee use same human_attribute_name logic with SCM models at group model (#9795)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8237 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-15 13:07:32 +00:00
Jean-Philippe Lang 4f5e7d678e Fixed: Unrelated error message when creating a group with an invalid name (#9795).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8231 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-15 11:13:36 +00:00
Jean-Philippe Lang b6e6f557f0 Display issue form fields according to permissions.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8227 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-15 10:41:49 +00:00
Jean-Philippe Lang 7c00a4a11f Restores migration broken by r8182 and removes default scope on Role (#9800).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8213 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-14 22:24:20 +00:00
Etienne Massip 7d2298f39c Save an @Issue#save@.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8212 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-14 20:31:34 +00:00
Jean-Philippe Lang cd0113a287 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-13 19:56:33 +00:00
Jean-Philippe Lang e1f885feda Use safe_attributes for issue watchers assignment.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8197 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-13 19:50:44 +00:00
Toshi MARUYAMA f1994ea9c0 Rails3: model: replace deprecated before_validation method at CustomField model
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8191 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-11 12:04:54 +00:00
Jean-Philippe Lang 0471de41ff Resourcified enumerations.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8189 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-11 10:26:12 +00:00
Jean-Philippe Lang 805c65f55d Extracted new_subclass_instance method to a module.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8183 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-10 19:18:06 +00:00
Jean-Philippe Lang 532a76f78c Resourcified roles.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8145 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-09 23:29:58 +00:00
Jean-Philippe Lang b127f9157d Resourcified custom fields.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8144 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-09 22:58:30 +00:00
Toshi MARUYAMA 312ffe43c7 Rails3: model: user: use ::Query instead of Query
Test fails on Rails 3.0.

<pre>
Error:
test_destroy_should_update_wiki_contents(UserTest):
NoMethodError: undefined method `delete_all' for ActiveRecord::AttributeMethods::Query:Module
    app/models/user.rb:602:in `remove_references_before_destroy'
    test/unit/user_test.rb:298:in `test_destroy_should_update_wiki_contents'
</pre>

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8140 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-09 12:08:58 +00:00
Jean-Philippe Lang 42d2bf0baf Makes project and tracker assigned first in #attributes=
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8131 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-08 20:37:12 +00:00
Jean-Philippe Lang 3976e2d15d Tests broken with ruby1.8.6 (#9751).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8128 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-08 18:50:15 +00:00
Toshi MARUYAMA aa127ebd4e Rails3: model: Member: add virtual attribute to prevent error
On Rails 3.0, test fails with following error.

<pre>
Error:
test_validate(MemberTest):
NoMethodError: undefined method `role' for #<Member:0x7f73caf8cd08>
    app/models/member.rb:87:in `validate_role'
    test/unit/member_test.rb:76:in `test_validate'
</pre>

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8127 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-08 15:12:02 +00:00
Toshi MARUYAMA 15bb2fefa4 back out r8124
r8124 shows ":roles can't be empty".

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8125 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-08 13:37:27 +00:00
Toshi MARUYAMA d9699adce5 Rails3: model: Member: errors must be set on existing attributes
On Rails 3.0, test fails with following error.

<pre>
Error:
test_validate(MemberTest):
NoMethodError: undefined method `role' for #<Member:0x7f73caf8cd08>
    app/models/member.rb:87:in `validate_role'
    test/unit/member_test.rb:76:in `test_validate'
</pre>

Contributed by Sylvain Utard.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8124 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-08 11:13:24 +00:00
Jean-Philippe Lang 5ca558f191 Fixed: error when filtering by numeric custom field with postgresql (#9719).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8098 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-05 20:45:45 +00:00
Jean-Philippe Lang afbdc51e01 Removed ARCondition.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8089 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 23:44:59 +00:00
Jean-Philippe Lang 0a92e382fa Use scopes instead of ARCondition.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8087 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 23:36:47 +00:00
Jean-Philippe Lang 1050993348 Removed unnecessary calculations in time entries index.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8085 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 23:01:42 +00:00
Jean-Philippe Lang 9e5ed4208b Adds named scopes for time entries index.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8084 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 22:49:46 +00:00
Jean-Philippe Lang ff0f141126 Adds named scopes for projects index.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8082 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 22:31:02 +00:00
Jean-Philippe Lang f52410be19 Adds named scopes for users index.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8081 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 22:24:33 +00:00
Jean-Philippe Lang 68149f8c73 Fixes spent time column sort for postgresql.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8077 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 19:13:09 +00:00
Jean-Philippe Lang 6d498a3c46 Makes spent time column available on the issue list (#971).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8073 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 16:43:32 +00:00
Toshi MARUYAMA bddd19c1e6 Rails3: model: replace deprecated validate method at watcher model
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8072 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 09:45:18 +00:00
Toshi MARUYAMA 32ed138c53 Rails3: model: replace deprecated before_save method at UserPreference model
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8070 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 06:44:39 +00:00
Toshi MARUYAMA 1de2c1c2af Rails3: model: replace deprecated validate method at member_role model
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8068 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 05:21:20 +00:00
Toshi MARUYAMA 997995397e Rails3: model: replace deprecated before_destroy method at member model
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8058 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-03 16:41:23 +00:00
Toshi MARUYAMA 23fd43374d Rails3: model: replace deprecated validate method at member model
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8047 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-03 14:33:49 +00:00
Jean-Philippe Lang 040cfa4ad5 Makes the link in an issue update notification point to the change (#9690).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8030 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-02 21:00:42 +00:00
Jean-Philippe Lang d92c204ed3 Fixed: version files in Files module cannot be downloaded if issue tracking is disabled (#9055).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7984 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-29 19:36:49 +00:00
Jean-Philippe Lang b8836d89b1 Removed deprecated methods.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-29 18:11:11 +00:00
Jean-Philippe Lang b8a924e4e1 Adds #current_version? method to wiki content.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7972 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-28 20:12:03 +00:00
Jean-Philippe Lang 6076db74f1 Improved user creation from incoming email.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7952 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-27 15:27:14 +00:00
Jean-Philippe Lang 5a1fcf826f Sort the issue list by author/assignee according to user display format (#9669).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7938 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-26 17:37:20 +00:00
Toshi MARUYAMA 1dab1cd5cc Ruby 1.9: fix encoding error on wiki diffs (#4050)
WikiDiff#to_html returns a string with ASCII encoding if
the WikiJournal content has been Zlib compressed because
Zlib::Inflate.inflate returns strings with ASCII encoding.
Forcing the encoding to be UTF8 fixes this bug.

Contributed by Moritz Breit.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7927 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-25 23:15:55 +00:00
Jean-Philippe Lang 6dab391932 Use user's time zone when logging time while editing ticket (#9619).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7918 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-24 20:39:24 +00:00
Jean-Philippe Lang 902b3078d5 Limit the characters stripped by Attachment#sanitize_filename (#4324).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7917 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-24 20:17:56 +00:00
Toshi MARUYAMA 564321b2d5 move logic to use latest image file attachment to class method for common use (#3261)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7908 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-24 05:31:29 +00:00
Jean-Philippe Lang 3adc1c3192 Prevent clash with Rails 3 Query module.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7899 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-23 19:02:50 +00:00
Jean-Philippe Lang 3d23c42fc0 Do not use .merge_conditions.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7898 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-23 19:00:54 +00:00
Jean-Philippe Lang 2081730f42 Do not use instance variable.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7897 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-23 18:32:21 +00:00
Toshi MARUYAMA 9be9c5f565 fix inconsistent image filename extensions (#9638)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7891 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-23 05:30:53 +00:00
Jean-Philippe Lang 34c73c7573 REST API for issue categories (#9553).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7882 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-20 17:09:01 +00:00
Jean-Philippe Lang e4cda67cf4 Fixed: Issue filter by assigned_to_role is not project specific (#9540).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7847 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-11-19 15:11:20 +00:00