Commit Graph

4055 Commits

Author SHA1 Message Date
Jean-Philippe Lang dbda62849d Removed dead code.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9176 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-10 18:20:07 +00:00
Etienne Massip 8612fa2fc1 Fixed Gantt months/weeks/days headers display with Ruby 1.9.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9175 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-10 15:10:32 +00:00
Jean-Philippe Lang 125f5e1710 Use #find_project_by_project_id from super-class.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9172 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-10 13:44:52 +00:00
Jean-Philippe Lang 036b81abfd Use #find_project_by_project_id from super-class.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9160 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 20:03:05 +00:00
Toshi MARUYAMA 0cbbb9fda8 remove trailing white-space from app/models/repository/git.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9145 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 07:56:30 +00:00
Toshi MARUYAMA 999a4ba30d scm: git: performance improvements in fetching revisions (#8857, #9472)
Parse a revision for a given branch,
just if we haven't parsed it for any branches before.
Moved the db check to for existing revisions into a grouped search.
Search for many revisions at once: this reduces db load.
Revisions are grouped into sets of 100.
This is to improve memory consumption.
There will be just one query instead of each 100.
The above two methods significantly increase parsing speed.
Test case was a git repo with 6000+ commits on a master branch,
and several other branches originating for master.
Speed improved from 1.4h to 18min.

Contributed by Gergely Fábián.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9144 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 07:56:15 +00:00
Toshi MARUYAMA bcba955456 scm: git: reduce saving heads times in fetching revisions (#8857, #9472)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9143 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 05:57:59 +00:00
Toshi MARUYAMA f0987e4b8f scm: git: backout r8839 (#8857)
call "git log" only once instead of per branch in fetching revisions.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9142 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 05:57:44 +00:00
Toshi MARUYAMA 374c2aa705 scm: git: backout r8840 (#8857, #9472)
reduce saving heads times in fetching revisions.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9141 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 05:57:29 +00:00
Jean-Philippe Lang 2bcf9f2871 Prevent mass-assignment when adding/updating a forum (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9140 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 21:36:28 +00:00
Jean-Philippe Lang 87356648f6 Set user_id as a protected attribute (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9139 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 20:57:33 +00:00
Jean-Philippe Lang efddab48be Prevent mass-assignment when adding/updating a wiki (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9138 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 20:34:38 +00:00
Jean-Philippe Lang fef2e4b672 Prevent mass-assignment when adding/updating a version (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9137 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 20:31:45 +00:00
Jean-Philippe Lang 1ec2d98c14 Prevent mass-assignment when adding/updating a time entry (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9136 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 20:23:00 +00:00
Jean-Philippe Lang 0ee1de5686 Use safe_attributes= just like in #create.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9135 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 19:52:10 +00:00
Jean-Philippe Lang d0356fe935 Prevent mass-assignment when adding/updating a news (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9134 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 19:50:10 +00:00
Jean-Philippe Lang 286bda14f1 Prevent mass-assignment when adding/updating a forum message (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9133 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 19:46:59 +00:00
Jean-Philippe Lang 2c6ad7525a Prevent mass-assignment when adding a project member (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9132 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 19:39:37 +00:00
Jean-Philippe Lang 460239d1f9 Prevent mass-assignment when adding/updating an issue category (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9131 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 18:59:32 +00:00
Jean-Philippe Lang 809d35d34b Prevent mass-assignment when adding/updating a document (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9130 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 18:54:41 +00:00
Jean-Philippe Lang bdf6e90f05 Prevent mass-assignment when adding a news comment (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9129 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 18:48:47 +00:00
Jean-Philippe Lang 6aad82e524 Fixed that the proposed users list may be empty when adding a project member (#10374).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9128 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 18:37:30 +00:00
Jean-Philippe Lang 6b47cad8ce Cleanup in TimelogController#destroy.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9095 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 15:24:14 +00:00
Jean-Philippe Lang dc50edae5e Adds a template for API error messages so that it does not depend on AR::Errors serialization.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9094 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 15:16:50 +00:00
Jean-Philippe Lang d862843c9d Renamed Mailer#test to Mailer#test_email.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9080 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 12:38:34 +00:00
Jean-Philippe Lang 60b0a6c4b8 Removed sort order on issues association.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9075 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 11:53:15 +00:00
Jean-Philippe Lang bf05656c36 Rails 3.1 compatibility.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9074 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 11:45:15 +00:00
Jean-Philippe Lang 64d843a4d7 Rails 3.1 compatibility.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9073 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 11:41:10 +00:00
Jean-Philippe Lang af75583b23 Adds Redmine::Utils.random_hex for generating a random hex string.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9071 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 11:05:02 +00:00
Jean-Philippe Lang 70ced2f2af Rails 3.1 compatibility.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9067 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 10:44:59 +00:00
Jean-Philippe Lang c7b1a42d19 Adds Redmine::Plugin.public_directory to be used instead of Engines.public_directory.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9065 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 10:29:47 +00:00
Jean-Philippe Lang b3866b05c1 Removes all #verify calls in controllers. Verification is handled at routing level now that the default route is removed.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9061 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-03 15:09:20 +00:00
Jean-Philippe Lang 9c4014f446 Use a single query to retrieve issues on the roadmap.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9057 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-02 16:27:14 +00:00
Jean-Philippe Lang 1c0988cad3 Use a single query to retrieve issues_count, open_issues_count and closed_issues_count.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9056 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-02 16:26:06 +00:00
Jean-Philippe Lang fe481453c4 Use #issues_count which is already retrieved.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9055 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-02 16:23:10 +00:00
Jean-Philippe Lang 9ffccf5304 Adds functional test for #test_connection.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9053 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-02 11:31:44 +00:00
Jean-Philippe Lang 7448e0dbc4 Fixed that the bulk edit/copy form does not propose versions and categories for the target project (#10350).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9046 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-01 20:22:08 +00:00
Jean-Philippe Lang 60741b3e1c Adds an optional LDAP filter (#1060).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9044 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-01 16:26:10 +00:00
Jean-Philippe Lang ab46c52d4a MailHandler: fixed that sender's fullname is not unquoted (#10334).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9043 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-01 15:32:34 +00:00
Jean-Philippe Lang e1d1a3a0c2 Fixes r9029.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9030 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-28 06:27:23 +00:00
Jean-Philippe Lang df3c2466f8 Implements the behaviour expected in user_test.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9029 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-28 05:46:33 +00:00
Jean-Philippe Lang e6b9ddad18 Mailer#url_for not called in views with Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9023 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-27 20:43:25 +00:00
Etienne Massip 7056649a4b Override @#url_for@ in AM to force generation of absolute links (#10251).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9022 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-27 18:42:03 +00:00
Jean-Philippe Lang 0d2a22f37a Use controller_name and action_name instead of params.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9018 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 19:20:37 +00:00
Jean-Philippe Lang 7c568cccaf Adds a helper for displaying validation error messages.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9017 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 18:07:13 +00:00
Jean-Philippe Lang ad2036aaba Rails 3.1 compatibility (order declared on association takes precedence).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9015 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 13:05:19 +00:00
Jean-Philippe Lang 65b4d8a649 Make sure that projects_to_search is a Project Array.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 11:42:29 +00:00
Toshi MARUYAMA 3363e4f790 remove trailing white-spaces from app/models/attachment.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9012 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 10:16:09 +00:00
Toshi MARUYAMA aa0935c13b Rails3: html_safe for project_tree_options_for_select method in application helper
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 07:10:54 +00:00
Jean-Philippe Lang b6742bda3d Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9002 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 13:04:34 +00:00