Toshi MARUYAMA
9abdbd423d
prevent issue tree hierarchy is broken in race conditions ( #6579 )
...
awesome_nested_set 2.1.6 uses lock.
Issue model uses as same way.
git-svn-id: http://svn.redmine.org/redmine/branches/2.5-stable@12925 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-02-25 06:49:53 +00:00
Jean-Philippe Lang
066e9b7f94
Merged r12912 and r12913 from trunk.
...
git-svn-id: http://svn.redmine.org/redmine/branches/2.5-stable@12921 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-02-23 08:14:59 +00:00
Toshi MARUYAMA
a0baf7ee5d
fix wrong issue 'assigned-to-my-group' css class ( #16038 )
...
git-svn-id: http://svn.redmine.org/redmine/trunk@12844 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-02-06 12:16:27 +00:00
Jean-Philippe Lang
888823a449
Fixed calculation of done_ratio of parent task with child having estimated_time at 0 ( #15870 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@12745 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-31 17:42:46 +00:00
Jean-Philippe Lang
d5a9af54fa
Reverts r12669 and add a test for #15870 .
...
git-svn-id: http://svn.redmine.org/redmine/trunk@12739 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-30 22:18:07 +00:00
Toshi MARUYAMA
35cc911192
update copyright year ( #15977 )
...
Contributed by Daniel Felix.
git-svn-id: http://svn.redmine.org/redmine/trunk@12736 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-29 22:45:39 +00:00
Toshi MARUYAMA
a711cbb44e
back out from r12715 to r12720: #connection replacing
...
These revisions have performance regression on Rails 3.2.16.
git-svn-id: http://svn.redmine.org/redmine/trunk@12735 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-27 07:21:47 +00:00
Toshi MARUYAMA
0daa1a1a4f
Rails4: replace deprecated #connection from Issue model
...
DEPRECATION WARNING: #connection is deprecated in favour of accessing it via the class.
git-svn-id: http://svn.redmine.org/redmine/trunk@12715 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-27 01:06:58 +00:00
Jean-Philippe Lang
6f1cda4852
Make sure that we don't set the done ratio to a value > 100% ( #15870 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@12669 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-19 08:35:59 +00:00
Toshi MARUYAMA
56a3c1ad40
Rails4: replace deprecated Relation#sum with finder options at Issue#total_spent_hours
...
git-svn-id: http://svn.redmine.org/redmine/trunk@12588 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-10 05:02:44 +00:00
Toshi MARUYAMA
5feb02c31d
Rails4: replace deprecated Relation#calculate with finder options at Issue model
...
git-svn-id: http://svn.redmine.org/redmine/trunk@12537 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-08 14:53:29 +00:00
Toshi MARUYAMA
8aa22a05f4
Rails4: replace deprecated Relation#update_all at Issue model
...
git-svn-id: http://svn.redmine.org/redmine/trunk@12532 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-08 12:20:52 +00:00
Toshi MARUYAMA
599ac20570
Rails4: replace deprecated Relation#update_all at Issue model
...
git-svn-id: http://svn.redmine.org/redmine/trunk@12528 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-08 10:27:37 +00:00
Jean-Philippe Lang
5c5ba0c61a
Fixed that time entries custom values are not deleted when deleting a project or an issue ( #15709 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@12421 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-18 18:39:09 +00:00
Jean-Philippe Lang
0ee2af4c06
Fixed that previous assignee is not notified on issue update ( #15714 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@12419 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-17 20:48:18 +00:00
Toshi MARUYAMA
16b94e126b
code format cleanup app/models/issue.rb
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12230 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-24 05:40:21 +00:00
Jean-Philippe Lang
99bf8c95ab
Fixed that issue nested set update is triggered even if parent is not changed ( #15135 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12226 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-20 09:25:14 +00:00
Jean-Philippe Lang
94e7df78ca
Fixed that controller_issues_edit_before/after_save hooks have no controller context ( #15044 ).
...
Patch by Jordan Hollinger.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12219 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-13 10:31:04 +00:00
Jean-Philippe Lang
62b66e9b38
Prevents invalid SQL with invalid group_ids ( #14902 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12162 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-09-25 17:35:59 +00:00
Jean-Philippe Lang
cb747a34ef
Wrong done_ratio calculation for parent with subtask having estimated_hours=0 ().
...
Patch by Daniel Felix.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12131 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-09-11 22:00:18 +00:00
Toshi MARUYAMA
ae2b47afd6
code format cleanup app/models/issue.rb
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12087 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-08-06 06:27:16 +00:00
Jean-Philippe Lang
474453d2b0
Additional status transitions for assignees do not work if assigned to a group ( #14447 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12056 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-28 14:58:06 +00:00
Jean-Philippe Lang
205eda8b33
Use AR callbacks instead of observers (removed in Rails4) for notifications.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12021 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-14 14:26:27 +00:00
Jean-Philippe Lang
594589e0ec
Use Hash#reject that returns a Hash with ruby1.8 when Hash#select that returns an Array.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12016 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-13 10:39:36 +00:00
Jean-Philippe Lang
628d05629b
Role-based issue custom field visibility ( #5037 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12012 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-13 09:20:11 +00:00
Jean-Philippe Lang
80b1a73ccf
Adds 'assigned-to-my-group' css class to issues that are assigned to a user's group ( #12681 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12006 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-11 19:35:40 +00:00
Jean-Philippe Lang
f9ddb562d5
Cleanup of finders with :conditions option.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11963 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-12 19:13:25 +00:00
Jean-Philippe Lang
32464f4912
Perf: don't load all projects.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11956 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-11 16:54:48 +00:00
Jean-Philippe Lang
8cea7d8cf2
Don't validate start date when updating an issue without changing it ( #14086 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11931 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-05 19:56:59 +00:00
Jean-Philippe Lang
46085644ed
Adds a specific error message for when the start date is too earlier than the minimum start date ( #14086 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11926 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-04 17:17:48 +00:00
Jean-Philippe Lang
76a3298306
Issue#children is never nil ( #14015 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11833 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-12 08:49:54 +00:00
Jean-Philippe Lang
922acdbcc2
Check inclusion only once ( #14015 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11832 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-12 08:45:40 +00:00
Jean-Philippe Lang
a7102db8c4
Replaces camelcase variable names ( #14015 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11831 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-12 08:42:41 +00:00
Jean-Philippe Lang
a2b6088772
Removes some empty lines ( #14015 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11830 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-12 08:41:21 +00:00
Jean-Philippe Lang
cf30a68312
Removes then's ( #14015 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11829 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-12 08:39:18 +00:00
Jean-Philippe Lang
8c9bba1cbf
Replaces camelcase variable names ( #14015 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11828 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-12 08:37:54 +00:00
Jean-Philippe Lang
78dc37d8af
Improved Issue#all_dependent_issues ( #14015 ).
...
Patch by Jost Baron.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11827 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-12 08:33:21 +00:00
Jean-Philippe Lang
ed5b14884c
Fixed that r11641 prevents precedes/follows relations between subtasks ( #13586 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11692 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-26 21:31:29 +00:00
Jean-Philippe Lang
24e99f8b22
Code cleanup.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11642 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-17 15:17:48 +00:00
Jean-Philippe Lang
38b3e045cf
Fixed: Circular loop when using relations and subtasks ( #8794 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11641 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-17 15:02:57 +00:00
Jean-Philippe Lang
b1afd75620
Fixed: subtasks don't resepect following/precedes relations on creation ( #12968 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11640 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-17 13:46:20 +00:00
Jean-Philippe Lang
caf61dc923
Fixed that copying an issue as a child of itself creates an extra issue ( #13328 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11513 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-01 12:26:06 +00:00
Jean-Philippe Lang
a140a03a35
Adds "tracker-[id]" CSS class to issues ( #13309 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11509 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-01 10:42:05 +00:00
Jean-Philippe Lang
5c1e1ee4bb
Fixed that #reload raises a Stack too deep error with ruby 2.0.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11497 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-28 18:47:25 +00:00
Jean-Philippe Lang
f544dd682b
Code cleanup.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11496 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-28 17:52:29 +00:00
Jean-Philippe Lang
5bf647f290
Don't reload the issue in after_save callback.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11495 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-28 17:47:58 +00:00
Jean-Philippe Lang
8e17c2aeac
Fixed that relations may not be refreshed when adding a follows relation ( #13251 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11461 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-24 09:59:45 +00:00
Toshi MARUYAMA
e79b232a02
replace tabs to spaces at app/models/issue.rb
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11422 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-17 10:17:10 +00:00
Jean-Philippe Lang
7b7427b46e
Adds Issue#status_was that returns the initial issue status.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11412 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-17 09:30:17 +00:00
Jean-Philippe Lang
a45c0dc550
Adds closed_on column that stores the time of the last closing ( #824 ).
...
The value is preserved when reopening the issue.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11402 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-16 09:38:01 +00:00