Commit Graph

4743 Commits

Author SHA1 Message Date
Jean-Philippe Lang 8b23d41cf9 Test failure.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11224 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-20 15:09:57 +00:00
Jean-Philippe Lang 5741d007f6 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11222 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-20 13:57:29 +00:00
Jean-Philippe Lang e355a55e3c Don't use && return.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11221 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-20 13:54:42 +00:00
Jean-Philippe Lang b07a27b028 Don't use && return.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11220 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-20 13:53:26 +00:00
Jean-Philippe Lang 92b92d6bb8 Safer find_by_ call.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11219 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-20 13:50:51 +00:00
Jean-Philippe Lang 22f9b8846b Plugin settings div should perhaps have 'settings' CSS class (#12910).
Patch by Harry Garrood.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11217 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-20 13:05:23 +00:00
Jean-Philippe Lang bb31402939 Fix 500 error for requests to the settings path for non-configurable plugins (#12911).
Path by Harry Garrood.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11216 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-20 13:03:55 +00:00
Jean-Philippe Lang 253197c598 Changed fieldset legend and make it hidden by default like on the issue list (#12122).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11215 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-20 12:55:09 +00:00
Jean-Philippe Lang 8b91a2bb30 Removed duplicate HTML element id (#12122).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11211 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-20 12:31:17 +00:00
Jean-Philippe Lang 237f297f03 Gantt progress lines (#12122).
Patch by Toshi MARUYAMA.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11210 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-20 12:30:40 +00:00
Jean-Philippe Lang 48fb02e383 Split "Manage documents" permission into create, edit and delete permissions (#12401).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11206 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-20 11:38:20 +00:00
Jean-Philippe Lang 1257f1960f Adds pagination to users list when adding project or group members (#9549).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11200 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-18 17:57:16 +00:00
Jean-Philippe Lang 93e0885b64 Link to attachment should return latest attachment (#7510).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11196 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-15 21:08:27 +00:00
Jean-Philippe Lang 1386c10074 Use helper.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11190 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-14 21:13:09 +00:00
Jean-Philippe Lang 2230c11baa Use named route with attachment filename for inline images.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11189 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-14 21:03:53 +00:00
Jean-Philippe Lang 6ce28450c0 Adds a named route for thumbnails and use route helper in #thumbnail_tag.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11188 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-14 20:51:49 +00:00
Jean-Philippe Lang 4ebdcf13db Add named routes for attachments and use route helpers in #link_to_attachment.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11187 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-14 20:44:48 +00:00
Jean-Philippe Lang f607a7a023 Use route helper in #link_to_message.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11186 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-14 19:22:09 +00:00
Jean-Philippe Lang b41b738aa4 Removed deprecated call from examples.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11185 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-14 19:18:52 +00:00
Jean-Philippe Lang 1da158edcf Use route helper in #link_to_project.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11184 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-14 19:16:29 +00:00
Jean-Philippe Lang 9a80e118b9 Add links to projects in Group projects list (#12843).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11183 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-14 17:40:51 +00:00
Jean-Philippe Lang e224d50408 Removed useless require 'iconv' (#12787).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11176 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 20:36:22 +00:00
Jean-Philippe Lang e18d0e268d Makes issue custom fields available as timelog columns (#1766).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11174 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 13:09:06 +00:00
Jean-Philippe Lang 14b09361e4 Adds issue custom fields to time entries filters (#10191).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11171 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 12:38:45 +00:00
Jean-Philippe Lang e396a0eebe Copyright for 2013 (#12788).
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11169 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 09:29:31 +00:00
Jean-Philippe Lang bf2fb5d535 Adds a message about disabling multiple values on custom field form (#12251).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11168 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 09:27:03 +00:00
Jean-Philippe Lang 5c1039a69e Ability to uncheck "Multiple values" for existing custom fields (#12251).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11167 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 09:12:09 +00:00
Jean-Philippe Lang 18061b641f Code cleanup (#12801).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11158 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-10 21:40:04 +00:00
Jean-Philippe Lang d0ffc0575a Fixed that viewing the history of a wiki page with attachments raises an error (#12801).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11157 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-10 21:38:11 +00:00
Jean-Philippe Lang 9394d739b1 Deprecation warnings (#12774).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11139 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-08 20:18:12 +00:00
Jean-Philippe Lang 8ee0b52d59 Gantt perf: fixed that Project#start_date and #due_date run way too much queries.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11135 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-06 14:03:49 +00:00
Jean-Philippe Lang 062b003deb Generate project identifier automatically with JavaScript (#9225).
Based on Jan Schulz-Hofen's patch.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11129 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-06 11:41:37 +00:00
Toshi MARUYAMA 4bc2805c4a remove trailing white-spaces from app/models/mail_handler.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11127 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-06 09:32:42 +00:00
Jean-Philippe Lang 45c93340b7 Negative estimated hours should not be valid (#12735).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11125 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-05 16:34:41 +00:00
Jean-Philippe Lang 3e14c3017c Adds a custom validator for dates (#12736).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11124 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-05 16:09:15 +00:00
Jean-Philippe Lang 7c2490c6fc Login link unexpected logs you out (#12611).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11122 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-05 13:53:18 +00:00
Jean-Philippe Lang d56f916a0e Store the other issue in a variable (#10916).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11121 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-05 13:23:33 +00:00
Jean-Philippe Lang 601148c5b1 Show precedes/follows and blocks/blocked relations on the Gantt diagram (#3436).
Based on Toshi MARUYAMA's patch.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11118 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-05 12:28:34 +00:00
Jean-Philippe Lang 9adb0c61a9 Make sure that dates are stored as YYYY-MM-DD in journal details (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11117 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 15:38:52 +00:00
Jean-Philippe Lang 9a66463ff8 Prevent sqlserver adapter from breaking the sub-query (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11116 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 10:08:29 +00:00
Jean-Philippe Lang a8083fb9a8 Pass the order option as an array to satisfy sqlserver adapter (#12713).
Unlike other adapters, the sqlserver adapter processes the order option and wipes it when using functions.
Here we can see a "ASC" inserted in the COALESCE call:

irb(main):001:0> Issue.order("coalesce(estimated_hours, 0), id").to_sql
=> "SELECT [issues].* FROM [issues] ORDER BY coalesce(estimated_hours ASC, 0) ASC, id ASC"

This does not happen when passing the order SQL fragments separately.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11115 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 10:04:25 +00:00
Jean-Philippe Lang 9613a13b10 Deprecates Version#*_pourcent in favour of #*_percent (#12724).
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11113 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 08:30:25 +00:00
Toshi MARUYAMA 3bf6f8d7ff remove trailing white-space from app/controllers/wiki_controller.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11110 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-04 01:11:33 +00:00
Jean-Philippe Lang 24ec41f7d4 A column has been specified more than once in the order by list (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11106 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 13:40:50 +00:00
Jean-Philippe Lang 503933c585 Don't do any query if id is not present.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11105 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 13:39:04 +00:00
Jean-Philippe Lang 77f6b404fa Make sure we don't cast an empty string to numeric (#12713).
SQLServer evaluates the CAST condition even if the <> '' condition is false.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11103 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 13:33:16 +00:00
Jean-Philippe Lang d82159bcf5 Use joins instead of sub-queries in group by/sort by when using custom fields (#12713).
Sub-queries in group by are not supported by SQLServer.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11102 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 12:28:50 +00:00
Jean-Philippe Lang 049eaeb776 Repository changesets are already sorted by committed_on DESC (#12713).
SQLServer raises an error because committed_on is specified twice in the order by list.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11101 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:40:39 +00:00
Jean-Philippe Lang 8b08c1a534 Prevents position to be specified more than once in the order by list which is not supported by SQLServer (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11100 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:37:07 +00:00
Jean-Philippe Lang dd7d54b3a1 SQLServer: rule is a reserved keyword (#12713).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11099 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-03 11:21:45 +00:00