4878d749f4
Do not query git for tags and branches multiple times per request.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3467 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-20 13:35:22 +00:00
9e22faa640
Converted the REDMINE_SUPPORTED_SCM constant to a class
...
Now SCMs can be added or removed using a simple API, instead of being
hardcoded:
Redmine::Scm::Base.add('ScmName')
Redmine::Scm::Base.delete('ScmName')
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3440 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-16 22:41:59 +00:00
ea3e2b1121
Changes SubversionAdapter to use ActiveSupport::XmlMini API for XML parsing.
...
This allows easy switching to one of the faster XML parsers supported by XmlMini (eg. libxml-ruby).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3424 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-13 13:58:05 +00:00
3c20a9b0ac
Do not parse the entire git log to fetch new commits (takes several minutes for a few thousands commits), but only 1 week before the last known commit ( #4547 , #4716 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3394 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-02-07 15:17:21 +00:00
b1a92b9b2e
Fixed: Subversion password visible in development logs ( #4448 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3251 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-26 16:20:22 +00:00
22d12032e7
Reject empty Mercurial entries ( #4098 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3029 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-11-11 15:33:30 +00:00
cabf052127
Prevent undefined method `<=>' for nil:NilClass in AbstractAdapter ( #4098 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2957 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-10-24 11:08:09 +00:00
c28b044d68
Added branch and tag support to the git repository viewer. ( #1406 )
...
Many thanks to Adam Soltys and everyone else who tested this patch.
* Updated git test repository so it has a branch with some differences from the master branch
* Moved redmine diff class into a module so as not to clash with diff-lcs gem which is required by grit
* Find changesets from all branches, not just master
* Got revision browsing working
* Got file actions working properly
* Allow browsing by short form of commit identifier
* Added a method to retrieve repository branches
* Allow browsing by branch names as well as commit numbers
* Handle the case where a git repository has no master branch
* Expand revision box and handle finding revisions by first 8 characters
* Added branches dropdown to repository show page
* Combined repository browse and show into a single action. Moved branch/revision navigation into a partial.
* Renamed partial navigation -> breadcrumbs
* Made it so latest revisions list uses branch and path context
* Preserve current path when changing branch or revision
* Perform slightly more graceful error handling in the case of invalid repository URLs
* Allow branch names to contain periods
* Allow dashes in branch names
* Sort branches by name
* Adding tags dropdown
* Need to disable both branches and tags dropdowns before submitting revision form
* Support underscores in revision (branch/tag) names
* Making file history sensitive to current branch/tag/revision, adding common navigation to changes page
* Updated translation files to include labels for 'branch', 'tag', and 'view all revisions'
* Reenable fields after submit so they don't look disabled and don't stay disabled on browser back button
* Instead of dashes just use empty string for default dropdown value
* Individual entry views now sport the upgraded revision navigation
* Don't display dropdowns with no entries
* Consider all revisions when doing initial load
* Fixed bug grabbing changesets. Thanks to Bernhard Furtmueller for catching.
* Always check the entire log to find new revisions, rather than trying to go forward from the latest known one
* Added some cleverness to avoid selecting the whole changesets table any time someone views the repository root
* File copies and renames being detected properly
* Return gracefully if no revisions are found in the git log
* Applied patch from Babar Le Lapin to improve Windows compatibility
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2840 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-08-15 22:41:40 +00:00
1a9942ba99
Change subversion adapter to not cache authentication and run non interactively
...
#3424
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2819 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-07-10 03:24:46 +00:00
6a54a0c94c
Fixed: Bazaar "[merge]" tags parsing fails ( #3445 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2780 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-06-06 10:49:36 +00:00
a7ea14f5af
Prevent nil error when retrieving svn version ( #3268 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2722 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-05-10 09:49:39 +00:00
ac6ecdb360
Fixed: Mercurial integration doesn't work if redmine is installed in folder path containing space ( #3159 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2679 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-04-21 16:05:04 +00:00
ab5e07e83e
Adds a setting to limit the number of revisions displayed on a repository file log (default=100).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2350 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-01 19:54:50 +00:00
8590165238
Merged r2231 from 0.8-stable ( #2402 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2232 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-04 13:27:48 +00:00
a7a4c9f848
Fixed: deleted files should not be shown when browsing a Darcs repository ( #2385 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2189 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-27 18:33:35 +00:00
840bb53f5b
Fixed: CVS browser should not show dead revisions (deleted files) ( #2319 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2135 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-14 15:57:13 +00:00
a37f4b9cf6
Capture scm CLI stderr to log/scm.stderr.log when running in dev environment
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2128 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-12 16:07:14 +00:00
472ec31662
Fixed: CVS connexion string may not contain @.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2096 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-06 17:40:54 +00:00
e61916ea91
SubversionAdapter#entries performance improvement.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2045 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-18 18:36:47 +00:00
3fdc273252
Do not query multiple times git for branch ( #1435 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2043 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-17 17:27:08 +00:00
486ecc6661
Fixed: non-ASCII subversion path can't be displayed (patch #1993 by Chaoqun Zou).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2004 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-10 11:33:04 +00:00
6157d20ec0
Git adapter: use commit time instead of author time ( #2108 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@1999 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-09 12:07:35 +00:00
11b9ceb054
git path reverted.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@1996 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-08 17:15:18 +00:00
9352bb527b
Tells git to output dates in ISO format.
...
Fixes: Git Adapter date parsing ignores timezone (#2149 ).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@1995 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-08 15:50:51 +00:00
47475acdaf
Fixed Bazaar shared repository browsing ( #2101 , patch #1685 by Dmitry Shaposhnik).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@1994 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-08 15:28:00 +00:00
d93f96765b
Adds support for file viewing with Darcs 2.0+ (patch #1799 by Ralph Lange slightly edited).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1759 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-08-25 14:33:30 +00:00
dbf4438dda
More detailed error message in log when scm command fails ( #1682 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1757 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-08-25 12:31:53 +00:00
0d55652552
Fixes method name in AbstractAdapter.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1756 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-08-25 12:27:15 +00:00
116091a1d2
Fixes platform determination under JRuby ( #1804 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1753 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-08-25 11:01:37 +00:00
622b6121f4
Fixes nil error when svn binary version is unknown ( #1607 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1652 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-07-12 09:06:19 +00:00
29fb8db936
Adds MercurialAdapter.client_version and prevent @hg --version@ to be called on each request.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1628 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-07-05 09:39:00 +00:00
12fbd06c02
Display svn properties in the browser, svn >= 1.5.0 only ( #1581 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1627 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-07-05 08:59:04 +00:00
00593f2f34
Reduces memory usage when importing large git repositories ( #1482 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1599 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-06-29 09:41:42 +00:00
fda7bcdfb6
Mercurial adapter tests fix ( #1469 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1563 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-06-18 17:02:39 +00:00
ca6e69ec24
Fixed: view file at given revision with CVS.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-06-15 15:47:28 +00:00
40a9bbe946
CVS: add support for modules names with spaces ( #1434 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1527 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-06-14 11:42:50 +00:00
ec0525d497
Move unified diff parser out of the scm abstract adapter so it can be reused for viewing attached diffs ( #1403 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1513 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-06-08 16:28:42 +00:00
a0d1414606
Filesystem adapter: read files in binary mode.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1510 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-06-08 15:44:23 +00:00
5dea200774
Filesystem adapter: negative size is displayed for large files under win32.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1509 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-06-08 15:43:32 +00:00
e69b4647f2
Adds Filesystem adapter (patch #1393 by Paul R).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1508 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-06-08 15:40:24 +00:00
6d5db302ee
Subversion adapter: ignore directories with no commit date ( #1370 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1500 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-06-07 10:08:11 +00:00
aa9d04a4a7
Mercurial adapter improvements (patch #1199 by Pierre Paysant-Le Roux).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1499 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-06-07 09:19:50 +00:00
a5ee8f8986
Fixed: SVN errors lead to svn username/password being displayed to end users ( #1368 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1493 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-06-06 14:37:49 +00:00
891a71ad47
Fixed: new line at the end of a file is not displayed in diff.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-06-02 20:14:06 +00:00
e1a86106d0
Fixed: GitAdapter#get_rev should use current branch instead of hardwiring @master@ ( #1319 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1475 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-05-29 18:48:00 +00:00
835cc7ed7c
Fixed: Redmine::Scm::Adapters::GitAdapter#get_rev ignored GIT_BIN constant ( #1207 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1428 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-05-13 17:54:51 +00:00
a73f68a185
Fixed: Links to repository directories don't work ( #1119 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1365 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-04-27 10:12:15 +00:00
7aaa538fd9
Fixed: error when browsing an empty Mercurial repository ( #1046 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1343 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-04-12 17:13:17 +00:00
db7f890030
Mercurial: Get proper file action on revision ( #983 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1332 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-04-06 12:00:11 +00:00
154f60edd3
Fix repository browsing at given revision for various scm and add tests for this.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1329 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-04-06 10:35:55 +00:00
14a2b7e9b5
Verify rev and rev_to params format in RepositoriesController. And turn revision arguments into integers in SubversionAdapter.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1324 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-04-03 16:50:53 +00:00
472654aebe
Fixed: revision is ignored in MercurialAdapter#cat.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1288 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-03-21 22:19:37 +00:00
f162337e1b
Always show 'View' and 'Annotate' links on repository files (download will be forced when clicking 'View' if the file is binary).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1274 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-03-19 17:51:13 +00:00
451aa6ba4e
Add "--encoding utf8" option to the Mercurial "hg log" command in order to get utf8 encoded commit logs ( #834 ).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1256 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-03-15 11:05:22 +00:00
01fdaf5977
Mercurial adapter:
...
* fetch changesets by batches of 100 (rather than in a single transaction)
* fix: fetch_changesets tries to re-insert the last revision that exists in the db (#860 )
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1255 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-03-15 10:30:56 +00:00
ea161c9ea4
Prevent unexpected nil error in GitAdapter#info if the repository path is invalid.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1239 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-03-12 23:09:11 +00:00
2c1e63720e
SCM AbstractAdapter use shell_quote to more properly escape path ( closes #838 by John Goerzen).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-03-12 23:00:11 +00:00
3a9b0988c7
Merged Git support branch (r1200 to r1226).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1236 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-03-12 20:28:49 +00:00
a9c972fbb3
Quotes Mercurial entries command depending on the OS.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1229 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-03-11 20:15:05 +00:00
71d3bb2f7b
Fixes Mercurial browsing under unix-like os and for directory depth > 2 and (patch #826 by Frederic Moulins, slightly edited to preserve win32 compatibility).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1228 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-03-11 20:06:25 +00:00
53a04b0a44
Fixed: CVS repository doesn't work if port is used in the url ( #653 ).
...
Added functional tests for CVS adapter.
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1156 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-02-16 18:09:26 +00:00
91dc13f4b2
Show explicit error message when the scm command failed (eg. when svn binary is not available).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1094 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-01-23 17:25:11 +00:00
78d9ae9754
Fixed: crash when fetching Mercurial changesets if changeset[:files] is nil (same fix as r921).
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1045 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-01-06 17:33:41 +00:00
832c7eaaa5
Fixed: undefined local variable or method 'log' in CvsAdapter when a cvs command fails.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1034 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-01-03 18:28:14 +00:00
e219af1fbd
Ignore empty diffs.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1014 e93f8b46-1217-0410-a6f0-8f06a7374b81
2007-12-19 20:11:44 +00:00
ea35fff5bf
SCM adapters: moved Errno::ENOENT exception rescuing to the abstract adapter.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1001 e93f8b46-1217-0410-a6f0-8f06a7374b81
2007-12-15 12:14:40 +00:00
7fae4b0892
Bazaar adapter: fixed log with partial revisions parsing.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@962 e93f8b46-1217-0410-a6f0-8f06a7374b81
2007-12-07 17:51:54 +00:00
056e3703da
Added Bazaar adapter.
...
Fixed 'quick jump to a revision' form on the revisions list.
git-svn-id: http://redmine.rubyforge.org/svn/trunk@950 e93f8b46-1217-0410-a6f0-8f06a7374b81
2007-12-03 17:40:43 +00:00
8c65cc4712
Added Annotate/Blame view for Subversion, CVS and Mercurial repositories.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2007-12-02 20:58:02 +00:00
5e6fa147da
* Fixed: Error when displaying the issue list if a float custom field is marked as 'used as filter'
...
* Fixed: Mercurial adapter breaks on missing :files entry in changeset hash (James Britt)
* Fixed: Wrong feed URLs on the home page
git-svn-id: http://redmine.rubyforge.org/svn/trunk@921 e93f8b46-1217-0410-a6f0-8f06a7374b81
2007-11-21 18:45:18 +00:00
1469a4c8df
Fixed (CVS adapter): changes not recorded when using :pserver string.
...
Updated Russian js calendar (iGor kMeta).
git-svn-id: http://redmine.rubyforge.org/svn/trunk@907 e93f8b46-1217-0410-a6f0-8f06a7374b81
2007-11-16 21:24:22 +00:00
ecfc40629f
Quote subversion username and password in svn commands.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@852 e93f8b46-1217-0410-a6f0-8f06a7374b81
2007-10-19 17:59:59 +00:00
c2220cffcf
Added svn command output to error log when SubversionAdapter#entries parsing fails.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@780 e93f8b46-1217-0410-a6f0-8f06a7374b81
2007-09-30 17:38:07 +00:00
83eed09109
Added 2 log messages in SubversionAdapter#entries.
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@743 e93f8b46-1217-0410-a6f0-8f06a7374b81
2007-09-18 21:22:28 +00:00
889d50089d
Added syntax highlightment for repository files (using CodeRay).
...
Supported languages: c, ruby, rhtml, yaml, html, xml.
git-svn-id: http://redmine.rubyforge.org/svn/trunk@644 e93f8b46-1217-0410-a6f0-8f06a7374b81
2007-08-15 20:20:18 +00:00
05c1888703
Fix: SVN commit dates are now stored as local time
...
git-svn-id: http://redmine.rubyforge.org/svn/trunk@587 e93f8b46-1217-0410-a6f0-8f06a7374b81
2007-07-14 14:53:18 +00:00
ba1b857197
Added Darcs basic support.
...
Files in the repository can not be viewed or downloaded since Darcs doesn't support cat-like command.
git-svn-id: http://redmine.rubyforge.org/svn/trunk@573 e93f8b46-1217-0410-a6f0-8f06a7374b81
2007-06-24 19:30:38 +00:00
438161ad1f
Added basic support for CVS and Mercurial SCMs.
...
Browsing, changesets fetching and diff viewing are implemented.
Only tested with local repositories.
Thanks to Ralph Vater for CVS specific code.
git-svn-id: http://redmine.rubyforge.org/svn/trunk@559 e93f8b46-1217-0410-a6f0-8f06a7374b81
2007-06-12 20:12:05 +00:00
Jean-Philippe Lang
Eric Davis