kolan
/
Redmine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
3,576 Commits 2 Branches 91 Tags 22 MiB
Commit Graph

881 Commits

Author SHA1 Message Date
Eric Davis 80256cf298 Refactor: extract #bulk_update method from IssuesController#bulk_edit. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4037 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-24 15:27:12 +00:00
Eric Davis b67b3820a1 Refactor: move IssuesController#changes to JournalsController#index. 
Since #changes is only an Atom feed of journals of a query, it makes
more sense to have it on the JournalsController resource.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4034 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-23 15:04:36 +00:00
Eric Davis dfd1d0c7fe Refactor: merge IssuesController#update_form into IssuesController#new 
The #update_form action was only refreshing the issue attributes form,
so it's just a specialized JavaScript version of #new.  This also removed
old code that was extracted in other places (@issue.new_statuses_allowed_to).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4011 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-20 15:22:19 +00:00
Eric Davis 1fcc1bdc89 Refactor: move IssuesController#context_menu to a new controller. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4006 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-19 18:16:54 +00:00
Eric Davis 73ba49a715 Use the base layout for all 403, 404, and 500 pages. #6172 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3949 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-19 01:01:35 +00:00
Eric Davis e6e21046c0 No more IssuesController#preview action. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3947 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-18 15:03:42 +00:00
Eric Davis 1f8d396e3f Refactor: move IssuesController#preview to a new controller. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3946 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-18 15:01:35 +00:00
Eric Davis 3eff27344b Refactor: move IssuesController#auto_complete to a new controller. #4382 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3945 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-17 15:03:58 +00:00
Eric Davis e63acb70ca Add the Calendar as a project menu item. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3944 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-16 23:56:42 +00:00
Eric Davis a24f448dc0 Add the Gantt chart as a project menu item 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3943 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-16 23:56:37 +00:00
Eric Davis d2b0a51848 Allow key authentication for Boards. #6132 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3942 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-16 23:39:27 +00:00
Eric Davis 22c978ad94 Refactor: move IssuesController#reply to JournalsController 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3941 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-16 16:25:04 +00:00
Eric Davis 13fe01a185 Refactor: pull up method to ApplicationController. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3940 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-13 14:59:04 +00:00
Eric Davis f18b126fba Refactor: Pull up method to ApplicationController. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3938 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-12 13:57:51 +00:00
Eric Davis ff43bb1a74 Refactor: Extract a new IssueMovesController from IssuesController. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3936 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-11 14:42:10 +00:00
Jean-Baptiste Barth e43f9fc21e Show projects depending on their visibility in user's profile. #6100 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3935 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-10 23:07:44 +00:00
Jean-Baptiste Barth 0cfa757db0 Added a warning when a new user or group membership is invalid. #3834 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3934 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-10 22:37:00 +00:00
Eric Davis 52c624aabd Refactor: extract method from #move and #perform_move. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3932 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-10 15:11:11 +00:00
Eric Davis 424b482579 Refactor TimelogController#report's joins and provide a hook to add more. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3931 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-09 23:15:32 +00:00
Eric Davis a1b89a53eb Refactor: extract POST version of IssuesController#move to #perform_move. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3930 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-09 14:53:23 +00:00
Eric Davis 041bca6ac9 Refactor: start to split IssuesController#move into two separate actions. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3918 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-06 15:47:27 +00:00
Eric Davis e4af6e77a7 Refactor: extract method in IssuesController#move. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3917 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-05 17:43:07 +00:00
Eric Davis 8c79385261 Refactor: extract back_url method to ApplicationController. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3912 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-04 13:37:44 +00:00
Eric Davis 13234f8552 Refactor: Add methods to User to edit the encapsulate the status field. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3906 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-08-03 15:26:50 +00:00
Jean-Philippe Lang 701d2eaeac Display project names in cross-project gantt PNG (#5904). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3885 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-07-25 11:43:19 +00:00
Jean-Philippe Lang fe63eefc1f Adds missing visibility scope. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3866 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-07-25 09:29:46 +00:00
Jean-Philippe Lang a9a4e0d6b8 Moves code to controller. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3865 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-07-25 09:29:17 +00:00
Eric Davis 48a5460da4 Allow js formatted responses. 
Otherwise they return the invalid format error (406) instead of 403, 404, or 500

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3827 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-07-05 18:00:50 +00:00
Eric Davis bd1384db7d Added hook :controller_timelog_available_criterias 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3826 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-07-01 18:49:25 +00:00
Eric Davis 11ff334cd8 Refactor: extract @available_criterias to utility method. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3825 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-07-01 18:47:25 +00:00
Eric Davis 7376ef2ad7 Typecast issue ids when searched for. 
Older Postgres versions don't allow searching over the id field's max size.

Contributed by Holger Just

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3806 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 20:01:32 +00:00
Eric Davis c98f46d691 Handle unsuccessful destroys in TimelogController. #5700 
Contributed by Jan

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3805 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 19:30:51 +00:00
Eric Davis 95c3c63cfe Fix for Ruby 1.9 strings. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3798 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 16:08:15 +00:00
Eric Davis 2562bc5bcd Hide the role forms when editing or adding Project members. #5452 
Contributed by Yuki Kita

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3784 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 19:51:43 +00:00
Eric Davis 921b425b8e Accept key authentication to ProjectsController#index (for feeds). #5317 
Contributed by Greg Mefford

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3777 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 17:45:04 +00:00
Eric Davis 345301284a Added JSON support to the issues API. #1214 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3766 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-05 03:52:59 +00:00
Eric Davis f3cc84b343 Show subproject versions on the Roadmap. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3760 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-27 17:16:10 +00:00
Eric Davis 0d34c3731b Add error messages to MembersController#new so a user is informed of missing data. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3749 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-24 20:21:16 +00:00
Eric Davis 908d44519c Allow AuthSources to control if they allow password changes. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3745 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-23 03:16:37 +00:00
Eric Davis 715c9d16ef Refactor AuthSourcesController to support non-LDAP sources. #1131 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3744 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-23 03:16:31 +00:00
Jean-Philippe Lang e417d755e9 Eager load group projects to avoid N SQL queries. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3735 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-09 11:31:39 +00:00
Eric Davis 36c82ecc1f Refactor: move Project Calendar to it's own controller. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3732 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-03 16:02:37 +00:00
Eric Davis 306ca5e714 Refactor: Pull up #find_optional_project to ApplicationController. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3716 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-30 17:24:11 +00:00
Jean-Philippe Lang a4e411c643 Removes broken code in ProjectsController (#5412). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3706 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-30 11:14:57 +00:00
Jean-Philippe Lang e5180884c1 Fixes selected menu tab when issue creation fails. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3704 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-30 10:48:19 +00:00
Jean-Philippe Lang 0d938dff59 Fixed: 500 internal error when browsing any Redmine page in Epiphany (#5401). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3702 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-30 10:33:25 +00:00
Eric Davis 488879d9cf Refactor: pull #query_statement_invalid up to ApplicationController. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3696 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-29 15:19:19 +00:00
Eric Davis e65c3cfc7d Refactor: Move gantts to a separate controller. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3695 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-28 15:54:46 +00:00
Jean-Philippe Lang c18cb9451d Fixed: private subprojects names may be revealed on issue summary report (#5360). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3692 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-27 16:43:52 +00:00
Eric Davis df7edb843b Refactor: move method to helper. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3691 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-27 15:28:52 +00:00
Eric Davis dfc448030d Refactor: extract error to new method with before_filter. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3690 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-26 15:08:06 +00:00
Eric Davis 23f097e344 Refactor: Extract duplicated code to a new method. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3689 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-23 15:05:13 +00:00
Eric Davis 2c898d8a81 Refactor: Split IssuesController#new to #new and #create to match REST pattern. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3688 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-22 15:43:57 +00:00
Eric Davis bf33b57aa4 Refactor: Move method to Query model 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3684 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-19 15:08:28 +00:00
Jean-Philippe Lang 0004b52646 Fixes behaviour of move_issues permission for non member role (#5309). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3683 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-18 12:47:41 +00:00
Jean-Philippe Lang 3bf6790826 Add "Repository" menu item after repository creation (#5328). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3680 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-17 12:51:46 +00:00
Jean-Philippe Lang aa4d1fe816 Fixed: API 401 response does not include WWW-Authenticate header (#5322). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3679 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-17 12:45:23 +00:00
Jean-Philippe Lang 9ccccb9984 Do not raise an error when destroying a Version with assigned issues. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3668 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-11 17:47:29 +00:00
Jean-Philippe Lang 43e5bb75d2 Fixed: issue optimistic locking broken by r3308 (#5280). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3663 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-11 16:27:37 +00:00
Jean-Philippe Lang 5879273739 Makes the wiki sidebar editable (#5208). 
The content of the wiki page named 'Sidebar' is rendered in the sidebar if it exists. Permission to edit protected pages is required to create this page.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3632 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-11 12:56:18 +00:00
Azamat Hackimov eb80b79c26 New strings to localization (#5225) 
* error_can_not_delete_custom_field: Unable to delete custom field
* error_unable_to_connect: Unable to connect ({{value}})
* error_can_not_remove_role: This role is in use and can not be deleted.
* error_can_not_delete_tracker: This tracker contains issues and can't be deleted.


git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3627 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-03 11:54:24 +00:00
Jean-Philippe Lang 2bbc948e06 Preview description if it was edited while updating an issue (#741). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3623 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-28 15:17:46 +00:00
Jean-Philippe Lang b93cf03483 Fixes backslashes escaping when quoting issue description/note (#5129). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3616 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-27 13:33:19 +00:00
Jean-Philippe Lang 84dfff5957 Fixes permission check in QueriesController (#5181). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3611 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-24 20:25:09 +00:00
Jean-Philippe Lang 79b4f68176 Adds an option to enable/disable email notifications during a project copy (#4672). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3608 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-21 11:17:29 +00:00
Jean-Philippe Lang e584ae220d Cleans up status assignment in IssuesController#new handled by Issue#safe_attributes= now. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3606 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-20 17:37:04 +00:00
Eric Davis 6e6e260cea Refactor: Extract Query#sortable_columns from the controller. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3604 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-19 15:42:03 +00:00
Eric Davis b5d9a1dfbd Refactor: Extract method to the Member model 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3601 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-18 15:49:11 +00:00
Eric Davis 194dab8e96 Refactor: Change the different find_object filters to share a common method. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3597 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-17 15:41:58 +00:00
Eric Davis e6c8760ad7 Refactor: Split the find_object methods to prep for a larger refactoring. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3591 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-16 15:17:47 +00:00
Jean-Philippe Lang 8e3d1b694a Adds subtasking (#443) including: 
* priority, start/due dates, progress, estimate, spent time roll-up to parent issues
* descendant issues tree displayed on the issue view with context menu support
* issue tree display on the gantt chart
* issue tree copy on project copy
* unlimited nesting

Defining subtasks requires the new permission 'Manage subtasks'.
Subtasks can not belong to a different project than the parent task.

Implementation is based on scoped nested sets for fast reads and updates.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3573 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-13 14:56:49 +00:00
Jean-Philippe Lang e109c9b6b6 Do not reset session when a non logged in user request the login form (#4958). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3572 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-12 19:22:11 +00:00
Jean-Philippe Lang 63ed494f21 Adds missing flash messages on project settings (#5043). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3565 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-12 13:51:00 +00:00
Eric Davis c7c3c0cc7c Refactor: Extract method for setting the flash on bulk issue saves. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3560 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-11 16:34:08 +00:00
Jean-Philippe Lang b99d4189b7 Fixed: NoMethodError error on roadmap if no trackers are selected and a shared version is available (#5006). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3555 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-08 20:17:09 +00:00
Jean-Philippe Lang 6511e94233 Moves ProjectsController#add_issue_category to IssueCategoriesController#new. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3549 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-06 18:43:00 +00:00
Jean-Philippe Lang 729bea1cf3 Moves ProjectsController#add_version to VersionsController#new. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3548 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-06 18:25:01 +00:00
Eric Davis d65922afde Remove double negative condition 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3546 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-05 17:25:51 +00:00
Eric Davis 3f3e30c2aa Refactor: Moved the contents of #issue_update into Issue. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3545 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-05 17:11:50 +00:00
Eric Davis c58dc83e74 Refactor: Replace @journal with @issue.current_journal 
This removes an instance variable in #issue_update which will let it be moved
to the Issue model.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3540 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 16:18:51 +00:00
Eric Davis afdcd770dc Refactor: Extract method 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3538 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 05:33:54 +00:00
Eric Davis bc79caaf69 Refactor: Extract method 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3537 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 05:33:49 +00:00
Eric Davis be20d98040 Refactor: Extract methods to before_filters 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3536 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 05:33:45 +00:00
Eric Davis 3a99f18913 Refactor: Split method 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3535 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 05:33:40 +00:00
Eric Davis ca6df3d78d Refactor: Extract method 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3534 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 05:33:35 +00:00
Eric Davis 976cba0c5d Refactor: use the existing Issue#new_statuses_allowed_to method. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3533 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 00:58:52 +00:00
Eric Davis fe1e3ccd18 Refactor: Decouple failed attachments and the flash messages 
Attachment#attach_files will no longer need to return a flash message,
instead it will put unsaved attachments into object#unsaved_attachments
where the calling object can access them.

A utility method #render_attachment_warning_if_needed is included for setting
the standard flash warning.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3528 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-03 17:05:00 +00:00
Eric Davis f6d8752e44 Fixes destroying attachments if the update fails. (r2875 r3523) 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3526 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-03 17:04:50 +00:00
Jean-Philippe Lang b09a483aa9 Fixed: error while deleting an in-use enumeration (#4970). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3524 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-02 20:03:09 +00:00
Eric Davis 0fd7e2d696 Refactor: Moved ApplicationController#attach_files to the Attachment model 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3523 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-02 19:26:03 +00:00
Eric Davis f5f5a5f64f Verify issues are updated by HTTP PUT only. Regression from r3486. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3520 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-01 18:29:18 +00:00
Eric Davis 8699e5bbcd Refactor: Decouple building Issue and TimeEntry objects in #issue_update. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3519 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-01 17:40:54 +00:00
Jean-Philippe Lang c174540a0e Adds attachments upload on wiki edit form (#1223). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3500 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-28 09:43:13 +00:00
Eric Davis ddec53b9a2 Refactor: Extracted saving logic out of #update and into a utility method 
Now #issue_update can be refactored and push to the Model(s) while keeping
the public interface (#update) clean.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3497 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-26 16:16:18 +00:00
Jean-Philippe Lang bfed36ac84 Let administrators see locked user profiles. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3493 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-26 15:50:16 +00:00
Eric Davis 3de1f2e157 Refactor: Extracted the duplication from the last commit into a new method 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3487 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-25 17:01:10 +00:00
Eric Davis c68d853bf4 Refactor: Move the updating of an Issue to the #update method. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3486 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-25 17:01:05 +00:00
Eric Davis d581510af6 Refactor: Start to extract IssuesController#edit into #update (REST). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3480 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-24 17:21:41 +00:00
Jean-Philippe Lang e24d6cc223 Bulk edit refactoring. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3478 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-23 21:26:29 +00:00
Eric Davis f838904a7e Refactor: Extract Issue#bulk_edit from the IssuesController 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3475 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-23 17:06:08 +00:00
Jean-Philippe Lang 08d7c5bfb4 Adds a controller hook before issue move (#4850). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3457 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-19 19:10:50 +00:00
Jean-Philippe Lang 74e85953f0 Move SQL LIKE tokens to acts_as_searchable. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3445 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-17 20:20:51 +00:00
Jean-Philippe Lang c11d30ebc9 Makes search providers extensible (#3936). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3444 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-17 20:05:51 +00:00
Eric Davis 9e22faa640 Converted the REDMINE_SUPPORTED_SCM constant to a class 
Now SCMs can be added or removed using a simple API, instead of being
hardcoded:

  Redmine::Scm::Base.add('ScmName')
  Redmine::Scm::Base.delete('ScmName')

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3440 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-16 22:41:59 +00:00
Eric Davis 49bfee0535 Refactor: Merged TrackersController#list and #index 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3437 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-15 16:41:27 +00:00
Eric Davis c5f30fde28 Refactor: Merged AuthSourcesController#list and #index 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3436 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-15 16:41:21 +00:00
Eric Davis 038a88e970 Refactor: Merged RolesController#list and #index 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3435 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-15 16:41:16 +00:00
Eric Davis 8d086cb7d4 Removed hard coded English string. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3416 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-12 19:15:39 +00:00
Eric Davis c18f8d34fb Refactor: Merged IssueStatusesController#list and #index. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3415 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-12 19:15:33 +00:00
Jean-Philippe Lang 55a3ac764f Issue relation: fixes error with postgres when entering a non-numeric id (#4820) + accept hash (#) before id. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3413 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-12 18:35:31 +00:00
Eric Davis d2baf5f2a7 Log failed user logins to the Rails logger 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3411 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-11 18:25:38 +00:00
Eric Davis 937d0c70f7 Refactored IssueStatus finder to a before_filter 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3410 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-11 16:42:52 +00:00
Jean-Philippe Lang 1fec53cc25 Fixed: roadmap show subprojects issues even if subprojects is unchecked (#4761). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3408 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-10 21:29:31 +00:00
Eric Davis a8a49a26a1 Refactor: inline the utility methods in ReportsController. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3404 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-10 16:59:58 +00:00
Eric Davis f50feca730 Extracted the rendering from each case statement in issue_reports_details 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3401 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-09 16:47:27 +00:00
Eric Davis 597725d77c Separated ReportsController#issue_report into two separate actions. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3396 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-08 17:53:58 +00:00
Jean-Philippe Lang eac7fcff6e Fixed: error raised when trying to view the gantt or calendar with a grouped query (#4751). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3379 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-06 18:07:25 +00:00
Jean-Philippe Lang 8fb29d4d21 Adds pagination to forum messages (#4664). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3373 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-06 12:54:13 +00:00
Jean-Philippe Lang 6c8b87fbc8 Adds a permission for exporting wiki pages. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3371 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-06 09:30:53 +00:00
Eric Davis e5d300af0a Refactor: Pull up several #find_project methods to ApplicationController 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3370 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-05 16:57:02 +00:00
Jean-Philippe Lang 626b71622d Fixed: invalid format parameter returns a DoubleRenderError on issues index (#4737). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3368 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-04 19:58:42 +00:00
Jean-Philippe Lang ea51dcf911 Reverts r3366. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3367 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-04 19:57:45 +00:00
Jean-Philippe Lang cfe4d0e7db Fixed: invalid format parameter returns a DoubleRenderError on issues index (#4737). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3366 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-04 19:52:51 +00:00
Eric Davis b86b9b898e Refactor: Moved the raw SQL finders from ReportsController to Issue. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3362 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-03 16:49:21 +00:00
Jean-Philippe Lang d43c860448 Allow commits to reference issues of parent projects and subprojects (#4674). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3357 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-31 16:25:06 +00:00
Jean-Philippe Lang 1bc00ac022 Accept filters from API calls without set_filter parameter. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3335 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-18 19:53:06 +00:00
Jean-Philippe Lang 320c191f04 Fixed: PDF export of a issue list grouped by a custom field raises an error (#4600). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3333 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-18 18:00:27 +00:00
Jean-Philippe Lang 0ef9bc039d Adds a log message when an API call raises an InvalidAuthenticityToken error. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3332 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-17 20:23:06 +00:00
Jean-Philippe Lang f8b52b13a0 Fixed: Issue Summary tables that list by user are not sorted (#4552). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3323 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-17 11:07:53 +00:00
Eric Davis 1827d609a1 Cleaned up the IssueController redirects to use the back_url like the other actions. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3315 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-14 23:24:55 +00:00
Jean-Philippe Lang 68a4cd38f5 XML REST API for Projects (#296). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3313 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-14 20:00:17 +00:00
Jean-Philippe Lang 3873388f9b XML REST API for issues that provides CRUD operations for Issues (#1214). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3310 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-13 19:29:19 +00:00
Jean-Philippe Lang 0a05cc2a37 Set a white list of issue attributes that can be mass-assigned from controllers. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3308 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-12 20:17:20 +00:00
Jean-Philippe Lang fe7d65922b Fixed: can not search for 2 letters word (#4381). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3306 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-10 14:15:12 +00:00
Jean-Philippe Lang d7c9886b8c Fixed: attachments get saved on issue update even if validation fails (#4401). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3305 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-10 14:05:42 +00:00
Jean-Philippe Lang eb3b7d055a Fixed: error when downloading a file with no matching mime type (#3782). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3281 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-05 18:16:03 +00:00
Jean-Philippe Lang cab99aa5ad Allow bulk edit custom fields of any type (#461). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3278 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-03 11:18:09 +00:00
Jean-Philippe Lang e9810b5de6 Fixed: bulk edit doesn't include global custom fields (#4505). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3277 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-01-03 10:50:40 +00:00
Eric Davis c67cc7c285 Added :controller_issues_new_before_save hook. (#4465) 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3263 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-29 23:31:24 +00:00
Jean-Philippe Lang ff7eb7b23a Auto-detect attachment content type when blank (#3782). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3258 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-29 13:28:30 +00:00
Jean-Philippe Lang 9c1efcfa48 Do not display the copy form when project copy is created. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3242 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-26 10:18:28 +00:00
Jean-Philippe Lang 62c83bdd2e Adds a 'Add subprojects' permission. 
* 'Add project' permission will let user create a root project
* 'Add subprojects' permission will let project members create subprojects

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3238 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-24 16:18:15 +00:00
Eric Davis bfcd5039f2 Added an Admin setting to enable/disable the REST web service. (#3920) 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3220 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-23 06:27:44 +00:00
Eric Davis e07e9d8bfe Added support for HTTP Basic access to the API. (#3920) 
A user can authenticate using either their:

* username/password
* api-key/random

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3219 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-23 06:27:38 +00:00
Eric Davis baa1ad4256 Allow authenticating with an API token via XML or JSON. (#3920) 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3218 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-23 06:27:33 +00:00
Eric Davis aa9951b38b Added an API token for each User to use when making API requests. (#3920) 
The API key will be displayed on My Account page with a link to reset or
generate a new one.  All existing users will have a token generated by the
migration.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3217 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-23 06:27:28 +00:00
Eric Davis e1013c44a3 Make sure the RSS token is getting destroyed and created. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3210 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-21 02:24:49 +00:00
Eric Davis c478fa7f90 Extract method 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3209 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-21 02:24:44 +00:00
Eric Davis 0844a22b02 Refactor: Use the existing method for failing onthefly creations. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3208 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-20 20:13:50 +00:00
Jean-Philippe Lang c5976333c2 Adds a 'Create and continue' button on new user form. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3204 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2009-12-20 10:51:33 +00:00