Commit Graph

1857 Commits

Author SHA1 Message Date
Toshi MARUYAMA 14fa4dc683 Rails4: replace deprecated Relation#update_all at IssuePriority model
git-svn-id: http://svn.redmine.org/redmine/trunk@12489 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-07 12:33:43 +00:00
Toshi MARUYAMA e17bf40fe1 use lambda form in Version model scope (#12499)
git-svn-id: http://svn.redmine.org/redmine/trunk@12486 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-07 07:51:15 +00:00
Jean-Philippe Lang 77ac3b7891 Reduces the number of subqueries when searching with many custom fields set as searchable (#15781).
git-svn-id: http://svn.redmine.org/redmine/trunk@12481 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-05 14:23:36 +00:00
Jean-Philippe Lang 3c540594dc Fixed test failure with ruby1.8 (#8842).
git-svn-id: http://svn.redmine.org/redmine/trunk@12479 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-03 19:42:43 +00:00
Jean-Philippe Lang 429b3a5dae Fixed test failure with sqlite (#8842).
git-svn-id: http://svn.redmine.org/redmine/trunk@12478 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-03 16:36:04 +00:00
Jean-Philippe Lang a4d3da988a Allow filtering with timestamp (#8842).
git-svn-id: http://svn.redmine.org/redmine/trunk@12477 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-03 15:54:49 +00:00
Toshi MARUYAMA 803a0a030e support more character encoding in incoming emails (#15785)
Supporting encodings of iconv on Ruby 1.8 depend on iconv implementation.
glibc-common-2.12-1.132 on CentOS6 does not support ks_c_5601-1987.

Contributed by Felix Schäfer.

git-svn-id: http://svn.redmine.org/redmine/trunk@12474 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-01 05:54:28 +00:00
Toshi MARUYAMA 3ace0292c2 Rails4: replace deprecated find_by_id at Changeset class
git-svn-id: http://svn.redmine.org/redmine/trunk@12473 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-29 13:49:09 +00:00
Toshi MARUYAMA e9470e5585 explicitly define fix has_and_belongs_to_many join_table at Group and User
Rails4 cannot resolve automatically.

git-svn-id: http://svn.redmine.org/redmine/trunk@12471 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-27 23:33:15 +00:00
Toshi MARUYAMA 25a0bde311 Rails4 compatibility of version group count
git-svn-id: http://svn.redmine.org/redmine/trunk@12465 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-26 10:33:18 +00:00
Toshi MARUYAMA 61c6858b05 code format cleanup Principal class
git-svn-id: http://svn.redmine.org/redmine/trunk@12464 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-26 09:19:56 +00:00
Toshi MARUYAMA 3e4d4a0c1a Rails4 compatibility of Setting model
git-svn-id: http://svn.redmine.org/redmine/trunk@12423 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-20 11:54:23 +00:00
Jean-Philippe Lang 5c5ba0c61a Fixed that time entries custom values are not deleted when deleting a project or an issue (#15709).
git-svn-id: http://svn.redmine.org/redmine/trunk@12421 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-18 18:39:09 +00:00
Jean-Philippe Lang d4297ca3ff Fixed that text/plain attachments are added to issue description (#15684).
git-svn-id: http://svn.redmine.org/redmine/trunk@12420 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-18 18:13:13 +00:00
Jean-Philippe Lang 0ee2af4c06 Fixed that previous assignee is not notified on issue update (#15714).
git-svn-id: http://svn.redmine.org/redmine/trunk@12419 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-17 20:48:18 +00:00
Jean-Philippe Lang 77665b5252 Store relation type instead of i18n key in journals (#15704).
git-svn-id: http://svn.redmine.org/redmine/trunk@12416 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-15 11:02:24 +00:00
Jean-Philippe Lang c6fc1a8047 Fixed that filtering time entries on activity does not take care of activity overrides (#15623).
git-svn-id: http://svn.redmine.org/redmine/trunk@12414 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-15 09:49:12 +00:00
Jean-Philippe Lang 2e2e2cfe42 Merged custom fields format refactoring.
git-svn-id: http://svn.redmine.org/redmine/trunk@12400 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-12-14 08:22:43 +00:00
Jean-Philippe Lang 23974fb0ce Fixed that validating a Setting with invalid name triggers an error (#15551).
git-svn-id: http://svn.redmine.org/redmine/trunk@12348 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-11-29 21:18:35 +00:00
Jean-Philippe Lang f4aff7919a Log errors when moving attachments (#15295).
git-svn-id: http://svn.redmine.org/redmine/trunk@12249 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-11-09 09:46:55 +00:00
Jean-Philippe Lang 10e29f2223 Accept custom field format added at runtime (#15277).
Patch by Boris Bera.

git-svn-id: http://svn.redmine.org/redmine/trunk@12248 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-11-09 09:07:48 +00:00
Toshi MARUYAMA 3109ed9320 code format cleanup app/models/changeset.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12231 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-24 05:40:32 +00:00
Toshi MARUYAMA 16b94e126b code format cleanup app/models/issue.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12230 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-24 05:40:21 +00:00
Jean-Philippe Lang b48fcdaa97 Avoid a query if enabled_modules association is already loaded (#15058).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12228 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-20 16:04:04 +00:00
Jean-Philippe Lang 99bf8c95ab Fixed that issue nested set update is triggered even if parent is not changed (#15135).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12226 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-20 09:25:14 +00:00
Jean-Philippe Lang 3172359f97 Avoid N queries when displaying the issue list with custom fields.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12223 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-15 16:38:17 +00:00
Jean-Philippe Lang 5f747faa58 Fixed that viewing/editing a wiki page without WikiContent raises an error (#14986).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12220 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-13 11:19:47 +00:00
Jean-Philippe Lang 94e7df78ca Fixed that controller_issues_edit_before/after_save hooks have no controller context (#15044).
Patch by Jordan Hollinger.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12219 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-13 10:31:04 +00:00
Jean-Philippe Lang 7bea176cdb Avoid lots of CustomField.find_by_id calls when displaying an issue history with custom fields (#15072).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12217 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-13 10:04:59 +00:00
Jean-Philippe Lang 176ce78574 Fixed that the mail method should return a Mail::Message (#15113).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12210 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-13 07:58:33 +00:00
Jean-Philippe Lang b6cb7aa8e3 Ability to define commit keywords per tracker (#7590).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12208 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-13 07:37:49 +00:00
Jean-Philippe Lang cfc65d9397 NoMethodError when uploading a file without logger (#14977).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12202 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-05 11:37:57 +00:00
Jean-Philippe Lang 7b1b605ae8 Don't update issues nor log time when importing old changesets (#4823).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12199 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-05 10:33:03 +00:00
Jean-Philippe Lang 0444ecca3c Pass the commit keyword used to update the issue to the plugin hook.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-05 10:02:31 +00:00
Jean-Philippe Lang a77b462a53 Support for multiple issue update keywords/rules in commit messages (#4911).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12197 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-10-05 09:41:11 +00:00
Toshi MARUYAMA d8ddb2cee4 remove trailing white-spaces from app/models/custom_field.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12188 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-09-30 09:53:57 +00:00
Jean-Philippe Lang cfc05d310e Exclude attachments from incoming emails based on file name (#3413).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12167 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-09-29 11:50:49 +00:00
Jean-Philippe Lang 886284b33f REST API: custom fields definition (#11159).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12165 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-09-29 10:08:30 +00:00
Jean-Philippe Lang 62b66e9b38 Prevents invalid SQL with invalid group_ids (#14902).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12162 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-09-25 17:35:59 +00:00
Jean-Philippe Lang 59b935aa46 Filters show issues with unused custom fields (#13537).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12133 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-09-13 17:41:54 +00:00
Jean-Philippe Lang cb747a34ef Wrong done_ratio calculation for parent with subtask having estimated_hours=0 ().
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12131 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-09-11 22:00:18 +00:00
Jean-Philippe Lang 02fca76c13 Strip eols from file names (#14819).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12128 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-09-11 19:19:24 +00:00
Jean-Philippe Lang 06efcaddfa Fixed usage of #attribute_present? in UserPreference (#13008).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12126 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-09-10 17:39:49 +00:00
Toshi MARUYAMA 15ab64488a remove trailing white-space from app/models/journal.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12121 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-09-05 11:14:30 +00:00
Toshi MARUYAMA ae2b47afd6 code format cleanup app/models/issue.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12087 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-08-06 06:27:16 +00:00
Jean-Philippe Lang b764e39847 Option to force a user to change his password (#3872).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12081 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-08-05 17:58:33 +00:00
Jean-Philippe Lang b19b902345 Moved CUSTOM_FIELDS_TABS out of the model.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12077 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-08-04 10:26:54 +00:00
Toshi MARUYAMA 7711e37da4 remove ineffective "logger.info" and "logger.error" check from MailHandler model (#14598)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12073 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-08-03 10:46:53 +00:00
Jean-Philippe Lang 3df08b02b4 Broken tests (#14491).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12068 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-29 19:08:01 +00:00
Jean-Philippe Lang 1502da5726 Use the default project when receiving an email with an invalid project keyword (#14491).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12067 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-29 16:37:45 +00:00
Jean-Philippe Lang 4a70a319c5 Filtering issues on "related to" may ignore other filters (#14401).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12058 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-28 15:29:31 +00:00
Jean-Philippe Lang 474453d2b0 Additional status transitions for assignees do not work if assigned to a group (#14447).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12056 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-28 14:58:06 +00:00
Jean-Philippe Lang 21fc903c04 Fixed that sorting time entries by custom field raises a SQL error (#14366).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12042 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-28 09:59:34 +00:00
Jean-Philippe Lang dc5e5eca6b Fixed that displaying time entries with custom field column raises an error (#5037).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12041 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-24 18:18:08 +00:00
Jean-Philippe Lang 9ca8b20d55 Don't hardcode news model in Comment.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12026 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-15 20:53:23 +00:00
Jean-Philippe Lang 205eda8b33 Use AR callbacks instead of observers (removed in Rails4) for notifications.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12021 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-14 14:26:27 +00:00
Jean-Philippe Lang 010bfc56e1 Ability to save Gantt query filters (#7836).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12020 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-14 13:41:30 +00:00
Jean-Philippe Lang 594589e0ec Use Hash#reject that returns a Hash with ruby1.8 when Hash#select that returns an Array.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12016 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-13 10:39:36 +00:00
Jean-Philippe Lang 0087d237f7 Don't notify users about relations that are not visible (#1005).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12015 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-13 10:32:48 +00:00
Jean-Philippe Lang 7509dda1ff Fixed that relations to issues that are not visible are displayed in the issue history (#1005).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12014 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-13 09:56:58 +00:00
Jean-Philippe Lang 628d05629b Role-based issue custom field visibility (#5037).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12012 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-13 09:20:11 +00:00
Jean-Philippe Lang a74d55edd9 Removed dead code.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-13 08:13:34 +00:00
Jean-Philippe Lang 8ff33ac9f7 Log email delivery errors (#14403).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12010 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-13 08:11:20 +00:00
Jean-Philippe Lang 80b1a73ccf Adds 'assigned-to-my-group' css class to issues that are assigned to a user's group (#12681).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12006 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-11 19:35:40 +00:00
Jean-Philippe Lang 888c3581eb Role based custom queries (#1019).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11994 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-11 17:45:10 +00:00
Toshi MARUYAMA edb6e245cf gender neutral source comment at app/models/user.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11989 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-06 00:04:58 +00:00
Toshi MARUYAMA e1ca4a8663 gender neutral source comment at app/models/mailer.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11988 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-06 00:04:47 +00:00
Jean-Philippe Lang 2f53246c13 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11967 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-13 19:31:43 +00:00
Jean-Philippe Lang 07d88851bf Fixed tests broken by r11965.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11966 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-12 21:55:39 +00:00
Jean-Philippe Lang e978b3ace0 Adds User#builtin_role.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11965 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-12 19:38:43 +00:00
Jean-Philippe Lang f9ddb562d5 Cleanup of finders with :conditions option.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11963 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-12 19:13:25 +00:00
Jean-Philippe Lang e0c7eb25a4 Adds Watcher.any_watched? to check if at least one object of a collection is watched.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11959 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-11 18:25:05 +00:00
Jean-Philippe Lang 32464f4912 Perf: don't load all projects.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11956 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-11 16:54:48 +00:00
Toshi MARUYAMA cb140248ea remove trailing white-space from app/models/user.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11954 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-10 08:48:49 +00:00
Jean-Philippe Lang 4bd874ab46 Adds a way for a registered user to get a new action email (#14228).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11946 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-09 10:01:56 +00:00
Toshi MARUYAMA a0423f4eb1 fix that project auto generation fails when projects created in the same time (#14242)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11942 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-08 09:50:34 +00:00
Jean-Philippe Lang 8cea7d8cf2 Don't validate start date when updating an issue without changing it (#14086).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11931 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-05 19:56:59 +00:00
Jean-Philippe Lang 46085644ed Adds a specific error message for when the start date is too earlier than the minimum start date (#14086).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11926 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-04 17:17:48 +00:00
Jean-Philippe Lang e27deb1ece Query#add_custom_fields_filters now takes a custom fields scope.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11917 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-01 10:56:12 +00:00
Jean-Philippe Lang bf76b3b286 Project#all_issue_custom_fields now returns a scope.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11916 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-01 10:26:17 +00:00
Toshi MARUYAMA 4dbe2e7062 remove trailing white-space from app/models/mailer.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11902 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-25 05:35:13 +00:00
Toshi MARUYAMA 1f9e1ca318 add journal after creating/deleting issue relation (#1005)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11885 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-19 02:09:39 +00:00
Jean-Philippe Lang ed364c9114 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11873 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-18 19:58:43 +00:00
Jean-Philippe Lang 35ca873269 Fixed that filtering may return unwanted blank values (#14051).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11850 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-16 16:29:59 +00:00
Jean-Philippe Lang ece5232110 Fixed that values of custom fields are not kept in issues when copying a project (#13910).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11843 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-13 19:52:37 +00:00
Jean-Philippe Lang 4a59b869c0 Update notified_project_ids while saving record.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11840 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-13 17:11:38 +00:00
Jean-Philippe Lang 10ed306b19 Fixed that locking and unlocking a user resets the email notification checkbox (#14020).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11839 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-13 16:38:08 +00:00
Jean-Philippe Lang 9b7d312a0e Fix handling multiple text parts in email (#13646).
Patch by Alex Shulgin.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11834 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-12 09:38:20 +00:00
Jean-Philippe Lang 76a3298306 Issue#children is never nil (#14015).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11833 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-12 08:49:54 +00:00
Jean-Philippe Lang 922acdbcc2 Check inclusion only once (#14015).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11832 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-12 08:45:40 +00:00
Jean-Philippe Lang a7102db8c4 Replaces camelcase variable names (#14015).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11831 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-12 08:42:41 +00:00
Jean-Philippe Lang a2b6088772 Removes some empty lines (#14015).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11830 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-12 08:41:21 +00:00
Jean-Philippe Lang cf30a68312 Removes then's (#14015).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11829 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-12 08:39:18 +00:00
Jean-Philippe Lang 8c9bba1cbf Replaces camelcase variable names (#14015).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11828 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-12 08:37:54 +00:00
Jean-Philippe Lang 78dc37d8af Improved Issue#all_dependent_issues (#14015).
Patch by Jost Baron.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11827 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-12 08:33:21 +00:00
Jean-Philippe Lang ed18b3359b Adds a method for extracting MailHandler options from ENV.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11785 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-04 07:32:35 +00:00
Jean-Philippe Lang c5ac2d3966 Fixed that deleting a system activity with children in use raises an error (#13783).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11763 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-01 17:10:15 +00:00
Jean-Philippe Lang 6c39a260a3 Propose system activities only when reassigning time entries (#13783).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11762 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-01 16:43:51 +00:00
Jean-Philippe Lang 5a3b903733 Fixed: Unable to set custom fields for versions using the REST API (#13850).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11760 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-05-01 15:57:31 +00:00
Toshi MARUYAMA fe903be480 remove trailing white-space from app/models/project.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11736 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-04-21 04:56:26 +00:00
Toshi MARUYAMA 7ab18f6aa1 remove trailing white-spaces and redundant empty line from app/models/issue_query.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11726 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-04-19 07:18:38 +00:00
Toshi MARUYAMA 36120d17e7 remove trailing white-space from app/models/role.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11715 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-04-12 01:50:01 +00:00
Jean-Philippe Lang ed5b14884c Fixed that r11641 prevents precedes/follows relations between subtasks (#13586).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11692 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-26 21:31:29 +00:00
Toshi MARUYAMA de68231632 remove trailing white-space from app/models/setting.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11688 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-25 13:39:56 +00:00
Toshi MARUYAMA b26f1c55cc remove trailing white-space from app/models/user_preference.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11670 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-20 08:48:03 +00:00
Toshi MARUYAMA 32391269ae remove trailing white space from app/models/version.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11651 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-19 07:29:00 +00:00
Toshi MARUYAMA cc5f59abd4 fix broken tests on Rails 3.2.13 with Ruby 1.8 (#12399, #12375)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11650 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-19 06:35:39 +00:00
Toshi MARUYAMA 5d600587a1 replace tab to space at app/models/mail_handler.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11643 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-18 02:14:11 +00:00
Jean-Philippe Lang 24e99f8b22 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11642 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-17 15:17:48 +00:00
Jean-Philippe Lang 38b3e045cf Fixed: Circular loop when using relations and subtasks (#8794).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11641 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-17 15:02:57 +00:00
Jean-Philippe Lang b1afd75620 Fixed: subtasks don't resepect following/precedes relations on creation (#12968).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11640 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-17 13:46:20 +00:00
Jean-Philippe Lang 6d20cfe831 Moves Project#users to a regular method.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11609 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-12 18:32:36 +00:00
Jean-Philippe Lang 3528343863 Moves Project#principals to a regular method.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11608 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-12 18:07:37 +00:00
Jean-Philippe Lang 447e15d6cb Prevent one query per User#member_of? call after r11508 (#13301).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11605 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-12 17:08:50 +00:00
Jean-Philippe Lang bca9a8431e Mail handler: set mail_notification to only_my_events when creating a new user (#13341).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11590 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-11 17:50:18 +00:00
Toshi MARUYAMA b53b7b1acd use %r{} instead of // at app/models/repository/subversion.rb
Syntax highlight is broken in gedit 2.28.4 on CentOS 6.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11543 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-07 04:07:20 +00:00
Jean-Philippe Lang f77ed4a7c3 Mail handler: adds --no-notification option to disable notifications to the created user (#13341).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11526 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-03 08:57:00 +00:00
Jean-Philippe Lang 6cffab9919 Mail handler: adds --no-account-notice option for not sending account information to the created user (#11498).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11525 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-03 08:41:52 +00:00
Jean-Philippe Lang b25d496c24 Mail handler: adds --default-group option to add created user to one or more groups (#13340).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11522 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-03 07:59:29 +00:00
Jean-Philippe Lang caf61dc923 Fixed that copying an issue as a child of itself creates an extra issue (#13328).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11513 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-01 12:26:06 +00:00
Jean-Philippe Lang a140a03a35 Adds "tracker-[id]" CSS class to issues (#13309).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11509 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-01 10:42:05 +00:00
Jean-Philippe Lang 6803d95a32 Performance: avoid querying all memberships in User#roles_for_project (#13301).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11508 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-03-01 10:24:23 +00:00
Jean-Philippe Lang 5c1e1ee4bb Fixed that #reload raises a Stack too deep error with ruby 2.0.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11497 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-28 18:47:25 +00:00
Jean-Philippe Lang f544dd682b Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11496 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-28 17:52:29 +00:00
Jean-Philippe Lang 5bf647f290 Don't reload the issue in after_save callback.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11495 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-28 17:47:58 +00:00
Jean-Philippe Lang 458800c1d5 Time entry with 2 digits year should not validate (#3107).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11472 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-24 12:28:44 +00:00
Jean-Philippe Lang 8e17c2aeac Fixed that relations may not be refreshed when adding a follows relation (#13251).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11461 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-24 09:59:45 +00:00
Jean-Philippe Lang e14caf8e33 Use User#generate_password in MailHandler.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11457 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-23 16:57:45 +00:00
Jean-Philippe Lang fac4a79d4c Option to generate a random password on user creation/update.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11456 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-23 16:50:07 +00:00
Jean-Philippe Lang 9b1ebd6808 Refactor: makes issue id a regular QueryColumn.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11447 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-23 10:53:21 +00:00
Toshi MARUYAMA f76dcf33ef fix typo at app/models/user.rb (#5719)
Contributed by Tom Copeland.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11427 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-18 11:00:21 +00:00
Jean-Philippe Lang 64bbf64fb6 Optimizes the SQL query behind Principal#member_of.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11426 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-17 12:41:31 +00:00
Toshi MARUYAMA e79b232a02 replace tabs to spaces at app/models/issue.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11422 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-17 10:17:10 +00:00
Toshi MARUYAMA e478f3044e replace tabs to spaces at app/models/setting.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11421 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-17 10:16:46 +00:00
Toshi MARUYAMA e31a8e2cb3 remove trailing tabs from app/models/project.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11415 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-17 10:14:08 +00:00
Jean-Philippe Lang 7b7427b46e Adds Issue#status_was that returns the initial issue status.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11412 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-17 09:30:17 +00:00
Jean-Philippe Lang 98cd140a19 Makes closed_on available as column and filter on the issue list (#824).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11403 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-16 09:39:52 +00:00
Jean-Philippe Lang a45c0dc550 Adds closed_on column that stores the time of the last closing (#824).
The value is preserved when reopening the issue.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11402 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-16 09:38:01 +00:00
Jean-Philippe Lang 9a3e4e0a51 Test broken by r11392 (#13174).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11395 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-15 08:32:06 +00:00
Jean-Philippe Lang 4e9fbeb851 Possibility to define the default enable trackers when creating a project (#13175).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11394 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-15 08:28:34 +00:00
Jean-Philippe Lang ee1d9647b8 Raised group name maximum length to 255 characters (#13174).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11392 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-15 07:48:37 +00:00
Jean-Philippe Lang 3c3ac3c6ee Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11375 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-14 22:13:49 +00:00
Jean-Philippe Lang 812da860b3 Adds token finder methods.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11374 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-14 21:47:07 +00:00
Jean-Philippe Lang 0be82ea2c4 Refactor: use an ordered hash to store available filters and remove :order option (#13154).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11372 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-14 20:37:17 +00:00
Toshi MARUYAMA 77bc6e11ff remove trailing white-spaces from app/models/custom_field.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11354 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-12 00:51:11 +00:00
Toshi MARUYAMA 7303cc416c remove trailing white-space from app/models/board.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11338 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-10 04:04:21 +00:00
Jean-Philippe Lang 0d93b6dc3c Typo that breaks with ruby1.8.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11337 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-09 15:20:07 +00:00
Jean-Philippe Lang 0f2ee79f35 Fixed that project overview page shows trackers from subprojects with disabled issue module (#13076).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11336 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-09 13:56:11 +00:00
Jean-Philippe Lang 2cd749955e Fixed: error raised when copying project wiki with wiki module disabled (#13097).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11332 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-07 19:24:57 +00:00
Jean-Philippe Lang b3a2d07257 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11313 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-02-03 08:23:20 +00:00