Commit Graph

4207 Commits

Author SHA1 Message Date
Jean-Philippe Lang 1334cbf78c Adds double quotes around issue change details in plain text notifications (#10603).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9368 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-08 17:30:08 +00:00
Jean-Philippe Lang fde9c7315a Fixed: reminder mails are not sent when delivery_method is :async_smtp (#5058).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9367 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 18:57:05 +00:00
Jean-Philippe Lang 2e240103f3 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9364 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 16:53:12 +00:00
Jean-Philippe Lang 18270ee587 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9363 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 16:51:10 +00:00
Jean-Philippe Lang ab28a55b4e Fixed test_show_with_permission_should_display_the_new_message_form broken by r9351.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9359 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 13:51:16 +00:00
Jean-Philippe Lang dd1163b58a Makes the mail handler ignore out-of-office emails (#10607).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9358 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 13:24:30 +00:00
Jean-Philippe Lang 54bb145c76 Removed permissions logic from view.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9351 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 12:21:45 +00:00
Jean-Philippe Lang a7bacf70fb Fixed: Unable to change locked, sticky flags and board when editing a message (#10564).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9350 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 12:20:47 +00:00
Jean-Philippe Lang 07d20cc5f7 Let non required list/user/version custom fields to be set to blank when bulk editing (#10605).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9349 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 11:56:30 +00:00
Jean-Philippe Lang b4975862d6 Uploading of attachments which filename contains non-ASCII chars fails with Ruby 1.9 on issue update (#10575).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9334 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 09:31:29 +00:00
Jean-Philippe Lang 331cf23345 Do not display the magnifier for added files in email notifications (#4774).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9333 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 09:20:40 +00:00
Jean-Philippe Lang f05f84a2ea Moved the magnifier just after the filename.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9332 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 08:49:04 +00:00
Jean-Philippe Lang bac7dff5bb Force encoding of custom field possible values (#10593).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9330 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 07:39:50 +00:00
Jean-Philippe Lang f1cae4f7af WikiContent::Version#text may return ascii-8bit encoded string (#10590).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9329 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 07:21:51 +00:00
Toshi MARUYAMA e964135b62 delete :only_path option from link_to options at application_helper link_to_attachment (#10602)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9328 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 06:07:13 +00:00
Toshi MARUYAMA 8828c0f13e fix attachment link has get parameter :class (#10602)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9327 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 05:45:04 +00:00
Toshi MARUYAMA f277f127c6 add a view link to note attachment file (#4774)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9326 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 05:44:48 +00:00
Toshi MARUYAMA b88586b56d code layout cleanup app/helpers/issues_helper.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9325 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 05:44:30 +00:00
Toshi MARUYAMA c1dd88b015 replace tabs to spaces at app/views/attachments/_links.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9324 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-06 05:44:14 +00:00
Etienne Massip d36d64f664 Fixed Internal Error in watchers XHR search (#10600).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9323 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-05 18:10:54 +00:00
Toshi MARUYAMA ddce7ef142 code layout clean up app/views/repositories/show.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9321 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-04 10:43:29 +00:00
Toshi MARUYAMA 9aefe8b1e9 fix html tag at app/views/repositories/show.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9320 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-04 10:43:15 +00:00
Toshi MARUYAMA 72590ea997 code layout clean up app/views/repositories/show.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9319 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-04 10:19:55 +00:00
Toshi MARUYAMA a5b480c62e replace tabs to spaces at app/views/repositories/show.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9318 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-04 10:19:41 +00:00
Toshi MARUYAMA f0f7158d87 fix typo "RedMine" at app/models/wiki_content.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9316 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-03 14:04:38 +00:00
Toshi MARUYAMA 29782860b7 scm: mercurial: git: save parents in creating changesets (#10470)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9311 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-04-03 08:05:30 +00:00
Toshi MARUYAMA 0098c7b128 fix source indents of app/views/repositories/revisions.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9291 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-30 01:48:59 +00:00
Toshi MARUYAMA f36eb54141 scm: git: use Changeset#create and Changeset#create_change as same with Subversion and Mercurial
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9290 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-29 22:41:20 +00:00
Toshi MARUYAMA b2a2cb68dd scm: mercurial: transaction for each imported revisions (#10470)
Subversion transaction switched at r2563.
Subversion and Mercurial have a sequential revision number.
So, Mercurial can use the same logic with Subversion.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9288 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-29 16:50:10 +00:00
Toshi MARUYAMA 76435033e7 scm: git: add the comment of the reason to scan database in fetching every time (#10470)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9287 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-29 10:05:13 +00:00
Toshi MARUYAMA 27dca22c91 scm: git: fix typo in fetching revisions comment.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9286 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-29 02:42:20 +00:00
Toshi MARUYAMA 5232d379f9 scm: git: fix model source indents (#10470)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9284 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-28 17:18:19 +00:00
Toshi MARUYAMA 9b333e1c87 scm: git: process new git revisions all at once rather than per branch (#10470)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9283 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-28 17:18:04 +00:00
Toshi MARUYAMA 5f37d0d1c8 replace tabs to spaces and fix indents at app/views/issues/new.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9279 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-28 03:34:39 +00:00
Jean-Philippe Lang 274566f13b Failing test with 1.8.7 and jruby (#10538).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9270 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-25 20:21:04 +00:00
Jean-Philippe Lang 6115a079ec Remove duplicate watchers (#10538).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9268 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-25 19:35:32 +00:00
Jean-Philippe Lang 1294f72175 Fixed that issues can be moved to projects with issue tracking disabled (#10467).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9267 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-25 19:32:05 +00:00
Jean-Philippe Lang 5663ca89fa Fixes error message for LDAP filter (#1060).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9258 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-24 14:07:42 +00:00
Jean-Philippe Lang ee8002b0c9 Adds the repository identifier in the activity and search results (#779).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9257 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-24 13:51:28 +00:00
Jean-Philippe Lang bb36fa5d12 Adds the repository identifier to Changeset#text_tag (#779).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9255 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-24 13:03:36 +00:00
Jean-Philippe Lang fae5250e52 Ability to add non-member watchers on issue creation (#5159).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9254 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-24 12:57:28 +00:00
Toshi MARUYAMA e2bb8721d9 Replace tables that were using the 'width' attribute with inline styles (should be replaced with an ID/class).
Contributed by Andrew Smith.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9253 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-24 00:03:05 +00:00
Toshi MARUYAMA 103cd46f78 Remove some inline styling and some depreciated table cell attributes and replace them with proper class names.
Contributed by Andrew Smith.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9252 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-24 00:02:49 +00:00
Toshi MARUYAMA 8bc638f404 Fix missing cells at app/views/issues/show.html.erb
Contributed by Andrew Smith.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9251 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-24 00:02:35 +00:00
Toshi MARUYAMA 27c390bb62 Fix duplicated 'back_url' IDs
Various hidden input fields are used to hold a URL to send the user back
to the correct page after submitting a form, however, they all use the
same ID which isn't allowed in HTML. Passing in 'id' as nil stops the
'hidden_field_tag' from adding an ID attribute to the tag.

Contributed by Andrew Smith.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9250 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-24 00:02:20 +00:00
Jean-Philippe Lang 7c5635f6c6 Typo (#1913).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9243 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-17 12:19:01 +00:00
Jean-Philippe Lang fdeb398c5e LDAP: adds the ability to bind with user's account (#1913).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9241 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-17 12:09:59 +00:00
Jean-Philippe Lang 95b10f3bd3 Don't use #delete on String in Mailer.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9237 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-12 18:34:12 +00:00
Jean-Philippe Lang 60e6a623bd Adds an icon to the "Test" link.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9235 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-11 12:15:56 +00:00
Jean-Philippe Lang a8e392c0e5 Fixed that LDAP error is not displayed when testing connection.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9234 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-11 12:01:41 +00:00
Jean-Philippe Lang 71e636ff71 Resourcified auth_sources.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9233 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-11 11:53:28 +00:00
Jean-Philippe Lang bd47af098f Merged LdapAuthSourceController into AuthSourceController.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9232 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-11 11:43:27 +00:00
Jean-Philippe Lang dbda62849d Removed dead code.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9176 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-10 18:20:07 +00:00
Etienne Massip 8612fa2fc1 Fixed Gantt months/weeks/days headers display with Ruby 1.9.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9175 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-10 15:10:32 +00:00
Jean-Philippe Lang 125f5e1710 Use #find_project_by_project_id from super-class.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9172 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-10 13:44:52 +00:00
Jean-Philippe Lang 036b81abfd Use #find_project_by_project_id from super-class.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9160 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 20:03:05 +00:00
Toshi MARUYAMA 0cbbb9fda8 remove trailing white-space from app/models/repository/git.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9145 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 07:56:30 +00:00
Toshi MARUYAMA 999a4ba30d scm: git: performance improvements in fetching revisions (#8857, #9472)
Parse a revision for a given branch,
just if we haven't parsed it for any branches before.
Moved the db check to for existing revisions into a grouped search.
Search for many revisions at once: this reduces db load.
Revisions are grouped into sets of 100.
This is to improve memory consumption.
There will be just one query instead of each 100.
The above two methods significantly increase parsing speed.
Test case was a git repo with 6000+ commits on a master branch,
and several other branches originating for master.
Speed improved from 1.4h to 18min.

Contributed by Gergely Fábián.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9144 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 07:56:15 +00:00
Toshi MARUYAMA bcba955456 scm: git: reduce saving heads times in fetching revisions (#8857, #9472)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9143 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 05:57:59 +00:00
Toshi MARUYAMA f0987e4b8f scm: git: backout r8839 (#8857)
call "git log" only once instead of per branch in fetching revisions.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9142 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 05:57:44 +00:00
Toshi MARUYAMA 374c2aa705 scm: git: backout r8840 (#8857, #9472)
reduce saving heads times in fetching revisions.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9141 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 05:57:29 +00:00
Jean-Philippe Lang 2bcf9f2871 Prevent mass-assignment when adding/updating a forum (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9140 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 21:36:28 +00:00
Jean-Philippe Lang 87356648f6 Set user_id as a protected attribute (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9139 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 20:57:33 +00:00
Jean-Philippe Lang efddab48be Prevent mass-assignment when adding/updating a wiki (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9138 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 20:34:38 +00:00
Jean-Philippe Lang fef2e4b672 Prevent mass-assignment when adding/updating a version (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9137 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 20:31:45 +00:00
Jean-Philippe Lang 1ec2d98c14 Prevent mass-assignment when adding/updating a time entry (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9136 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 20:23:00 +00:00
Jean-Philippe Lang 0ee1de5686 Use safe_attributes= just like in #create.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9135 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 19:52:10 +00:00
Jean-Philippe Lang d0356fe935 Prevent mass-assignment when adding/updating a news (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9134 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 19:50:10 +00:00
Jean-Philippe Lang 286bda14f1 Prevent mass-assignment when adding/updating a forum message (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9133 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 19:46:59 +00:00
Jean-Philippe Lang 2c6ad7525a Prevent mass-assignment when adding a project member (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9132 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 19:39:37 +00:00
Jean-Philippe Lang 460239d1f9 Prevent mass-assignment when adding/updating an issue category (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9131 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 18:59:32 +00:00
Jean-Philippe Lang 809d35d34b Prevent mass-assignment when adding/updating a document (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9130 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 18:54:41 +00:00
Jean-Philippe Lang bdf6e90f05 Prevent mass-assignment when adding a news comment (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9129 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 18:48:47 +00:00
Jean-Philippe Lang 6aad82e524 Fixed that the proposed users list may be empty when adding a project member (#10374).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9128 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 18:37:30 +00:00
Jean-Philippe Lang 6b47cad8ce Cleanup in TimelogController#destroy.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9095 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 15:24:14 +00:00
Jean-Philippe Lang dc50edae5e Adds a template for API error messages so that it does not depend on AR::Errors serialization.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9094 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 15:16:50 +00:00
Jean-Philippe Lang d862843c9d Renamed Mailer#test to Mailer#test_email.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9080 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 12:38:34 +00:00
Jean-Philippe Lang 60b0a6c4b8 Removed sort order on issues association.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9075 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 11:53:15 +00:00
Jean-Philippe Lang bf05656c36 Rails 3.1 compatibility.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9074 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 11:45:15 +00:00
Jean-Philippe Lang 64d843a4d7 Rails 3.1 compatibility.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9073 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 11:41:10 +00:00
Jean-Philippe Lang af75583b23 Adds Redmine::Utils.random_hex for generating a random hex string.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9071 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 11:05:02 +00:00
Jean-Philippe Lang 70ced2f2af Rails 3.1 compatibility.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9067 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 10:44:59 +00:00
Jean-Philippe Lang c7b1a42d19 Adds Redmine::Plugin.public_directory to be used instead of Engines.public_directory.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9065 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 10:29:47 +00:00
Jean-Philippe Lang b3866b05c1 Removes all #verify calls in controllers. Verification is handled at routing level now that the default route is removed.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9061 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-03 15:09:20 +00:00
Jean-Philippe Lang 9c4014f446 Use a single query to retrieve issues on the roadmap.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9057 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-02 16:27:14 +00:00
Jean-Philippe Lang 1c0988cad3 Use a single query to retrieve issues_count, open_issues_count and closed_issues_count.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9056 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-02 16:26:06 +00:00
Jean-Philippe Lang fe481453c4 Use #issues_count which is already retrieved.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9055 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-02 16:23:10 +00:00
Jean-Philippe Lang 9ffccf5304 Adds functional test for #test_connection.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9053 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-02 11:31:44 +00:00
Jean-Philippe Lang 7448e0dbc4 Fixed that the bulk edit/copy form does not propose versions and categories for the target project (#10350).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9046 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-01 20:22:08 +00:00
Jean-Philippe Lang 60741b3e1c Adds an optional LDAP filter (#1060).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9044 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-01 16:26:10 +00:00
Jean-Philippe Lang ab46c52d4a MailHandler: fixed that sender's fullname is not unquoted (#10334).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9043 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-01 15:32:34 +00:00
Jean-Philippe Lang e1d1a3a0c2 Fixes r9029.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9030 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-28 06:27:23 +00:00
Jean-Philippe Lang df3c2466f8 Implements the behaviour expected in user_test.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9029 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-28 05:46:33 +00:00
Jean-Philippe Lang e6b9ddad18 Mailer#url_for not called in views with Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9023 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-27 20:43:25 +00:00
Etienne Massip 7056649a4b Override @#url_for@ in AM to force generation of absolute links (#10251).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9022 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-27 18:42:03 +00:00
Jean-Philippe Lang 0d2a22f37a Use controller_name and action_name instead of params.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9018 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 19:20:37 +00:00
Jean-Philippe Lang 7c568cccaf Adds a helper for displaying validation error messages.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9017 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 18:07:13 +00:00
Jean-Philippe Lang ad2036aaba Rails 3.1 compatibility (order declared on association takes precedence).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9015 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 13:05:19 +00:00
Jean-Philippe Lang 65b4d8a649 Make sure that projects_to_search is a Project Array.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 11:42:29 +00:00
Toshi MARUYAMA 3363e4f790 remove trailing white-spaces from app/models/attachment.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9012 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 10:16:09 +00:00
Toshi MARUYAMA aa0935c13b Rails3: html_safe for project_tree_options_for_select method in application helper
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 07:10:54 +00:00
Jean-Philippe Lang b6742bda3d Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9002 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 13:04:34 +00:00
Jean-Philippe Lang cf9154f924 Can not use Project#find on scopes with Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9001 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 12:57:30 +00:00
Jean-Philippe Lang 0cc60f3631 Use content_tag for empty option.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9000 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 12:37:28 +00:00
Jean-Philippe Lang 56a5f598f1 Preserve xml output with Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8998 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 12:19:56 +00:00
Jean-Philippe Lang b795bd5ace Fixed escaping issue with Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8994 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 11:06:14 +00:00
Jean-Philippe Lang 61b14f6391 Use content_tag for empty option.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8993 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 11:04:38 +00:00
Jean-Philippe Lang f1b26008b8 Fixed escaping issue with Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8990 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 09:37:18 +00:00
Jean-Philippe Lang 36fa1ff9a9 Use content_tag for "no change" options.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8989 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 09:29:56 +00:00
Toshi MARUYAMA b4630c03f7 Rails3: prevent double rendering file view and annotate on Rails 3.0.11 and Rails 3.1.3
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8988 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 06:01:48 +00:00
Jean-Philippe Lang f04c7a7680 Fixed Version#issues_progress for Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8986 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 00:07:09 +00:00
Jean-Philippe Lang 30282f20da Fixed escaping issues in #textilizable with Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8985 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 00:00:58 +00:00
Jean-Philippe Lang 7ad40e22fe Replace auto_link with link_to in email templates.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8984 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 23:16:59 +00:00
Jean-Philippe Lang d04b4aafb6 Use :joins instead of :include.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8982 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 18:55:09 +00:00
Jean-Philippe Lang 430477d4d6 Round hours when reading TimeEntry attribute.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8980 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 18:40:22 +00:00
Jean-Philippe Lang 492cce7975 Cleanup instance variables when reloading a project.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8979 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 18:38:05 +00:00
Jean-Philippe Lang 67d816705d Removed useless option.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8978 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 18:27:38 +00:00
Jean-Philippe Lang 528735b955 Use subclasses method instead of class variable.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 18:23:58 +00:00
Toshi MARUYAMA 55a8087f67 Rails3: scm: mercurial: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8976 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:59:54 +00:00
Toshi MARUYAMA ebb109b67e Rails3: scm: git: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8975 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:59:31 +00:00
Toshi MARUYAMA e6916cf72f Rails3: scm: filesystem: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8974 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:59:06 +00:00
Toshi MARUYAMA 7100ca61ba Rails3: scm: darcs: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8973 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:58:43 +00:00
Toshi MARUYAMA e5bcac1572 Rails3: scm: cvs: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8972 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:58:18 +00:00
Toshi MARUYAMA 565ac00b70 Rails3: scm: bazaar: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8971 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:57:52 +00:00
Toshi MARUYAMA cd9b62d734 Rails3: scm: use .to_s for overriding human_attribute_name parameter at repository model
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8970 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:57:26 +00:00
Toshi MARUYAMA a4ee104bd7 Rails3: use .to_s for overriding human_attribute_name parameter at group model
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8969 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:56:54 +00:00
Toshi MARUYAMA 34d14500c9 Rails3: view: html_safe for auto_link of project homepage
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8956 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 23:08:00 +00:00
Jean-Philippe Lang 77aab5c468 Fixes HTML.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8955 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 15:42:15 +00:00
Jean-Philippe Lang 8cfc080470 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8953 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 15:28:49 +00:00
Jean-Philippe Lang 3be511cdab Removed dead code.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8951 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 15:23:03 +00:00
Jean-Philippe Lang 0a8b35718a Pass the message id when previewing in edit mode (#10275).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8950 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 15:17:13 +00:00
Jean-Philippe Lang 3762a92a35 Pass the topic objet to #textilizable (#10275).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8949 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 15:11:17 +00:00
Jean-Philippe Lang 95811c8e4c Removed dead code.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8946 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 14:19:42 +00:00
Jean-Philippe Lang 8f24aa6c67 Preserve uploaded files when on documents.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8944 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 13:10:51 +00:00
Jean-Philippe Lang 3871cbc75c Preserve uploaded files when on news.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8943 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 13:08:32 +00:00
Jean-Philippe Lang 707ce0beef Preserve uploaded files when on news.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8942 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 13:07:27 +00:00
Jean-Philippe Lang 4f217618af Do not check the request http method.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8941 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 13:05:10 +00:00
Jean-Philippe Lang 435a634ac7 Preserve uploaded files when creating a forum topic.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8940 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 13:02:35 +00:00
Toshi MARUYAMA 6bdc2c36f1 scm: mercurial: use to_s for revision in find_changeset_by_name method
On Rails 3.0.11, functional test fails.

<pre>
Error: test_diff_two_revs(RepositoriesMercurialControllerTest)
NoMethodError: undefined method `empty?' for 4:Fixnum
app/models/repository/mercurial.rb:76:in `find_changeset_by_name'
</pre>

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8938 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 12:18:30 +00:00
Jean-Philippe Lang 7e347069d5 Better message for file size validation error.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8937 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 12:18:10 +00:00
Jean-Philippe Lang afa6c1a9a7 Removed testing code.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8933 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 10:57:50 +00:00
Toshi MARUYAMA a261006666 scm: use to_s for revision in find_changeset_by_name method
On Rails 3.0.11, Subversion functional test fails.

<pre>
Error: test_directory_diff(RepositoriesSubversionControllerTest)
NoMethodError: undefined method `match' for 2:Fixnum
app/models/repository.rb:234:in `find_changeset_by_name'
</pre>

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8931 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 10:11:19 +00:00
Jean-Philippe Lang 77626ef6fb Adds support for adding attachments to issues through the REST API (#8171).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8928 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 10:01:16 +00:00
Toshi MARUYAMA aa286a8e3f add ":id => nil" to "Overall activity" link_to
On Rails 3.2.1, "Overall activity" link becomes "/assets?controller=activities".

Contributed by John Yani.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8922 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-22 14:36:31 +00:00
Toshi MARUYAMA d7692b2575 code layout cleanup app/views/users/show.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8921 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-22 14:36:16 +00:00
Toshi MARUYAMA 652871d4c3 Rails3: view: html_safe for common/_diff.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8919 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-22 03:38:08 +00:00
Jean-Philippe Lang 77287d1f0b Fixed magic link in the note added when closing an issue by a commit from a subproject (#10284).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8917 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-20 21:58:57 +00:00
Jean-Philippe Lang 3e3d7c8d4f Friendly response when the LDAP connection fails.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8911 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-19 18:13:46 +00:00
Jean-Philippe Lang 59c2530001 Fixed random failures in RepositoriesControllerTest with ruby-1.8.7-p358.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8909 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-19 15:34:06 +00:00
Jean-Philippe Lang 97075c85e8 Require net/ldap.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8907 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-19 15:04:10 +00:00