Toshi MARUYAMA
2ab7dba964
Rails3: model: mailer: use .to_s at redmine_headers method
...
On Rails 3.0:
<pre>
DEPRECATION WARNING: Using a non-String object for a header's value is deprecated.
You specified 15 (a Fixnum) for X-Redmine-Issue-Id.
</pre>
On Rails 3.1.3:
<pre>
Error:
test_message_posted_message_id(MailerTest):
NoMethodError: undefined method `index' for 1:Fixnum
test/unit/mailer_test.rb:226:in `test_message_posted_message_id'
</pre>
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8468 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-02 09:35:50 +00:00
Jean-Philippe Lang
1f6764e2af
Rails3 compat.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8459 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-01 17:58:14 +00:00
Jean-Philippe Lang
cd256fe89f
Order is already defined on attachments association.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8458 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-01 17:35:34 +00:00
Jean-Philippe Lang
852dee37ec
Do not add errors on attributes on fake attributes.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8388 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-26 13:34:50 +00:00
Jean-Philippe Lang
a03432cbe6
Rails3 compatibility.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8383 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-26 12:22:03 +00:00
Jean-Philippe Lang
b20598d755
Use :joins instead of :include in calculations.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8382 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-26 12:07:07 +00:00
Jean-Philippe Lang
20ead6d8f7
Code cleanup.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8345 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-24 09:53:10 +00:00
Jean-Philippe Lang
8f23043851
Dup attributes instead of issue object.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8344 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-24 09:51:26 +00:00
Toshi MARUYAMA
16e8818d9e
remove trailing white-spaces from app/models/user.rb
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8296 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-19 04:41:13 +00:00
Jean-Philippe Lang
f5987a5ca0
Use validation callback.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8293 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 15:48:06 +00:00
Jean-Philippe Lang
14ea087edc
Removed unused scope.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8292 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 15:04:34 +00:00
Jean-Philippe Lang
b7ceb3c333
Removed unused scope.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8291 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 15:04:08 +00:00
Jean-Philippe Lang
b8ce888d98
Use scoped method instead of merge_conditions.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8290 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 15:02:46 +00:00
Jean-Philippe Lang
9e83ee2ddf
Removed after_initialize methods.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8288 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 14:57:58 +00:00
Jean-Philippe Lang
062fbeae80
Makes models #initialize accept additional arguments.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8287 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 13:26:20 +00:00
Jean-Philippe Lang
5eed64b848
human_attribute_name accepts optional argument.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8286 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 13:20:19 +00:00
Jean-Philippe Lang
2a0257e8af
Use open scope in version issues count methods.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8285 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 13:05:46 +00:00
Jean-Philippe Lang
3717ff34af
Rails3.1 compatibility
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8275 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-18 08:21:29 +00:00
Toshi MARUYAMA
a36904c9ee
use same human_attribute_name logic with SCM models at group model ( #9795 )
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8237 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-15 13:07:32 +00:00
Jean-Philippe Lang
4f5e7d678e
Fixed: Unrelated error message when creating a group with an invalid name ( #9795 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8231 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-15 11:13:36 +00:00
Jean-Philippe Lang
b6e6f557f0
Display issue form fields according to permissions.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8227 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-15 10:41:49 +00:00
Jean-Philippe Lang
7c00a4a11f
Restores migration broken by r8182 and removes default scope on Role ( #9800 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8213 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-14 22:24:20 +00:00
Etienne Massip
7d2298f39c
Save an @Issue#save@.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8212 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-14 20:31:34 +00:00
Jean-Philippe Lang
cd0113a287
Code cleanup.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-13 19:56:33 +00:00
Jean-Philippe Lang
e1f885feda
Use safe_attributes for issue watchers assignment.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8197 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-13 19:50:44 +00:00
Toshi MARUYAMA
f1994ea9c0
Rails3: model: replace deprecated before_validation method at CustomField model
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8191 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-11 12:04:54 +00:00
Jean-Philippe Lang
0471de41ff
Resourcified enumerations.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8189 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-11 10:26:12 +00:00
Jean-Philippe Lang
805c65f55d
Extracted new_subclass_instance method to a module.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8183 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-10 19:18:06 +00:00
Jean-Philippe Lang
532a76f78c
Resourcified roles.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8145 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-09 23:29:58 +00:00
Jean-Philippe Lang
b127f9157d
Resourcified custom fields.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8144 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-09 22:58:30 +00:00
Toshi MARUYAMA
312ffe43c7
Rails3: model: user: use ::Query instead of Query
...
Test fails on Rails 3.0.
<pre>
Error:
test_destroy_should_update_wiki_contents(UserTest):
NoMethodError: undefined method `delete_all' for ActiveRecord::AttributeMethods::Query:Module
app/models/user.rb:602:in `remove_references_before_destroy'
test/unit/user_test.rb:298:in `test_destroy_should_update_wiki_contents'
</pre>
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8140 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-09 12:08:58 +00:00
Jean-Philippe Lang
42d2bf0baf
Makes project and tracker assigned first in #attributes=
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8131 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-08 20:37:12 +00:00
Jean-Philippe Lang
3976e2d15d
Tests broken with ruby1.8.6 ( #9751 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8128 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-08 18:50:15 +00:00
Toshi MARUYAMA
aa127ebd4e
Rails3: model: Member: add virtual attribute to prevent error
...
On Rails 3.0, test fails with following error.
<pre>
Error:
test_validate(MemberTest):
NoMethodError: undefined method `role' for #<Member:0x7f73caf8cd08>
app/models/member.rb:87:in `validate_role'
test/unit/member_test.rb:76:in `test_validate'
</pre>
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8127 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-08 15:12:02 +00:00
Toshi MARUYAMA
15bb2fefa4
back out r8124
...
r8124 shows ":roles can't be empty".
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8125 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-08 13:37:27 +00:00
Toshi MARUYAMA
d9699adce5
Rails3: model: Member: errors must be set on existing attributes
...
On Rails 3.0, test fails with following error.
<pre>
Error:
test_validate(MemberTest):
NoMethodError: undefined method `role' for #<Member:0x7f73caf8cd08>
app/models/member.rb:87:in `validate_role'
test/unit/member_test.rb:76:in `test_validate'
</pre>
Contributed by Sylvain Utard.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8124 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-08 11:13:24 +00:00
Jean-Philippe Lang
5ca558f191
Fixed: error when filtering by numeric custom field with postgresql ( #9719 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8098 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-05 20:45:45 +00:00
Jean-Philippe Lang
afbdc51e01
Removed ARCondition.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8089 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 23:44:59 +00:00
Jean-Philippe Lang
0a92e382fa
Use scopes instead of ARCondition.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8087 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 23:36:47 +00:00
Jean-Philippe Lang
1050993348
Removed unnecessary calculations in time entries index.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8085 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 23:01:42 +00:00
Jean-Philippe Lang
9e5ed4208b
Adds named scopes for time entries index.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8084 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 22:49:46 +00:00
Jean-Philippe Lang
ff0f141126
Adds named scopes for projects index.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8082 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 22:31:02 +00:00
Jean-Philippe Lang
f52410be19
Adds named scopes for users index.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8081 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 22:24:33 +00:00
Jean-Philippe Lang
68149f8c73
Fixes spent time column sort for postgresql.
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8077 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 19:13:09 +00:00
Jean-Philippe Lang
6d498a3c46
Makes spent time column available on the issue list ( #971 ).
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8073 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 16:43:32 +00:00
Toshi MARUYAMA
bddd19c1e6
Rails3: model: replace deprecated validate method at watcher model
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8072 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 09:45:18 +00:00
Toshi MARUYAMA
32ed138c53
Rails3: model: replace deprecated before_save method at UserPreference model
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8070 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 06:44:39 +00:00
Toshi MARUYAMA
1de2c1c2af
Rails3: model: replace deprecated validate method at member_role model
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8068 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-04 05:21:20 +00:00
Toshi MARUYAMA
997995397e
Rails3: model: replace deprecated before_destroy method at member model
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8058 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-03 16:41:23 +00:00
Toshi MARUYAMA
23fd43374d
Rails3: model: replace deprecated validate method at member model
...
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8047 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-12-03 14:33:49 +00:00