Commit Graph

4150 Commits

Author SHA1 Message Date
Toshi MARUYAMA 999a4ba30d scm: git: performance improvements in fetching revisions (#8857, #9472)
Parse a revision for a given branch,
just if we haven't parsed it for any branches before.
Moved the db check to for existing revisions into a grouped search.
Search for many revisions at once: this reduces db load.
Revisions are grouped into sets of 100.
This is to improve memory consumption.
There will be just one query instead of each 100.
The above two methods significantly increase parsing speed.
Test case was a git repo with 6000+ commits on a master branch,
and several other branches originating for master.
Speed improved from 1.4h to 18min.

Contributed by Gergely Fábián.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9144 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 07:56:15 +00:00
Toshi MARUYAMA bcba955456 scm: git: reduce saving heads times in fetching revisions (#8857, #9472)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9143 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 05:57:59 +00:00
Toshi MARUYAMA f0987e4b8f scm: git: backout r8839 (#8857)
call "git log" only once instead of per branch in fetching revisions.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9142 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 05:57:44 +00:00
Toshi MARUYAMA 374c2aa705 scm: git: backout r8840 (#8857, #9472)
reduce saving heads times in fetching revisions.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9141 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-07 05:57:29 +00:00
Jean-Philippe Lang 2bcf9f2871 Prevent mass-assignment when adding/updating a forum (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9140 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 21:36:28 +00:00
Jean-Philippe Lang 87356648f6 Set user_id as a protected attribute (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9139 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 20:57:33 +00:00
Jean-Philippe Lang efddab48be Prevent mass-assignment when adding/updating a wiki (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9138 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 20:34:38 +00:00
Jean-Philippe Lang fef2e4b672 Prevent mass-assignment when adding/updating a version (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9137 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 20:31:45 +00:00
Jean-Philippe Lang 1ec2d98c14 Prevent mass-assignment when adding/updating a time entry (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9136 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 20:23:00 +00:00
Jean-Philippe Lang 0ee1de5686 Use safe_attributes= just like in #create.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9135 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 19:52:10 +00:00
Jean-Philippe Lang d0356fe935 Prevent mass-assignment when adding/updating a news (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9134 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 19:50:10 +00:00
Jean-Philippe Lang 286bda14f1 Prevent mass-assignment when adding/updating a forum message (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9133 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 19:46:59 +00:00
Jean-Philippe Lang 2c6ad7525a Prevent mass-assignment when adding a project member (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9132 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 19:39:37 +00:00
Jean-Philippe Lang 460239d1f9 Prevent mass-assignment when adding/updating an issue category (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9131 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 18:59:32 +00:00
Jean-Philippe Lang 809d35d34b Prevent mass-assignment when adding/updating a document (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9130 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 18:54:41 +00:00
Jean-Philippe Lang bdf6e90f05 Prevent mass-assignment when adding a news comment (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9129 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 18:48:47 +00:00
Jean-Philippe Lang 6aad82e524 Fixed that the proposed users list may be empty when adding a project member (#10374).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9128 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-06 18:37:30 +00:00
Jean-Philippe Lang 6b47cad8ce Cleanup in TimelogController#destroy.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9095 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 15:24:14 +00:00
Jean-Philippe Lang dc50edae5e Adds a template for API error messages so that it does not depend on AR::Errors serialization.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9094 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 15:16:50 +00:00
Jean-Philippe Lang d862843c9d Renamed Mailer#test to Mailer#test_email.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9080 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 12:38:34 +00:00
Jean-Philippe Lang 60b0a6c4b8 Removed sort order on issues association.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9075 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 11:53:15 +00:00
Jean-Philippe Lang bf05656c36 Rails 3.1 compatibility.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9074 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 11:45:15 +00:00
Jean-Philippe Lang 64d843a4d7 Rails 3.1 compatibility.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9073 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 11:41:10 +00:00
Jean-Philippe Lang af75583b23 Adds Redmine::Utils.random_hex for generating a random hex string.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9071 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 11:05:02 +00:00
Jean-Philippe Lang 70ced2f2af Rails 3.1 compatibility.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9067 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 10:44:59 +00:00
Jean-Philippe Lang c7b1a42d19 Adds Redmine::Plugin.public_directory to be used instead of Engines.public_directory.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9065 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-04 10:29:47 +00:00
Jean-Philippe Lang b3866b05c1 Removes all #verify calls in controllers. Verification is handled at routing level now that the default route is removed.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9061 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-03 15:09:20 +00:00
Jean-Philippe Lang 9c4014f446 Use a single query to retrieve issues on the roadmap.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9057 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-02 16:27:14 +00:00
Jean-Philippe Lang 1c0988cad3 Use a single query to retrieve issues_count, open_issues_count and closed_issues_count.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9056 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-02 16:26:06 +00:00
Jean-Philippe Lang fe481453c4 Use #issues_count which is already retrieved.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9055 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-02 16:23:10 +00:00
Jean-Philippe Lang 9ffccf5304 Adds functional test for #test_connection.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9053 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-02 11:31:44 +00:00
Jean-Philippe Lang 7448e0dbc4 Fixed that the bulk edit/copy form does not propose versions and categories for the target project (#10350).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9046 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-01 20:22:08 +00:00
Jean-Philippe Lang 60741b3e1c Adds an optional LDAP filter (#1060).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9044 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-01 16:26:10 +00:00
Jean-Philippe Lang ab46c52d4a MailHandler: fixed that sender's fullname is not unquoted (#10334).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9043 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-01 15:32:34 +00:00
Jean-Philippe Lang e1d1a3a0c2 Fixes r9029.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9030 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-28 06:27:23 +00:00
Jean-Philippe Lang df3c2466f8 Implements the behaviour expected in user_test.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9029 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-28 05:46:33 +00:00
Jean-Philippe Lang e6b9ddad18 Mailer#url_for not called in views with Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9023 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-27 20:43:25 +00:00
Etienne Massip 7056649a4b Override @#url_for@ in AM to force generation of absolute links (#10251).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9022 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-27 18:42:03 +00:00
Jean-Philippe Lang 0d2a22f37a Use controller_name and action_name instead of params.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9018 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 19:20:37 +00:00
Jean-Philippe Lang 7c568cccaf Adds a helper for displaying validation error messages.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9017 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 18:07:13 +00:00
Jean-Philippe Lang ad2036aaba Rails 3.1 compatibility (order declared on association takes precedence).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9015 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 13:05:19 +00:00
Jean-Philippe Lang 65b4d8a649 Make sure that projects_to_search is a Project Array.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 11:42:29 +00:00
Toshi MARUYAMA 3363e4f790 remove trailing white-spaces from app/models/attachment.rb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9012 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 10:16:09 +00:00
Toshi MARUYAMA aa0935c13b Rails3: html_safe for project_tree_options_for_select method in application helper
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-26 07:10:54 +00:00
Jean-Philippe Lang b6742bda3d Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9002 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 13:04:34 +00:00
Jean-Philippe Lang cf9154f924 Can not use Project#find on scopes with Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9001 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 12:57:30 +00:00
Jean-Philippe Lang 0cc60f3631 Use content_tag for empty option.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9000 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 12:37:28 +00:00
Jean-Philippe Lang 56a5f598f1 Preserve xml output with Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8998 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 12:19:56 +00:00
Jean-Philippe Lang b795bd5ace Fixed escaping issue with Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8994 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 11:06:14 +00:00
Jean-Philippe Lang 61b14f6391 Use content_tag for empty option.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8993 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 11:04:38 +00:00
Jean-Philippe Lang f1b26008b8 Fixed escaping issue with Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8990 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 09:37:18 +00:00
Jean-Philippe Lang 36fa1ff9a9 Use content_tag for "no change" options.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8989 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 09:29:56 +00:00
Toshi MARUYAMA b4630c03f7 Rails3: prevent double rendering file view and annotate on Rails 3.0.11 and Rails 3.1.3
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8988 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 06:01:48 +00:00
Jean-Philippe Lang f04c7a7680 Fixed Version#issues_progress for Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8986 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 00:07:09 +00:00
Jean-Philippe Lang 30282f20da Fixed escaping issues in #textilizable with Rails 3.1.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8985 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 00:00:58 +00:00
Jean-Philippe Lang 7ad40e22fe Replace auto_link with link_to in email templates.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8984 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 23:16:59 +00:00
Jean-Philippe Lang d04b4aafb6 Use :joins instead of :include.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8982 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 18:55:09 +00:00
Jean-Philippe Lang 430477d4d6 Round hours when reading TimeEntry attribute.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8980 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 18:40:22 +00:00
Jean-Philippe Lang 492cce7975 Cleanup instance variables when reloading a project.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8979 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 18:38:05 +00:00
Jean-Philippe Lang 67d816705d Removed useless option.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8978 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 18:27:38 +00:00
Jean-Philippe Lang 528735b955 Use subclasses method instead of class variable.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 18:23:58 +00:00
Toshi MARUYAMA 55a8087f67 Rails3: scm: mercurial: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8976 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:59:54 +00:00
Toshi MARUYAMA ebb109b67e Rails3: scm: git: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8975 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:59:31 +00:00
Toshi MARUYAMA e6916cf72f Rails3: scm: filesystem: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8974 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:59:06 +00:00
Toshi MARUYAMA 7100ca61ba Rails3: scm: darcs: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8973 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:58:43 +00:00
Toshi MARUYAMA e5bcac1572 Rails3: scm: cvs: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8972 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:58:18 +00:00
Toshi MARUYAMA 565ac00b70 Rails3: scm: bazaar: use .to_s for overriding human_attribute_name parameter
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8971 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:57:52 +00:00
Toshi MARUYAMA cd9b62d734 Rails3: scm: use .to_s for overriding human_attribute_name parameter at repository model
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8970 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:57:26 +00:00
Toshi MARUYAMA a4ee104bd7 Rails3: use .to_s for overriding human_attribute_name parameter at group model
On Rails 3.0.11, parameter is symbol not string in activerecord validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8969 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-24 14:56:54 +00:00
Toshi MARUYAMA 34d14500c9 Rails3: view: html_safe for auto_link of project homepage
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8956 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 23:08:00 +00:00
Jean-Philippe Lang 77aab5c468 Fixes HTML.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8955 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 15:42:15 +00:00
Jean-Philippe Lang 8cfc080470 Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8953 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 15:28:49 +00:00
Jean-Philippe Lang 3be511cdab Removed dead code.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8951 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 15:23:03 +00:00
Jean-Philippe Lang 0a8b35718a Pass the message id when previewing in edit mode (#10275).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8950 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 15:17:13 +00:00
Jean-Philippe Lang 3762a92a35 Pass the topic objet to #textilizable (#10275).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8949 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 15:11:17 +00:00
Jean-Philippe Lang 95811c8e4c Removed dead code.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8946 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 14:19:42 +00:00
Jean-Philippe Lang 8f24aa6c67 Preserve uploaded files when on documents.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8944 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 13:10:51 +00:00
Jean-Philippe Lang 3871cbc75c Preserve uploaded files when on news.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8943 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 13:08:32 +00:00
Jean-Philippe Lang 707ce0beef Preserve uploaded files when on news.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8942 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 13:07:27 +00:00
Jean-Philippe Lang 4f217618af Do not check the request http method.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8941 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 13:05:10 +00:00
Jean-Philippe Lang 435a634ac7 Preserve uploaded files when creating a forum topic.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8940 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 13:02:35 +00:00
Toshi MARUYAMA 6bdc2c36f1 scm: mercurial: use to_s for revision in find_changeset_by_name method
On Rails 3.0.11, functional test fails.

<pre>
Error: test_diff_two_revs(RepositoriesMercurialControllerTest)
NoMethodError: undefined method `empty?' for 4:Fixnum
app/models/repository/mercurial.rb:76:in `find_changeset_by_name'
</pre>

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8938 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 12:18:30 +00:00
Jean-Philippe Lang 7e347069d5 Better message for file size validation error.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8937 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 12:18:10 +00:00
Jean-Philippe Lang afa6c1a9a7 Removed testing code.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8933 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 10:57:50 +00:00
Toshi MARUYAMA a261006666 scm: use to_s for revision in find_changeset_by_name method
On Rails 3.0.11, Subversion functional test fails.

<pre>
Error: test_directory_diff(RepositoriesSubversionControllerTest)
NoMethodError: undefined method `match' for 2:Fixnum
app/models/repository.rb:234:in `find_changeset_by_name'
</pre>

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8931 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 10:11:19 +00:00
Jean-Philippe Lang 77626ef6fb Adds support for adding attachments to issues through the REST API (#8171).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8928 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-23 10:01:16 +00:00
Toshi MARUYAMA aa286a8e3f add ":id => nil" to "Overall activity" link_to
On Rails 3.2.1, "Overall activity" link becomes "/assets?controller=activities".

Contributed by John Yani.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8922 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-22 14:36:31 +00:00
Toshi MARUYAMA d7692b2575 code layout cleanup app/views/users/show.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8921 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-22 14:36:16 +00:00
Toshi MARUYAMA 652871d4c3 Rails3: view: html_safe for common/_diff.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8919 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-22 03:38:08 +00:00
Jean-Philippe Lang 77287d1f0b Fixed magic link in the note added when closing an issue by a commit from a subproject (#10284).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8917 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-20 21:58:57 +00:00
Jean-Philippe Lang 3e3d7c8d4f Friendly response when the LDAP connection fails.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8911 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-19 18:13:46 +00:00
Jean-Philippe Lang 59c2530001 Fixed random failures in RepositoriesControllerTest with ruby-1.8.7-p358.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8909 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-19 15:34:06 +00:00
Jean-Philippe Lang 97075c85e8 Require net/ldap.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8907 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-19 15:04:10 +00:00
Toshi MARUYAMA f6e7daaf18 Rails3: view: mail: html_safe for auto_link
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8895 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-17 09:20:49 +00:00
Toshi MARUYAMA c495dba18a Rails3: view: mail: html_safe for header and footer
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8894 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-17 08:23:59 +00:00
Jean-Philippe Lang b455ac2a27 Adds a rake test that removes old unattached uploads (#10253).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8893 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-16 21:18:01 +00:00
Jean-Philippe Lang 4c090e869e Missing argument to new_project_query_path named route (#10254).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8892 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-16 21:01:48 +00:00
Jean-Philippe Lang d4e6355eb3 Better handling of attachments when issue validation fails (#10253).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8891 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-16 21:00:11 +00:00
Toshi MARUYAMA a6bad4a47d replace tabs to spaces app/views/issues/show.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8888 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-16 01:34:58 +00:00
Toshi MARUYAMA 8c6a68ba4c replace tabs to spaces app/views/issues/new.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8887 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-16 01:34:28 +00:00
Toshi MARUYAMA 84dd4ecbd4 route: split issue preview route to adding and editing
"No route matches" error raises in "preview_issue_path"
at app/views/issues/new.html.erb:35 on Rails 3.0.11 and Rails 3.1.3 new route format.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8886 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-15 22:49:03 +00:00
Jean-Philippe Lang 9599875f48 Adds confirmation message to changeset/issue relation delete link.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8884 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-15 20:19:16 +00:00
Jean-Philippe Lang 8792131e03 Adds confirmation message to relation delete link (#8413).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8883 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-15 20:18:10 +00:00
Etienne Massip f84273ca91 Prevents SCM browser to overlay over the new repository sidebar (#779).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8881 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-15 18:24:23 +00:00
Jean-Philippe Lang 4cf6901057 Allow API auth on GET /versions/:id (#10241).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8880 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-15 18:09:03 +00:00
Jean-Philippe Lang 5c3ac1a40e Adds support for "Magic links" to notes (#2715).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8877 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-15 17:49:31 +00:00
Jean-Philippe Lang 008557581d Makes user autocompleters work with firstname and lastname.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8875 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-14 16:29:48 +00:00
Jean-Philippe Lang bd2581e7c9 Restyles user search fields and ajax indicator.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8874 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-14 15:34:27 +00:00
Jean-Philippe Lang 4ccb898360 Fixed: {{toc}} uses identical anchors for subsections with the same name (#8194).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8871 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-14 08:09:23 +00:00
Etienne Massip 75f8c152ce Removed useless style.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8868 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-14 06:27:23 +00:00
Etienne Massip c5317a14ac Redraw revision graph on window resize (#10206).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8866 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-13 20:20:18 +00:00
Jean-Philippe Lang cccfed7006 Fixed: error when creating a project with a version format custom field (#10218).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8865 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-13 18:57:12 +00:00
Jean-Philippe Lang 7fa18cad57 Prevent ActiveRecord::StaleObjectError in Issue#reschedule_after (#7920).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8864 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-12 19:41:42 +00:00
Jean-Philippe Lang d289619c75 Fixed potential error when sorting members without role (#10053).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8863 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-12 14:54:30 +00:00
Jean-Philippe Lang 96757857c4 Removed "clear:both" divs that break the issue form with long sidebar content.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8858 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-12 10:50:41 +00:00
Jean-Philippe Lang 8ddcc4caf5 Adds a News#commentable? method to easily specific additional rules.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8854 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 17:14:56 +00:00
Etienne Massip 9678e335a4 Moved revision graph holder div out of the table structure.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8853 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 15:32:24 +00:00
Etienne Massip 2da8e97268 Included scm stylesheet in changes page.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8852 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 15:31:11 +00:00
Etienne Massip ec537f6ea4 Use of local variable for consistency.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8851 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 14:59:57 +00:00
Etienne Massip 1ad977f712 Integrated revision graph into scmid column.
Allow wrapping of comment text so that the width doesn't overlap the sidebar while using multiple repositories.
Some code cleanup also.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8850 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 14:57:44 +00:00
Jean-Philippe Lang 8f92121606 Fixed that changesets parents associations are not deleted when deleting a repository.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8847 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 14:17:47 +00:00
Jean-Philippe Lang 60b9e59d15 Displays the full form when creating a version from the issue form so that required custom fields can be filled (#7398).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8845 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 13:05:41 +00:00
Jean-Philippe Lang 2ec55c5337 Only show statuses that can be applied to all issues on the bulk edit form (#10181).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8844 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 12:03:48 +00:00
Jean-Philippe Lang 686430ee36 Fixed: wrong section edit links when a heading contains inline code (#10199).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8841 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 10:02:24 +00:00
Toshi MARUYAMA 165327a074 scm: git: reduce saving heads times in fetching revisions (#8857, #9472)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8840 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 05:42:43 +00:00
Toshi MARUYAMA 1e5f16722f scm: git: call "git log" only once instead of per branch in fetching revisions (#8857)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8839 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 05:42:06 +00:00
Toshi MARUYAMA c2943ffd29 code layout cleanup app/views/repositories/committers.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8838 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-11 03:37:09 +00:00
Toshi MARUYAMA d90cdb1b10 scm: git: raise exception if "git log" is error and block is given in lib revision method (#8857)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-10 22:56:54 +00:00
Jean-Philippe Lang c0491d298b Makes error class more specific to prevent clashes with syntax highlight (#10193).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8835 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-10 18:03:10 +00:00
Jean-Philippe Lang daacea11dc Do not hide context menu when clicking on a folder menu item.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8829 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-09 20:25:01 +00:00
Jean-Philippe Lang 8c38510ee5 Use #reduce instead of #inject for getting the intersection of arrays.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8827 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-09 20:06:36 +00:00
Jean-Philippe Lang 8b3ed4175d Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8826 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-09 19:51:38 +00:00
Jean-Philippe Lang 07a93c2731 Only show allowed statuses in context menu (#10181).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8825 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-09 19:34:56 +00:00
Jean-Philippe Lang 5e0c1cc5ce Bulk-edit custom fields through context menu (#6296).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8824 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-09 18:22:11 +00:00
Jean-Philippe Lang de7c49c6ca Moved #context_menu_link to a new helper.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8823 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-09 18:00:22 +00:00
Toshi MARUYAMA 693191e8bf scm: git: add model method to get heads from extra_info branches hash (#8857)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8816 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-09 00:11:03 +00:00
Toshi MARUYAMA adb81b1ff6 scm: git: split fetch_changesets method
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8814 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-08 11:10:46 +00:00
Jean-Philippe Lang cdcf813fa7 Adds membership ids to /users/:id API response.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8805 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-06 16:32:50 +00:00
Jean-Philippe Lang dfbab5d61e Fixed "can't convert Fixnum into String" error on projects with numerical identifier (#10135).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8804 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-06 14:44:40 +00:00
Jean-Philippe Lang be246de161 Adds a simple API for listing roles (#9725).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8799 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-06 10:06:32 +00:00
Jean-Philippe Lang c5665276b7 REST API for project memberships (#7420).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8798 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-06 09:47:10 +00:00
Toshi MARUYAMA 2ef86a2f0a code layout cleanup app/views/repositories/_related_issues.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8794 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-05 23:51:26 +00:00
Toshi MARUYAMA d360ca4e14 code layout cleanup app/views/wiki/edit.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8793 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-05 23:51:03 +00:00
Toshi MARUYAMA 297d4f8bab replace tabs to spaces at app/views/wiki/edit.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8792 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-05 23:50:36 +00:00
Toshi MARUYAMA e0b0f1315b replace tabs to spaces at app/views/issues/_conflict.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8791 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-05 23:50:01 +00:00
Toshi MARUYAMA adbe4097b3 replace tabs to spaces at app/views/issues/_edit.html.erb
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8790 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-05 23:49:19 +00:00
Jean-Philippe Lang 78bd24c6f7 Resourcified project memberships.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8789 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-05 16:35:27 +00:00
Jean-Philippe Lang 001b255b08 Ability to edit a wiki page's parent on the edit page (#6449).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8787 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-05 14:35:27 +00:00
Jean-Philippe Lang 967f42aa98 Adds a X-Redmine-Sender header to email notifications (#5643).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8785 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-05 12:57:19 +00:00
Jean-Philippe Lang f52f18c281 Removed unsafe attributes assignment.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8784 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-05 12:21:21 +00:00