From f9f5e9e7c6c601aea66d1e15c818e1fae8bae81f Mon Sep 17 00:00:00 2001 From: Jean-Philippe Lang Date: Tue, 26 Jun 2012 17:03:08 +0000 Subject: [PATCH] Fixed: Link is escaped in wiki added/updated notification email (#11262). MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Patch by Ɓukasz Jachymczyk. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9896 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/views/mailer/wiki_content_added.html.erb | 2 +- app/views/mailer/wiki_content_updated.html.erb | 2 +- test/unit/mailer_test.rb | 10 ++++++++++ 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/app/views/mailer/wiki_content_added.html.erb b/app/views/mailer/wiki_content_added.html.erb index 160f5730f..8c83f62c8 100644 --- a/app/views/mailer/wiki_content_added.html.erb +++ b/app/views/mailer/wiki_content_added.html.erb @@ -1,3 +1,3 @@

<%= l(:mail_body_wiki_content_added, :id => link_to(h(@wiki_content.page.pretty_title), @wiki_content_url), - :author => h(@wiki_content.author)) %>
+ :author => h(@wiki_content.author)).html_safe %>
<%=h @wiki_content.comments %>

diff --git a/app/views/mailer/wiki_content_updated.html.erb b/app/views/mailer/wiki_content_updated.html.erb index 8ef24d1ba..f1f3857bd 100644 --- a/app/views/mailer/wiki_content_updated.html.erb +++ b/app/views/mailer/wiki_content_updated.html.erb @@ -1,5 +1,5 @@

<%= l(:mail_body_wiki_content_updated, :id => link_to(h(@wiki_content.page.pretty_title), @wiki_content_url), - :author => h(@wiki_content.author)) %>
+ :author => h(@wiki_content.author)).html_safe %>
<%=h @wiki_content.comments %>

<%= l(:label_view_diff) %>:
diff --git a/test/unit/mailer_test.rb b/test/unit/mailer_test.rb index 0bf62cfa7..3721ad497 100644 --- a/test/unit/mailer_test.rb +++ b/test/unit/mailer_test.rb @@ -404,6 +404,11 @@ class MailerTest < ActiveSupport::TestCase Setting.default_language = lang.to_s assert_difference 'ActionMailer::Base.deliveries.size' do assert Mailer.wiki_content_added(content).deliver + assert_select_email do + assert_select 'a[href=?]', + 'http://mydomain.foo/projects/ecookbook/wiki/CookBook_documentation', + :text => 'CookBook documentation' + end end end end @@ -414,6 +419,11 @@ class MailerTest < ActiveSupport::TestCase Setting.default_language = lang.to_s assert_difference 'ActionMailer::Base.deliveries.size' do assert Mailer.wiki_content_updated(content).deliver + assert_select_email do + assert_select 'a[href=?]', + 'http://mydomain.foo/projects/ecookbook/wiki/CookBook_documentation', + :text => 'CookBook documentation' + end end end end