kolan/Redmine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed that requesting a message from an invalid forum should respond with 404 (#13232).

Browse Source 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11446 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang 2013-02-20 20:59:52 +00:00
parent 2ae7ddcb24
commit d1244b31a4
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/controllers/messages_controller.rb
View File

@ -125,7 +125,7 @@ class MessagesController < ApplicationController
private private
def find_message def find_message
find_board return unless find_board
@message = @board.messages.find(params[:id], :include => :parent) @message = @board.messages.find(params[:id], :include => :parent)
@topic = @message.root @topic = @message.root
rescue ActiveRecord::RecordNotFound rescue ActiveRecord::RecordNotFound
@ -137,5 +137,6 @@ private
@project = @board.project @project = @board.project
rescue ActiveRecord::RecordNotFound rescue ActiveRecord::RecordNotFound
render_404 render_404
nil
end end
end end

5
test/functional/messages_controller_test.rb
View File

@ -74,6 +74,11 @@ class MessagesControllerTest < ActionController::TestCase
assert_response 404 assert_response 404
end end
def test_show_message_from_invalid_board_should_respond_with_404
get :show, :board_id => 999, :id => 1
assert_response 404
end
def test_get_new def test_get_new
@request.session[:user_id] = 2 @request.session[:user_id] = 2
get :new, :board_id => 1 get :new, :board_id => 1