Adds a setting that allows to reference/fix issues of all projects (#3087).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8750 e93f8b46-1217-0410-a6f0-8f06a7374b81

app/models/changeset.rb

@@ -187,11 +187,13 @@ class Changeset < ActiveRecord::Base
   private
 
   # Finds an issue that can be referenced by the commit message
-  # i.e. an issue that belong to the repository project, a subproject or a parent project
   def find_referenced_issue_by_id(id)
     return nil if id.blank?
     issue = Issue.find_by_id(id.to_i, :include => :project)
-    if issue
+    if Setting.commit_cross_project_ref?
+      # all issues can be referenced/fixed
+    elsif issue
+      # issue that belong to the repository project, a subproject or a parent project only
       unless issue.project &&
                 (project == issue.project || project.is_ancestor_of?(issue.project) ||
                  project.is_descendant_of?(issue.project))

app/views/settings/_repositories.html.erb

@@ -81,6 +81,8 @@
                                                        :label => false %>
 <br /><em><%= l(:text_comma_separated) %></em></p>
 
+<p><%= setting_check_box :commit_cross_project_ref %></p>
+
 <p><%= setting_check_box :commit_logtime_enabled,
                          :onclick =>
                             "if (this.checked) { Form.Element.enable('settings_commit_logtime_activity_id'); } else { Form.Element.disable('settings_commit_logtime_activity_id'); }"%></p>

config/locales/ar.yml

@@ -1017,3 +1017,4 @@ ar:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/bg.yml

@@ -1015,3 +1015,4 @@ bg:
   description_date_range_interval: Изберете диапазон чрез задаване на начална и крайна дати
   description_date_from: Въведете начална дата
   description_date_to: Въведете крайна дата
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/bs.yml

@@ -1031,3 +1031,4 @@ bs:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/ca.yml

@@ -1019,3 +1019,4 @@ ca:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/cs.yml

@@ -1020,3 +1020,4 @@ cs:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/da.yml

@@ -1034,3 +1034,4 @@ da:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/de.yml

@@ -1037,3 +1037,4 @@ de:
   label_item_position: "%{position}/%{count}"
   label_completed_versions: Completed versions
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/el.yml

@@ -1017,3 +1017,4 @@ el:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/en-GB.yml

@@ -1019,3 +1019,4 @@ en-GB:
   label_item_position: "%{position} of %{count}"
   label_completed_versions: Completed versions
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/en.yml

@@ -380,6 +380,7 @@ en:
   setting_gantt_items_limit: Maximum number of items displayed on the gantt chart
   setting_issue_group_assignment: Allow issue assignment to groups
   setting_default_issue_start_date_to_creation_date: Use current date as start date for new issues
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed
 
   permission_add_project: Create project
   permission_add_subprojects: Create subprojects

config/locales/es.yml

@@ -1054,3 +1054,4 @@ es:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/eu.yml

@@ -1020,3 +1020,4 @@ eu:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/fa.yml

@@ -1019,3 +1019,4 @@ fa:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/fi.yml

@@ -1038,3 +1038,4 @@ fi:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/fr.yml

@@ -376,6 +376,7 @@ fr:
   setting_gantt_items_limit: Nombre maximum d'éléments affichés sur le gantt
   setting_issue_group_assignment: Permettre l'assignement des demandes aux groupes
   setting_default_issue_start_date_to_creation_date: Donner à la date de début d'une nouvelle demande la valeur de la date du jour
+  setting_commit_cross_project_ref: Permettre le référencement et la résolution des demandes de tous les autres projets
 
   permission_add_project: Créer un projet
   permission_add_subprojects: Créer des sous-projets

config/locales/gl.yml

@@ -1028,3 +1028,4 @@ gl:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/he.yml

@@ -1022,3 +1022,4 @@ he:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/hr.yml

@@ -1023,3 +1023,4 @@ hr:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/hu.yml

@@ -1036,3 +1036,4 @@
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/id.yml

@@ -1023,3 +1023,4 @@ id:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/it.yml

@@ -1018,3 +1018,4 @@ it:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/ja.yml

@@ -1047,3 +1047,4 @@ ja:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/ko.yml

@@ -1069,3 +1069,4 @@ ko:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/lt.yml

@@ -1077,3 +1077,4 @@ lt:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/lv.yml

@@ -1011,3 +1011,4 @@ lv:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/mk.yml

@@ -1017,3 +1017,4 @@ mk:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/mn.yml

@@ -1017,3 +1017,4 @@ mn:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/nl.yml

@@ -999,3 +999,4 @@ nl:
   label_item_position: "%{position}/%{count}"
   label_completed_versions: Completed versions
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/no.yml

@@ -1007,3 +1007,4 @@
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/pl.yml

@@ -1034,3 +1034,4 @@ pl:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/pt-BR.yml

@@ -1040,3 +1040,4 @@ pt-BR:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/pt.yml

@@ -1022,3 +1022,4 @@ pt:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/ro.yml

@@ -1014,3 +1014,4 @@ ro:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/ru.yml

@@ -1130,3 +1130,4 @@ ru:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/sk.yml

@@ -1017,3 +1017,4 @@ sk:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/sl.yml

@@ -1017,3 +1017,4 @@ sl:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/sr-YU.yml

@@ -1017,3 +1017,4 @@ sr-YU:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/sr.yml

@@ -1018,3 +1018,4 @@ sr:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/sv.yml

@@ -1058,3 +1058,4 @@ sv:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/th.yml

@@ -1014,3 +1014,4 @@ th:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/tr.yml

@@ -1036,3 +1036,4 @@ tr:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/uk.yml

@@ -1014,3 +1014,4 @@ uk:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/vi.yml

@@ -1068,3 +1068,4 @@ vi:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/zh-TW.yml

@@ -1097,3 +1097,4 @@
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/locales/zh.yml

@@ -1019,3 +1019,4 @@ zh:
   label_completed_versions: Completed versions
   text_project_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.
   field_multiple: Multiple values
+  setting_commit_cross_project_ref: Allow issues of all the other projects to be referenced and fixed

config/settings.yml

@@ -92,6 +92,8 @@ sys_api_enabled:
   default: 0
 sys_api_key:
   default: ''
+commit_cross_project_ref:
+  default: 0
 commit_ref_keywords:
   default: 'refs,references,IssueID'
 commit_fix_keywords:

test/unit/changeset_test.rb

@@ -192,6 +192,36 @@ class ChangesetTest < ActiveSupport::TestCase
     assert c.issues.first.project != c.project
   end
 
+  def test_commit_referencing_a_project_with_commit_cross_project_ref_disabled
+    r = Repository::Subversion.create!(
+          :project => Project.find(3),
+          :url     => 'svn://localhost/test')
+          
+    with_settings :commit_cross_project_ref => '0' do
+      c = Changeset.new(:repository   => r,
+                        :committed_on => Time.now,
+                        :comments     => 'refs #4, an issue of a different project',
+                        :revision     => '12345')
+      assert c.save
+      assert_equal [], c.issue_ids
+    end
+  end
+
+  def test_commit_referencing_a_project_with_commit_cross_project_ref_enabled
+    r = Repository::Subversion.create!(
+          :project => Project.find(3),
+          :url     => 'svn://localhost/test')
+          
+    with_settings :commit_cross_project_ref => '1' do
+      c = Changeset.new(:repository   => r,
+                        :committed_on => Time.now,
+                        :comments     => 'refs #4, an issue of a different project',
+                        :revision     => '12345')
+      assert c.save
+      assert_equal [4], c.issue_ids
+    end
+  end
+
   def test_text_tag_revision
     c = Changeset.new(:revision => '520')
     assert_equal 'r520', c.text_tag