From c050028102247e0981966f89b5f291122361abce Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Wed, 24 Oct 2012 10:22:17 +0000 Subject: [PATCH] Merged r10709 from trunk to 2.1-stable (#12196) fix "Page not found" on OK button in SCM "View all revisions" page. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/branches/2.1-stable@10710 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/views/repositories/revisions.html.erb | 3 ++- .../repositories_git_controller_test.rb | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/app/views/repositories/revisions.html.erb b/app/views/repositories/revisions.html.erb index 0395e4b96..76ca629ae 100644 --- a/app/views/repositories/revisions.html.erb +++ b/app/views/repositories/revisions.html.erb @@ -1,7 +1,8 @@
<%= form_tag( {:controller => 'repositories', :action => 'revision', :id => @project, - :repository_id => @repository.identifier_param} + :repository_id => @repository.identifier_param}, + :method => :get ) do %> <%= l(:label_revision) %>: <%= text_field_tag 'rev', @rev, :size => 8 %> <%= submit_tag 'OK' %> diff --git a/test/functional/repositories_git_controller_test.rb b/test/functional/repositories_git_controller_test.rb index 07c663294..423d0c1ea 100644 --- a/test/functional/repositories_git_controller_test.rb +++ b/test/functional/repositories_git_controller_test.rb @@ -532,6 +532,21 @@ class RepositoriesGitControllerTest < ActionController::TestCase end end + def test_revisions + assert_equal 0, @repository.changesets.count + @repository.fetch_changesets + @project.reload + assert_equal NUM_REV, @repository.changesets.count + get :revisions, :id => PRJ_ID + assert_response :success + assert_template 'revisions' + assert_tag :tag => 'form', + :attributes => { + :method => 'get', + :action => '/projects/subproject1/repository/revision' + } + end + def test_revision assert_equal 0, @repository.changesets.count @repository.fetch_changesets