kolan/Redmine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Refactor: extract finder to a utility method

Browse Source 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4252 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Eric Davis 2010-10-14 18:01:46 +00:00
parent e8468b51cc
commit bbbfd4ee4c
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
app/controllers/wiki_controller.rb
View File

@ -175,12 +175,7 @@ class WikiController < ApplicationController
case page_title case page_title
# show pages index, sorted by title # show pages index, sorted by title
when 'page_index', 'date_index' when 'page_index', 'date_index'
# eager load information about last updates, without loading text load_pages_grouped_by_date_without_content
@pages = @wiki.pages.find :all, :select => "#{WikiPage.table_name}.*, #{WikiContent.table_name}.updated_on",
:joins => "LEFT JOIN #{WikiContent.table_name} ON #{WikiContent.table_name}.page_id = #{WikiPage.table_name}.id",
:order => 'title'
@pages_by_date = @pages.group_by {|p| p.updated_on.to_date}
@pages_by_parent_id = @pages.group_by(&:parent_id)
when 'export' when 'export'
redirect_to :action => 'export', :id => @project # Compatibility stub while refactoring redirect_to :action => 'export', :id => @project # Compatibility stub while refactoring
return return
@ -249,4 +244,14 @@ private
extend helper unless self.instance_of?(helper) extend helper unless self.instance_of?(helper)
helper.instance_method(:initial_page_content).bind(self).call(page) helper.instance_method(:initial_page_content).bind(self).call(page)
end end
# eager load information about last updates, without loading text
def load_pages_grouped_by_date_without_content
@pages = @wiki.pages.find :all, :select => "#{WikiPage.table_name}.*, #{WikiContent.table_name}.updated_on",
:joins => "LEFT JOIN #{WikiContent.table_name} ON #{WikiContent.table_name}.page_id = #{WikiPage.table_name}.id",
:order => 'title'
@pages_by_date = @pages.group_by {|p| p.updated_on.to_date}
@pages_by_parent_id = @pages.group_by(&:parent_id)
end
end end