kolan
/
Redmine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Redmine links not working with html escpaed characters (#16668). 

git-svn-id: http://svn.redmine.org/redmine/trunk@13106 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang 2014-04-26 07:34:11 +00:00
parent d197203d79
commit a4fa0364d4
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/helpers/application_helper.rb
View File

@ -822,6 +822,7 @@ module ApplicationHelper
elsif sep == ':' elsif sep == ':'
# removes the double quotes if any # removes the double quotes if any
name = identifier.gsub(%r{^"(.*)"$}, "\\1") name = identifier.gsub(%r{^"(.*)"$}, "\\1")
name = CGI.unescapeHTML(name)
case prefix case prefix
when 'document' when 'document'
if project && document = project.documents.visible.find_by_title(name) if project && document = project.documents.visible.find_by_title(name)

8
test/unit/helpers/application_helper_test.rb
View File

@ -436,6 +436,14 @@ RAW
end end
end end
def test_redmine_links_by_name_should_work_with_html_escaped_characters
v = Version.generate!(:name => "Test & Show.txt", :project_id => 1)
link = link_to("Test & Show.txt", "/versions/#{v.id}", :class => "version")
@project = v.project
assert_equal "<p>#{link}</p>", textilizable('version:"Test & Show.txt"')
end
def test_link_to_issue_subject def test_link_to_issue_subject
issue = Issue.generate!(:subject => "01234567890123456789") issue = Issue.generate!(:subject => "01234567890123456789")
str = link_to_issue(issue, :truncate => 10) str = link_to_issue(issue, :truncate => 10)