Added the revision title to any revision links.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3216 e93f8b46-1217-0410-a6f0-8f06a7374b81

app/helpers/application_helper.rb

@@ -96,6 +96,15 @@ module ApplicationHelper
     link_to(h(text), {:controller => 'attachments', :action => action, :id => attachment, :filename => attachment.filename }, options)
   end
 
+  # Generates a link to a SCM revision
+  # Options:
+  # * :text - Link text (default to the formatted revision)
+  def link_to_revision(revision, project, options={})
+    text = options.delete(:text) || format_revision(revision)
+
+    link_to(text, {:controller => 'repositories', :action => 'revision', :id => project, :rev => revision}, :title => l(:label_revision_id, revision))
+  end
+
   def toggle_link(name, id, options={})
     onclick = "Element.toggle('#{id}'); "
     onclick << (options[:focus] ? "Form.Element.focus('#{options[:focus]}'); " : "this.blur(); ")

app/views/repositories/_dir_list_content.rhtml

@@ -17,7 +17,7 @@
 </td>
 <td class="size"><%= (entry.size ? number_to_human_size(entry.size) : "?") unless entry.is_dir? %></td>
 <% changeset = @project.repository.changesets.find_by_revision(entry.lastrev.identifier) if entry.lastrev && entry.lastrev.identifier %>
-<td class="revision"><%= link_to(format_revision(entry.lastrev.name), :action => 'revision', :id => @project, :rev => entry.lastrev.identifier) if entry.lastrev && entry.lastrev.identifier %></td>
+<td class="revision"><%= link_to_revision(changeset.revision, @project) if changeset %></td>
 <td class="age"><%= distance_of_time_in_words(entry.lastrev.time, Time.now) if entry.lastrev && entry.lastrev.time %></td>
 <td class="author"><%= changeset.nil? ? h(entry.lastrev.author.to_s.split('<').first) : changeset.author if entry.lastrev %></td>
 <td class="comments"><%=h truncate(changeset.comments, :length => 50) unless changeset.nil? %></td>

app/views/repositories/_revisions.rhtml

@@ -13,7 +13,7 @@
 <% line_num = 1 %>
 <% revisions.each do |changeset| %>
 <tr class="changeset <%= cycle 'odd', 'even' %>">
-<td class="id"><%= link_to format_revision(changeset.revision), :action => 'revision', :id => project, :rev => changeset.revision %></td>
+<td class="id"><%= link_to_revision(changeset.revision, project) %></td>
 <td class="checkbox"><%= radio_button_tag('rev', changeset.revision, (line_num==1), :id => "cb-#{line_num}", :onclick => "$('cbto-#{line_num+1}').checked=true;") if show_diff && (line_num < revisions.size) %></td>
 <td class="checkbox"><%= radio_button_tag('rev_to', changeset.revision, (line_num==2), :id => "cbto-#{line_num}", :onclick => "if ($('cb-#{line_num}').checked==true) {$('cb-#{line_num-1}').checked=true;}") if show_diff && (line_num > 1) %></td>
 <td class="committed_on"><%= format_time(changeset.committed_on) %></td>

app/views/repositories/revision.rhtml

@@ -1,13 +1,13 @@
 <div class="contextual">
   &#171;
   <% unless @changeset.previous.nil? -%>
-    <%= link_to l(:label_previous), :controller => 'repositories', :action => 'revision', :id => @project, :rev => @changeset.previous.revision %>
+    <%= link_to_revision(@changeset.previous.revision, @project, :text => l(:label_previous)) %>
   <% else -%>
     <%= l(:label_previous) %>
   <% end -%>
 |
   <% unless @changeset.next.nil? -%>
-    <%= link_to l(:label_next), :controller => 'repositories', :action => 'revision', :id => @project, :rev => @changeset.next.revision %>
+    <%= link_to_revision(@changeset.next.revision, @project, :text => l(:label_next)) %>
   <% else -%>
     <%= l(:label_next) %>
   <% end -%>

config/locales/bg.yml

@@ -856,3 +856,4 @@ bg:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/bs.yml

@@ -880,3 +880,4 @@ bs:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/ca.yml

@@ -859,3 +859,4 @@ ca:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/cs.yml

@@ -862,3 +862,4 @@ cs:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/da.yml

@@ -882,3 +882,4 @@ da:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/de.yml

@@ -882,3 +882,4 @@ de:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/el.yml

@@ -862,3 +862,4 @@ el:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/en.yml

@@ -580,6 +580,7 @@ en:
   label_tag: Tag 
   label_revision: Revision
   label_revision_plural: Revisions
+  label_revision_id: "Revision {{value}}"
   label_associated_revisions: Associated revisions
   label_added: added
   label_modified: modified

config/locales/es.yml

@@ -903,3 +903,4 @@ es:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/fi.yml

@@ -892,3 +892,4 @@ fi:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/fr.yml

@@ -885,3 +885,4 @@ fr:
   enumeration_system_activity: Activité système
   setting_gravatar_default: Default Gravatar image
   setting_start_of_week: Start calendars on
+  label_revision_id: Revision {{value}}

config/locales/gl.yml

@@ -882,3 +882,4 @@ gl:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/he.yml

@@ -866,3 +866,4 @@ he:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/hu.yml

@@ -887,3 +887,4 @@
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/it.yml

@@ -869,3 +869,4 @@ it:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/ja.yml

@@ -891,3 +891,4 @@ ja:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/ko.yml

@@ -922,3 +922,4 @@ ko:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/lt.yml

@@ -930,3 +930,4 @@ lt:
   label_update_issue_done_ratios: Update issue done ratios
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/nl.yml

@@ -844,3 +844,4 @@ nl:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/no.yml

@@ -857,3 +857,4 @@
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/pl.yml

@@ -885,3 +885,4 @@ pl:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/pt-BR.yml

@@ -890,3 +890,4 @@ pt-BR:
 
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/pt.yml

@@ -874,3 +874,4 @@ pt:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/ro.yml

@@ -859,3 +859,4 @@ ro:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/ru.yml

@@ -970,3 +970,4 @@ ru:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/sk.yml

@@ -861,3 +861,4 @@ sk:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/sl.yml

@@ -858,3 +858,4 @@ sl:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/sr.yml

@@ -877,3 +877,4 @@
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/sv.yml

@@ -911,3 +911,4 @@ sv:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/th.yml

@@ -859,3 +859,4 @@ th:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/tr.yml

@@ -889,3 +889,4 @@ tr:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/uk.yml

@@ -858,3 +858,4 @@ uk:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/vi.yml

@@ -921,3 +921,4 @@ vi:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}

config/locales/zh-TW.yml

@@ -955,3 +955,4 @@
   enumeration_doc_categories: 文件分類
   enumeration_activities: 活動 (時間追蹤)
   enumeration_system_activity: 系統活動
+  label_revision_id: Revision {{value}}

config/locales/zh.yml

@@ -886,3 +886,4 @@ zh:
   setting_start_of_week: Start calendars on
   permission_view_issues: View Issues
   label_display_used_statuses_only: Only display statuses that are used by this tracker
+  label_revision_id: Revision {{value}}