kolan
/
Redmine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed undefined method `<=>' for nil:NilClass when sorting repositories with nil identifiers (#10827). 

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9619 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang 2012-05-04 16:57:15 +00:00
parent ad8193dcde
commit 9f396a6dfb
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/repository.rb
View File

@ -119,7 +119,7 @@ class Repository < ActiveRecord::Base
elsif repository.is_default? elsif repository.is_default?
1 1
else else
identifier <=> repository.identifier identifier.to_s <=> repository.identifier.to_s
end end
end end

9
test/unit/repository_test.rb
View File

@ -318,4 +318,13 @@ class RepositoryTest < ActiveSupport::TestCase
assert_equal "test_value_23", assert_equal "test_value_23",
repo.extra_info["test_2"]["test_23"] repo.extra_info["test_2"]["test_23"]
end end
def test_sort_should_not_raise_an_error_with_nil_identifiers
r1 = Repository.new
r2 = Repository.new
assert_nothing_raised do
[r1, r2].sort
end
end
end end