kolan
/
Redmine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make sure that custom field format cannot be changed. 

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10624 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang 2012-10-13 07:40:07 +00:00
parent e04bd297e0
commit 8a6ce3a646
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/models/custom_field.rb
View File

@ -53,6 +53,11 @@ class CustomField < ActiveRecord::Base
CUSTOM_FIELDS_NAMES = CUSTOM_FIELDS_TABS.collect{|v| v[:name]} CUSTOM_FIELDS_NAMES = CUSTOM_FIELDS_TABS.collect{|v| v[:name]}
def field_format=(arg)
# cannot change format of a saved custom field
super if new_record?
end
def set_searchable def set_searchable
# make sure these fields are not searchable # make sure these fields are not searchable
self.searchable = false if %w(int float date bool).include?(field_format) self.searchable = false if %w(int float date bool).include?(field_format)

6
test/unit/custom_field_test.rb
View File

@ -57,6 +57,12 @@ class CustomFieldTest < ActiveSupport::TestCase
assert field.valid? assert field.valid?
end end
def test_should_not_change_field_format_of_existing_custom_field
field = CustomField.find(1)
field.field_format = 'int'
assert_equal 'list', field.field_format
end
def test_possible_values_should_accept_an_array def test_possible_values_should_accept_an_array
field = CustomField.new field = CustomField.new
field.possible_values = ["One value", ""] field.possible_values = ["One value", ""]