kolan
/
Redmine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

move repositories helper to_utf8 logic to lib/redmine/codeset_util.rb for common use (#2371) 

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7825 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Toshi MARUYAMA 2011-11-17 11:53:15 +00:00
parent fdf6e8547b
commit 88f8daf8b7
2 changed files with 35 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
app/helpers/repositories_helper.rb
View File

@ -117,36 +117,9 @@ module RepositoriesHelper
end
def to_utf8(str)
return str if str.nil?
str = to_utf8_internal(str)
if str.respond_to?(:force_encoding)
str.force_encoding('UTF-8')
end
str
Redmine::CodesetUtil.to_utf8_by_setting(str)
end
def to_utf8_internal(str)
return str if str.nil?
if str.respond_to?(:force_encoding)
str.force_encoding('ASCII-8BIT')
end
return str if str.empty?
return str if /\A[\r\n\t\x20-\x7e]*\Z/n.match(str) # for us-ascii
if str.respond_to?(:force_encoding)
str.force_encoding('UTF-8')
end
@encodings ||= Setting.repositories_encodings.split(',').collect(&:strip)
@encodings.each do |encoding|
begin
return Iconv.conv('UTF-8', encoding, str)
rescue Iconv::Failure
# do nothing here and try the next encoding
end
end
str = Redmine::CodesetUtil.replace_invalid_utf8(str)
end
private :to_utf8_internal
def repository_field_tags(form, repository)
method = repository.class.name.demodulize.underscore + "_field_tags"
if repository.is_a?(Repository) &&

34
lib/redmine/codeset_util.rb
View File

@ -79,6 +79,40 @@ module Redmine
str
end
def self.to_utf8_by_setting(str)
return str if str.nil?
str = self.to_utf8_by_setting_internal(str)
if str.respond_to?(:force_encoding)
str.force_encoding('UTF-8')
end
str
end
def self.to_utf8_by_setting_internal(str)
return str if str.nil?
if str.respond_to?(:force_encoding)
str.force_encoding('ASCII-8BIT')
end
return str if str.empty?
return str if /\A[\r\n\t\x20-\x7e]*\Z/n.match(str) # for us-ascii
if str.respond_to?(:force_encoding)
str.force_encoding('UTF-8')
end
encodings = Setting.repositories_encodings.split(',').collect(&:strip)
encodings.each do |encoding|
begin
return Iconv.conv('UTF-8', encoding, str)
rescue Iconv::Failure
# do nothing here and try the next encoding
end
end
str = self.replace_invalid_utf8(str)
if str.respond_to?(:force_encoding)
str.force_encoding('UTF-8')
end
str
end
def self.from_utf8(str, encoding)
str ||= ''
if str.respond_to?(:force_encoding)