From 86442e60edef0ed7c0e6cdca0b14398ffdb8b432 Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Mon, 22 Apr 2013 08:10:48 +0000 Subject: [PATCH] application.js: randomKey function optimization (#13826) Contributed by Filou Centrinov. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11741 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- public/javascripts/application.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/public/javascripts/application.js b/public/javascripts/application.js index a19ff23c4..d626d0382 100644 --- a/public/javascripts/application.js +++ b/public/javascripts/application.js @@ -431,10 +431,10 @@ function scmEntryClick(id, url) { } function randomKey(size) { - var chars = new Array('0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z', 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z'); + var chars = '0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz'; var key = ''; - for (i = 0; i < size; i++) { - key += chars[Math.floor(Math.random() * chars.length)]; + for (var i = 0; i < size; i++) { + key += chars.charAt(Math.floor(Math.random() * chars.length)); } return key; }