kolan/Redmine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

code format clean up Repository::Git model

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@12742 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Toshi MARUYAMA 2014-01-31 10:15:37 +00:00
parent 7c56ed6004
commit 8574948617
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/models/repository/git.rb
View File

@ -180,10 +180,13 @@ class Repository::Git < Repository
# So, Redmine needs to scan revisions and database every time. # So, Redmine needs to scan revisions and database every time.
# #
# This is replacing the one-after-one queries. # This is replacing the one-after-one queries.
# Find all revisions, that are in the database, and then remove them from the revision array. # Find all revisions, that are in the database, and then remove them
# from the revision array.
# Then later we won't need any conditions for db existence. # Then later we won't need any conditions for db existence.
# Query for several revisions at once, and remove them from the revisions array, if they are there. # Query for several revisions at once, and remove them
# Do this in chunks, to avoid eventual memory problems (in case of tens of thousands of commits). # from the revisions array, if they are there.
# Do this in chunks, to avoid eventual memory problems
# (in case of tens of thousands of commits).
# If there are no revisions (because the original code's algorithm filtered them), # If there are no revisions (because the original code's algorithm filtered them),
# then this part will be stepped over. # then this part will be stepped over.
# We make queries, just if there is any revision. # We make queries, just if there is any revision.
@ -198,7 +201,6 @@ class Repository::Git < Repository
revisions.reject!{|r| recent_revisions.include?(r.scmid)} revisions.reject!{|r| recent_revisions.include?(r.scmid)}
offset += limit offset += limit
end end
revisions.each do |rev| revisions.each do |rev|
transaction do transaction do
# There is no search in the db for this revision, because above we ensured, # There is no search in the db for this revision, because above we ensured,
@ -240,7 +242,6 @@ class Repository::Git < Repository
def latest_changesets(path,rev,limit=10) def latest_changesets(path,rev,limit=10)
revisions = scm.revisions(path, nil, rev, :limit => limit, :all => false) revisions = scm.revisions(path, nil, rev, :limit => limit, :all => false)
return [] if revisions.nil? || revisions.empty? return [] if revisions.nil? || revisions.empty?
changesets.where(:scmid => revisions.map {|c| c.scmid}).all changesets.where(:scmid => revisions.map {|c| c.scmid}).all
end end