kolan
/
Redmine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

data locking for issues 

git-svn-id: http://redmine.rubyforge.org/svn/trunk@23 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang 2006-09-09 16:07:02 +00:00
parent 893a433165
commit 5f185b6c05
9 changed files with 67 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

109
redmine/app/controllers/issues_controller.rb
View File

@ -16,61 +16,66 @@
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
class IssuesController < ApplicationController class IssuesController < ApplicationController
layout 'base' layout 'base'
before_filter :find_project, :authorize before_filter :find_project, :authorize
helper :custom_fields helper :custom_fields
include CustomFieldsHelper include CustomFieldsHelper
def show
@status_options = @issue.status.workflows.find(:all, :conditions => ["role_id=? and tracker_id=?", self.logged_in_user.role_for_project(@project.id), @issue.tracker.id]).collect{ |w| w.new_status } if self.logged_in_user
@custom_values = @issue.custom_values.find(:all, :include => :custom_field)
end
def edit def show
@priorities = Enumeration::get_values('IPRI') @status_options = @issue.status.workflows.find(:all, :include => :new_status, :conditions => ["role_id=? and tracker_id=?", self.logged_in_user.role_for_project(@project.id), @issue.tracker.id]).collect{ |w| w.new_status } if self.logged_in_user
@custom_values = @issue.custom_values.find(:all, :include => :custom_field)
if request.get? end
@custom_values = @project.custom_fields_for_issues(@issue.tracker).collect { |x| @issue.custom_values.find_by_custom_field_id(x.id) || CustomValue.new(:custom_field => x, :customized => @issue) }
else def edit
# Retrieve custom fields and values @priorities = Enumeration::get_values('IPRI')
@custom_values = @project.custom_fields_for_issues(@issue.tracker).collect { |x| CustomValue.new(:custom_field => x, :customized => @issue, :value => params["custom_fields"][x.id.to_s]) } if request.get?
@issue.custom_values = @custom_values @custom_values = @project.custom_fields_for_issues(@issue.tracker).collect { |x| @issue.custom_values.find_by_custom_field_id(x.id) || CustomValue.new(:custom_field => x, :customized => @issue) }
@issue.attributes = params[:issue] else
if @issue.save begin
flash[:notice] = l(:notice_successful_update) # Retrieve custom fields and values
redirect_to :action => 'show', :id => @issue @custom_values = @project.custom_fields_for_issues(@issue.tracker).collect { |x| CustomValue.new(:custom_field => x, :customized => @issue, :value => params["custom_fields"][x.id.to_s]) }
end @issue.custom_values = @custom_values
end @issue.attributes = params[:issue]
end if @issue.save
flash[:notice] = l(:notice_successful_update)
def change_status redirect_to :action => 'show', :id => @issue
@history = @issue.histories.build(params[:history]) end
rescue ActiveRecord::StaleObjectError
# Optimistic locking exception
flash[:notice] = l(:notice_locking_conflict)
end
end
end
def change_status
@history = @issue.histories.build(params[:history])
@status_options = @issue.status.workflows.find(:all, :conditions => ["role_id=? and tracker_id=?", self.logged_in_user.role_for_project(@project.id), @issue.tracker.id]).collect{ |w| w.new_status } if self.logged_in_user @status_options = @issue.status.workflows.find(:all, :conditions => ["role_id=? and tracker_id=?", self.logged_in_user.role_for_project(@project.id), @issue.tracker.id]).collect{ |w| w.new_status } if self.logged_in_user
if params[:confirm]
if params[:confirm] begin
@history.author_id = self.logged_in_user.id if self.logged_in_user @history.author_id = self.logged_in_user.id if self.logged_in_user
@issue.status = @history.status
if @history.save @issue.fixed_version_id = (params[:issue][:fixed_version_id])
@issue.status = @history.status @issue.assigned_to_id = (params[:issue][:assigned_to_id])
@issue.fixed_version_id = (params[:issue][:fixed_version_id]) @issue.lock_version = (params[:issue][:lock_version])
@issue.assigned_to_id = (params[:issue][:assigned_to_id]) if @issue.save
if @issue.save flash[:notice] = l(:notice_successful_update)
flash[:notice] = l(:notice_successful_update) Mailer.deliver_issue_change_status(@issue) if Permission.find_by_controller_and_action(@params[:controller], @params[:action]).mail_enabled?
Mailer.deliver_issue_change_status(@issue) if Permission.find_by_controller_and_action(@params[:controller], @params[:action]).mail_enabled? redirect_to :action => 'show', :id => @issue
redirect_to :action => 'show', :id => @issue end
end rescue ActiveRecord::StaleObjectError
end # Optimistic locking exception
end flash[:notice] = l(:notice_locking_conflict)
end
end
@assignable_to = @project.members.find(:all, :include => :user).collect{ |m| m.user } @assignable_to = @project.members.find(:all, :include => :user).collect{ |m| m.user }
end
end
def destroy
def destroy @issue.destroy
@issue.destroy redirect_to :controller => 'projects', :action => 'list_issues', :id => @project
redirect_to :controller => 'projects', :action => 'list_issues', :id => @project end
end
def add_attachment def add_attachment
# Save the attachment # Save the attachment
if params[:attachment][:file].size > 0 if params[:attachment][:file].size > 0
@ -94,7 +99,7 @@ class IssuesController < ApplicationController
private private
def find_project def find_project
@issue = Issue.find(params[:id]) @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
@project = @issue.project @project = @issue.project
end end
end end

3
redmine/app/views/issues/change_status.rhtml
View File

@ -24,6 +24,7 @@
<p><label for="history_notes"><%=l(:field_notes)%></label> <p><label for="history_notes"><%=l(:field_notes)%></label>
<%= text_area 'history', 'notes', :cols => 60, :rows => 10 %></p> <%= text_area 'history', 'notes', :cols => 60, :rows => 10 %></p>
</div> </div>
<%= hidden_field 'issue', 'lock_version' %>
<%= submit_tag l(:button_save) %> <%= submit_tag l(:button_save) %>
<%= end_form_tag %> <%= end_form_tag %>

2
redmine/app/views/issues/edit.rhtml
View File

@ -21,6 +21,6 @@
</select></p> </select></p>
<!--[eoform:issue]--> <!--[eoform:issue]-->
</div> </div>
<%= f.hidden_field :lock_version %>
<%= submit_tag l(:button_save) %> <%= submit_tag l(:button_save) %>
<% end %> <% end %>

2
redmine/app/views/issues/show.rhtml
View File

@ -49,7 +49,7 @@
<div class="box"> <div class="box">
<h3><%=l(:label_history)%></h3> <h3><%=l(:label_history)%></h3>
<table width="100%"> <table width="100%">
<% for history in @issue.histories.find(:all, :include => :author) %> <% for history in @issue.histories.find(:all, :include => [:author, :status]) %>
<tr> <tr>
<td><%= format_date(history.created_on) %></td> <td><%= format_date(history.created_on) %></td>
<td><%= history.author.display_name %></td> <td><%= history.author.display_name %></td>

3
redmine/db/migrate/001_setup.rb
View File

@ -120,7 +120,8 @@ class Setup < ActiveRecord::Migration
t.column "assigned_to_id", :integer t.column "assigned_to_id", :integer
t.column "priority_id", :integer, :default => 0, :null => false t.column "priority_id", :integer, :default => 0, :null => false
t.column "fixed_version_id", :integer t.column "fixed_version_id", :integer
t.column "author_id", :integer, :default => 0, :null => false t.column "author_id", :integer, :default => 0, :null => false
t.column "lock_version", :integer, :default => 0, :null => false
t.column "created_on", :timestamp t.column "created_on", :timestamp
t.column "updated_on", :timestamp t.column "updated_on", :timestamp
end end

1
redmine/lang/de.yml
View File

@ -58,6 +58,7 @@ notice_successful_update: Erfolgreiches Update.
notice_successful_delete: Erfolgreiche Auslassung. notice_successful_delete: Erfolgreiche Auslassung.
notice_successful_connection: Erfolgreicher Anschluß. notice_successful_connection: Erfolgreicher Anschluß.
notice_file_not_found: Erbetene Akte besteht nicht oder ist gelöscht worden. notice_file_not_found: Erbetene Akte besteht nicht oder ist gelöscht worden.
notice_locking_conflict: Data have been updated by another user.
gui_validation_error: 1 Störung gui_validation_error: 1 Störung
gui_validation_error_plural: %d Störungen gui_validation_error_plural: %d Störungen

1
redmine/lang/en.yml
View File

@ -58,6 +58,7 @@ notice_successful_update: Successful update.
notice_successful_delete: Successful deletion. notice_successful_delete: Successful deletion.
notice_successful_connection: Successful connection. notice_successful_connection: Successful connection.
notice_file_not_found: Requested file doesn't exist or has been deleted. notice_file_not_found: Requested file doesn't exist or has been deleted.
notice_locking_conflict: Data have been updated by another user.
gui_validation_error: 1 error gui_validation_error: 1 error
gui_validation_error_plural: %d errors gui_validation_error_plural: %d errors

1
redmine/lang/es.yml
View File

@ -58,6 +58,7 @@ notice_successful_update: Successful update.
notice_successful_delete: Successful deletion. notice_successful_delete: Successful deletion.
notice_successful_connection: Successful connection. notice_successful_connection: Successful connection.
notice_file_not_found: Requested file doesn't exist or has been deleted. notice_file_not_found: Requested file doesn't exist or has been deleted.
notice_locking_conflict: Data have been updated by another user.
gui_validation_error: 1 error gui_validation_error: 1 error
gui_validation_error_plural: %d errores gui_validation_error_plural: %d errores

1
redmine/lang/fr.yml
View File

@ -58,6 +58,7 @@ notice_successful_update: Mise à jour effectuée avec succès.
notice_successful_delete: Suppression effectuée avec succès. notice_successful_delete: Suppression effectuée avec succès.
notice_successful_connection: Connection réussie. notice_successful_connection: Connection réussie.
notice_file_not_found: Le fichier demandé n'existe pas ou a été supprimé. notice_file_not_found: Le fichier demandé n'existe pas ou a été supprimé.
notice_locking_conflict: Les données ont été mises à jour par un autre utilisateur. Mise à jour impossible.
gui_validation_error: 1 erreur gui_validation_error: 1 erreur
gui_validation_error_plural: %d erreurs gui_validation_error_plural: %d erreurs