kolan
/
Redmine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Makes Issue.generate_with_descendants! helper accept attributes only. 

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10612 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang 2012-10-12 08:56:09 +00:00
parent 8bde60dc56
commit 51818cbbb6
4 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/functional/issues_controller_test.rb
View File

@ -2320,7 +2320,7 @@ class IssuesControllerTest < ActionController::TestCase
def test_new_as_copy_with_subtasks_should_show_copy_subtasks_checkbox def test_new_as_copy_with_subtasks_should_show_copy_subtasks_checkbox
@request.session[:user_id] = 2 @request.session[:user_id] = 2
issue = Issue.generate_with_descendants!(Project.find(1), :subject => 'Parent') issue = Issue.generate_with_descendants!
get :new, :project_id => 1, :copy_from => issue.id get :new, :project_id => 1, :copy_from => issue.id
assert_select 'input[type=checkbox][name=copy_subtasks][checked=checked][value=1]' assert_select 'input[type=checkbox][name=copy_subtasks][checked=checked][value=1]'
@ -2422,7 +2422,7 @@ class IssuesControllerTest < ActionController::TestCase
def test_create_as_copy_should_copy_subtasks def test_create_as_copy_should_copy_subtasks
@request.session[:user_id] = 2 @request.session[:user_id] = 2
issue = Issue.generate_with_descendants!(Project.find(1), :subject => 'Parent') issue = Issue.generate_with_descendants!
count = issue.descendants.count count = issue.descendants.count
assert_difference 'Issue.count', count+1 do assert_difference 'Issue.count', count+1 do
@ -2439,7 +2439,7 @@ class IssuesControllerTest < ActionController::TestCase
def test_create_as_copy_without_copy_subtasks_option_should_not_copy_subtasks def test_create_as_copy_without_copy_subtasks_option_should_not_copy_subtasks
@request.session[:user_id] = 2 @request.session[:user_id] = 2
issue = Issue.generate_with_descendants!(Project.find(1), :subject => 'Parent') issue = Issue.generate_with_descendants!
assert_difference 'Issue.count', 1 do assert_difference 'Issue.count', 1 do
assert_no_difference 'Journal.count' do assert_no_difference 'Journal.count' do
@ -3634,7 +3634,7 @@ class IssuesControllerTest < ActionController::TestCase
end end
def test_bulk_copy_should_allow_not_copying_the_subtasks def test_bulk_copy_should_allow_not_copying_the_subtasks
issue = Issue.generate_with_descendants!(Project.find(1), :subject => 'Parent') issue = Issue.generate_with_descendants!
@request.session[:user_id] = 2 @request.session[:user_id] = 2
assert_difference 'Issue.count', 1 do assert_difference 'Issue.count', 1 do
@ -3646,7 +3646,7 @@ class IssuesControllerTest < ActionController::TestCase
end end
def test_bulk_copy_should_allow_copying_the_subtasks def test_bulk_copy_should_allow_copying_the_subtasks
issue = Issue.generate_with_descendants!(Project.find(1), :subject => 'Parent') issue = Issue.generate_with_descendants!
count = issue.descendants.count count = issue.descendants.count
@request.session[:user_id] = 2 @request.session[:user_id] = 2
@ -3661,7 +3661,7 @@ class IssuesControllerTest < ActionController::TestCase
end end
def test_bulk_copy_should_not_copy_selected_subtasks_twice def test_bulk_copy_should_not_copy_selected_subtasks_twice
issue = Issue.generate_with_descendants!(Project.find(1), :subject => 'Parent') issue = Issue.generate_with_descendants!
count = issue.descendants.count count = issue.descendants.count
@request.session[:user_id] = 2 @request.session[:user_id] = 2

12
test/object_helpers.rb
View File

@ -70,12 +70,12 @@ module ObjectHelpers
issue issue
end end
# Generates an issue with some children and a grandchild # Generates an issue with 2 children and a grandchild
def Issue.generate_with_descendants!(project, attributes={}) def Issue.generate_with_descendants!(attributes={})
issue = Issue.generate!(attributes.merge(:project => project)) issue = Issue.generate!(attributes)
child = Issue.generate!(:project => project, :subject => 'Child1', :parent_issue_id => issue.id) child = Issue.generate!(:project => issue.project, :subject => 'Child1', :parent_issue_id => issue.id)
Issue.generate!(:project => project, :subject => 'Child2', :parent_issue_id => issue.id) Issue.generate!(:project => issue.project, :subject => 'Child2', :parent_issue_id => issue.id)
Issue.generate!(:project => project, :subject => 'Child11', :parent_issue_id => child.id) Issue.generate!(:project => issue.project, :subject => 'Child11', :parent_issue_id => child.id)
issue.reload issue.reload
end end

6
test/unit/issue_test.rb
View File

@ -650,7 +650,7 @@ class IssueTest < ActiveSupport::TestCase
end end
def test_copy_should_copy_subtasks def test_copy_should_copy_subtasks
issue = Issue.generate_with_descendants!(Project.find(1), :subject => 'Parent') issue = Issue.generate_with_descendants!
copy = issue.reload.copy copy = issue.reload.copy
copy.author = User.find(7) copy.author = User.find(7)
@ -665,7 +665,7 @@ class IssueTest < ActiveSupport::TestCase
end end
def test_copy_should_copy_subtasks_to_target_project def test_copy_should_copy_subtasks_to_target_project
issue = Issue.generate_with_descendants!(Project.find(1), :subject => 'Parent') issue = Issue.generate_with_descendants!
copy = issue.copy(:project_id => 3) copy = issue.copy(:project_id => 3)
assert_difference 'Issue.count', 1+issue.descendants.count do assert_difference 'Issue.count', 1+issue.descendants.count do
@ -675,7 +675,7 @@ class IssueTest < ActiveSupport::TestCase
end end
def test_copy_should_not_copy_subtasks_twice_when_saving_twice def test_copy_should_not_copy_subtasks_twice_when_saving_twice
issue = Issue.generate_with_descendants!(Project.find(1), :subject => 'Parent') issue = Issue.generate_with_descendants!
copy = issue.reload.copy copy = issue.reload.copy
assert_difference 'Issue.count', 1+issue.descendants.count do assert_difference 'Issue.count', 1+issue.descendants.count do

2
test/unit/project_test.rb
View File

@ -1054,7 +1054,7 @@ class ProjectTest < ActiveSupport::TestCase
def test_copy_should_copy_subtasks def test_copy_should_copy_subtasks
source = Project.generate!(:tracker_ids => [1]) source = Project.generate!(:tracker_ids => [1])
issue = Issue.generate_with_descendants!(source, :subject => 'Parent') issue = Issue.generate_with_descendants!(:project => source)
project = Project.new(:name => 'Copy', :identifier => 'copy', :tracker_ids => [1]) project = Project.new(:name => 'Copy', :identifier => 'copy', :tracker_ids => [1])
assert_difference 'Project.count' do assert_difference 'Project.count' do