diff --git a/test/unit/helpers/issues_helper_test.rb b/test/unit/helpers/issues_helper_test.rb index edf66b732..ce27e6afe 100644 --- a/test/unit/helpers/issues_helper_test.rb +++ b/test/unit/helpers/issues_helper_test.rb @@ -211,20 +211,23 @@ class IssuesHelperTest < ActionView::TestCase assert_match 'error281.txt', show_detail(detail, true) end - def test_show_detail_create_relation + def test_show_detail_relation_added detail = JournalDetail.new(:property => 'relation', :prop_key => 'label_precedes', :value => 1) assert_equal "Precedes Bug #1: Can't print recipes added", show_detail(detail, true) assert_match %r{Precedes Bug #1: Can't print recipes added}, show_detail(detail, false) - non_existed_issue_number = 9999 - assert_nil Issue.find_by_id(non_existed_issue_number) + end + + def test_show_detail_relation_added_with_inexistant_issue + inexistant_issue_number = 9999 + assert_nil Issue.find_by_id(inexistant_issue_number) detail = JournalDetail.new(:property => 'relation', :prop_key => 'label_precedes', - :value => non_existed_issue_number) - assert_equal "Precedes Issue ##{non_existed_issue_number} added", show_detail(detail, true) - assert_equal "Precedes Issue ##{non_existed_issue_number} added", show_detail(detail, false) + :value => inexistant_issue_number) + assert_equal "Precedes Issue ##{inexistant_issue_number} added", show_detail(detail, true) + assert_equal "Precedes Issue ##{inexistant_issue_number} added", show_detail(detail, false) end def test_show_detail_relation_added_should_not_disclose_issue_that_is_not_visible @@ -237,18 +240,21 @@ class IssuesHelperTest < ActionView::TestCase assert_equal "Precedes Issue ##{issue.id} added", show_detail(detail, false) end - def test_show_detail_delete_relation + def test_show_detail_relation_deleted detail = JournalDetail.new(:property => 'relation', :prop_key => 'label_precedes', :old_value => 1) assert_equal "Precedes deleted (Bug #1: Can't print recipes)", show_detail(detail, true) assert_match %r{Precedes deleted \(Bug #1: Can't print recipes\)}, show_detail(detail, false) - non_existed_issue_number = 9999 - assert_nil Issue.find_by_id(non_existed_issue_number) + end + + def test_show_detail_relation_deleted_with_inexistant_issue + inexistant_issue_number = 9999 + assert_nil Issue.find_by_id(inexistant_issue_number) detail = JournalDetail.new(:property => 'relation', :prop_key => 'label_precedes', - :old_value => non_existed_issue_number) + :old_value => inexistant_issue_number) assert_equal "Precedes deleted (Issue #9999)", show_detail(detail, true) assert_equal "Precedes deleted (Issue #9999)", show_detail(detail, false) end