From 28cdc8adfc5d63befe8d763c8b84cfe24e3f9603 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Lang Date: Tue, 24 Jul 2012 21:51:10 +0000 Subject: [PATCH] Don't turn #nnn with leading zeros into link (#11494). git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10077 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/helpers/application_helper.rb | 2 +- test/unit/helpers/application_helper_test.rb | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index a20b8d693..f97cc0638 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -703,7 +703,7 @@ module ApplicationHelper oid = identifier.to_i case prefix when nil - if issue = Issue.visible.find_by_id(oid, :include => :status) + if oid.to_s == identifier && issue = Issue.visible.find_by_id(oid, :include => :status) anchor = comment_id ? "note-#{comment_id}" : nil link = link_to("##{oid}", {:only_path => only_path, :controller => 'issues', :action => 'show', :id => oid, :anchor => anchor}, :class => issue.css_classes, diff --git a/test/unit/helpers/application_helper_test.rb b/test/unit/helpers/application_helper_test.rb index 8b22df08a..1740fbc52 100644 --- a/test/unit/helpers/application_helper_test.rb +++ b/test/unit/helpers/application_helper_test.rb @@ -260,6 +260,8 @@ RAW # ticket notes '#3-14' => note_link, '#3#note-14' => note_link, + # should not ignore leading zero + '#03' => '#03', # changesets 'r1' => changeset_link, 'r1.' => "#{changeset_link}.",