kolan
/
Redmine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Rails3: controller: repositories: use to_s for revision parameter 

On Rails 3.0 and Ruby 1.8.7, following error raises.

Error:
test_revision(RepositoriesControllerTest):
NoMethodError: undefined method `strip' for 1:Fixnum
    app/controllers/repositories_controller.rb:252:in `find_repository'
    test/functional/repositories_controller_test.rb:44:in `test_revision'

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7622 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Toshi MARUYAMA 2011-10-09 23:34:53 +00:00
parent 8e1cf61d86
commit 1f4ff3687c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/repositories_controller.rb
View File

@ -249,7 +249,7 @@ class RepositoriesController < ApplicationController
(render_404; return false) unless @repository (render_404; return false) unless @repository
@path = params[:path].join('/') unless params[:path].nil? @path = params[:path].join('/') unless params[:path].nil?
@path ||= '' @path ||= ''
@rev = params[:rev].blank? ? @repository.default_branch : params[:rev].strip @rev = params[:rev].blank? ? @repository.default_branch : params[:rev].to_s.strip
@rev_to = params[:rev_to] @rev_to = params[:rev_to]
unless @rev.to_s.match(REV_PARAM_RE) && @rev_to.to_s.match(REV_PARAM_RE) unless @rev.to_s.match(REV_PARAM_RE) && @rev_to.to_s.match(REV_PARAM_RE)