From 16cb0ce1c96894f910120965d3ec1fe41452fcf7 Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Fri, 6 Jan 2012 07:47:38 +0000 Subject: [PATCH] remove redundant "email" parameter from MailHandler#create_user_from_email "email" is defined as attr_reader. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8521 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/models/mail_handler.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/mail_handler.rb b/app/models/mail_handler.rb index 4ded2acb0..30bbe1cba 100644 --- a/app/models/mail_handler.rb +++ b/app/models/mail_handler.rb @@ -61,7 +61,7 @@ class MailHandler < ActionMailer::Base when 'accept' @user = User.anonymous when 'create' - @user = create_user_from_email(email) + @user = create_user_from_email if @user logger.info "MailHandler: [#{@user.login}] account created" if logger && logger.info Mailer.deliver_account_information(@user, @user.password) @@ -356,7 +356,7 @@ class MailHandler < ActionMailer::Base # Creates a User for the +email+ sender # Returns the user or nil if it could not be created - def create_user_from_email(email) + def create_user_from_email addr = email.from_addrs.to_a.first if addr && !addr.spec.blank? user = self.class.new_user_from_attributes(addr.spec, addr.name)