kolan
/
Redmine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

scm: mercurial: add :order => 'id DESC' explicitly for MySQL test fails. 

Because :order => 'id DESC' is defined at 'has_many',
there is no need to set 'order'.
But, MySQL test fails.
Sqlite3 and PostgreSQL pass.
Is this MySQL bug?

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5091 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Toshi MARUYAMA 2011-03-11 07:34:14 +00:00
parent cb8c2d59bf
commit 0d63e9e8fd
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/models/repository/mercurial.rb
View File

@ -81,16 +81,23 @@ class Repository::Mercurial < Repository
# Returns the latest changesets for +path+; sorted by revision number # Returns the latest changesets for +path+; sorted by revision number
# Default behavior is to search in cached changesets # Default behavior is to search in cached changesets
#
# Because :order => 'id DESC' is defined at 'has_many',
# there is no need to set 'order'.
# But, MySQL test fails.
# Sqlite3 and PostgreSQL pass.
# Is this MySQL bug?
def latest_changesets(path, rev, limit=10) def latest_changesets(path, rev, limit=10)
if path.blank? if path.blank?
changesets.find(:all, :include => :user, :limit => limit) changesets.find(:all, :include => :user, :limit => limit, :order => 'id DESC')
else else
changesets.find(:all, :select => "DISTINCT #{Changeset.table_name}.*", changesets.find(:all, :select => "DISTINCT #{Changeset.table_name}.*",
:joins => :changes, :joins => :changes,
:conditions => ["#{Change.table_name}.path = ? OR #{Change.table_name}.path LIKE ? ESCAPE ?", :conditions => ["#{Change.table_name}.path = ? OR #{Change.table_name}.path LIKE ? ESCAPE ?",
path.with_leading_slash, path.with_leading_slash,
"#{path.with_leading_slash.gsub(/[%_\\]/) { |s| "\\#{s}" }}/%", '\\'], "#{path.with_leading_slash.gsub(/[%_\\]/) { |s| "\\#{s}" }}/%", '\\'],
:include => :user, :limit => limit) :include => :user, :limit => limit,
:order => "#{Changeset.table_name}.id DESC" )
end end
end end