Fixed that validation fails when receiving an email with list custom fields (#12400).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10992 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang 2012-12-13 13:14:46 +00:00
parent b99a6f11f3
commit 0a773bcbb3
4 changed files with 15 additions and 3 deletions

View File

@ -160,7 +160,13 @@ class CustomField < ActiveRecord::Base
possible_values_options = possible_values_options(customized) possible_values_options = possible_values_options(customized)
if possible_values_options.present? if possible_values_options.present?
keyword = keyword.to_s.downcase keyword = keyword.to_s.downcase
possible_values_options.detect {|text, id| text.downcase == keyword}.try(:last) if v = possible_values_options.detect {|text, id| text.downcase == keyword}
if v.is_a?(Array)
v.last
else
v
end
end
else else
keyword keyword
end end

View File

@ -39,3 +39,4 @@ pulvinar dui, a gravida orci mi eget odio. Nunc a lacus.
category: Stock management category: Stock management
searchable field: Value for a custom field searchable field: Value for a custom field
Database: postgresql

View File

@ -218,4 +218,9 @@ class CustomFieldTest < ActiveSupport::TestCase
assert_nil CustomField.new(:field_format => 'text').value_class assert_nil CustomField.new(:field_format => 'text').value_class
assert_nil CustomField.new.value_class assert_nil CustomField.new.value_class
end end
def test_value_from_keyword_for_list_custom_field
field = CustomField.find(1)
assert_equal 'PostgreSQL', field.value_from_keyword('postgresql', Issue.find(1))
end
end end

View File

@ -177,8 +177,8 @@ class MailHandlerTest < ActiveSupport::TestCase
assert !issue.new_record? assert !issue.new_record?
issue.reload issue.reload
assert_equal 'New ticket with custom field values', issue.subject assert_equal 'New ticket with custom field values', issue.subject
assert_equal 'Value for a custom field', assert_equal 'PostgreSQL', issue.custom_field_value(1)
issue.custom_value_for(CustomField.find_by_name('Searchable field')).value assert_equal 'Value for a custom field', issue.custom_field_value(2)
assert !issue.description.match(/^searchable field:/i) assert !issue.description.match(/^searchable field:/i)
end end